126248 2013-12-26 16:22:06 -0800 Fix build error on 64bit debug build 2013-12-29 16:36:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim alecflett commit-queue jsbell oldest_to_newest 963039 0 gyuyoung.kim 2013-12-26 16:22:06 -0800 r161076 used ‘%lli’(for long long int) for int64_t(aka long int). However, in a 64bit compile, int64_t is 'long int', not a 'long long int'. To support both 32bit and 64bit, we use static_cast<long long>. 963040 1 220038 gyuyoung.kim 2013-12-26 16:23:19 -0800 Created attachment 220038 Patch 963041 2 220038 mrobinson 2013-12-26 16:26:54 -0800 Comment on attachment 220038 Patch Is it possible to use PRId64 here ala http://stackoverflow.com/questions/9225567/how-to-print-a-int64-t-type-in-c ? 963043 3 gyuyoung.kim 2013-12-26 16:45:16 -0800 (In reply to comment #2) > (From update of attachment 220038 [details]) > Is it possible to use PRId64 here ala http://stackoverflow.com/questions/9225567/how-to-print-a-int64-t-type-in-c ? I'm not sure if this can be supported by MSVC as well. Besides we may include <inttypes.h> to use it. It seems to me current is better for all platforms. 963255 4 220038 commit-queue 2013-12-29 16:29:34 -0800 Comment on attachment 220038 Patch Rejecting attachment 220038 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 220038, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5672591746400256 963257 5 220038 gyuyoung.kim 2013-12-29 16:36:31 -0800 Comment on attachment 220038 Patch Clearing flags on attachment: 220038 Committed r161133: <http://trac.webkit.org/changeset/161133> 963258 6 gyuyoung.kim 2013-12-29 16:36:38 -0800 All reviewed patches have been landed. Closing bug. 220038 2013-12-26 16:23:19 -0800 2013-12-29 16:36:31 -0800 Patch bug-126248-20131227092317.patch text/plain 2287 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ2YWJkZjYxMTBhNzU4 OTE1NWVkZWUzYjc0YTdiNjE5NzY0ZjA4NC4uNWU5NDM2YWM0MTJlMzhmMTc3MmRiYzA1ZWI4YjIw MzhmZTU0MTQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTI2ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxk IGVycm9yIG9uIDY0Yml0IGRlYnVnIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjQ4CisKKyAgICAgICAgcjE2MTA3NiB1c2VkIOKAmCVs bGnigJkoZm9yIGxvbmcgbG9uZyBpbnQpIGZvciBpbnQ2NF90KGFrYSBsb25nIGludCkuCisgICAg ICAgIEhvd2V2ZXIsIGluIGEgNjRiaXQgY29tcGlsZSwgaW50NjRfdCBpcyAnbG9uZyBpbnQnLCBu b3QgYSAnbG9uZyBsb25nIGludCcuCisgICAgICAgIFRvIHN1cHBvcnQgMzJiaXQgYW5kIDY0Yml0 LCB3ZSB1c2Ugc3RhdGljX2Nhc3Q8bG9uZyBsb25nPi4KKworICAgICAgICAqIE1vZHVsZXMvaW5k ZXhlZGRiL0lEQlRyYW5zYWN0aW9uQmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJU cmFuc2FjdGlvbkJhY2tlbmQ6OmNvbW1pdCk6CisKIDIwMTMtMTItMjYgIFRoaWFnbyBkZSBCYXJy b3MgTGFjZXJkYSAgPHRoaWFnby5sYWNlcmRhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW05p eF0gQ2xlYW51cCBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybU5peC5jbWFrZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb25CYWNrZW5kLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9uQmFja2Vu ZC5jcHAKaW5kZXggMWZlMTQzNTJlNmU0OWM5YjNmZjA1NzE4NDFkOWViZGU3YTRiZGJhNi4uNGNj MmRhN2QxOWNlYTJjNjJmNTVkNDAwYzY2YmZjZGYyNDQzNDE0MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rpb25CYWNrZW5kLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbkJhY2tlbmQu Y3BwCkBAIC0yMDEsNyArMjAxLDcgQEAgdm9pZCBJREJUcmFuc2FjdGlvbkJhY2tlbmQ6OnN0YXJ0 KCkKIAogdm9pZCBJREJUcmFuc2FjdGlvbkJhY2tlbmQ6OmNvbW1pdCgpCiB7Ci0gICAgTE9HKFN0 b3JhZ2VBUEksICJJREJUcmFuc2FjdGlvbkJhY2tlbmQ6OmNvbW1pdCAoVHJhbnNhY3Rpb24gJWxs aSkiLCBtX2lkKTsKKyAgICBMT0coU3RvcmFnZUFQSSwgIklEQlRyYW5zYWN0aW9uQmFja2VuZDo6 Y29tbWl0IChUcmFuc2FjdGlvbiAlbGxpKSIsIHN0YXRpY19jYXN0PGxvbmcgbG9uZz4obV9pZCkp OwogCiAgICAgLy8gSW4gbXVsdGlwcm9jZXNzIHBvcnRzLCBmcm9udC1lbmQgbWF5IGhhdmUgcmVx dWVzdGVkIGEgY29tbWl0IGJ1dCBhbiBhYm9ydCBoYXMgYWxyZWFkeQogICAgIC8vIGJlZW4gaW5p dGlhdGVkIGFzeW5jaHJvbm91c2x5IGJ5IHRoZSBiYWNrLWVuZC4KQEAgLTIxNCw3ICsyMTQsNyBA QCB2b2lkIElEQlRyYW5zYWN0aW9uQmFja2VuZDo6Y29tbWl0KCkKICAgICAvLyBGcm9udC1lbmQg aGFzIHJlcXVlc3RlZCBhIGNvbW1pdCwgYnV0IHRoZXJlIG1heSBiZSB0YXNrcyBsaWtlIGNyZWF0 ZUluZGV4IHdoaWNoCiAgICAgLy8gYXJlIGNvbnNpZGVyZWQgc3luY2hyb25vdXMgYnkgdGhlIGZy b250LWVuZCBidXQgYXJlIHByb2Nlc3NlZCBhc3luY2hyb25vdXNseS4KICAgICBpZiAoaGFzUGVu ZGluZ1Rhc2tzKCkpIHsKLSAgICAgICAgTE9HKFN0b3JhZ2VBUEksICJJREJUcmFuc2FjdGlvbkJh Y2tlbmQ6OmNvbW1pdCAtIE5vdCBjb21taXR0aW5nIG5vdywgdHJhbnNhY3Rpb24gc3RpbGwgaGFz IHBlbmRpbmcgdGFza3MgKFRyYW5zYWN0aW9uICVsbGkpIiwgbV9pZCk7CisgICAgICAgIExPRyhT dG9yYWdlQVBJLCAiSURCVHJhbnNhY3Rpb25CYWNrZW5kOjpjb21taXQgLSBOb3QgY29tbWl0dGlu ZyBub3csIHRyYW5zYWN0aW9uIHN0aWxsIGhhcyBwZW5kaW5nIHRhc2tzIChUcmFuc2FjdGlvbiAl bGxpKSIsIHN0YXRpY19jYXN0PGxvbmcgbG9uZz4obV9pZCkpOwogICAgICAgICByZXR1cm47CiAg ICAgfQogCg==