126247 2013-12-26 14:52:58 -0800 WebKitGtk 2 build fails from git 2013-12-28 00:54:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scampa.giovanni webkit-unassigned cgarcia changseok commit-queue gustavo zan oldest_to_newest 963033 0 scampa.giovanni 2013-12-26 14:52:58 -0800 Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode. The simple fix is: diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter index a01a00c..81a9725 100644 --- a/Source/autotools/symbols.filter +++ b/Source/autotools/symbols.filter @@ -2,6 +2,7 @@ global: webkit_*; WebProcessMainGtk; + NetworkProcessMain; _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv; _ZN6WebKit22WebGtkExtensionManager6sharedEv; local: I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway). Thanks! 963100 1 zan 2013-12-27 01:57:55 -0800 Feel free to upload the proper patch, someone else can commit it for you or through the commit queue (the automated commit bot for reviewed patches). 963121 2 changseok 2013-12-27 07:45:48 -0800 *** Bug 126241 has been marked as a duplicate of this bug. *** 963122 3 changseok 2013-12-27 07:49:35 -0800 (In reply to comment #0) > Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode. > > The simple fix is: > > diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter > index a01a00c..81a9725 100644 > --- a/Source/autotools/symbols.filter > +++ b/Source/autotools/symbols.filter > @@ -2,6 +2,7 @@ > global: > webkit_*; > WebProcessMainGtk; > + NetworkProcessMain; > _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv; > _ZN6WebKit22WebGtkExtensionManager6sharedEv; > local: > > I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway). Please go ahead. Sooner is better :) 963139 4 220065 scampa.giovanni 2013-12-27 15:17:19 -0800 Created attachment 220065 Patch 963160 5 220065 commit-queue 2013-12-28 00:54:34 -0800 Comment on attachment 220065 Patch Clearing flags on attachment: 220065 Committed r161110: <http://trac.webkit.org/changeset/161110> 963161 6 commit-queue 2013-12-28 00:54:36 -0800 All reviewed patches have been landed. Closing bug. 220065 2013-12-27 15:17:19 -0800 2013-12-28 00:54:33 -0800 Patch bug-126247-20131228001734.patch text/plain 1055 scampa.giovanni U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgppbmRleCBh MDFhMDBjMmFkODViYjljY2FkMTJkNWEzNTBjOWI4OTVmMjZjMDAwLi44MWE5NzI1NTI3NWIxOGNl OTcwZTk4ZTNlMzhmN2VlNDI0NjY2ZDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL3N5 bWJvbHMuZmlsdGVyCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIKQEAgLTIs NiArMiw3IEBACiBnbG9iYWw6CiAgIHdlYmtpdF8qOwogICBXZWJQcm9jZXNzTWFpbkd0azsKKyAg TmV0d29ya1Byb2Nlc3NNYWluOwogICBfWk42V2ViS2l0MjJXZWJHdGtFeHRlbnNpb25NYW5hZ2Vy MTBpbml0aWFsaXplRVBLMTRPcGFxdWVXS0J1bmRsZVBLdjsKICAgX1pONldlYktpdDIyV2ViR3Rr RXh0ZW5zaW9uTWFuYWdlcjZzaGFyZWRFdjsKIGxvY2FsOgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IGJjN2ViNTcyY2UxNjlkMWQxOTQ0NGQ5ZjczNmRjOTIxMzVhYjVl N2MuLjY2MTE4ZTljMWM0OGYzMmYwOTE4NGE4Y2IzZjA0MTY4NmY0OGQ2OWUgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0xMi0yNyAg R2lvdmFubmkgQ2FtcGFnbmEgIDxnY2FtcGFnbmFAc3JjLmdub21lLm9yZz4KKworICAgICAgICBb R1RLXSBGaXggcmVsZWFzZSBidWlsZHMgd2l0aCBOZXR3b3JrUHJvY2VzcyBlbmFibGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyNDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9hdXRv dG9vbHMvc3ltYm9scy5maWx0ZXI6CisKIDIwMTMtMTItMjUgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gUHJvcGVybHkgbmFt ZSB0aGUgSmF2YVNjcmlwdENvcmUgbGlicmFyeQo=