126246 2013-12-26 14:24:01 -0800 EWS status JSON should include Access-Control-Allow-Origin 2014-01-02 10:51:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue rniwa oldest_to_newest 963030 0 ap 2013-12-26 14:24:01 -0800 Because we need to load it from build.webkit.org. 963031 1 220036 ap 2013-12-26 14:25:25 -0800 Created attachment 220036 proposed patch 963032 2 commit-queue 2013-12-26 14:26:46 -0800 Attachment 220036 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/handlers/queuestatusjson.py', '--commit-queue']" exit_code: 1 ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:76: [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'response' member [pylint/E1101] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 963036 3 220036 rniwa 2013-12-26 15:33:48 -0800 Comment on attachment 220036 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=220036&action=review > Tools/QueueStatusServer/handlers/queuestatusjson.py:76 > + self.response.headers["Access-Control-Allow-Origin"] = "*" Should we restrict this to webkit.org sub domains? 963052 4 ap 2013-12-26 18:00:13 -0800 > Should we restrict this to webkit.org sub domains? I don't see any reason to, and that would interfere with testing from staging servers (such as 127.0.0.1). 963783 5 ap 2014-01-02 10:50:56 -0800 Committed in <http://trac.webkit.org/changeset/161098> a few days ago. 220036 2013-12-26 14:25:25 -0800 2013-12-26 15:33:48 -0800 proposed patch JSONAccessControl.txt text/plain 1705 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTA5MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTEyLTI2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEVXUyBzdGF0dXMgSlNPTiBzaG91bGQgaW5jbHVkZSBBY2Nlc3MtQ29udHJv bC1BbGxvdy1PcmlnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjI0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvYXBwLnlhbWw6IFVwZGF0ZSB2ZXJzaW9uLgorICAg ICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3F1ZXVlc3RhdHVzanNvbi5weToKKyAg ICAgICAgKFF1ZXVlU3RhdHVzSlNPTi5nZXQpOiBBZGQgdGhlIGhlYWRlciBmaWVsZC4KKwogMjAx My0xMi0yNiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBT b21lIGxpbmtzIGF0IGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIGRvbid0IHNob3cgc3RhdHVz IG1lc3NhZ2VzLCBhbmQgYXJlbid0IGtleWJvYXJkIGFjY2Vzc2libGUKSW5kZXg6IFRvb2xzL1F1 ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1F1ZXVlU3RhdHVz U2VydmVyL2FwcC55YW1sCShyZXZpc2lvbiAxNjEwOTMpCisrKyBUb29scy9RdWV1ZVN0YXR1c1Nl cnZlci9hcHAueWFtbAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIGFwcGxpY2F0aW9u OiB3ZWJraXQtcXVldWVzCi12ZXJzaW9uOiAxNjEwNjIgIyBCdWd6aWxsYSBidWcgSUQgb2YgbGFz dCBtYWpvciBjaGFuZ2UKK3ZlcnNpb246IDE2MTA5NCAjIEJ1Z3ppbGxhIGJ1ZyBJRCBvZiBsYXN0 IG1ham9yIGNoYW5nZQogcnVudGltZTogcHl0aG9uCiBhcGlfdmVyc2lvbjogMQogCkluZGV4OiBU b29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1c2pzb24ucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvcXVldWVzdGF0dXNqc29u LnB5CShyZXZpc2lvbiAxNjEwOTMpCisrKyBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVy cy9xdWV1ZXN0YXR1c2pzb24ucHkJKHdvcmtpbmcgY29weSkKQEAgLTczLDYgKzczLDggQEAgY2xh c3MgUXVldWVTdGF0dXNKU09OKHdlYmFwcC5SZXF1ZXN0SGFuZAogICAgICAgICByZXR1cm4gcmVz dWx0CiAKICAgICBkZWYgZ2V0KHNlbGYsIHF1ZXVlX25hbWUpOgorICAgICAgICBzZWxmLnJlc3Bv bnNlLmhlYWRlcnNbIkFjY2Vzcy1Db250cm9sLUFsbG93LU9yaWdpbiJdID0gIioiCisKICAgICAg ICAgcXVldWVfbmFtZSA9IHF1ZXVlX25hbWUubG93ZXIoKQogICAgICAgICBxdWV1ZSA9IFF1ZXVl LnF1ZXVlX3dpdGhfbmFtZShxdWV1ZV9uYW1lKQogICAgICAgICBpZiBub3QgcXVldWU6Cg==