126243 2013-12-26 02:08:19 -0800 [WK2][CoordinatedGraphics] Removing duplicated scale information from WebVIew.cpp 2013-12-27 02:10:17 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126022 126254 1 thiago.lacerda thiago.lacerda benjamin cmarcelo commit-queue luiz noam ryuan.choi zeno oldest_to_newest 962984 0 thiago.lacerda 2013-12-26 02:08:19 -0800 The scale factor of the WebView must reflect the same information present in WebPageProxy. Previously, in WebView.cpp, there was a m_contentScaleFactor member, which adds information duplication and needs to be synchronizing with pageScaleFactor in WebPageProxy. We can avoid this by just making WebView access and set WebPageProxy's pageScaleFactor directly. 962986 1 220029 thiago.lacerda 2013-12-26 02:15:22 -0800 Created attachment 220029 Patch 962993 2 220029 benjamin 2013-12-26 04:24:24 -0800 Comment on attachment 220029 Patch This is great. 963005 3 220029 commit-queue 2013-12-26 07:00:52 -0800 Comment on attachment 220029 Patch Clearing flags on attachment: 220029 Committed r161087: <http://trac.webkit.org/changeset/161087> 963006 4 commit-queue 2013-12-26 07:00:57 -0800 All reviewed patches have been landed. Closing bug. 963055 5 ryuan.choi 2013-12-26 18:23:11 -0800 (In reply to comment #4) > All reviewed patches have been landed. Closing bug. After this commit, we have the regression that some sites are scaling up/down infinitely while loading. ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com 963057 6 thiago.lacerda 2013-12-26 19:11:18 -0800 (In reply to comment #5) > (In reply to comment #4) > > All reviewed patches have been landed. Closing bug. > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. Maybe the same on EFL? 963058 7 ryuan.choi 2013-12-26 19:23:08 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > All reviewed patches have been landed. Closing bug. > > > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com > > We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. > Maybe the same on EFL? Not sure, can I see the patch which nix fixes? 963103 8 thiago.lacerda 2013-12-27 02:10:17 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > All reviewed patches have been landed. Closing bug. > > > > > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > > > > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com > > > > We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. > > Maybe the same on EFL? > > Not sure, can I see the patch which nix fixes? Sorry, I'm landing it today. But seems that you already found a solution :) 220029 2013-12-26 02:15:22 -0800 2013-12-26 07:00:51 -0800 Patch bug-126243-20131226071430.patch text/plain 4385 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2MwOGYwNjcyOWEzMmE5 NDNlNDA2NWQxMTBlZGZmOWYxOGMyZDcwYi4uNzYwNjU1NDliZTEzZTc2NDVlNmI3ZGNlNmY3MDRk NmRmMzNkMzczNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTEyLTI2ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtXSzJdW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFJlbW92aW5nIGR1cGxpY2F0ZSBzY2Fs ZSBpbmZvcm1hdGlvbiBmcm9tIFdlYlZJZXcuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2NhbGUgZmFjdG9yIG9mIHRoZSBXZWJWaWV3IG11 c3QgcmVmbGVjdCB0aGUgc2FtZSBpbmZvcm1hdGlvbiBwcmVzZW50IGluCisgICAgICAgIFdlYlBh Z2VQcm94eS4KKyAgICAgICAgUHJldmlvdXNseSwgaW4gV2ViVmlldy5jcHAsIHRoZXJlIHdhcyBh IG1fY29udGVudFNjYWxlRmFjdG9yIG1lbWJlciwgd2hpY2ggYWRkcworICAgICAgICBpbmZvcm1h dGlvbiBkdXBsaWNhdGlvbiBhbmQgbmVlZHMgdG8gYmUgc3luY2hyb25pemluZyB3aXRoIHBhZ2VT Y2FsZUZhY3RvciBpbgorICAgICAgICBXZWJQYWdlUHJveHkuIFdlIGNhbiBhdm9pZCB0aGlzIGJ5 IGp1c3QgbWFraW5nIFdlYlZpZXcgYWNjZXNzIGFuZCBzZXQgV2ViUGFnZVByb3h5J3MKKyAgICAg ICAgcGFnZVNjYWxlRmFjdG9yIGRpcmVjdGx5LgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6Oldl YlZpZXcpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3OjpzZXRDb250ZW50U2NhbGVGYWN0b3Ip OgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojp0cmFuc2Zvcm1Ub1NjZW5lKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlldzo6dmlzaWJsZUNvbnRlbnRzU2l6ZSk6CisgICAgICAgICogVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3Ojpjb250ZW50U2NhbGVGYWN0b3IpOgorCiAyMDEzLTEyLTI1ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTYxMDMzIGFuZCByMTYxMDc0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAppbmRleCAxMDBmYTM5YmUzNGNh M2VkOGVjNDEwNDQ0NTQ3ODgzZjA1NjA1YmU4Li43NTFkZjE2YTBjOWZjNzgyYjhiZDY5MDFiMDY1 NTRkMWRjNmMzOWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRp bmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Q29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApAQCAtNDgsNyArNDgsNiBAQCBuYW1lc3Bh Y2UgV2ViS2l0IHsKIFdlYlZpZXc6OldlYlZpZXcoV2ViQ29udGV4dCogY29udGV4dCwgV2ViUGFn ZUdyb3VwKiBwYWdlR3JvdXApCiAgICAgOiBtX2ZvY3VzZWQoZmFsc2UpCiAgICAgLCBtX3Zpc2li bGUoZmFsc2UpCi0gICAgLCBtX2NvbnRlbnRTY2FsZUZhY3RvcigxLjApCiAgICAgLCBtX29wYWNp dHkoMS4wKQogewogICAgIC8vIE5lZWQgdG8gY2FsbCBjcmVhdGVXZWJQYWdlIGFmdGVyIG90aGVy IGRhdGEgbWVtYmVycywgc3BlY2lmaWNhbGx5IG1fdmlzaWJsZSwgYXJlIGluaXRpYWxpemVkLgpA QCAtNzcsNiArNzYsMTIgQEAgdm9pZCBXZWJWaWV3Ojppbml0aWFsaXplKCkKICAgICBzZXRBY3Rp dmUodHJ1ZSk7CiB9CiAKK3ZvaWQgV2ViVmlldzo6c2V0Q29udGVudFNjYWxlRmFjdG9yKGZsb2F0 IHNjYWxlRmFjdG9yKQoreworICAgIG1fcGFnZS0+c2NhbGVQYWdlKHNjYWxlRmFjdG9yLCByb3Vu ZGVkSW50UG9pbnQoY29udGVudFBvc2l0aW9uKCkpKTsKKyAgICB1cGRhdGVWaWV3cG9ydFNpemUo KTsKK30KKwogdm9pZCBXZWJWaWV3OjpzZXRBY3RpdmUoYm9vbCBhY3RpdmUpCiB7CiAgICAgQ29v cmRpbmF0ZWRHcmFwaGljc1NjZW5lKiBzY2VuZSA9IGNvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZSgp OwpAQCAtMjM4LDcgKzI0Myw3IEBAIEFmZmluZVRyYW5zZm9ybSBXZWJWaWV3Ojp0cmFuc2Zvcm1G cm9tU2NlbmUoKSBjb25zdAogQWZmaW5lVHJhbnNmb3JtIFdlYlZpZXc6OnRyYW5zZm9ybVRvU2Nl bmUoKSBjb25zdAogewogICAgIEZsb2F0UG9pbnQgcG9zaXRpb24gPSAtbV9jb250ZW50UG9zaXRp b247Ci0gICAgZmxvYXQgZWZmZWN0aXZlU2NhbGUgPSBtX2NvbnRlbnRTY2FsZUZhY3RvciAqIG1f cGFnZS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsKKyAgICBmbG9hdCBlZmZlY3RpdmVTY2FsZSA9IGNv bnRlbnRTY2FsZUZhY3RvcigpICogbV9wYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpOwogICAgIHBv c2l0aW9uLnNjYWxlKGVmZmVjdGl2ZVNjYWxlLCBlZmZlY3RpdmVTY2FsZSk7CiAKICAgICBUcmFu c2Zvcm1hdGlvbk1hdHJpeCB0cmFuc2Zvcm0gPSBtX3VzZXJWaWV3cG9ydFRyYW5zZm9ybTsKQEAg LTI3OCw3ICsyODMsNyBAQCBpbmxpbmUgV2ViQ29yZTo6RmxvYXRTaXplIFdlYlZpZXc6OmRpcFNp emUoKSBjb25zdAogV2ViQ29yZTo6RmxvYXRTaXplIFdlYlZpZXc6OnZpc2libGVDb250ZW50c1Np emUoKSBjb25zdAogewogICAgIEZsb2F0U2l6ZSB2aXNpYmxlQ29udGVudHNTaXplKGRpcFNpemUo KSk7Ci0gICAgdmlzaWJsZUNvbnRlbnRzU2l6ZS5zY2FsZSgxIC8gbV9jb250ZW50U2NhbGVGYWN0 b3IpOworICAgIHZpc2libGVDb250ZW50c1NpemUuc2NhbGUoMSAvIGNvbnRlbnRTY2FsZUZhY3Rv cigpKTsKIAogICAgIHJldHVybiB2aXNpYmxlQ29udGVudHNTaXplOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oCmlu ZGV4IDdjMzQ0ZTlkNThhMjlkOTkwMGQyZmViMWExNzdiMjVkYWUxMTJjNzEuLjljNDg3NzdiYjgz YTFkNDcwZGQ4NzE4YzkyNDgyYmQyNjhhZTE0NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmgKQEAgLTcwLDggKzcw LDggQEAgcHVibGljOgogICAgIGJvb2wgaXNWaXNpYmxlKCkgY29uc3QgeyByZXR1cm4gbV92aXNp YmxlOyB9CiAgICAgdm9pZCBzZXRWaXNpYmxlKGJvb2wpOwogCi0gICAgdm9pZCBzZXRDb250ZW50 U2NhbGVGYWN0b3IoZmxvYXQgc2NhbGVGYWN0b3IpIHsgbV9jb250ZW50U2NhbGVGYWN0b3IgPSBz Y2FsZUZhY3RvcjsgfQotICAgIGZsb2F0IGNvbnRlbnRTY2FsZUZhY3RvcigpIGNvbnN0IHsgcmV0 dXJuIG1fY29udGVudFNjYWxlRmFjdG9yOyB9CisgICAgdm9pZCBzZXRDb250ZW50U2NhbGVGYWN0 b3IoZmxvYXQpOworICAgIGZsb2F0IGNvbnRlbnRTY2FsZUZhY3RvcigpIGNvbnN0IHsgcmV0dXJu IG1fcGFnZS0+cGFnZVNjYWxlRmFjdG9yKCk7IH0KIAogICAgIHZvaWQgc2V0Q29udGVudFBvc2l0 aW9uKGNvbnN0IFdlYkNvcmU6OkZsb2F0UG9pbnQmIHBvc2l0aW9uKSB7IG1fY29udGVudFBvc2l0 aW9uID0gcG9zaXRpb247IH0KICAgICBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50JiBjb250ZW50 UG9zaXRpb24oKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRQb3NpdGlvbjsgfQpAQCAtMjEzLDcg KzIxMyw2IEBAIHByb3RlY3RlZDoKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fc2l6ZTsgLy8gU2l6 ZSBpbiBkZXZpY2UgdW5pdHMuCiAgICAgYm9vbCBtX2ZvY3VzZWQ7CiAgICAgYm9vbCBtX3Zpc2li bGU7Ci0gICAgZmxvYXQgbV9jb250ZW50U2NhbGVGYWN0b3I7CiAgICAgZG91YmxlIG1fb3BhY2l0 eTsKICAgICBXZWJDb3JlOjpGbG9hdFBvaW50IG1fY29udGVudFBvc2l0aW9uOyAvLyBQb3NpdGlv biBpbiBVSSB1bml0cy4KICAgICBXZWJDb3JlOjpJbnRTaXplIG1fY29udGVudHNTaXplOwo=