126235 2013-12-25 15:23:17 -0800 Revision selection behavior at build.webkit.org/dashboard is annoying 2013-12-25 16:30:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue rniwa thorton timothy oldest_to_newest 962881 0 ap 2013-12-25 15:23:17 -0800 I don't like it that I can only select the numbers in "r123456", and the jagginess of user-select:all is unpleasant. Not sure if there were some deep reasons for such behavior. Let me propose a patch to see if there is something I overlook. 962882 1 220005 ap 2013-12-25 15:25:27 -0800 Created attachment 220005 proposed patch 962904 2 thorton 2013-12-25 15:59:48 -0800 Not really. My fault, I thought it would be cute (and I was repairing the user-select:none that was already there). But you're right, it's not great. 962921 3 220005 commit-queue 2013-12-25 16:30:05 -0800 Comment on attachment 220005 proposed patch Clearing flags on attachment: 220005 Committed r161078: <http://trac.webkit.org/changeset/161078> 962922 4 commit-queue 2013-12-25 16:30:07 -0800 All reviewed patches have been landed. Closing bug. 220005 2013-12-25 15:25:27 -0800 2013-12-25 16:30:05 -0800 proposed patch UserSelect.txt text/plain 2543 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTA3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTEyLTI1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlzaW9uIHNlbGVjdGlvbiBiZWhhdmlvciBhdCBidWlsZC53ZWJraXQu b3JnL2Rhc2hib2FyZCBpcyBhbm5veWluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlVmlldy5qczoK KyAgICAgICAgKEJ1aWxkYm90UXVldWVWaWV3LnByb3RvdHlwZS5yZXZpc2lvbkxpbmtzRm9ySXRl cmF0aW9uKTogTWFrZSB0aGUgd2hvbGUgbWVzc2FnZQorICAgICAgICBzZWxlY3RhYmxlLCBub3Qg anVzdCB0aGUgbnVtYmVycyBpbiBpdC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3Nz OgorICAgICAgICAoLnNlbGVjdGFibGUpOiBNYWtlIHNlbGVjdGFibGUgZW5hYmxlIGRlZmF1bHQg YmVoYXZpb3IsIG5vdCB1c2VyLXNlbGVjdDphbGwuCisKIDIwMTMtMTItMjUgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gQ2xl YW4gdXAgZ2VuZXJhdGVkIHNvdXJjZXMgZGlyZWN0b3JpZXMKSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90UXVldWVWaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90UXVldWVWaWV3LmpzCShyZXZpc2lvbiAxNjEwNDcpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlVmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAtODgs MTIgKzg4LDggQEAgQnVpbGRib3RRdWV1ZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAg dmFyIGxpbmtFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOwogICAgICAgICAg ICAgbGlua0VsZW1lbnQuaHJlZiA9IGl0ZXJhdGlvbi5xdWV1ZS5idWlsZGJvdC50cmFjUmV2aXNp b25VUkwocmV2aXNpb24sIGludGVybmFsKTsKICAgICAgICAgICAgIGxpbmtFbGVtZW50LnRhcmdl dCA9ICJfYmxhbmsiOwotICAgICAgICAgICAgbGlua0VsZW1lbnQudGV4dENvbnRlbnQgPSAiciI7 Ci0KLSAgICAgICAgICAgIHZhciByZXZpc2lvbkxhYmVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgic3BhbiIpOwotICAgICAgICAgICAgcmV2aXNpb25MYWJlbC5jbGFzc0xpc3QuYWRkKCJzZWxl Y3RhYmxlIik7Ci0gICAgICAgICAgICByZXZpc2lvbkxhYmVsLnRleHRDb250ZW50ID0gcmV2aXNp b247Ci0gICAgICAgICAgICBsaW5rRWxlbWVudC5hcHBlbmRDaGlsZChyZXZpc2lvbkxhYmVsKTsK KyAgICAgICAgICAgIGxpbmtFbGVtZW50LnRleHRDb250ZW50ID0gInIiICsgcmV2aXNpb247Cisg ICAgICAgICAgICBsaW5rRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJzZWxlY3RhYmxlIik7CiAKICAg ICAgICAgICAgIHJldHVybiBsaW5rRWxlbWVudDsKICAgICAgICAgfQpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1N0eWxlcy9NYWluLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01h aW4uY3NzCShyZXZpc2lvbiAxNjEwNDcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3Nz CSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIGE6bGluayB7CiB9CiAKIC5zZWxlY3Rh YmxlIHsKLSAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBhbGw7CisgICAgLXdlYmtpdC11c2VyLXNl bGVjdDogYXV0bzsKIH0KIAogZGl2LmNlbGxCdXR0b24gewo=