126234 2013-12-25 15:04:56 -0800 Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible 2013-12-26 11:17:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap timothy oldest_to_newest 962878 0 ap 2013-12-25 15:04:56 -0800 I think that we could use <a> for links, not <div>. 962879 1 220004 ap 2013-12-25 15:17:29 -0800 Created attachment 220004 proposed fix I think that this makes the code noticeably simpler, although I do not know if forcing display:block is a good idea. Without display:block, the label line becomes a few pixels higher, breaking layout. Is there another way around that? 963020 2 ap 2013-12-26 11:17:07 -0800 Committed <http://trac.webkit.org/r161092>. 220004 2013-12-25 15:17:29 -0800 2013-12-26 09:19:19 -0800 proposed fix UseAnchor.txt text/plain 6565 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTA3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMxIEBACisyMDEzLTEyLTI1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFNvbWUgbGlua3MgYXQgYnVpbGQud2Via2l0Lm9yZy9kYXNoYm9hcmQgZG9u J3Qgc2hvdyBzdGF0dXMgbWVzc2FnZXMsIGFuZCBhcmVuJ3Qga2V5Ym9hcmQgYWNjZXNzaWJsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjM0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCBl bGVtZW50cyB0aGF0IGFyZSBzZW1hbnRpY2FsbHkgbGlua3MgZnJvbSA8ZGl2PiB0byA8YT4uCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9TdGF0dXNMaW5lVmlldy5qczoKKyAgICAgICAgKFN0 YXR1c0xpbmVWaWV3KTogQ3JlYXRlIDxhPiBvciA8ZGl2PiBlbGVtZW50cyBjb25kaXRpb25hbGx5 IG9uIHdoZXRoZXIgd2UgaGF2ZSBhIFVSTC4KKyAgICAgICAgRG9uJ3QgdHJ5IHNpbXVsYXRlIGEg bGluayB3aXRoIENTUy9KUywgaXQncyBub3QgbmVlZGVkIGFueSBtb3JlLgorICAgICAgICAoU3Rh dHVzTGluZVZpZXcucHJvdG90eXBlLl9jbGlja2VkKTogUmVtb3ZlZC4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TdHlsZXMvQnVpbGRib3RRdWV1ZVZpZXcuY3NzOgorICAgICAgICBSZW1vdmVkIHRleHQt ZGVjb3JhdGlvbiBydWxlcywgZGVmYXVsdCBvbmVzIGluIE1haW4uY3NzIG5vdyB3b3JrIGZvciBx dWV1ZSBlbGVtZW50cy4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3M6CisgICAg ICAgIFNpbXBsaWZpZWQgY3Vyc29yIHJ1bGVzLgorICAgICAgICBBZGRlZCBhIHVuaXZlcnNhbCBy dWxlIGZvciBsaW5rcyB0byBvbmx5IHNob3cgdW5kZXJsaW5lIG9uIGhvdmVyLCBhcyB0aGlzIGlz IHdoYXQKKyAgICAgICAgd2Ugd2FudCBhbG1vc3QgZXZlcnl3aGVyZS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TdHlsZXMvU3RhdHVzTGluZVZpZXcuY3NzOgorICAgICAgICAoLnN0YXR1cy1saW5lIC5i dWJibGUpOiBBZGRlZCB0ZXh0LWRlY29yYXRpb246IG5vbmUsIGFzIHRoaXMgaXMgdGhlIG9uZSBw bGFjZSB3aGVyZQorICAgICAgICB3ZSBkb24ndCB3YW50IGl0IGV2ZW4gb24gaG92ZXIuCisgICAg ICAgICguc3RhdHVzLWxpbmUgLmxhYmVsKTogRm9yY2UgZGlzcGxheTogYmxvY2sgZm9yIGNvbnNp c3RlbnQgbGF5b3V0IGJldHdlZW4gPGE+CisgICAgICAgIGFuZCA8ZGl2Pi4KKwogMjAxMy0xMi0y NSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gW0NNYWtlXSBDbGVhbiB1cCBnZW5lcmF0ZWQgc291cmNlcyBkaXJlY3RvcmllcwpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvU3RhdHVzTGluZVZpZXcuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv ZGFzaGJvYXJkL1NjcmlwdHMvU3RhdHVzTGluZVZpZXcuanMJKHJldmlzaW9uIDE2MTA0NykKKysr IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL2Rhc2hib2FyZC9TY3JpcHRzL1N0YXR1c0xpbmVWaWV3LmpzCSh3b3JraW5nIGNvcHkpCkBA IC0zMywxMSArMzMsMjEgQEAgU3RhdHVzTGluZVZpZXcgPSBmdW5jdGlvbihtZXNzYWdlLCBzdGF0 dQogICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJzdGF0dXMtbGluZSIpOwogICAgIHRo aXMuZWxlbWVudC5fX3N0YXR1c0xpbmVWaWV3ID0gdGhpczsKIAotICAgIHRoaXMuX3N0YXR1c0J1 YmJsZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICBpZiAodXJs KSB7CisgICAgICAgIHRoaXMuX3N0YXR1c0J1YmJsZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJhIik7CisgICAgICAgIHRoaXMuX3N0YXR1c0J1YmJsZUVsZW1lbnQuaHJlZiA9IHVy bDsKKyAgICAgICAgdGhpcy5fc3RhdHVzQnViYmxlRWxlbWVudC50YXJnZXQgPSAiX2JsYW5rIjsK KyAgICB9IGVsc2UKKyAgICAgICAgdGhpcy5fc3RhdHVzQnViYmxlRWxlbWVudCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuX3N0YXR1c0J1YmJsZUVsZW1lbnQuY2xh c3NMaXN0LmFkZCgiYnViYmxlIik7CiAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu X3N0YXR1c0J1YmJsZUVsZW1lbnQpOwogCi0gICAgdGhpcy5fbGFiZWxFbGVtZW50ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgaWYgKHVybCkgeworICAgICAgICB0aGlzLl9s YWJlbEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJhIik7CisgICAgICAgIHRoaXMu X2xhYmVsRWxlbWVudC5ocmVmID0gdXJsOworICAgICAgICB0aGlzLl9sYWJlbEVsZW1lbnQudGFy Z2V0ID0gIl9ibGFuayI7CisgICAgfSBlbHNlCisgICAgICAgIHRoaXMuX2xhYmVsRWxlbWVudCA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuX2xhYmVsRWxlbWVudC5j bGFzc0xpc3QuYWRkKCJsYWJlbCIpOwogCiAgICAgdGhpcy5fbWVzc2FnZUVsZW1lbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKQEAgLTQ5LDExICs1OSw2IEBAIFN0YXR1c0xpbmVW aWV3ID0gZnVuY3Rpb24obWVzc2FnZSwgc3RhdHUKICAgICB0aGlzLmxhYmVsID0gbGFiZWwgfHwg IiI7CiAgICAgdGhpcy5yZXBlYXRDb3VudCA9IHJlcGVhdENvdW50IHx8IDA7CiAgICAgdGhpcy51 cmwgPSB1cmwgfHwgbnVsbDsKLQotICAgIGlmICh1cmwpIHsKLSAgICAgICAgdGhpcy5lbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fY2xpY2tlZC5iaW5kKHRoaXMpKTsKLSAg ICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5hZGQoImxpbmtlZCIpOwotICAgIH0KIH07CiAK IFN0YXR1c0xpbmVWaWV3LlN0YXR1cyA9IHsKQEAgLTE1MywxNyArMTU4LDUgQEAgU3RhdHVzTGlu ZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgdGhpcy5f bWVzc2FnZUVsZW1lbnQudGV4dENvbnRlbnQgPSB4OwogICAgICAgICB9Ci0gICAgfSwKLQotICAg IF9jbGlja2VkOiBmdW5jdGlvbihldmVudCkKLSAgICB7Ci0gICAgICAgIGlmICghdGhpcy51cmwp Ci0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgdmFyIGFuY2hvciA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoImEiKTsKLSAgICAgICAgYW5jaG9yLmhyZWYgPSB0aGlzLnVybDsKLSAgICAg ICAgYW5jaG9yLnRhcmdldCA9ICJfYmxhbmsiOwotCi0gICAgICAgIGFuY2hvci5jbGljaygpOwog ICAgIH0KIH07CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL0J1aWxkYm90UXVldWVWaWV3LmNz cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL0J1aWxkYm90UXVldWVWaWV3LmNz cwkocmV2aXNpb24gMTYxMDQ3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9CdWlsZGJvdFF1ZXVl Vmlldy5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTM0LDExICszNCw2IEBACiAgICAgZm9udC1mYW1p bHk6ICJIZWx2ZXRpY2FOZXVlLUxpZ2h0IiwgIkhlbHZldGljYSBOZXVlIiwgc2Fucy1zZXJpZjsK ICAgICBjb2xvcjogcmdiKDE0NSwgMTM1LCA5NSk7CiAgICAgdGV4dC1hbGlnbjogbGVmdDsKLSAg ICB0ZXh0LWRlY29yYXRpb246IG5vbmU7Ci19Ci0KLS5xdWV1ZS12aWV3IC5xdWV1ZUxhYmVsOmhv dmVyIHsKLSAgICB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsKIH0KIAogLnF1ZXVlLXZpZXcg LnF1ZXVlTGFiZWw6bm90KDpmaXJzdC1jaGlsZCkgewpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxl cy9NYWluLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCShy ZXZpc2lvbiAxNjEwNDcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCSh3b3JraW5n IGNvcHkpCkBAIC0yNSwxMyArMjUsMTYgQEAKIAogKiB7CiAgICAgYm94LXNpemluZzogYm9yZGVy LWJveDsKLSAgICBjdXJzb3I6IGRlZmF1bHQ7CiAgICAgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9u ZTsKICAgICAtd2Via2l0LXVzZXItZHJhZzogbm9uZTsKIH0KIAotYTpsaW5rIHsKLSAgICBjdXJz b3I6IHBvaW50ZXI7CithIHsKKyAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7Cit9CisKK2E6aG92 ZXIgeworICAgIHRleHQtZGVjb3JhdGlvbjogdW5kZXJsaW5lOwogfQogCiAuc2VsZWN0YWJsZSB7 CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL1N0YXR1c0xpbmVWaWV3LmNzcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL1N0YXR1c0xpbmVWaWV3LmNzcwkocmV2aXNpb24gMTYx MDQ3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9TdGF0dXNMaW5lVmlldy5jc3MJKHdvcmtpbmcg Y29weSkKQEAgLTI5LDExICsyOSw2IEBACiAgICAgcGFkZGluZzogMnB4IDA7CiB9CiAKLS5zdGF0 dXMtbGluZS5saW5rZWQsCi0uc3RhdHVzLWxpbmUubGlua2VkICogewotICAgIGN1cnNvcjogcG9p bnRlcjsKLX0KLQogLnN0YXR1cy1saW5lIC5idWJibGUgewogICAgIGZsb2F0OiBsZWZ0OwogICAg IG1pbi13aWR0aDogMjRweDsKQEAgLTQ4LDYgKzQzLDcgQEAKICAgICBvdmVyZmxvdzogaGlkZGVu OwogICAgIG1hcmdpbi10b3A6IDJweDsKICAgICBtYXJnaW4tcmlnaHQ6IDZweDsKKyAgICB0ZXh0 LWRlY29yYXRpb246IG5vbmU7CiB9CiAKIC5zdGF0dXMtbGluZS5uZXV0cmFsIC5idWJibGUgewpA QCAtOTIsNiArODgsNyBAQAogICAgIHRleHQtdHJhbnNmb3JtOiBsb3dlcmNhc2U7CiAgICAgbGlu ZS1oZWlnaHQ6IDExcHg7CiAgICAgcGFkZGluZy10b3A6IDFweDsKKyAgICBkaXNwbGF5OiBibG9j azsKIH0KIAogLnN0YXR1cy1saW5lIC5tZXNzYWdlIHsKQEAgLTEwNCwxNCArMTAxLDYgQEAKICAg ICBjb2xvcjogaW5oZXJpdDsKIH0KIAotLnN0YXR1cy1saW5lIC5tZXNzYWdlIGE6bGluayB7Ci0g ICAgdGV4dC1kZWNvcmF0aW9uOiBub25lOwotfQotCi0uc3RhdHVzLWxpbmUgLm1lc3NhZ2UgYTps aW5rOmhvdmVyIHsKLSAgICB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsKLX0KLQogLnN0YXR1 cy1saW5lLm5vLWxhYmVsIC5tZXNzYWdlIHsKICAgICBsaW5lLWhlaWdodDogMjhweDsKIH0KQEAg LTEzOSw3ICsxMjgsMyBAQAogLnN0YXR1cy1saW5lLmJhZCAubWVzc2FnZSB7CiAgICAgY29sb3I6 IHJnYigxOTEsIDY3LCA0MSk7CiB9Ci0KLS5zdGF0dXMtbGluZS5saW5rZWQgLmxhYmVsOmhvdmVy IHsKLSAgICB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsKLX0KXCBObyBuZXdsaW5lIGF0IGVu ZCBvZiBmaWxlCg==