126230 2013-12-25 10:43:40 -0800 [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix 2013-12-26 01:38:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda commit-queue dbates ossy pnormand oldest_to_newest 962842 0 thiago.lacerda 2013-12-25 10:43:40 -0800 [Nix] Adding createDragImageIconForCachedImageFilename to DragImageNix 962844 1 219996 thiago.lacerda 2013-12-25 10:46:41 -0800 Created attachment 219996 Patch 962888 2 219996 dbates 2013-12-25 15:43:06 -0800 Comment on attachment 219996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219996&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is adding a function that is materially consistent with an empty function. > Source/WebCore/platform/nix/DragImageNix.cpp:73 > + return 0; Nit: 0 => nullptr 962932 3 220018 thiago.lacerda 2013-12-25 18:26:35 -0800 Created attachment 220018 Patch for landing 962944 4 220018 commit-queue 2013-12-25 19:00:21 -0800 Comment on attachment 220018 Patch for landing Clearing flags on attachment: 220018 Committed r161081: <http://trac.webkit.org/changeset/161081> 962983 5 pnormand 2013-12-26 01:38:00 -0800 This can be closed I suppose. 219996 2013-12-25 10:46:41 -0800 2013-12-25 15:43:05 -0800 Patch bug-126230-20131225154551.patch text/plain 1283 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVhYTJhZDVjMGFiNzk1 NTc1MWY3YmIwZmU3OWY0NGU0OGIzYjg1OS4uNTM0N2ZmNmEyZmYwMGU1Nzg2NGE2MzlkNWM5NDE3 MDA1NzY4YzJiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTI1ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtOaXhdIEFkZGluZyBjcmVhdGVEcmFnSW1hZ2VJY29uRm9yQ2FjaGVkSW1hZ2VGaWxl bmFtZSBtZXRob2QgdG8gRHJhZ0ltYWdlTml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxh dGZvcm0vbml4L0RyYWdJbWFnZU5peC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVEcmFn SW1hZ2VJY29uRm9yQ2FjaGVkSW1hZ2VGaWxlbmFtZSk6CisKIDIwMTMtMTItMjQgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxNjA5NTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u aXgvRHJhZ0ltYWdlTml4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnSW1h Z2VOaXguY3BwCmluZGV4IGY3ZTc3YzVhNjFkNWMzYmEwMTU2Njk4NGQ2MmVhZWJjZDg1OGE5MTEu LmUxZjFlZTVhYzZjNGViYjE5MzU4MDBlY2EwYWY4NTVjYWQ2Nzc3NjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnSW1hZ2VOaXguY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnSW1hZ2VOaXguY3BwCkBAIC02Nyw0ICs2NywxMCBAQCBE cmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlKENhY2hlZEltYWdl KikKICAgICByZXR1cm4gMDsKIH0KIAorRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUljb25G b3JDYWNoZWRJbWFnZUZpbGVuYW1lKGNvbnN0IFN0cmluZyYpCit7CisgICAgbm90SW1wbGVtZW50 ZWQoKTsKKyAgICByZXR1cm4gMDsKK30KKwogfQo= 220018 2013-12-25 18:26:35 -0800 2013-12-25 19:00:21 -0800 Patch for landing bug-126230-20131225232544.patch text/plain 1717 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWY5YjRiNDA3ZmJmYTQ0 MmQzMTQ0YmJmMTQ3YjJkZTlmODhmMDc1My4uMDQ0NzUwYmYzYmZlYjJkOGYzZjZlNDBiNTY5NzNh NTJmMDE0YjY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTI1ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtOaXhdIEFkZGluZyBjcmVhdGVEcmFnSW1hZ2VJY29uRm9yQ2FjaGVkSW1hZ2VGaWxl bmFtZSBtZXRob2QgdG8gRHJhZ0ltYWdlTml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyMzAKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwg QmF0ZXMuCisKKyAgICAgICAgQWxzbyByZXR1cm5pbmcgbnVsbHB0ciBpbiBvdGhlciBmdW5jdGlv bnMgdGhhdCB3ZXJlIHJldHVybmluZyAwIGFzIGEgcG9pbnRlci4KKworICAgICAgICAqIHBsYXRm b3JtL25peC9EcmFnSW1hZ2VOaXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRHJhZ0lt YWdlRnJvbUltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZURyYWdJbWFnZUljb25Gb3JD YWNoZWRJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VJY29uRm9yQ2Fj aGVkSW1hZ2VGaWxlbmFtZSk6CisKIDIwMTMtMTItMjUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1x dWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNjEw MzMgYW5kIHIxNjEwNzQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uaXgv RHJhZ0ltYWdlTml4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnSW1hZ2VO aXguY3BwCmluZGV4IGY3ZTc3YzVhNjFkNWMzYmEwMTU2Njk4NGQ2MmVhZWJjZDg1OGE5MTEuLmRl NDcwYjY4Y2RiNTczYmI2NWEyZDczNGQ2ZmM1N2RmMTY0ZWQ3NDEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnSW1hZ2VOaXguY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25peC9EcmFnSW1hZ2VOaXguY3BwCkBAIC01OCwxMyArNTgsMTkgQEAgRHJh Z0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2Us IGZsb2F0KQogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZShJbWFnZSosIElt YWdlT3JpZW50YXRpb25EZXNjcmlwdGlvbikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwotICAg IHJldHVybiAwOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBEcmFnSW1hZ2VSZWYgY3JlYXRl RHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlKENhY2hlZEltYWdlKikKIHsKICAgICBub3RJbXBs ZW1lbnRlZCgpOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBudWxscHRyOworfQorCitEcmFn SW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlRmlsZW5hbWUoY29uc3Qg U3RyaW5nJikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiBudWxscHRyOwog fQogCiB9Cg==