126229 2013-12-25 10:39:34 -0800 [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp 2013-12-26 01:58:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda commit-queue dbates ossy oldest_to_newest 962840 0 thiago.lacerda 2013-12-25 10:39:34 -0800 [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp 962841 1 219995 thiago.lacerda 2013-12-25 10:41:21 -0800 Created attachment 219995 Patch 962884 2 219995 dbates 2013-12-25 15:39:19 -0800 Comment on attachment 219995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix. > Source/WebCore/platform/nix/DragDataNix.cpp:90 > return 0; Nit: 0 => nullptr 962930 3 thiago.lacerda 2013-12-25 18:18:48 -0800 (In reply to comment #2) > (From update of attachment 219995 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix. OK > > > Source/WebCore/platform/nix/DragDataNix.cpp:90 > > return 0; > > Nit: 0 => nullptr OK 962931 4 220017 thiago.lacerda 2013-12-25 18:19:36 -0800 Created attachment 220017 Patch for landing 962940 5 220017 commit-queue 2013-12-25 18:54:24 -0800 Comment on attachment 220017 Patch for landing Clearing flags on attachment: 220017 Committed r161080: <http://trac.webkit.org/changeset/161080> 219995 2013-12-25 10:41:21 -0800 2013-12-25 15:39:19 -0800 Patch bug-126229-20131225154031.patch text/plain 1343 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVhYTJhZDVjMGFiNzk1 NTc1MWY3YmIwZmU3OWY0NGU0OGIzYjg1OS4uZjUzNGJkZDFlYzJiYzdjOGVlOTgzYTIxNzUxZTJh YjU0OWI3NzI3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTI1ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtOaXhdIEZpeGluZyBEcmFnRGF0YTo6YXNGcmFnbWVudCBzaWduYXR1cmUgaW4gRHJh Z0RhdGFOaXguY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjYyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbml4L0RyYWdE YXRhTml4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjphc0ZyYWdtZW50KToKKwog MjAxMy0xMi0yNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE2MDk1OS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnRGF0YU5peC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uaXgvRHJhZ0RhdGFOaXguY3BwCmluZGV4IDlmZmI2OTg2YWZhNGYyMWViMDI3NTc3 YjZmMWFjMTY0OTcxNWM3NzUuLjU2NzA0MWY0YWZjZjhkZDJlMzFjYzhhNmRlYmQ0NDViNTI5N2Ji OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnRGF0YU5peC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbml4L0RyYWdEYXRhTml4LmNwcApAQCAt ODUsNyArODUsNyBAQCBTdHJpbmcgRHJhZ0RhdGE6OmFzVVJMKEZyYW1lKiwgRmlsZW5hbWVDb252 ZXJzaW9uUG9saWN5LCBTdHJpbmcqKSBjb25zdAogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAot UGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFnbWVudChGcmFtZSos IFBhc3NSZWZQdHI8UmFuZ2U+LCBib29sLCBib29sJikgY29uc3QKK1Bhc3NSZWZQdHI8RG9jdW1l bnRGcmFnbWVudD4gRHJhZ0RhdGE6OmFzRnJhZ21lbnQoRnJhbWUqLCBSYW5nZSYsIGJvb2wsIGJv b2wmKSBjb25zdAogewogICAgIHJldHVybiAwOwogfQo= 220017 2013-12-25 18:19:36 -0800 2013-12-25 18:54:24 -0800 Patch for landing bug-126229-20131225231845.patch text/plain 1347 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWY5YjRiNDA3ZmJmYTQ0 MmQzMTQ0YmJmMTQ3YjJkZTlmODhmMDc1My4uY2YwMjkwMzZlY2FlNmU2MzVlMDkxMjEyN2RhNmVh ZTEyMmYxOWEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTI1ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtOaXhdIEZpeGluZyBEcmFnRGF0YTo6YXNGcmFnbWVudCBzaWduYXR1cmUgaW4gRHJh Z0RhdGFOaXguY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjYyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uaXgvRHJhZ0RhdGFOaXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJh Z0RhdGE6OmFzRnJhZ21lbnQpOgorCiAyMDEzLTEyLTI1ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYx MDMzIGFuZCByMTYxMDc0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbml4 L0RyYWdEYXRhTml4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25peC9EcmFnRGF0YU5p eC5jcHAKaW5kZXggOWZmYjY5ODZhZmE0ZjIxZWIwMjc1NzdiNmYxYWMxNjQ5NzE1Yzc3NS4uZTQx OTZmMjYzMDc4YWJjNWJmYmM1OTlhOTczYjNlOTFjNDc5OTJhMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbml4L0RyYWdEYXRhTml4LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uaXgvRHJhZ0RhdGFOaXguY3BwCkBAIC04NSw5ICs4NSw5IEBAIFN0cmluZyBE cmFnRGF0YTo6YXNVUkwoRnJhbWUqLCBGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3ksIFN0cmluZyop IGNvbnN0CiAgICAgcmV0dXJuIFN0cmluZygpOwogfQogCi1QYXNzUmVmUHRyPERvY3VtZW50RnJh Z21lbnQ+IERyYWdEYXRhOjphc0ZyYWdtZW50KEZyYW1lKiwgUGFzc1JlZlB0cjxSYW5nZT4sIGJv b2wsIGJvb2wmKSBjb25zdAorUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6 YXNGcmFnbWVudChGcmFtZSosIFJhbmdlJiwgYm9vbCwgYm9vbCYpIGNvbnN0CiB7Ci0gICAgcmV0 dXJuIDA7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIH0K