126225 2013-12-25 01:41:45 -0800 [GTK] Fix warnings when generating WebExtensions gobject-instrospection files 2013-12-25 01:53:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 962822 0 cgarcia 2013-12-25 01:41:45 -0800 Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:414: Warning: WebKit2WebExtension: webkit_web_page_get_dom_document: return value: Missing (transfer) annotation Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:68: Warning: WebKit2WebExtension: webkit_web_page_get_main_frame: return value: Missing (transfer) annotation webkit_web_page_get_main_frame is not even documented :-P 962823 1 219988 cgarcia 2013-12-25 01:44:07 -0800 Created attachment 219988 Patch 962824 2 219988 pnormand 2013-12-25 01:47:54 -0800 Comment on attachment 219988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219988&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:466 > + * Retruns the main frame of a #WebKitWebPage. Returns 962826 3 cgarcia 2013-12-25 01:53:02 -0800 Committed r161064: <http://trac.webkit.org/changeset/161064> 219988 2013-12-25 01:44:07 -0800 2013-12-25 01:47:54 -0800 Patch wk2-extensions-gi-warnings.diff text/plain 2050 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkYjQ4NTRlLi5hYWFjMTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMTItMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEZpeCB3YXJuaW5ncyB3aGVuIGdlbmVyYXRpbmcgV2ViRXh0ZW5z aW9ucyBnb2JqZWN0LWluc3Ryb3NwZWN0aW9uIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdHJhbnNmZXIgYW5ub3RhdGlvbiB0byB3ZWJr aXRfd2ViX3BhZ2VfZ2V0X2RvbV9kb2N1bWVudCgpIGFuZAorICAgICAgICBkb2N1bWVudCB3ZWJr aXRfd2ViX3BhZ2VfZ2V0X21haW5fZnJhbWUoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdlLmNwcDoKKworMjAxMy0xMi0yNSAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10g TWlzc2luZyBpbnRyb3NwZWN0aW9uIGluZm9ybWF0aW9uIGZvciBXZWJFeHRlbnNpb25zCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI0MDcKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3Rr L1dlYktpdFdlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvZ3RrL1dlYktpdFdlYlBhZ2UuY3BwCmluZGV4IDU5YjY0NjUuLjU2NzEzNDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0 ay9XZWJLaXRXZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViUGFnZS5jcHAKQEAgLTQxMSw3ICs0MTEsNyBAQCB2 b2lkIHdlYmtpdFdlYlBhZ2VEaWRSZWNlaXZlTWVzc2FnZShXZWJLaXRXZWJQYWdlKiBwYWdlLCBj b25zdCBTdHJpbmcmIG1lc3NhZ2VOYQogICoKICAqIEdldCB0aGUgI1dlYktpdERPTURvY3VtZW50 IGN1cnJlbnRseSBsb2FkZWQgaW4gQHdlYl9wYWdlCiAgKgotICogUmV0dXJuczogdGhlICNXZWJL aXRET01Eb2N1bWVudCBjdXJyZW50bHkgbG9hZGVkLCBvciAlTlVMTAorICogUmV0dXJuczogKHRy YW5zZmVyIG5vbmUpOiB0aGUgI1dlYktpdERPTURvY3VtZW50IGN1cnJlbnRseSBsb2FkZWQsIG9y ICVOVUxMCiAgKiAgICBpZiBubyBkb2N1bWVudCBpcyBjdXJyZW50bHkgbG9hZGVkLgogICovCiBX ZWJLaXRET01Eb2N1bWVudCogd2Via2l0X3dlYl9wYWdlX2dldF9kb21fZG9jdW1lbnQoV2ViS2l0 V2ViUGFnZSogd2ViUGFnZSkKQEAgLTQ1OSw2ICs0NTksMTYgQEAgY29uc3QgZ2NoYXIqIHdlYmtp dF93ZWJfcGFnZV9nZXRfdXJpKFdlYktpdFdlYlBhZ2UqIHdlYlBhZ2UpCiAgICAgcmV0dXJuIHdl YlBhZ2UtPnByaXYtPnVyaS5kYXRhKCk7CiB9CiAKKy8qKgorICogd2Via2l0X3dlYl9wYWdlX2dl dF9tYWluX2ZyYW1lOgorICogQHdlYl9wYWdlOiBhICNXZWJLaXRXZWJQYWdlCisgKgorICogUmV0 cnVucyB0aGUgbWFpbiBmcmFtZSBvZiBhICNXZWJLaXRXZWJQYWdlLgorICoKKyAqIFJldHVybnM6 ICh0cmFuc2ZlciBub25lKTogdGhlICNXZWJLaXRGcmFtZSB0aGF0IGlzIHRoZSBtYWluIGZyYW1l IG9mIEB3ZWJfcGFnZQorICoKKyAqIFNpbmNlOiAyLjIKKyAqLwogV2ViS2l0RnJhbWUqIHdlYmtp dF93ZWJfcGFnZV9nZXRfbWFpbl9mcmFtZShXZWJLaXRXZWJQYWdlKiB3ZWJQYWdlKQogewogICAg IGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfUEFHRSh3ZWJQYWdlKSwgMCk7Cg==