126196 2013-12-23 17:47:56 -0800 Add the pseudo classes link and any-link to the Selector Code Generator 2013-12-23 19:25:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue esprehn+autocc kangil.han koivisto rniwa oldest_to_newest 962669 0 benjamin 2013-12-23 17:47:56 -0800 Add the pseudo classes link and any-link to the Selector Code Generator 962670 1 219949 benjamin 2013-12-23 17:48:27 -0800 Created attachment 219949 Patch 962683 2 219949 rniwa 2013-12-23 18:36:40 -0800 Comment on attachment 219949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219949&action=review > Source/WebCore/dom/Node.h:566 > static ptrdiff_t nodeFlagsMemoryOffset() { return OBJECT_OFFSETOF(Node, m_nodeFlags); } > - static uint8_t flagIsElement() { return IsElementFlag; } > + static int32_t flagIsElement() { return IsElementFlag; } > + static int32_t flagIsLink() { return IsLinkFlag; } It's unfortunate that we have to expose flags... ideally we have some mechanism to assert that the flag condition we're checking is consistent with Node's implementation. 962697 3 219949 benjamin 2013-12-23 19:25:27 -0800 Comment on attachment 219949 Patch Clearing flags on attachment: 219949 Committed r161046: <http://trac.webkit.org/changeset/161046> 962698 4 benjamin 2013-12-23 19:25:29 -0800 All reviewed patches have been landed. Closing bug. 219949 2013-12-23 17:48:27 -0800 2013-12-23 19:25:26 -0800 Patch bug-126196-20131223174826.patch text/plain 3755 benjamin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTA0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEyLTIzICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgdGhlIHBzZXVk byBjbGFzc2VzIGxpbmsgYW5kIGFueS1saW5rIHRvIHRoZSBTZWxlY3RvciBDb2RlIEdlbmVyYXRv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MTk2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3Nq aXQvU2VsZWN0b3JDb21waWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNvbXBp bGVyOjphZGRQc2V1ZG9UeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ29tcGlsZXI6 OlNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVFbGVtZW50TWF0Y2hpbmcpOgorICAgICAg ICAoV2ViQ29yZTo6U2VsZWN0b3JDb21waWxlcjo6U2VsZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5l cmF0ZUVsZW1lbnRJc0xpbmspOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisgICAgICAgIChXZWJD b3JlOjpOb2RlOjpmbGFnSXNFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmZsYWdJ c0xpbmspOgorICAgICAgICBGaXggdGhlIHR5cGUgdG8gbWF0Y2ggVHJ1c3RlZEltbTMyLgorCiAy MDEzLTEyLTIzICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBBZGQgdGhlIHBzZXVkbyBjbGFzcyA6Zm9jdXMgdG8gdGhlIFNlbGVjdG9yIENvZGUgR2Vu ZXJhdG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3Bw CShyZXZpc2lvbiAxNjEwNDEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21w aWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Myw2ICsxNDMsNyBAQCBwcml2YXRlOgogICAg IHZvaWQgZ2VuZXJhdGVFbGVtZW50SGFzSWQoQXNzZW1ibGVyOjpKdW1wTGlzdCYgZmFpbHVyZUNh c2VzLCBjb25zdCBMb2NhbFJlZ2lzdGVyJiBlbGVtZW50RGF0YUFkZHJlc3MsIGNvbnN0IEF0b21p Y1N0cmluZyYgaWRUb01hdGNoKTsKICAgICB2b2lkIGdlbmVyYXRlRWxlbWVudEhhc0NsYXNzZXMo QXNzZW1ibGVyOjpKdW1wTGlzdCYgZmFpbHVyZUNhc2VzLCBjb25zdCBMb2NhbFJlZ2lzdGVyJiBl bGVtZW50RGF0YUFkZHJlc3MsIGNvbnN0IFZlY3Rvcjxjb25zdCBBdG9taWNTdHJpbmdJbXBsKj4m IGNsYXNzTmFtZXMpOwogICAgIHZvaWQgZ2VuZXJhdGVFbGVtZW50SXNGb2N1c2VkKEFzc2VtYmxl cjo6SnVtcExpc3QmIGZhaWx1cmVDYXNlcyk7CisgICAgdm9pZCBnZW5lcmF0ZUVsZW1lbnRJc0xp bmsoQXNzZW1ibGVyOjpKdW1wTGlzdCYgZmFpbHVyZUNhc2VzKTsKIAogICAgIEFzc2VtYmxlciBt X2Fzc2VtYmxlcjsKICAgICBSZWdpc3RlckFsbG9jYXRvciBtX3JlZ2lzdGVyQWxsb2NhdG9yOwpA QCAtMjA0LDYgKzIwNSwxMCBAQCBzdGF0aWMgaW5saW5lIEZ1bmN0aW9uVHlwZSBtb3N0UmVzdHJp Y3RpCiBzdGF0aWMgaW5saW5lIEZ1bmN0aW9uVHlwZSBhZGRQc2V1ZG9UeXBlKENTU1NlbGVjdG9y OjpQc2V1ZG9UeXBlIHR5cGUsIEhhc2hTZXQ8dW5zaWduZWQ+JiBwc2V1ZG9DbGFzc2VzKQogewog ICAgIHN3aXRjaCAodHlwZSkgeworICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0FueUxpbms6 CisgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvTGluazoKKyAgICAgICAgcHNldWRvQ2xhc3Nl cy5hZGQoQ1NTU2VsZWN0b3I6OlBzZXVkb0xpbmspOworICAgICAgICByZXR1cm4gRnVuY3Rpb25U eXBlOjpTaW1wbGVTZWxlY3RvckNoZWNrZXI7CiAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRv Rm9jdXM6CiAgICAgICAgIHBzZXVkb0NsYXNzZXMuYWRkKENTU1NlbGVjdG9yOjpQc2V1ZG9Gb2N1 cyk7CiAgICAgICAgIHJldHVybiBGdW5jdGlvblR5cGU6OlNpbXBsZVNlbGVjdG9yQ2hlY2tlcjsK QEAgLTc2OCw2ICs3NzMsOSBAQCB2b2lkIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVC YWNrCiAKIHZvaWQgU2VsZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZUVsZW1lbnRNYXRjaGlu ZyhBc3NlbWJsZXI6Okp1bXBMaXN0JiBmYWlsdXJlQ2FzZXMsIGNvbnN0IFNlbGVjdG9yRnJhZ21l bnQmIGZyYWdtZW50KQogeworICAgIGlmIChmcmFnbWVudC5wc2V1ZG9DbGFzc2VzLmNvbnRhaW5z KENTU1NlbGVjdG9yOjpQc2V1ZG9MaW5rKSkKKyAgICAgICAgZ2VuZXJhdGVFbGVtZW50SXNMaW5r KGZhaWx1cmVDYXNlcyk7CisKICAgICBpZiAoZnJhZ21lbnQudGFnTmFtZSkKICAgICAgICAgZ2Vu ZXJhdGVFbGVtZW50SGFzVGFnTmFtZShmYWlsdXJlQ2FzZXMsICooZnJhZ21lbnQudGFnTmFtZSkp OwogCkBAIC04NzQsNiArODgyLDExIEBAIHZvaWQgU2VsZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5l cmF0ZUVsZW0KICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGZ1bmN0aW9uQ2FsbC5jYWxsQW5kQnJh bmNoT25Db25kaXRpb24oQXNzZW1ibGVyOjpaZXJvKSk7CiB9CiAKK3ZvaWQgU2VsZWN0b3JDb2Rl R2VuZXJhdG9yOjpnZW5lcmF0ZUVsZW1lbnRJc0xpbmsoQXNzZW1ibGVyOjpKdW1wTGlzdCYgZmFp bHVyZUNhc2VzKQoreworICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQobV9hc3NlbWJsZXIuYnJhbmNo VGVzdDMyKEFzc2VtYmxlcjo6WmVybywgQXNzZW1ibGVyOjpBZGRyZXNzKGVsZW1lbnRBZGRyZXNz UmVnaXN0ZXIsIE5vZGU6Om5vZGVGbGFnc01lbW9yeU9mZnNldCgpKSwgQXNzZW1ibGVyOjpUcnVz dGVkSW1tMzIoTm9kZTo6ZmxhZ0lzTGluaygpKSkpOworfQorCiB9OyAvLyBuYW1lc3BhY2UgU2Vs ZWN0b3JDb21waWxlci4KIH07IC8vIG5hbWVzcGFjZSBXZWJDb3JlLgogCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl LmgJKHJldmlzaW9uIDE2MTA0MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgJKHdvcmtp bmcgY29weSkKQEAgLTU2Miw3ICs1NjIsOCBAQCBwdWJsaWM6CiAKICNpZiBFTkFCTEUoQ1NTX1NF TEVDVE9SX0pJVCkKICAgICBzdGF0aWMgcHRyZGlmZl90IG5vZGVGbGFnc01lbW9yeU9mZnNldCgp IHsgcmV0dXJuIE9CSkVDVF9PRkZTRVRPRihOb2RlLCBtX25vZGVGbGFncyk7IH0KLSAgICBzdGF0 aWMgdWludDhfdCBmbGFnSXNFbGVtZW50KCkgeyByZXR1cm4gSXNFbGVtZW50RmxhZzsgfQorICAg IHN0YXRpYyBpbnQzMl90IGZsYWdJc0VsZW1lbnQoKSB7IHJldHVybiBJc0VsZW1lbnRGbGFnOyB9 CisgICAgc3RhdGljIGludDMyX3QgZmxhZ0lzTGluaygpIHsgcmV0dXJuIElzTGlua0ZsYWc7IH0K ICNlbmRpZiAvLyBFTkFCTEUoQ1NTX1NFTEVDVE9SX0pJVCkKIAogcHJvdGVjdGVkOgo=