126191 2013-12-23 16:39:49 -0800 CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame() 2014-02-13 03:48:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 126790 P2 Normal --- 125849 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 962641 0 mark.lam 2013-12-23 16:39:49 -0800 1. JSStack::disableErrorStackReserve() was wrongly comparing m_end with m_useableTop. Fixed the comparison. 2. JSStack::installTrapsAfterFrame() is wrongly overwriting the top slow of the top frame. Fixed to start the traps at the slot below (as in at lower memory than) the top slot in the top frame. 962643 1 219941 mark.lam 2013-12-23 16:45:04 -0800 Created attachment 219941 the patch. 962647 2 mark.lam 2013-12-23 16:46:50 -0800 Landed in r161038 on the jsCStack branch: <http://trac.webkit.org/r161038>. 962650 3 219941 fpizlo 2013-12-23 16:57:03 -0800 Comment on attachment 219941 the patch. Is it possible to have tests for this? 967574 4 mark.lam 2014-01-13 17:26:36 -0800 Both JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame() were removed in r161927: <http://trac.webkit.org/r161927> for https://bugs.webkit.org/show_bug.cgi?id=126790. This bug is no longer relevant. *** This bug has been marked as a duplicate of bug 126790 *** 980218 5 219941 ossy 2014-02-13 03:48:55 -0800 Comment on attachment 219941 the patch. Cleared review? from attachment 219941 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 219941 2013-12-23 16:45:04 -0800 2014-02-13 03:48:55 -0800 the patch. bug-126191.patch text/plain 2513 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTEyLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6Rml4ZWQgSlNTdGFjazo6ZGlzYWJsZUVycm9yU3RhY2tSZXNlcnZlKCkgYW5kIEpTU3Rh Y2s6Omluc3RhbGxUcmFwc0FmdGVyRnJhbWUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjE5MS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAxLiBKU1N0YWNrOjpkaXNhYmxlRXJyb3JTdGFja1Jlc2Vy dmUoKSB3YXMgd3JvbmdseSBjb21wYXJpbmcgbV9lbmQgd2l0aCBtX3VzZWFibGVUb3AuCisgICAg ICAgICAgIEZpeGVkIHRoZSBjb21wYXJpc29uLgorICAgICAgICAyLiBKU1N0YWNrOjppbnN0YWxs VHJhcHNBZnRlckZyYW1lKCkgd2FzIHdyb25nbHkgb3ZlcndyaXRpbmcgdGhlIHRvcCBzbG90IG9m IHRoZSB0b3AKKyAgICAgICAgICAgZnJhbWUuIEZpeGVkIHRvIHN0YXJ0IHRoZSB0cmFwIHdvcmRz IGF0IHRoZSBzbG90IGJlbG93IHRoZSB0b3Agc2xvdCBpbiB0aGUgdG9wCisgICAgICAgICAgIGZy YW1lIChhcyBpbiBhdCBsb3dlciBtZW1vcnkgYmVsb3cgdGhlIGFsbG9jYXRlZCBzdGFjayBtZW1v cnkgYWJvdmUgaXQpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHA6CisgICAg ICAgIChKU0M6OkpTU3RhY2s6OmRpc2FibGVFcnJvclN0YWNrUmVzZXJ2ZSk6CisgICAgICAgICog aW50ZXJwcmV0ZXIvSlNTdGFja0lubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6aW5z dGFsbFRyYXBzQWZ0ZXJGcmFtZSk6CisKIDIwMTMtMTItMjMgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIENTdGFjazogRml4IEpTU3RhY2s6Omdyb3coKSwgc2hyaW5r KCksIGdyb3dTbG93Q2FzZSgpLCBhbmQgc2V0U3RhY2tMaW1pdCgpLgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmNwcAkocmV2aXNpb24gMTYxMDM2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjAsNyArMTYwLDcgQEAgdm9pZCBKU1N0YWNrOjpkaXNhYmxlRXJyb3JT dGFja1Jlc2VydmUoKQogICAgIC8vIHBsYWNlLiBUaGF0IG1lYW5zIHRoZSBzdGFjayBzcGFjZSBi ZXlvbmQgbV91c2VhYmxlVG9wIGJlZm9yZSB3ZQogICAgIC8vIGVuYWJsZWQgdGhlIHJlc2VydmUg d2FzIG5vdCBwcmV2aW91c2x5IGluIHVzZS4gSGVuY2UsIGl0IGlzIHNhZmUgdG8KICAgICAvLyBz aHJpbmsgYmFjayB0byB0aGF0IG1fdXNlYWJsZVRvcC4KLSAgICBpZiAobV9lbmQgPCBtX3VzZWFi bGVUb3ApIHsKKyAgICBpZiAobV9lbmQgKyAxIDwgbV91c2VhYmxlVG9wKSB7CiAgICAgICAgIEFT U0VSVChtX3RvcENhbGxGcmFtZS0+dG9wT2ZGcmFtZSgpID4gbV91c2VhYmxlVG9wKTsKICAgICAg ICAgc2hyaW5rKG1fdXNlYWJsZVRvcCk7CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2ludGVycHJldGVyL0pTU3RhY2tJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2tJbmxpbmVzLmgJKHJldmlzaW9uIDE2MTAz NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrSW5saW5lcy5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsOCArMjk1LDggQEAgaW5saW5lIHZvaWQgSlNTdGFjazo6 aW5zdGFsbFRyYXBzQWZ0ZXJGcgogCiAgICAgLy8gTGF5IHRoZSB0cmFwczoKICAgICBpbnQzMl90 KiBwID0gc3RhcnRPZlRyYXA7Ci0gICAgd2hpbGUgKHAgPiBlbmRPZlRyYXApCi0gICAgICAgICpw LS0gPSAweGFiYWRjYWZlOyAvLyBBIGJhZCB3b3JkIHRvIHRyaWdnZXIgYSBjcmFzaCBpZiBkZXJl ZidlZC4KKyAgICB3aGlsZSAoLS1wID49IGVuZE9mVHJhcCkKKyAgICAgICAgKnAgPSAweGFiYWRj YWZlOyAvLyBBIGJhZCB3b3JkIHRvIHRyaWdnZXIgYSBjcmFzaCBpZiBkZXJlZidlZC4KIH0KICNl bmRpZiAvLyBFTkFCTEUoREVCVUdfSlNTVEFDSykKICNlbmRpZiAvLyBFTkFCTEUoTExJTlRfQ19M T09QKQo=