126187 2013-12-23 15:55:13 -0800 Refactor PutPropertySlot to be aware of custom properties 2014-01-02 12:52:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126240 1 oliver oliver ap commit-queue rniwa oldest_to_newest 962626 0 oliver 2013-12-23 15:55:13 -0800 Refactor PutPropertySlot to be aware of custom properties 962628 1 oliver 2013-12-23 16:08:04 -0800 Committed r161033: <http://trac.webkit.org/changeset/161033> 962731 2 rniwa 2013-12-24 00:22:16 -0800 Looks like this caused http/tests/security/cross-frame-access-put.html to start to fail: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-put.html --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt @@ -1,5 +1,4 @@ CONSOLE MESSAGE: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match. -CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. @@ -381,5 +380,6 @@ This test checks cross-frame access security of window attribute setters (rdar://problem/5326791). +PASS: Unable to set property constructor: TypeError: Type error MAIN WINDOW: !!-- Test ended--!! 962901 3 ap 2013-12-25 15:56:57 -0800 Filed bug 126238 (although maybe it would be better to roll out?) 962907 4 oliver 2013-12-25 16:07:49 -0800 (In reply to comment #3) > Filed bug 126238 (although maybe it would be better to roll out?) Honestly i don't think i'm going to get to this as soon as i though, so a rollout is probably best :( 962913 5 commit-queue 2013-12-25 16:23:38 -0800 Re-opened since this is blocked by bug 126240 962920 6 ap 2013-12-25 16:28:01 -0800 OK, rolled out in <http://trac.webkit.org/changeset/161077>. 963845 7 oliver 2014-01-02 12:52:39 -0800 Committed r161220: <http://trac.webkit.org/changeset/161220>