126186 2013-12-23 15:26:43 -0800 CStack: Cosmetic: rename JSStack::m_commitEnd to m_commitTop. 2014-01-13 17:58:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125849 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 962618 0 mark.lam 2013-12-23 15:26:43 -0800 In the JSStack constructor, m_commitEnd is initialized to highAddress() which is the address just above the start of the stack. This is appropriate because no memory has been committed for the stack yet i.e. highAddress() - m_commitEnd should equal 0. When we grow the stack in growSlowCase, we set m_commitEnd to m_commitEnd - delta, where delta is some even multiple of commitSize (some units of page size). This means that if there is memory committed, m_commitEnd would point to an allocatable slot in the stack, not past it. Hence, m_commitEnd should more appropriately be named m_commitTop. 962619 1 219937 mark.lam 2013-12-23 15:36:05 -0800 Created attachment 219937 the patch. 962620 2 219938 mark.lam 2013-12-23 15:36:05 -0800 Created attachment 219938 962622 3 mark.lam 2013-12-23 15:40:02 -0800 Landed in r161030 on the jsCStack branch: <http://trac.webkit.org/r161030>. 967581 4 219937 ggaren 2014-01-13 17:41:35 -0800 Comment on attachment 219937 the patch. r=me 967587 5 mark.lam 2014-01-13 17:58:21 -0800 Thanks. Review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>. 219937 2013-12-23 15:36:05 -0800 2014-01-13 17:41:35 -0800 the patch. bug-126186.patch text/plain 6713 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDEzLTEyLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IENvc21ldGljOiByZW5hbWUgSlNTdGFjazo6bV9jb21taXRFbmQgdG8gbV9jb21taXRU b3AuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYx ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiB0 aGUgSlNTdGFjayBjb25zdHJ1Y3RvciwgbV9jb21taXRFbmQgaXMgaW5pdGlhbGl6ZWQgdG8gaGln aEFkZHJlc3MoKQorICAgICAgICB3aGljaCBpcyB0aGUgYWRkcmVzcyBqdXN0IGFib3ZlIHRoZSBz dGFydCBvZiB0aGUgc3RhY2suIFRoaXMgaXMKKyAgICAgICAgYXBwcm9wcmlhdGUgYmVjYXVzZSBu byBtZW1vcnkgaGFzIGJlZW4gY29tbWl0dGVkIGZvciB0aGUgc3RhY2sgeWV0IGkuZS4KKyAgICAg ICAgaGlnaEFkZHJlc3MoKSAtIG1fY29tbWl0RW5kIHNob3VsZCBlcXVhbCAwLgorCisgICAgICAg IFdoZW4gd2UgZ3JvdyB0aGUgc3RhY2sgaW4gZ3Jvd1Nsb3dDYXNlLCB3ZSBzZXQgbV9jb21taXRF bmQgdG8KKyAgICAgICAgbV9jb21taXRFbmQgLSBkZWx0YSwgd2hlcmUgZGVsdGEgaXMgc29tZSBl dmVuIG11bHRpcGxlIG9mIGNvbW1pdFNpemUKKyAgICAgICAgKHNvbWUgdW5pdHMgb2YgcGFnZSBz aXplKS4gVGhpcyBtZWFucyB0aGF0IGlmIHRoZXJlIGlzIG1lbW9yeSBjb21taXR0ZWQsCisgICAg ICAgIG1fY29tbWl0RW5kIHdvdWxkIHBvaW50IHRvIGFuIGFsbG9jYXRhYmxlIHNsb3QgaW4gdGhl IHN0YWNrLCBub3QgcGFzdCBpdC4KKyAgICAgICAgSGVuY2UsIG1fY29tbWl0RW5kIHNob3VsZCBt b3JlIGFwcHJvcHJpYXRlbHkgYmUgbmFtZWQgbV9jb21taXRUb3AuCisKKyAgICAgICAgKiBpbnRl cnByZXRlci9KU1N0YWNrLmNwcDoKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6SlNTdGFjayk6Cisg ICAgICAgIChKU0M6OkpTU3RhY2s6On5KU1N0YWNrKToKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6 Z3Jvd1Nsb3dDYXNlKToKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6cmVsZWFzZUV4Y2Vzc0NhcGFj aXR5KToKKyAgICAgICAgKiBpbnRlcnByZXRlci9KU1N0YWNrLmg6CisgICAgICAgICogaW50ZXJw cmV0ZXIvSlNTdGFja0lubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6c2hyaW5rKToK KyAgICAgICAgKEpTQzo6SlNTdGFjazo6aW5zdGFsbFRyYXBzQWZ0ZXJGcmFtZSk6CisKIDIwMTMt MTItMjMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENTdGFjazog Q29zbWV0aWM6IHJlbmFtZSBKU1N0YWNrOjptX3VzZWFibGVFbmQgdG8gbV91c2VhYmxlVG9wLgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmNwcAko cmV2aXNpb24gMTYxMDI3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pT U3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1OCw3IEBAIEpTU3RhY2s6OkpTU3Rh Y2soVk0mIHZtKQogCiAgICAgbV9yZXNlcnZhdGlvbiA9IFBhZ2VSZXNlcnZhdGlvbjo6cmVzZXJ2 ZShyb3VuZFVwQWxsb2NhdGlvblNpemUoY2FwYWNpdHkgKiBzaXplb2YoUmVnaXN0ZXIpLCBjb21t aXRTaXplKSwgT1NBbGxvY2F0b3I6OkpTVk1TdGFja1BhZ2VzKTsKICAgICBzZXRTdGFja0xpbWl0 KGhpZ2hBZGRyZXNzKCkpOwotICAgIG1fY29tbWl0RW5kID0gaGlnaEFkZHJlc3MoKTsKKyAgICBt X2NvbW1pdFRvcCA9IGhpZ2hBZGRyZXNzKCk7CiAgICAgCiAgICAgbV9sYXN0U3RhY2tUb3AgPSBi YXNlT2ZTdGFjaygpOwogCkBAIC03Miw4ICs3Miw4IEBAIEpTU3RhY2s6OkpTU3RhY2soVk0mIHZt KQogSlNTdGFjazo6fkpTU3RhY2soKQogewogICAgIHZvaWQqIGhpZ2hBZGRyZXNzID0gcmVpbnRl cnByZXRfY2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8Y2hhcio+KG1fcmVzZXJ2YXRpb24uYmFzZSgp KSArIG1fcmVzZXJ2YXRpb24uc2l6ZSgpKTsKLSAgICBtX3Jlc2VydmF0aW9uLmRlY29tbWl0KHJl aW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KG1fY29tbWl0RW5kKSwgcmVpbnRlcnByZXRfY2FzdDxpbnRw dHJfdD4oaGlnaEFkZHJlc3MpIC0gcmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4obV9jb21taXRF bmQpKTsKLSAgICBhZGRUb0NvbW1pdHRlZEJ5dGVDb3VudCgtKHJlaW50ZXJwcmV0X2Nhc3Q8aW50 cHRyX3Q+KGhpZ2hBZGRyZXNzKSAtIHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KG1fY29tbWl0 RW5kKSkpOworICAgIG1fcmVzZXJ2YXRpb24uZGVjb21taXQocmVpbnRlcnByZXRfY2FzdDx2b2lk Kj4obV9jb21taXRUb3ApLCByZWludGVycHJldF9jYXN0PGludHB0cl90PihoaWdoQWRkcmVzcykg LSByZWludGVycHJldF9jYXN0PGludHB0cl90PihtX2NvbW1pdFRvcCkpOworICAgIGFkZFRvQ29t bWl0dGVkQnl0ZUNvdW50KC0ocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oaGlnaEFkZHJlc3Mp IC0gcmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4obV9jb21taXRUb3ApKSk7CiAgICAgbV9yZXNl cnZhdGlvbi5kZWFsbG9jYXRlKCk7CiB9CiAKQEAgLTgxLDcgKzgxLDcgQEAgYm9vbCBKU1N0YWNr Ojpncm93U2xvd0Nhc2UoUmVnaXN0ZXIqIG5ldwogewogICAgIC8vIElmIHdlIGhhdmUgYWxyZWFk eSBjb21taXR0ZWQgZW5vdWdoIG1lbW9yeSB0byBzYXRpc2Z5IHRoaXMgcmVxdWVzdCwKICAgICAv LyBqdXN0IHVwZGF0ZSB0aGUgZW5kIHBvaW50ZXIgYW5kIHJldHVybi4KLSAgICBpZiAobmV3RW5k ID49IG1fY29tbWl0RW5kKSB7CisgICAgaWYgKG5ld0VuZCA+PSBtX2NvbW1pdFRvcCkgewogICAg ICAgICBzZXRTdGFja0xpbWl0KG5ld0VuZCk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K QEAgLTg5LDE1ICs4OSwxNSBAQCBib29sIEpTU3RhY2s6Omdyb3dTbG93Q2FzZShSZWdpc3Rlciog bmV3CiAgICAgLy8gQ29tcHV0ZSB0aGUgY2h1bmsgc2l6ZSBvZiBhZGRpdGlvbmFsIG1lbW9yeSB0 byBjb21taXQsIGFuZCBzZWUgaWYgd2UKICAgICAvLyBoYXZlIGl0IGlzIHN0aWxsIHdpdGhpbiBv dXIgYnVkZ2V0LiBJZiBub3QsIHdlJ2xsIGZhaWwgdG8gZ3JvdyBhbmQKICAgICAvLyByZXR1cm4g ZmFsc2UuCi0gICAgbG9uZyBkZWx0YSA9IHJvdW5kVXBBbGxvY2F0aW9uU2l6ZShyZWludGVycHJl dF9jYXN0PGNoYXIqPihtX2NvbW1pdEVuZCkgLSByZWludGVycHJldF9jYXN0PGNoYXIqPihuZXdF bmQpLCBjb21taXRTaXplKTsKLSAgICBpZiAocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV9jb21t aXRFbmQpIC0gZGVsdGEgPD0gcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV91c2VhYmxlVG9wKSkK KyAgICBsb25nIGRlbHRhID0gcm91bmRVcEFsbG9jYXRpb25TaXplKHJlaW50ZXJwcmV0X2Nhc3Q8 Y2hhcio+KG1fY29tbWl0VG9wKSAtIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KG5ld0VuZCksIGNv bW1pdFNpemUpOworICAgIGlmIChyZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdFRvcCkg LSBkZWx0YSA8PSByZWludGVycHJldF9jYXN0PGNoYXIqPihtX3VzZWFibGVUb3ApKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICAvLyBPdGhlcndpc2UsIHRoZSBncm93dGggaXMgc3RpbGwg d2l0aGluIG91ciBidWRnZXQuIEdvIGFoZWFkIGFuZCBjb21taXQKICAgICAvLyBpdCBhbmQgcmV0 dXJuIHRydWUuCi0gICAgbV9yZXNlcnZhdGlvbi5jb21taXQocmVpbnRlcnByZXRfY2FzdDxjaGFy Kj4obV9jb21taXRFbmQpIC0gZGVsdGEsIGRlbHRhKTsKKyAgICBtX3Jlc2VydmF0aW9uLmNvbW1p dChyZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdFRvcCkgLSBkZWx0YSwgZGVsdGEpOwog ICAgIGFkZFRvQ29tbWl0dGVkQnl0ZUNvdW50KGRlbHRhKTsKLSAgICBtX2NvbW1pdEVuZCA9IHJl aW50ZXJwcmV0X2Nhc3RfcHRyPFJlZ2lzdGVyKj4ocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV9j b21taXRFbmQpIC0gZGVsdGEpOworICAgIG1fY29tbWl0VG9wID0gcmVpbnRlcnByZXRfY2FzdF9w dHI8UmVnaXN0ZXIqPihyZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdFRvcCkgLSBkZWx0 YSk7CiAgICAgc2V0U3RhY2tMaW1pdChuZXdFbmQpOwogICAgIHJldHVybiB0cnVlOwogfQpAQCAt MTI3LDEwICsxMjcsMTAgQEAgdm9pZCBKU1N0YWNrOjpzYW5pdGl6ZVN0YWNrKCkKIAogdm9pZCBK U1N0YWNrOjpyZWxlYXNlRXhjZXNzQ2FwYWNpdHkoKQogewotICAgIHB0cmRpZmZfdCBkZWx0YSA9 IHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihoaWdoQWRkcmVzcygpKSAtIHJlaW50ZXJwcmV0 X2Nhc3Q8dWludHB0cl90PihtX2NvbW1pdEVuZCk7Ci0gICAgbV9yZXNlcnZhdGlvbi5kZWNvbW1p dChtX2NvbW1pdEVuZCwgZGVsdGEpOworICAgIHB0cmRpZmZfdCBkZWx0YSA9IHJlaW50ZXJwcmV0 X2Nhc3Q8dWludHB0cl90PihoaWdoQWRkcmVzcygpKSAtIHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0 cl90PihtX2NvbW1pdFRvcCk7CisgICAgbV9yZXNlcnZhdGlvbi5kZWNvbW1pdChtX2NvbW1pdFRv cCwgZGVsdGEpOwogICAgIGFkZFRvQ29tbWl0dGVkQnl0ZUNvdW50KC1kZWx0YSk7Ci0gICAgbV9j b21taXRFbmQgPSBoaWdoQWRkcmVzcygpOworICAgIG1fY29tbWl0VG9wID0gaGlnaEFkZHJlc3Mo KTsKIH0KIAogdm9pZCBKU1N0YWNrOjppbml0aWFsaXplVGhyZWFkaW5nKCkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAkocmV2aXNpb24gMTYxMDI3 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAkod29ya2lu ZyBjb3B5KQpAQCAtMTc2LDcgKzE3Niw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBDYWxs RnJhbWUqJiBtX3RvcENhbGxGcmFtZTsKICNpZiBFTkFCTEUoTExJTlRfQ19MT09QKQogICAgICAg ICBSZWdpc3RlciogbV9lbmQ7Ci0gICAgICAgIFJlZ2lzdGVyKiBtX2NvbW1pdEVuZDsKKyAgICAg ICAgUmVnaXN0ZXIqIG1fY29tbWl0VG9wOwogICAgICAgICBSZWdpc3RlciogbV91c2VhYmxlVG9w OwogICAgICAgICBQYWdlUmVzZXJ2YXRpb24gbV9yZXNlcnZhdGlvbjsKICAgICAgICAgUmVnaXN0 ZXIqIG1fbGFzdFN0YWNrVG9wOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0pTU3RhY2tJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2ludGVycHJldGVyL0pTU3RhY2tJbmxpbmVzLmgJKHJldmlzaW9uIDE2MTAyNSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrSW5saW5lcy5oCSh3b3JraW5nIGNv cHkpCkBAIC0xNzYsNyArMTc2LDcgQEAgaW5saW5lIHZvaWQgSlNTdGFjazo6c2hyaW5rKFJlZ2lz dGVyKiBuZQogICAgIGlmIChuZXdFbmQgPj0gbV9lbmQpCiAgICAgICAgIHJldHVybjsKICAgICBz ZXRTdGFja0xpbWl0KG5ld0VuZCk7Ci0gICAgaWYgKG1fZW5kID09IGJhc2VPZlN0YWNrKCkgJiYg KG1fY29tbWl0RW5kIC0gYmFzZU9mU3RhY2soKSkgPj0gbWF4RXhjZXNzQ2FwYWNpdHkpCisgICAg aWYgKG1fZW5kID09IGJhc2VPZlN0YWNrKCkgJiYgKG1fY29tbWl0VG9wIC0gYmFzZU9mU3RhY2so KSkgPj0gbWF4RXhjZXNzQ2FwYWNpdHkpCiAgICAgICAgIHJlbGVhc2VFeGNlc3NDYXBhY2l0eSgp OwogfQogCkBAIC0yODUsNyArMjg1LDcgQEAgaW5saW5lIHZvaWQgSlNTdGFjazo6aW5zdGFsbFRy YXBzQWZ0ZXJGcgogICAgIGNvbnN0IGludCBzaXplT2ZUcmFwID0gNjQ7CiAgICAgaW50MzJfdCog c3RhcnRPZlRyYXAgPSByZWludGVycHJldF9jYXN0PGludDMyX3QqPih0b3BPZkZyYW1lKTsKICAg ICBpbnQzMl90KiBlbmRPZlRyYXAgPSBzdGFydE9mVHJhcCAtIHNpemVPZlRyYXA7Ci0gICAgaW50 MzJfdCogZW5kT2ZDb21taXRlZE1lbW9yeSA9IHJlaW50ZXJwcmV0X2Nhc3Q8aW50MzJfdCo+KG1f Y29tbWl0RW5kKTsKKyAgICBpbnQzMl90KiBlbmRPZkNvbW1pdGVkTWVtb3J5ID0gcmVpbnRlcnBy ZXRfY2FzdDxpbnQzMl90Kj4obV9jb21taXRUb3ApOwogCiAgICAgLy8gTWFrZSBzdXJlIHdlJ3Jl IG5vdCBleGNlZWRpbmcgdGhlIGFtb3VudCBvZiBhdmFpbGFibGUgbWVtb3J5IHRvIHdyaXRlIHRv OgogICAgIGlmIChlbmRPZlRyYXAgPCBlbmRPZkNvbW1pdGVkTWVtb3J5KQo=