126184 2013-12-23 15:09:00 -0800 CStack: Cosmetic: rename JSStack::m_useableEnd to m_useableTop. 2014-01-13 17:58:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125849 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 962602 0 mark.lam 2013-12-23 15:09:00 -0800 In JSStack::enableErrorStackReserve() and disableErrorStackReserve(), m_useableEnd is initialize to reservationTop() or reservationTop() + commitSize. Hence, it points to an allocatable slot in the stack, not past it. Naming it m_useableTop is more correct. Will rename. 962609 1 219935 mark.lam 2013-12-23 15:12:16 -0800 Created attachment 219935 the patch. 962611 2 mark.lam 2013-12-23 15:14:35 -0800 Landed in r161027 on the jsCStack branch: <http://trac.webkit.org/r161027>. 967580 3 219935 ggaren 2014-01-13 17:41:07 -0800 Comment on attachment 219935 the patch. r=me 967586 4 mark.lam 2014-01-13 17:58:03 -0800 Thanks. Review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>. 219935 2013-12-23 15:12:16 -0800 2014-01-13 17:41:07 -0800 the patch. bug-126184.patch text/plain 3724 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDI1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTEyLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IENvc21ldGljOiByZW5hbWUgSlNTdGFjazo6bV91c2VhYmxlRW5kIHRvIG1fdXNlYWJs ZVRvcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NjE4NC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ biBKU1N0YWNrOjplbmFibGVFcnJvclN0YWNrUmVzZXJ2ZSgpIGFuZCBkaXNhYmxlRXJyb3JTdGFj a1Jlc2VydmUoKSwKKyAgICAgICAgbV91c2VhYmxlRW5kIGlzIGluaXRpYWxpemUgdG8gcmVzZXJ2 YXRpb25Ub3AoKSBvciByZXNlcnZhdGlvblRvcCgpICsKKyAgICAgICAgY29tbWl0U2l6ZS4gSGVu Y2UsIGl0IHBvaW50cyB0byBhbiBhbGxvY2F0YWJsZSBzbG90IGluIHRoZSBzdGFjaywgbm90Cisg ICAgICAgIHBhc3QgaXQuIE5hbWluZyBpdCBtX3VzZWFibGVUb3AgaXMgbW9yZSBjb3JyZWN0Lgor CisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHA6CisgICAgICAgIChKU0M6OkpTU3Rh Y2s6Omdyb3dTbG93Q2FzZSk6CisgICAgICAgIChKU0M6OkpTU3RhY2s6OmVuYWJsZUVycm9yU3Rh Y2tSZXNlcnZlKToKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6ZGlzYWJsZUVycm9yU3RhY2tSZXNl cnZlKToKKyAgICAgICAgKiBpbnRlcnByZXRlci9KU1N0YWNrLmg6CisKIDIwMTMtMTItMjMgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENTdGFjazogQ29zbWV0aWM6 IHJlbmFtZSByZXNlcnZhdGlvbkVuZCgpIHRvIHJlc2VydmF0aW9uVG9wKCkuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCShyZXZpc2lvbiAx NjEwMjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTkwLDcgKzkwLDcgQEAgYm9vbCBKU1N0YWNrOjpncm93U2xvd0Nh c2UoUmVnaXN0ZXIqIG5ldwogICAgIC8vIGhhdmUgaXQgaXMgc3RpbGwgd2l0aGluIG91ciBidWRn ZXQuIElmIG5vdCwgd2UnbGwgZmFpbCB0byBncm93IGFuZAogICAgIC8vIHJldHVybiBmYWxzZS4K ICAgICBsb25nIGRlbHRhID0gcm91bmRVcEFsbG9jYXRpb25TaXplKHJlaW50ZXJwcmV0X2Nhc3Q8 Y2hhcio+KG1fY29tbWl0RW5kKSAtIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KG5ld0VuZCksIGNv bW1pdFNpemUpOwotICAgIGlmIChyZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdEVuZCkg LSBkZWx0YSA8PSByZWludGVycHJldF9jYXN0PGNoYXIqPihtX3VzZWFibGVFbmQpKQorICAgIGlm IChyZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdEVuZCkgLSBkZWx0YSA8PSByZWludGVy cHJldF9jYXN0PGNoYXIqPihtX3VzZWFibGVUb3ApKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICAvLyBPdGhlcndpc2UsIHRoZSBncm93dGggaXMgc3RpbGwgd2l0aGluIG91ciBidWRnZXQu IEdvIGFoZWFkIGFuZCBjb21taXQKQEAgLTE0NywyMiArMTQ3LDIyIEBAIHZvaWQgSlNTdGFjazo6 YWRkVG9Db21taXR0ZWRCeXRlQ291bnQobG8KIAogdm9pZCBKU1N0YWNrOjplbmFibGVFcnJvclN0 YWNrUmVzZXJ2ZSgpCiB7Ci0gICAgbV91c2VhYmxlRW5kID0gcmVzZXJ2YXRpb25Ub3AoKTsKKyAg ICBtX3VzZWFibGVUb3AgPSByZXNlcnZhdGlvblRvcCgpOwogfQogCiB2b2lkIEpTU3RhY2s6OmRp c2FibGVFcnJvclN0YWNrUmVzZXJ2ZSgpCiB7Ci0gICAgY2hhciogdXNlYWJsZUVuZCA9IHJlaW50 ZXJwcmV0X2Nhc3Q8Y2hhcio+KHJlc2VydmF0aW9uVG9wKCkpICsgY29tbWl0U2l6ZTsKLSAgICBt X3VzZWFibGVFbmQgPSByZWludGVycHJldF9jYXN0X3B0cjxSZWdpc3Rlcio+KHVzZWFibGVFbmQp OworICAgIGNoYXIqIHVzZWFibGVUb3AgPSByZWludGVycHJldF9jYXN0PGNoYXIqPihyZXNlcnZh dGlvblRvcCgpKSArIGNvbW1pdFNpemU7CisgICAgbV91c2VhYmxlVG9wID0gcmVpbnRlcnByZXRf Y2FzdF9wdHI8UmVnaXN0ZXIqPih1c2VhYmxlVG9wKTsKIAogICAgIC8vIEJ5IHRoZSB0aW1lIHdl IGdldCBoZXJlLCB3ZSBhcmUgZ3VhcmFudGVlZCB0byBiZSBkZXN0cnVjdGluZyB0aGUgbGFzdAog ICAgIC8vIEludGVycHJldGVyOjpFcnJvckhhbmRsaW5nTW9kZSB0aGF0IGVuYWJsZWQgdGhpcyBy ZXNlcnZlIGluIHRoZSBmaXJzdAotICAgIC8vIHBsYWNlLiBUaGF0IG1lYW5zIHRoZSBzdGFjayBz cGFjZSBiZXlvbmQgbV91c2VhYmxlRW5kIGJlZm9yZSB3ZQorICAgIC8vIHBsYWNlLiBUaGF0IG1l YW5zIHRoZSBzdGFjayBzcGFjZSBiZXlvbmQgbV91c2VhYmxlVG9wIGJlZm9yZSB3ZQogICAgIC8v IGVuYWJsZWQgdGhlIHJlc2VydmUgd2FzIG5vdCBwcmV2aW91c2x5IGluIHVzZS4gSGVuY2UsIGl0 IGlzIHNhZmUgdG8KLSAgICAvLyBzaHJpbmsgYmFjayB0byB0aGF0IG1fdXNlYWJsZUVuZC4KLSAg ICBpZiAobV9lbmQgPCBtX3VzZWFibGVFbmQpIHsKLSAgICAgICAgQVNTRVJUKG1fdG9wQ2FsbEZy YW1lLT50b3BPZkZyYW1lKCkgPiBtX3VzZWFibGVFbmQpOwotICAgICAgICBzaHJpbmsobV91c2Vh YmxlRW5kKTsKKyAgICAvLyBzaHJpbmsgYmFjayB0byB0aGF0IG1fdXNlYWJsZVRvcC4KKyAgICBp ZiAobV9lbmQgPCBtX3VzZWFibGVUb3ApIHsKKyAgICAgICAgQVNTRVJUKG1fdG9wQ2FsbEZyYW1l LT50b3BPZkZyYW1lKCkgPiBtX3VzZWFibGVUb3ApOworICAgICAgICBzaHJpbmsobV91c2VhYmxl VG9wKTsKICAgICB9CiB9CiAjZW5kaWYgLy8gRU5BQkxFKExMSU5UX0NfTE9PUCkKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAkocmV2aXNpb24gMTYx MDI1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAkod29y a2luZyBjb3B5KQpAQCAtMTc3LDcgKzE3Nyw3IEBAIG5hbWVzcGFjZSBKU0MgewogI2lmIEVOQUJM RShMTElOVF9DX0xPT1ApCiAgICAgICAgIFJlZ2lzdGVyKiBtX2VuZDsKICAgICAgICAgUmVnaXN0 ZXIqIG1fY29tbWl0RW5kOwotICAgICAgICBSZWdpc3RlciogbV91c2VhYmxlRW5kOworICAgICAg ICBSZWdpc3RlciogbV91c2VhYmxlVG9wOwogICAgICAgICBQYWdlUmVzZXJ2YXRpb24gbV9yZXNl cnZhdGlvbjsKICAgICAgICAgUmVnaXN0ZXIqIG1fbGFzdFN0YWNrVG9wOwogI2VuZGlmIC8vIEVO QUJMRShMTElOVF9DX0xPT1ApCg==