126183 2013-12-23 15:03:57 -0800 Remove boolean argument from Element::setChildrenAffectBy* methods 2013-12-23 16:45:06 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa allan.jensen benjamin cmarcelo commit-queue dbates esprehn+autocc glenn gyuyoung.kim kangil.han kling koivisto macpherson menard oldest_to_newest 962600 0 rniwa 2013-12-23 15:03:57 -0800 Remove boolean argument from Element::setChildrenAffectBy* methods 962601 1 219933 rniwa 2013-12-23 15:04:59 -0800 Created attachment 219933 Cleanup 962621 2 219933 dbates 2013-12-23 15:36:59 -0800 Comment on attachment 219933 Cleanup We call setChildrenAffectedByActive(false), setChildrenAffectedByDrag(false) in ElementRareData::resetDynamicRestyleObservations(), <http://trac.webkit.org/browser/trunk/Source/WebCore/dom/ElementRareData.h?rev=159191#L225> 962623 3 219933 dbates 2013-12-23 15:42:42 -0800 Comment on attachment 219933 Cleanup My bad. ElementRareData defines setChildrenAffectedByDrag()and setChildrenAffectedByActive(). 962642 4 219933 commit-queue 2013-12-23 16:45:03 -0800 Comment on attachment 219933 Cleanup Clearing flags on attachment: 219933 Committed r161037: <http://trac.webkit.org/changeset/161037> 962644 5 commit-queue 2013-12-23 16:45:06 -0800 All reviewed patches have been landed. Closing bug. 219933 2013-12-23 15:04:59 -0800 2013-12-23 16:45:03 -0800 Cleanup bug-126183-20131223150458.patch text/plain 4640 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTAyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTEyLTIzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBib29sZWFuIGFyZ3Vt ZW50IGZyb20gRWxlbWVudDo6c2V0Q2hpbGRyZW5BZmZlY3RCeSogbWV0aG9kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MTgzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2UgaHR0cHM6Ly9jaHJv bWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9taXVtL2JsaW5rLysvMDY2ZWYyZmE3ODMzNmIyYjY1 MDUyY2IxN2NiODFiMzY3ZmU3ZGJiZgorCisgICAgICAgIFRoZXNlIGZ1bmN0aW9ucyBhcmUgbmV2 ZXIgY2FsbGVkIHdpdGggZmFsc2UuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JDaGVja2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmUpOgorICAgICAg ICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnNldENoaWxk cmVuQWZmZWN0ZWRCeUFjdGl2ZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpzZXRDaGls ZHJlbkFmZmVjdGVkQnlEcmFnKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVudDo6c2V0Q2hpbGRyZW5BZmZlY3RlZEJ5SG92ZXIpOgorCiAyMDEzLTEy LTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBpc0Rv Y3VtZW50RnJhZ21lbnQoKSBpbnN0ZWFkIG9mIGNvbXBhcmluZyBub2RlVHlwZSgpIHdpdGggTm9k ZTo6RE9DVU1FTlRfRlJBR01FTlRfTk9ERQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL1NlbGVj dG9yQ2hlY2tlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9y Q2hlY2tlci5jcHAJKHJldmlzaW9uIDE2MTAxNikKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TZWxl Y3RvckNoZWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDUsNyArNjA1LDcgQEAgYm9vbCBT ZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lKGNvbnN0IFNlbAogICAgICAgICAgICAgICAgIGlmIChj b250ZXh0LmVsZW1lbnRTdHlsZSkKICAgICAgICAgICAgICAgICAgICAgY29udGV4dC5lbGVtZW50 U3R5bGUtPnNldEFmZmVjdGVkQnlEcmFnKCk7CiAgICAgICAgICAgICAgICAgZWxzZQotICAgICAg ICAgICAgICAgICAgICBlbGVtZW50LT5zZXRDaGlsZHJlbkFmZmVjdGVkQnlEcmFnKHRydWUpOwor ICAgICAgICAgICAgICAgICAgICBlbGVtZW50LT5zZXRDaGlsZHJlbkFmZmVjdGVkQnlEcmFnKCk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAoZWxlbWVudC0+cmVuZGVyZXIoKSAmJiBl bGVtZW50LT5yZW5kZXJlcigpLT5pc0RyYWdnaW5nKCkpCiAgICAgICAgICAgICAgICAgcmV0dXJu IHRydWU7CkBAIC02MjAsNyArNjIwLDcgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25l KGNvbnN0IFNlbAogICAgICAgICAgICAgICAgICAgICBpZiAoY29udGV4dC5lbGVtZW50U3R5bGUp CiAgICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0LmVsZW1lbnRTdHlsZS0+c2V0QWZmZWN0 ZWRCeUhvdmVyKCk7CiAgICAgICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAg ICAgICAgIGVsZW1lbnQtPnNldENoaWxkcmVuQWZmZWN0ZWRCeUhvdmVyKHRydWUpOworICAgICAg ICAgICAgICAgICAgICAgICAgZWxlbWVudC0+c2V0Q2hpbGRyZW5BZmZlY3RlZEJ5SG92ZXIoKTsK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmhvdmVyZWQo KSB8fCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZvcmNlUHNldWRvU3RhdGUoZWxlbWVudCwg Q1NTU2VsZWN0b3I6OlBzZXVkb0hvdmVyKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CkBAIC02MzQsNyArNjM0LDcgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lKGNv bnN0IFNlbAogICAgICAgICAgICAgICAgICAgICBpZiAoY29udGV4dC5lbGVtZW50U3R5bGUpCiAg ICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0LmVsZW1lbnRTdHlsZS0+c2V0QWZmZWN0ZWRC eUFjdGl2ZSgpOwogICAgICAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAg ICAgICBlbGVtZW50LT5zZXRDaGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUodHJ1ZSk7CisgICAgICAg ICAgICAgICAgICAgICAgICBlbGVtZW50LT5zZXRDaGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUoKTsK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmFjdGl2ZSgp IHx8IEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6Zm9yY2VQc2V1ZG9TdGF0ZShlbGVtZW50LCBD U1NTZWxlY3Rvcjo6UHNldWRvQWN0aXZlKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjEwMTYpCisrKyBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNjUsMTYgKzIx NjUsMTQgQEAgdm9pZCBFbGVtZW50OjpzZXRTdHlsZUFmZmVjdGVkQnlFbXB0eSgpCiAgICAgZW5z dXJlRWxlbWVudFJhcmVEYXRhKCkuc2V0U3R5bGVBZmZlY3RlZEJ5RW1wdHkodHJ1ZSk7CiB9CiAK LXZvaWQgRWxlbWVudDo6c2V0Q2hpbGRyZW5BZmZlY3RlZEJ5QWN0aXZlKGJvb2wgdmFsdWUpCit2 b2lkIEVsZW1lbnQ6OnNldENoaWxkcmVuQWZmZWN0ZWRCeUFjdGl2ZSgpCiB7Ci0gICAgaWYgKHZh bHVlIHx8IGhhc1JhcmVEYXRhKCkpCi0gICAgICAgIGVuc3VyZUVsZW1lbnRSYXJlRGF0YSgpLnNl dENoaWxkcmVuQWZmZWN0ZWRCeUFjdGl2ZSh2YWx1ZSk7CisgICAgZW5zdXJlRWxlbWVudFJhcmVE YXRhKCkuc2V0Q2hpbGRyZW5BZmZlY3RlZEJ5QWN0aXZlKHRydWUpOwogfQogCi12b2lkIEVsZW1l bnQ6OnNldENoaWxkcmVuQWZmZWN0ZWRCeURyYWcoYm9vbCB2YWx1ZSkKK3ZvaWQgRWxlbWVudDo6 c2V0Q2hpbGRyZW5BZmZlY3RlZEJ5RHJhZygpCiB7Ci0gICAgaWYgKHZhbHVlIHx8IGhhc1JhcmVE YXRhKCkpCi0gICAgICAgIGVuc3VyZUVsZW1lbnRSYXJlRGF0YSgpLnNldENoaWxkcmVuQWZmZWN0 ZWRCeURyYWcodmFsdWUpOworICAgIGVuc3VyZUVsZW1lbnRSYXJlRGF0YSgpLnNldENoaWxkcmVu QWZmZWN0ZWRCeURyYWcodHJ1ZSk7CiB9CiAKIHZvaWQgRWxlbWVudDo6c2V0Q2hpbGRyZW5BZmZl Y3RlZEJ5RGlyZWN0QWRqYWNlbnRSdWxlcyhFbGVtZW50KiBlbGVtZW50KQpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5oCShyZXZpc2lvbiAxNjEwMTYpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNjIsOSArMzYyLDkgQEAgcHVibGljOgogICAgIGJvb2wg aGFzRmxhZ3NTZXREdXJpbmdTdHlsaW5nT2ZDaGlsZHJlbigpIGNvbnN0OwogCiAgICAgdm9pZCBz ZXRTdHlsZUFmZmVjdGVkQnlFbXB0eSgpOwotICAgIHZvaWQgc2V0Q2hpbGRyZW5BZmZlY3RlZEJ5 SG92ZXIoYm9vbCBmbGFnKSB7IHNldEZsYWcoZmxhZywgQ2hpbGRyZW5BZmZlY3RlZEJ5SG92ZXJS dWxlc0ZsYWcpOyB9Ci0gICAgdm9pZCBzZXRDaGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUoYm9vbCk7 Ci0gICAgdm9pZCBzZXRDaGlsZHJlbkFmZmVjdGVkQnlEcmFnKGJvb2wpOworICAgIHZvaWQgc2V0 Q2hpbGRyZW5BZmZlY3RlZEJ5SG92ZXIoKSB7IHNldEZsYWcoQ2hpbGRyZW5BZmZlY3RlZEJ5SG92 ZXJSdWxlc0ZsYWcpOyB9CisgICAgdm9pZCBzZXRDaGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUoKTsK KyAgICB2b2lkIHNldENoaWxkcmVuQWZmZWN0ZWRCeURyYWcoKTsKICAgICB2b2lkIHNldENoaWxk cmVuQWZmZWN0ZWRCeUZpcnN0Q2hpbGRSdWxlcygpIHsgc2V0RmxhZyhDaGlsZHJlbkFmZmVjdGVk QnlGaXJzdENoaWxkUnVsZXNGbGFnKTsgfQogICAgIHZvaWQgc2V0Q2hpbGRyZW5BZmZlY3RlZEJ5 TGFzdENoaWxkUnVsZXMoKSB7IHNldEZsYWcoQ2hpbGRyZW5BZmZlY3RlZEJ5TGFzdENoaWxkUnVs ZXNGbGFnKTsgfQogICAgIHN0YXRpYyB2b2lkIHNldENoaWxkcmVuQWZmZWN0ZWRCeURpcmVjdEFk amFjZW50UnVsZXMoRWxlbWVudCopOwo=