126181 2013-12-23 14:53:22 -0800 CStack: Cosmetic: rename reservationEnd() to reservationTop() 2013-12-23 16:50:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125849 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 962594 0 mark.lam 2013-12-23 14:53:22 -0800 reservationEnd() computes the end of the stack at the top. The value is computed as: char* reservationEnd = static_cast<char*>(m_reservation.base()); return reinterpret_cast_ptr<Register*>(reservationEnd); Since m_reservation.base() points at a slot of memory that is within the allocatable range of the stack, this function reservationEnd() is inappropriate. Per Geoff's input, "end" usually refers to the slot past the end of a buffer. Calling it "top" is more appropriate. Hence, I will rename it to reservationTop(). 962596 1 219932 mark.lam 2013-12-23 14:57:49 -0800 Created attachment 219932 the patch. 962599 2 mark.lam 2013-12-23 15:01:18 -0800 Landed in r161025 on the jsCStack branch: <http://trac.webkit.org/r161025>. 962649 3 mark.lam 2013-12-23 16:50:24 -0800 Thanks for the review. Review status updated in r161039: <http://trac.webkit.org/r161039>. 219932 2013-12-23 14:57:49 -0800 2013-12-23 16:33:33 -0800 the patch. bug-126181.patch text/plain 2964 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEzLTEyLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IENvc21ldGljOiByZW5hbWUgcmVzZXJ2YXRpb25FbmQoKSB0byByZXNlcnZhdGlvblRv cCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2 MTgxLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJl c2VydmF0aW9uRW5kKCkgY29tcHV0ZXMgdGhlIGVuZCBvZiB0aGUgc3RhY2sgYXQgdGhlIHRvcC4g VGhlIHZhbHVlCisgICAgICAgIGlzIGNvbXB1dGVkIGFzOgorCisgICAgICAgICAgICBjaGFyKiBy ZXNlcnZhdGlvbkVuZCA9IHN0YXRpY19jYXN0PGNoYXIqPihtX3Jlc2VydmF0aW9uLmJhc2UoKSk7 CisgICAgICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdF9wdHI8UmVnaXN0ZXIqPihyZXNl cnZhdGlvbkVuZCk7CisKKyAgICAgICAgU2luY2UgbV9yZXNlcnZhdGlvbi5iYXNlKCkgcG9pbnRz IGF0IGEgc2xvdCBvZiBtZW1vcnkgdGhhdCBpcyB3aXRoaW4gdGhlCisgICAgICAgIGFsbG9jYXRh YmxlIHJhbmdlIG9mIHRoZSBzdGFjaywgbmFtaW5nIHRoaXMgZnVuY3Rpb24gcmVzZXJ2YXRpb25F bmQoKSBpcworICAgICAgICBpbmFwcHJvcHJpYXRlLiAgUGVyIEdlb2ZmJ3MgaW5wdXQsICJlbmQi IHVzdWFsbHkgcmVmZXJzIHRvIHRoZSBzbG90IHBhc3QKKyAgICAgICAgdGhlIGVuZCBvZiBhIGJ1 ZmZlci4gQ2FsbGluZyBpdCAidG9wIiBpcyBtb3JlIGFwcHJvcHJpYXRlLiBIZW5jZSwgSSdtCisg ICAgICAgIHJlbmFtaW5nIGl0IHRvIHJlc2VydmF0aW9uVG9wKCkuCisKKyAgICAgICAgKiBpbnRl cnByZXRlci9KU1N0YWNrLmNwcDoKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6ZW5hYmxlRXJyb3JT dGFja1Jlc2VydmUpOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpkaXNhYmxlRXJyb3JTdGFja1Jl c2VydmUpOgorICAgICAgICAqIGludGVycHJldGVyL0pTU3RhY2suaDoKKyAgICAgICAgKEpTQzo6 SlNTdGFjazo6cmVzZXJ2YXRpb25Ub3ApOgorCiAyMDEzLTEyLTIzICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ1N0YWNrIEJyYW5jaDogU2V2ZXJhbCBkZmctYXJn dW1lbnRzLW9zci1leGl0IHRlc3RzIGZhaWwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9KU1N0YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHAJKHJldmlzaW9uIDE2MDk5NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTQ3LDEyICsxNDcsMTIgQEAgdm9pZCBKU1N0YWNrOjphZGRUb0NvbW1pdHRlZEJ5dGVDb3VudChs bwogCiB2b2lkIEpTU3RhY2s6OmVuYWJsZUVycm9yU3RhY2tSZXNlcnZlKCkKIHsKLSAgICBtX3Vz ZWFibGVFbmQgPSByZXNlcnZhdGlvbkVuZCgpOworICAgIG1fdXNlYWJsZUVuZCA9IHJlc2VydmF0 aW9uVG9wKCk7CiB9CiAKIHZvaWQgSlNTdGFjazo6ZGlzYWJsZUVycm9yU3RhY2tSZXNlcnZlKCkK IHsKLSAgICBjaGFyKiB1c2VhYmxlRW5kID0gcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4ocmVzZXJ2 YXRpb25FbmQoKSkgKyBjb21taXRTaXplOworICAgIGNoYXIqIHVzZWFibGVFbmQgPSByZWludGVy cHJldF9jYXN0PGNoYXIqPihyZXNlcnZhdGlvblRvcCgpKSArIGNvbW1pdFNpemU7CiAgICAgbV91 c2VhYmxlRW5kID0gcmVpbnRlcnByZXRfY2FzdF9wdHI8UmVnaXN0ZXIqPih1c2VhYmxlRW5kKTsK IAogICAgIC8vIEJ5IHRoZSB0aW1lIHdlIGdldCBoZXJlLCB3ZSBhcmUgZ3VhcmFudGVlZCB0byBi ZSBkZXN0cnVjdGluZyB0aGUgbGFzdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL0pTU3RhY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIvSlNTdGFjay5oCShyZXZpc2lvbiAxNjA5OTcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDYsMTAgKzE0 NiwxMCBAQCBuYW1lc3BhY2UgSlNDIHsKICNlbmRpZiAvLyBFTkFCTEUoTExJTlRfQ19MT09QKQog CiAjaWYgRU5BQkxFKExMSU5UX0NfTE9PUCkKLSAgICAgICAgUmVnaXN0ZXIqIHJlc2VydmF0aW9u RW5kKCkgY29uc3QKKyAgICAgICAgUmVnaXN0ZXIqIHJlc2VydmF0aW9uVG9wKCkgY29uc3QKICAg ICAgICAgewotICAgICAgICAgICAgY2hhciogcmVzZXJ2YXRpb25FbmQgPSBzdGF0aWNfY2FzdDxj aGFyKj4obV9yZXNlcnZhdGlvbi5iYXNlKCkpOwotICAgICAgICAgICAgcmV0dXJuIHJlaW50ZXJw cmV0X2Nhc3RfcHRyPFJlZ2lzdGVyKj4ocmVzZXJ2YXRpb25FbmQpOworICAgICAgICAgICAgY2hh ciogcmVzZXJ2YXRpb25Ub3AgPSBzdGF0aWNfY2FzdDxjaGFyKj4obV9yZXNlcnZhdGlvbi5iYXNl KCkpOworICAgICAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3RfcHRyPFJlZ2lzdGVyKj4o cmVzZXJ2YXRpb25Ub3ApOwogICAgICAgICB9CiAKICNpZiBFTkFCTEUoREVCVUdfSlNTVEFDSykK