126178 2013-12-23 13:41:58 -0800 Use isDocumentFragment() instead of comparing nodeType() with Node::DOCUMENT_FRAGMENT_NODE 2013-12-23 14:47:58 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa benjamin commit-queue esprehn+autocc kangil.han kling koivisto oldest_to_newest 962572 0 rniwa 2013-12-23 13:41:58 -0800 Inspired by https://chromium.googlesource.com/chromium/blink/+/a622cb80af2bfb0c5d91123cbcfa4fa72a06554c Node::isDocumentFragment() is faster than nodeType(), which is virtual. 962577 1 219930 rniwa 2013-12-23 13:52:43 -0800 Created attachment 219930 Cleanup 962591 2 219930 commit-queue 2013-12-23 14:47:55 -0800 Comment on attachment 219930 Cleanup Clearing flags on attachment: 219930 Committed r161024: <http://trac.webkit.org/changeset/161024> 962592 3 commit-queue 2013-12-23 14:47:58 -0800 All reviewed patches have been landed. Closing bug. 219930 2013-12-23 13:52:43 -0800 2013-12-23 14:47:55 -0800 Cleanup bug-126178-20131223135242.patch text/plain 2203 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTAxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEyLTIzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFVzZSBpc0RvY3VtZW50RnJhZ21l bnQoKSBpbnN0ZWFkIG9mIGNvbXBhcmluZyBub2RlVHlwZSgpIHdpdGggTm9kZTo6RE9DVU1FTlRf RlJBR01FTlRfTk9ERQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI2MTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5zcGlyZWQgYnkgaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9t aXVtL2JsaW5rLysvYTYyMmNiODBhZjJiZmIwYzVkOTExMjNjYmNmYTRmYTcyYTA2NTU0YworCisg ICAgICAgIFVzZSBpbmxpbmUgTm9kZTo6aXNEb2N1bWVudEZyYWdtZW50KCkgaW5zdGVhZCBvZiB2 aXJ0dWFsIG5vZGVUeXBlKCkuCisKKyAgICAgICAgKiBkb20vQ29udGFpbmVyTm9kZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpjb2xsZWN0Q2hpbGRyZW5BbmRSZW1vdmVGcm9tT2xkUGFyZW50KToK KyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6 OmNhblJlcGxhY2VDaGlsZCk6CisKIDIwMTMtMTItMjMgIEd3YW5nIFlvb24gSHdhbmcgIDxyeXVt aWVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIENsZWFyIFNjcmF0Y2hCdWZmZXI6Om1fbGFz dExheWVyU2l6ZSB3aGVuIGNsZWFyaW5nIHRoZSBzY3JhdGNoIGJ1ZmZlci4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9uIDE2MTAwNykKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODAsNyArODAs NyBAQCB1bnNpZ25lZCBOb0V2ZW50RGlzcGF0Y2hBc3NlcnRpb246OnNfY291CiAKIHN0YXRpYyB2 b2lkIGNvbGxlY3RDaGlsZHJlbkFuZFJlbW92ZUZyb21PbGRQYXJlbnQoTm9kZSYgbm9kZSwgTm9k ZVZlY3RvciYgbm9kZXMsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAgIGlmIChub2RlLm5vZGVU eXBlKCkgIT0gTm9kZTo6RE9DVU1FTlRfRlJBR01FTlRfTk9ERSkgeworICAgIGlmICghbm9kZS5p c0RvY3VtZW50RnJhZ21lbnQoKSkgewogICAgICAgICBub2Rlcy5hcHBlbmQobm9kZSk7CiAgICAg ICAgIGlmIChDb250YWluZXJOb2RlKiBvbGRQYXJlbnQgPSBub2RlLnBhcmVudE5vZGUoKSkKICAg ICAgICAgICAgIG9sZFBhcmVudC0+cmVtb3ZlQ2hpbGQoJm5vZGUsIGVjKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMTYxMDA3KQorKysgU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA4MSw3ICszMDgxLDcgQEAgYm9vbCBE b2N1bWVudDo6Y2FuUmVwbGFjZUNoaWxkKE5vZGUqIG5ldwogICAgIH0KICAgICAKICAgICAvLyBU aGVuLCBzZWUgaG93IG1hbnkgZG9jdHlwZXMgYW5kIGVsZW1lbnRzIG1pZ2h0IGJlIGFkZGVkIGJ5 IHRoZSBuZXcgY2hpbGQuCi0gICAgaWYgKG5ld0NoaWxkLT5ub2RlVHlwZSgpID09IERPQ1VNRU5U X0ZSQUdNRU5UX05PREUpIHsKKyAgICBpZiAobmV3Q2hpbGQtPmlzRG9jdW1lbnRGcmFnbWVudCgp KSB7CiAgICAgICAgIGZvciAoTm9kZSogYyA9IG5ld0NoaWxkLT5maXJzdENoaWxkKCk7IGM7IGMg PSBjLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgICAgICBzd2l0Y2ggKGMtPm5vZGVUeXBlKCkp IHsKICAgICAgICAgICAgIGNhc2UgQVRUUklCVVRFX05PREU6Cg==