126174 2013-12-23 12:42:55 -0800 jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit is failing in cStack 2014-01-15 08:27:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 126172 1 fpizlo mark.lam barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 962549 0 fpizlo 2013-12-23 12:42:55 -0800 Probably a varargs issue. 962629 1 fpizlo 2013-12-23 16:14:08 -0800 It looks like this fails even in the LLInt. Still investigating... 962639 2 fpizlo 2013-12-23 16:32:49 -0800 This looks like an exception throwing, unwinding, and stack overflow bug. All engines crash on the tests for stack overflow, where you apply with a ridiculous argument count. 962682 3 mark.lam 2013-12-23 18:24:23 -0800 Here's a reduced test case that reproduces this issue (or likely the root cause of this issue): function foo() { try { foo(); } catch (e) { throw e; } } foo(); 962963 4 220024 mark.lam 2013-12-25 23:04:33 -0800 Created attachment 220024 the patch. 962964 5 220025 mark.lam 2013-12-25 23:12:09 -0800 Created attachment 220025 the patch. 962966 6 mark.lam 2013-12-25 23:15:06 -0800 When we do a stack check in a function prologue, the activation object in the frame hasn't been set yet. The test failures came from the stack unwinding code trying to tear off the frame to a non-existant activation object. Since we haven't entered the function yet and the frame is technically not fully "pushed" yet, we can throw i.e. start the unwinding from the caller frame instead. This fixes the issue. Landed in r161084 on the jsCStack branch: <http://trac.webkit.org/r161084>. 963007 7 msaboff 2013-12-26 08:15:33 -0800 With the span size ASSERT disabled in ConservativeRoots.cpp, function-apply-aliased.js.layout-no-cjit (and the other instances of function-apply-aliased.js) fail after timing out: jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: Timed out after 169.000000 seconds! jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 1 0x10188adc0 WTFCrash jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 2 0x1011be960 jscmain(int, char**) jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 3 0x1018da288 WTF::threadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 4 0x1018db038 WTF::wtfThreadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 5 0x7fff8c879899 _pthread_body jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 6 0x7fff8c87972a _pthread_struct_init jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: 7 0x7fff8c87dfc9 thread_start jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: test_script_6882: line 2: 57151 Segmentation fault: 11 "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --enableConcurrentJIT\=false resources/standalone-pre.js function-apply-aliased.js resources/standalone-post.js jsc-layout-tests.yaml/js/script-tests/function-apply-aliased.js.layout-no-cjit: ERROR: Unexpected exit code: 139 963008 8 mark.lam 2013-12-26 08:17:37 -0800 (In reply to comment #7) > With the span size ASSERT disabled in ConservativeRoots.cpp, function-apply-aliased.js.layout-no-cjit (and the other instances of function-apply-aliased.js) fail after timing out: That is because the JSStack size used to be 512K. Now it is is 63M. I’m now working on adding a VM option to cap the C stack size, and we’ll cap the stack size to 4M for jsc and tests. With that, the tests won’t time out. 963009 9 fpizlo 2013-12-26 08:26:53 -0800 (In reply to comment #8) > (In reply to comment #7) > > With the span size ASSERT disabled in ConservativeRoots.cpp, function-apply-aliased.js.layout-no-cjit (and the other instances of function-apply-aliased.js) fail after timing out: > > That is because the JSStack size used to be 512K. Now it is is 63M. I’m now working on adding a VM option to cap the C stack size, and we’ll cap the stack size to 4M for jsc and tests. With that, the tests won’t time out. OK - we need to have an *actual* story for this. We can't have a WebKit user getting a spin every time that some program overflows stack. Maybe you should have limits on how much stack JS is allowed to use? As we talked previously, you'll have to have a story for how this will work in case of VM reentry. 963466 10 mark.lam 2013-12-30 22:37:23 -0800 (In reply to comment #9) > Maybe you should have limits on how much stack JS is allowed to use? As we talked previously, you'll have to have a story for how this will work in case of VM reentry. The work to use a separate limit for the JS stack is at https://bugs.webkit.org/show_bug.cgi?id=126320. 968055 11 220025 ggaren 2014-01-14 14:47:26 -0800 Comment on attachment 220025 the patch. r=me 968327 12 mark.lam 2014-01-15 08:27:42 -0800 Review status updated in r162014: <http://trac.webkit.org/r162014>. 220024 2013-12-25 23:04:33 -0800 2013-12-25 23:12:09 -0800 the patch. bug-126174.patch text/plain 4343 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTEyLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBq c2MtbGF5b3V0LXRlc3RzLnlhbWwvanMvc2NyaXB0LXRlc3RzL2Z1bmN0aW9uLWFwcGx5LWFsaWFz ZWQuanMubGF5b3V0LW5vLWNqaXQgaXMgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjE3NC4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGRvIGEgc3RhY2sgY2hlY2sgaW4gYSBm dW5jdGlvbiBwcm9sb2d1ZSwgdGhlIGFjdGl2YXRpb24gb2JqZWN0CisgICAgICAgIGluIHRoZSBm cmFtZSBoYXNuJ3QgYmVlbiBzZXQgeWV0LiBUaGUgdGVzdCBmYWlsdXJlcyBjYW1lIGZyb20gdGhl IHN0YWNrCisgICAgICAgIHVud2luZGluZyBjb2RlIHRyeWluZyB0byB0ZWFyIG9mZiB0aGUgZnJh bWUgdG8gYSBub24tZXhpc3RhbnQgYWN0aXZhdGlvbgorICAgICAgICBvYmplY3QuIFNpbmNlIHdl IGhhdmVuJ3QgZW50ZXJlZCB0aGUgZnVuY3Rpb24geWV0IGFuZCB0aGUgZnJhbWUgaXMKKyAgICAg ICAgdGVjaG5pY2FsbHkgbm90IGZ1bGx5ICJwdXNoZWQiIHlldCwgd2UgY2FuIHRocm93IGkuZS4g c3RhcnQgdGhlIHVud2luZGluZworICAgICAgICBmcm9tIHRoZSBjYWxsZXIgZnJhbWUgaW5zdGVh ZC4gVGhpcyBmaXhlcyB0aGUgaXNzdWUuCisKKyAgICAgICAgKiBsbGludC9MTEludFNsb3dQYXRo cy5jcHA6CisgICAgICAgIChKU0M6OkxMSW50OjpMTElOVF9TTE9XX1BBVEhfREVDTCk6CisgICAg ICAgIC0gV2hlbiB3ZSBoYXZlIGEgU3RhY2tPdmVyZmxvd0Vycm9yLCByZXR1cm4gdGhlIGNhbGxl cidzIENhbGxGcmFtZSBpbgorICAgICAgICAgIHRoZSBzZWNvbmQgdmFsdWUgaW4gdGhlIFNsb3dQ YXRoUmV0dXJuVHlwZS4KKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToK KyAgICAgICAgLSBDaGVjayBpZiB0aGUgc2Vjb25kIHZhbHVlIG9mIHRoZSBTbG93UGF0aFJldHVy blR5cGUgZnJvbSB0aGUgc3RhY2sKKyAgICAgICAgICBjaGVjayBpcyAwLiBJZiBub3QgMCwgc2V0 IHRoZSBjZnIgdG8gdGhlIHJldHVybmVkIENhbGxGcmFtZSogYmVmb3JlCisgICAgICAgICAgd2Ug c3RhcnQgaGFuZGxpbmcgdGhlIFN0YWNrT3ZlcmZsb3dFcnJvciBhbmQgdW53aW5kaW5nIHRoZSBz dGFjay4KKwogMjAxMy0xMi0yNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4K IAogICAgICAgICBDU3RhY2sgQnJhbmNoOiBlY21hL0V4ZWN1dGlvbkNvbnRleHRzLzEwLjEuNC0y LmpzIHRlc3QgZmFpbHMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNs b3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50U2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMTYxMDgzKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQyLDIwICs0 NDIsMzIgQEAgTExJTlRfU0xPV19QQVRIX0RFQ0woc3RhY2tfY2hlY2spCiAgICAgZGF0YUxvZ0Yo IkN1cnJlbnQgZW5kIGlzIGF0ICVwLlxuIiwgZXhlYy0+dm0oKS5pbnRlcnByZXRlci0+c3RhY2so KS5lbmQoKSk7CiAjZW5kaWYKIAorICAgIC8vIFRoaXMgc3RhY2sgY2hlY2sgaXMgZG9uZSBpbiB0 aGUgcHJvbG9ndWUgZm9yIGEgZnVuY3Rpb24gY2FsbCwgYW5kIHRoZQorICAgIC8vIENhbGxGcmFt ZSBpcyBub3QgY29tcGxldGVseSBzZXQgdXAgeWV0LiBGb3IgZXhhbXBsZSwgaWYgdGhlIGZyYW1l IG5lZWRzCisgICAgLy8gYW4gYWN0aXZhdGlvbiBvYmplY3QsIHRoZSBhY3RpdmF0aW9uIG9iamVj dCB3aWxsIG9ubHkgYmUgc2V0IHVwIGFmdGVyCisgICAgLy8gd2Ugc3RhcnQgZXhlY3V0aW5nIHRo ZSBmdW5jdGlvbi4gSWYgd2UgbmVlZCB0byB0aHJvdyBhIFN0YWNrT3ZlcmZsb3dFcnJvcgorICAg IC8vIGhlcmUsIHRoZW4gd2UgbmVlZCB0byB0ZWxsIHRoZSBwcm9sb2d1ZSB0byBzdGFydCB0aGUg c3RhY2sgdW53aW5kaW5nIGZyb20KKyAgICAvLyB0aGUgY2FsbGVyIGZyYW1lICh3aGljaCBpcyBm dWxseSBzZXQgdXApIGluc3RlYWQuIFRvIGRvIHRoYXQsIHdlIHJldHVybgorICAgIC8vIHRoZSBj YWxsZXIncyBDYWxsRnJhbWUgaW4gdGhlIHNlY29uZCByZXR1cm4gdmFsdWUuCisgICAgLy8KKyAg ICAvLyBJZiB0aGUgc3RhY2sgY2hlY2sgc3VjY2VlZHMgYW5kIHdlIGRvbid0IG5lZWQgdG8gdGhy b3cgdGhlIGVycm9yLCB0aGVuCisgICAgLy8gd2UnbGwgcmV0dXJuIDAgaW5zdGVhZC4gVGhlIHBy b2xvZ3VlIHdpbGwgY2hlY2sgZm9yIGEgbm9uLXplcm8gdmFsdWUKKyAgICAvLyB3aGVuIGRldGVy bWluaW5nIHdoZXRoZXIgdG8gc2V0IHRoZSBjYWxsRnJhbWUgb3Igbm90LgorCiAgICAgLy8gRm9y IEpJVCBlbmFibGVkIGJ1aWxkcyB3aGljaCB1c2VzIHRoZSBDIHN0YWNrLCB0aGUgc3RhY2sgaXMg bm90IGdyb3dhYmxlLgogICAgIC8vIEhlbmNlLCBpZiB3ZSBnZXQgaGVyZSwgdGhlbiB3ZSBrbm93 IGEgc3RhY2sgb3ZlcmZsb3cgaXMgaW1taW5lbnQuIFNvLCBqdXN0CiAgICAgLy8gdGhyb3cgdGhl IFN0YWNrT3ZlcmZsb3dFcnJvciB1bmNvbmRpdGlvbmFsbHkuCiAjaWYgRU5BQkxFKExMSU5UX0Nf TE9PUCkKICAgICBBU1NFUlQoIWV4ZWMtPnZtKCkuaW50ZXJwcmV0ZXItPnN0YWNrKCkuY29udGFp bnNBZGRyZXNzKGV4ZWMtPnRvcE9mRnJhbWUoKSkpOwotICAgIGlmIChVTkxJS0VMWSghdm0uaW50 ZXJwcmV0ZXItPnN0YWNrKCkuZW5zdXJlQ2FwYWNpdHlGb3IoZXhlYy0+dG9wT2ZGcmFtZSgpKSkp CisgICAgaWYgKExJS0VMWSghdm0uaW50ZXJwcmV0ZXItPnN0YWNrKCkuZW5zdXJlQ2FwYWNpdHlG b3IoZXhlYy0+dG9wT2ZGcmFtZSgpKSkpCisgICAgICAgIExMSU5UX1JFVFVSTl9UV08ocGMsIDAp OwogI2VuZGlmCi0gICAgewotICAgICAgICBleGVjID0gZXhlYy0+Y2FsbGVyRnJhbWUoKTsKLSAg ICAgICAgSW50ZXJwcmV0ZXI6OkVycm9ySGFuZGxpbmdNb2RlIG1vZGUoZXhlYyk7Ci0gICAgICAg IENvbW1vblNsb3dQYXRoczo6aW50ZXJwcmV0ZXJUaHJvd0luQ2FsbGVyKGV4ZWMsIGNyZWF0ZVN0 YWNrT3ZlcmZsb3dFcnJvcihleGVjKSk7Ci0gICAgICAgIHBjID0gcmV0dXJuVG9UaHJvd0ZvclRo cm93bkV4Y2VwdGlvbihleGVjKTsKLSAgICB9Ci0gICAgTExJTlRfRU5EX0lNUEwoKTsKKworICAg IGV4ZWMgPSBleGVjLT5jYWxsZXJGcmFtZSgpOworICAgIEludGVycHJldGVyOjpFcnJvckhhbmRs aW5nTW9kZSBtb2RlKGV4ZWMpOworICAgIENvbW1vblNsb3dQYXRoczo6aW50ZXJwcmV0ZXJUaHJv d0luQ2FsbGVyKGV4ZWMsIGNyZWF0ZVN0YWNrT3ZlcmZsb3dFcnJvcihleGVjKSk7CisgICAgcGMg PSByZXR1cm5Ub1Rocm93Rm9yVGhyb3duRXhjZXB0aW9uKGV4ZWMpOworICAgIExMSU5UX1JFVFVS Tl9UV08ocGMsIGV4ZWMpOwogfQogCiBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfY3Jl YXRlX2FjdGl2YXRpb24pCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlci5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCShyZXZpc2lvbiAxNjEwODMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20JKHdvcmtpbmcgY29w eSkKQEAgLTQzMyw2ICs0MzMsOCBAQCBtYWNybyBmdW5jdGlvbkluaXRpYWxpemF0aW9uKHByb2Zp bGVBcmdTCiAKICAgICAjIFN0YWNrIGhlaWdodCBjaGVjayBmYWlsZWQgLSBuZWVkIHRvIGNhbGwg YSBzbG93X3BhdGguCiAgICAgY2FsbFNsb3dQYXRoKF9sbGludF9zdGFja19jaGVjaykKKyAgICBi cGVxIHQxLCAwLCAuc3RhY2tIZWlnaHRPSworICAgIG1vdmUgdDEsIGNmcgogLnN0YWNrSGVpZ2h0 T0s6CiBlbmQKIAo= 220025 2013-12-25 23:12:09 -0800 2014-01-14 14:47:26 -0800 the patch. bug-126174.patch text/plain 4342 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMDgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTEyLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBq c2MtbGF5b3V0LXRlc3RzLnlhbWwvanMvc2NyaXB0LXRlc3RzL2Z1bmN0aW9uLWFwcGx5LWFsaWFz ZWQuanMubGF5b3V0LW5vLWNqaXQgaXMgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjE3NC4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGRvIGEgc3RhY2sgY2hlY2sgaW4gYSBm dW5jdGlvbiBwcm9sb2d1ZSwgdGhlIGFjdGl2YXRpb24gb2JqZWN0CisgICAgICAgIGluIHRoZSBm cmFtZSBoYXNuJ3QgYmVlbiBzZXQgeWV0LiBUaGUgdGVzdCBmYWlsdXJlcyBjYW1lIGZyb20gdGhl IHN0YWNrCisgICAgICAgIHVud2luZGluZyBjb2RlIHRyeWluZyB0byB0ZWFyIG9mZiB0aGUgZnJh bWUgdG8gYSBub24tZXhpc3RhbnQgYWN0aXZhdGlvbgorICAgICAgICBvYmplY3QuIFNpbmNlIHdl IGhhdmVuJ3QgZW50ZXJlZCB0aGUgZnVuY3Rpb24geWV0IGFuZCB0aGUgZnJhbWUgaXMKKyAgICAg ICAgdGVjaG5pY2FsbHkgbm90IGZ1bGx5ICJwdXNoZWQiIHlldCwgd2UgY2FuIHRocm93IGkuZS4g c3RhcnQgdGhlIHVud2luZGluZworICAgICAgICBmcm9tIHRoZSBjYWxsZXIgZnJhbWUgaW5zdGVh ZC4gVGhpcyBmaXhlcyB0aGUgaXNzdWUuCisKKyAgICAgICAgKiBsbGludC9MTEludFNsb3dQYXRo cy5jcHA6CisgICAgICAgIChKU0M6OkxMSW50OjpMTElOVF9TTE9XX1BBVEhfREVDTCk6CisgICAg ICAgIC0gV2hlbiB3ZSBoYXZlIGEgU3RhY2tPdmVyZmxvd0Vycm9yLCByZXR1cm4gdGhlIGNhbGxl cidzIENhbGxGcmFtZSBpbgorICAgICAgICAgIHRoZSBzZWNvbmQgdmFsdWUgaW4gdGhlIFNsb3dQ YXRoUmV0dXJuVHlwZS4KKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToK KyAgICAgICAgLSBDaGVjayBpZiB0aGUgc2Vjb25kIHZhbHVlIG9mIHRoZSBTbG93UGF0aFJldHVy blR5cGUgZnJvbSB0aGUgc3RhY2sKKyAgICAgICAgICBjaGVjayBpcyAwLiBJZiBub3QgMCwgc2V0 IHRoZSBjZnIgdG8gdGhlIHJldHVybmVkIENhbGxGcmFtZSogYmVmb3JlCisgICAgICAgICAgd2Ug c3RhcnQgaGFuZGxpbmcgdGhlIFN0YWNrT3ZlcmZsb3dFcnJvciBhbmQgdW53aW5kaW5nIHRoZSBz dGFjay4KKwogMjAxMy0xMi0yNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4K IAogICAgICAgICBDU3RhY2sgQnJhbmNoOiBlY21hL0V4ZWN1dGlvbkNvbnRleHRzLzEwLjEuNC0y LmpzIHRlc3QgZmFpbHMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNs b3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50U2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMTYxMDgzKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQyLDIwICs0 NDIsMzIgQEAgTExJTlRfU0xPV19QQVRIX0RFQ0woc3RhY2tfY2hlY2spCiAgICAgZGF0YUxvZ0Yo IkN1cnJlbnQgZW5kIGlzIGF0ICVwLlxuIiwgZXhlYy0+dm0oKS5pbnRlcnByZXRlci0+c3RhY2so KS5lbmQoKSk7CiAjZW5kaWYKIAorICAgIC8vIFRoaXMgc3RhY2sgY2hlY2sgaXMgZG9uZSBpbiB0 aGUgcHJvbG9ndWUgZm9yIGEgZnVuY3Rpb24gY2FsbCwgYW5kIHRoZQorICAgIC8vIENhbGxGcmFt ZSBpcyBub3QgY29tcGxldGVseSBzZXQgdXAgeWV0LiBGb3IgZXhhbXBsZSwgaWYgdGhlIGZyYW1l IG5lZWRzCisgICAgLy8gYW4gYWN0aXZhdGlvbiBvYmplY3QsIHRoZSBhY3RpdmF0aW9uIG9iamVj dCB3aWxsIG9ubHkgYmUgc2V0IHVwIGFmdGVyCisgICAgLy8gd2Ugc3RhcnQgZXhlY3V0aW5nIHRo ZSBmdW5jdGlvbi4gSWYgd2UgbmVlZCB0byB0aHJvdyBhIFN0YWNrT3ZlcmZsb3dFcnJvcgorICAg IC8vIGhlcmUsIHRoZW4gd2UgbmVlZCB0byB0ZWxsIHRoZSBwcm9sb2d1ZSB0byBzdGFydCB0aGUg c3RhY2sgdW53aW5kaW5nIGZyb20KKyAgICAvLyB0aGUgY2FsbGVyIGZyYW1lICh3aGljaCBpcyBm dWxseSBzZXQgdXApIGluc3RlYWQuIFRvIGRvIHRoYXQsIHdlIHJldHVybgorICAgIC8vIHRoZSBj YWxsZXIncyBDYWxsRnJhbWUgaW4gdGhlIHNlY29uZCByZXR1cm4gdmFsdWUuCisgICAgLy8KKyAg ICAvLyBJZiB0aGUgc3RhY2sgY2hlY2sgc3VjY2VlZHMgYW5kIHdlIGRvbid0IG5lZWQgdG8gdGhy b3cgdGhlIGVycm9yLCB0aGVuCisgICAgLy8gd2UnbGwgcmV0dXJuIDAgaW5zdGVhZC4gVGhlIHBy b2xvZ3VlIHdpbGwgY2hlY2sgZm9yIGEgbm9uLXplcm8gdmFsdWUKKyAgICAvLyB3aGVuIGRldGVy bWluaW5nIHdoZXRoZXIgdG8gc2V0IHRoZSBjYWxsRnJhbWUgb3Igbm90LgorCiAgICAgLy8gRm9y IEpJVCBlbmFibGVkIGJ1aWxkcyB3aGljaCB1c2VzIHRoZSBDIHN0YWNrLCB0aGUgc3RhY2sgaXMg bm90IGdyb3dhYmxlLgogICAgIC8vIEhlbmNlLCBpZiB3ZSBnZXQgaGVyZSwgdGhlbiB3ZSBrbm93 IGEgc3RhY2sgb3ZlcmZsb3cgaXMgaW1taW5lbnQuIFNvLCBqdXN0CiAgICAgLy8gdGhyb3cgdGhl IFN0YWNrT3ZlcmZsb3dFcnJvciB1bmNvbmRpdGlvbmFsbHkuCiAjaWYgRU5BQkxFKExMSU5UX0Nf TE9PUCkKICAgICBBU1NFUlQoIWV4ZWMtPnZtKCkuaW50ZXJwcmV0ZXItPnN0YWNrKCkuY29udGFp bnNBZGRyZXNzKGV4ZWMtPnRvcE9mRnJhbWUoKSkpOwotICAgIGlmIChVTkxJS0VMWSghdm0uaW50 ZXJwcmV0ZXItPnN0YWNrKCkuZW5zdXJlQ2FwYWNpdHlGb3IoZXhlYy0+dG9wT2ZGcmFtZSgpKSkp CisgICAgaWYgKExJS0VMWSh2bS5pbnRlcnByZXRlci0+c3RhY2soKS5lbnN1cmVDYXBhY2l0eUZv cihleGVjLT50b3BPZkZyYW1lKCkpKSkKKyAgICAgICAgTExJTlRfUkVUVVJOX1RXTyhwYywgMCk7 CiAjZW5kaWYKLSAgICB7Ci0gICAgICAgIGV4ZWMgPSBleGVjLT5jYWxsZXJGcmFtZSgpOwotICAg ICAgICBJbnRlcnByZXRlcjo6RXJyb3JIYW5kbGluZ01vZGUgbW9kZShleGVjKTsKLSAgICAgICAg Q29tbW9uU2xvd1BhdGhzOjppbnRlcnByZXRlclRocm93SW5DYWxsZXIoZXhlYywgY3JlYXRlU3Rh Y2tPdmVyZmxvd0Vycm9yKGV4ZWMpKTsKLSAgICAgICAgcGMgPSByZXR1cm5Ub1Rocm93Rm9yVGhy b3duRXhjZXB0aW9uKGV4ZWMpOwotICAgIH0KLSAgICBMTElOVF9FTkRfSU1QTCgpOworCisgICAg ZXhlYyA9IGV4ZWMtPmNhbGxlckZyYW1lKCk7CisgICAgSW50ZXJwcmV0ZXI6OkVycm9ySGFuZGxp bmdNb2RlIG1vZGUoZXhlYyk7CisgICAgQ29tbW9uU2xvd1BhdGhzOjppbnRlcnByZXRlclRocm93 SW5DYWxsZXIoZXhlYywgY3JlYXRlU3RhY2tPdmVyZmxvd0Vycm9yKGV4ZWMpKTsKKyAgICBwYyA9 IHJldHVyblRvVGhyb3dGb3JUaHJvd25FeGNlcHRpb24oZXhlYyk7CisgICAgTExJTlRfUkVUVVJO X1RXTyhwYywgZXhlYyk7CiB9CiAKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9jcmVh dGVfYWN0aXZhdGlvbikKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyLmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20JKHJldmlzaW9uIDE2MTA4MykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBjb3B5 KQpAQCAtNDMzLDYgKzQzMyw4IEBAIG1hY3JvIGZ1bmN0aW9uSW5pdGlhbGl6YXRpb24ocHJvZmls ZUFyZ1MKIAogICAgICMgU3RhY2sgaGVpZ2h0IGNoZWNrIGZhaWxlZCAtIG5lZWQgdG8gY2FsbCBh IHNsb3dfcGF0aC4KICAgICBjYWxsU2xvd1BhdGgoX2xsaW50X3N0YWNrX2NoZWNrKQorICAgIGJw ZXEgdDEsIDAsIC5zdGFja0hlaWdodE9LCisgICAgbW92ZSB0MSwgY2ZyCiAuc3RhY2tIZWlnaHRP SzoKIGVuZAogCg==