126169 2013-12-23 11:27:47 -0800 REGRESSION: plugins/plugin-remove-readystatechange.html is failing on debug bots 2015-01-04 16:04:50 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=130653 P2 Normal --- 1 ap ap commit-queue darin koivisto oldest_to_newest 962525 0 ap 2013-12-23 11:27:47 -0800 plugins/plugin-remove-readystatechange.html became very flaky on debug bots recently, possibly because of lazy tree creation (the first failure is in r160911:r160914 range, just a few revisions after r160908). http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fplugin-remove-readystatechange.html Looks like it's an extra blank line: ALERT: PASS: element could not be re-appended This test passes if it does not trip an assert in debug builds. It ensures a readystatechange event can't get dispatched until after a plugin is fully removed. + 1058554 1 ap 2015-01-04 11:54:51 -0800 Darin had a related fix for this test in bug 130653, but that got rolled out. I'm going to tweak the test to make it non-flaky, but it looks like a real bug in rendering code (that I have no idea how to fix). When embed is the last rendered element in a document, and there is a newline after it, we create a renderer for the newline, and don't remove it when the embed is removed. But when there is no embed by the time the first layout occurs, the newline is ignored. So, we get different render trees for the same DOM, depending on its history. It's unfortunate that this bug hasn't been looked into in more than a year, even though the culprit was immediately identified. 1058555 2 243934 ap 2015-01-04 12:03:40 -0800 Created attachment 243934 proposed fix 1058575 3 darin 2015-01-04 13:42:24 -0800 (In reply to comment #1) > It's unfortunate that this bug hasn't been looked into in more than a year, > even though the culprit was immediately identified. What was the culprit? 1058589 4 243934 ap 2015-01-04 15:24:15 -0800 Comment on attachment 243934 proposed fix > What was the culprit? Not a specific culprit in code, but circumstantial evidence was pointing to <http://trac.webkit.org/changeset/160908>. 1058601 5 243934 commit-queue 2015-01-04 16:04:46 -0800 Comment on attachment 243934 proposed fix Clearing flags on attachment: 243934 Committed r177879: <http://trac.webkit.org/changeset/177879> 1058602 6 commit-queue 2015-01-04 16:04:50 -0800 All reviewed patches have been landed. Closing bug. 243934 2015-01-04 12:03:40 -0800 2015-01-04 16:04:46 -0800 proposed fix NewlineRenderer.txt text/plain 2307 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3Nzg3NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTA0ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IHBsdWdpbnMvcGx1Z2lu LXJlbW92ZS1yZWFkeXN0YXRlY2hhbmdlLmh0bWwgaXMgZmFpbGluZyBvbiBkZWJ1ZyBib3RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYxNjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsdWdpbnMv cGx1Z2luLXJlbW92ZS1yZWFkeXN0YXRlY2hhbmdlLmh0bWw6IE1vdmUgdGhlIGVtYmVkIHNvIHRo YXQgaXQncyBub3QgdGhlCisgICAgICAgIGxhc3QgcmVuZGVyZWQgZWxlbWVudCBpbiB0aGUgdGVz dC4gSXQncyBvbmx5IGEgd29ya2Fyb3VuZCwgbm90IGEgcmVhbCBmaXggLSBpZgorICAgICAgICBh bnlvbmUgaXMgaW50ZXJlc3RlZCBpbiBmaXhpbmcgdGhlIGlzc3VlIGZvciByZWFsLCBwbGVhc2Ug ZmlsZSBhIG5ldyBidWcuCisgICAgICAgIEFsc28sIGRlbXlzdGlmaWVkIHRoZSB0ZXN0IGJ5IHVz aW5nIHJlYWR5U3RhdGUgaW5zdGVhZCBvZiBjb3VudGluZyByZWFkeXN0YXRlY2hhbmdlCisgICAg ICAgIGV2ZW50cy4KKwogMjAxNS0wMS0wMyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxl LmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBvcGVyYXRpb25OZXdGdW5jdGlvbiB3aGVuIHNjcm9s bGluZyBvbiBHb29nbGUrCkluZGV4OiBMYXlvdXRUZXN0cy9wbHVnaW5zL3BsdWdpbi1yZW1vdmUt cmVhZHlzdGF0ZWNoYW5nZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsdWdpbnMv cGx1Z2luLXJlbW92ZS1yZWFkeXN0YXRlY2hhbmdlLmh0bWwJKHJldmlzaW9uIDE3Nzg1NCkKKysr IExheW91dFRlc3RzL3BsdWdpbnMvcGx1Z2luLXJlbW92ZS1yZWFkeXN0YXRlY2hhbmdlLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTEsMTggKzEsMjAgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+ CiA8Ym9keT4KKzwhLS0gRklYTUU6IERvbid0IHVzZSBGbGFzaCwgaXQgbWF5IG5vdCBiZSBpbnN0 YWxsZWQgb24gdGhlIG1hY2hpbmUgd2hlcmUgdGhpcyB0ZXN0IGlzIHJ1bi4KKyAgICAgSXQgaXMg bm90IHRyaXZpYWwgdG8gc3dpdGNoIGZyb20gRmxhc2ggdG8gVGVzdE5ldHNjYXBlUGx1Z2luLCBi ZWNhdXNlIHdlIG5lZWQgdG8gYmUgbG9hZGluZworICAgICBhIHJlc291cmNlIGluIHRoaXMgdGVz dC4gLS0+Cis8ZW1iZWQgaWQ9InZpZXdlciIgc3JjPSJyZXNvdXJjZXMvc2ltcGxlX2JsYW5rLnN3 ZiI+PC9lbWJlZD4KIDxkaXY+CiBUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IHRyaXAg YW4gYXNzZXJ0IGluIGRlYnVnIGJ1aWxkcy4KIEl0IGVuc3VyZXMgYSByZWFkeXN0YXRlY2hhbmdl IGV2ZW50IGNhbid0IGdldCBkaXNwYXRjaGVkIHVudGlsIGFmdGVyIGEgcGx1Z2luIGlzIGZ1bGx5 IHJlbW92ZWQuCiA8L2Rpdj4KLTxlbWJlZCBpZD0idmlld2VyIiBzcmM9InJlc291cmNlcy9zaW1w bGVfYmxhbmsuc3dmIj48L2VtYmVkPgogPHNjcmlwdD4KIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK ICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKIAotdmFyIGkgPSAwOwogZG9jdW1lbnQuYWRk RXZlbnRMaXN0ZW5lcigncmVhZHlzdGF0ZWNoYW5nZScsIGZ1bmN0aW9uKCkgewotICAgIGlmIChp ID09IDEpIHsKKyAgICBpZiAoZG9jdW1lbnQucmVhZHlTdGF0ZSA9PSAiY29tcGxldGUiKSB7CiAg ICAgICAgIHRyeSB7CiAgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd2aWV3ZXInKSk7CiAgICAgICAgIH0KQEAgLTIwLDcgKzIyLDYg QEAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigncmVhZHlzdGF0ZWNoYQogICAgICAgICAgICAg YWxlcnQoJ1BBU1M6IGVsZW1lbnQgY291bGQgbm90IGJlIHJlLWFwcGVuZGVkJyk7CiAgICAgICAg fQogICAgIH0KLSAgICBpKys7CiB9KTsKIAogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ0RPTUNv bnRlbnRMb2FkZWQnLCBmdW5jdGlvbigpIHsK