<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126145</bug_id>
          
          <creation_ts>2013-12-22 20:29:37 -0800</creation_ts>
          <short_desc>[CMake] Fix typo from r160812</short_desc>
          <delta_ts>2013-12-23 06:43:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>gustavo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>962391</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-12-22 20:29:37 -0800</bug_when>
    <thetext>In r160812, JavaScriptCore_LIBRARY_TYPE is check against the string &quot;SHARED_LIBRARY,&quot; but should be check against &quot;SHARED.&quot; This prevents proper library versioning and installation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>962392</commentid>
    <comment_count>1</comment_count>
      <attachid>219890</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-12-22 20:30:51 -0800</bug_when>
    <thetext>Created attachment 219890
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>962451</commentid>
    <comment_count>2</comment_count>
      <attachid>219890</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2013-12-23 05:31:22 -0800</bug_when>
    <thetext>Comment on attachment 219890
Patch

Oops =)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>962468</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-12-23 06:43:27 -0800</bug_when>
    <thetext>Committed r160995: &lt;http://trac.webkit.org/changeset/160995&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>219890</attachid>
            <date>2013-12-22 20:30:51 -0800</date>
            <delta_ts>2013-12-23 05:31:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126145-20131222203051.patch</filename>
            <type>text/plain</type>
            <size>1532</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwOTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4
MjA3MmI2Mzg0NTNlZWY4NWQ2ZGIwOGYyYzEzYjQ2NTY5ZjEzMmJmLi4yYzIxOTYzNGI0MzJlMWE1
YjMzMDEzMzQwMDMyYjE2MDZlNTc0MjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNCBAQAogMjAxMy0xMi0yMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxp
YS5jb20+CiAKKyAgICAgICAgW0NNYWtlXSBGaXggdHlwbyBmcm9tIHIxNjA4MTIKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjE0NQorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6
IEZpeCB0eXBvIHdoZW4gZGV0ZWN0aW5nIHRoZSB0eXBlIG9mIGxpYnJhcnkuCisKKzIwMTMtMTIt
MjIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtH
VEtdW0NNYWtlXSBsaWJ0b29sLWNvbXBhdGlibGUgc292ZXJzaW9uIGNhbGN1bGF0aW9uCiAgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1MTEKIApkaWZm
IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGI2MWJmMzEzODg2MmU3NGYzODljZDNl
ZjM3NzdlM2QwYWEwZjJiZTQuLjIwYjVkMTRlMTVlZGQ4ODIyZTNkMTljMmUxZWUyYzZkZTM5MDE4
YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTc2MSw3ICs3NjEsNyBA
QCBpZiAoSmF2YVNjcmlwdENvcmVfT1VUUFVUX05BTUUpCiAgICAgc2V0X3RhcmdldF9wcm9wZXJ0
aWVzKEphdmFTY3JpcHRDb3JlIFBST1BFUlRJRVMgT1VUUFVUX05BTUUgJHtKYXZhU2NyaXB0Q29y
ZV9PVVRQVVRfTkFNRX0pCiBlbmRpZiAoKQogCi1pZiAoJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZ
X1RZUEV9IFNUUkVRVUFMICJTSEFSRURfTElCUkFSWSIpCitpZiAoJHtKYXZhU2NyaXB0Q29yZV9M
SUJSQVJZX1RZUEV9IFNUUkVRVUFMICJTSEFSRUQiKQogICAgIFBPUFVMQVRFX0xJQlJBUllfVkVS
U0lPTihKQVZBU0NSSVBUQ09SRSkKICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoSmF2YVNjcmlw
dENvcmUgUFJPUEVSVElFUyBWRVJTSU9OICR7SkFWQVNDUklQVENPUkVfVkVSU0lPTn0gU09WRVJT
SU9OICR7SkFWQVNDUklQVENPUkVfVkVSU0lPTl9NQUpPUn0pCiAgICAgaW5zdGFsbChUQVJHRVRT
IEphdmFTY3JpcHRDb3JlIERFU1RJTkFUSU9OICIke0xJQl9JTlNUQUxMX0RJUn0iKQo=
</data>
<flag name="review"
          id="243555"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>