126139 2013-12-22 14:12:45 -0800 CStack: Fixed some JSStack on C Stack boundary computations. 2013-12-29 08:41:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125928 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 962369 0 mark.lam 2013-12-22 14:12:45 -0800 Basically committedByteCount() and containsAddress() needs to be fixed. 962370 1 219886 mark.lam 2013-12-22 14:15:15 -0800 Created attachment 219886 the patch. 962371 2 mark.lam 2013-12-22 14:24:31 -0800 Landed in r160981 on the jsCStack branch: <http://trac.webkit.org/r160981>. 963212 3 mark.lam 2013-12-29 08:41:15 -0800 Thanks for the review. Updated review status in r161119: <http://trac.webkit.org/r161119>. 219886 2013-12-22 14:15:15 -0800 2013-12-29 08:37:58 -0800 the patch. bug-126139.patch text/plain 4995 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwOTgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTEyLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IEZpeGVkIHNvbWUgSlNTdGFjayBvbiBDIFN0YWNrIGJvdW5kYXJ5IGNvbXB1dGF0aW9u cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjEz OS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAxLiBJ bXBsZW1lbnQgY29tbWl0dGVkQnl0ZUNvdW50KCkgZm9yIEpTU3RhY2sgb24gdGhlIEMgc3RhY2sg dXNpbmcgdGhlCisgICAgICAgICAgIGN1cnJlbnQgc3RhY2sgdXNhZ2UgYXMgYW4gZXN0aW1hdGUg b2YgY29tbWl0dGVkIHN0YWNrIG1lbW9yeS4KKyAgICAgICAgMi4gSW1wbGVtZW50IGxvd0FkZHJl c3MoKSBhbmQgaGlnaEFkZHJlc3MoKSBmb3IgSlNTdGFjayBvbiB0aGUgQyBzdGFjaworICAgICAg ICAgICBmb3IgY29udGFpbnNBZGRyZXNzKCkuIGxvd0FkZHJlc3MoKSB3aWxsIGJlIHRoZSB0b3Ag b2YgdGhlIEpTIHN0YWNrLgorICAgICAgICAgICBoaWdoQWRkcmVzcygpIHdpbGwgYmUgMSBwYXN0 IHRoZSBlbmQgb2YgdGhlIEpTIHN0YWNrLgorICAgICAgICAzLiBNb3ZlZCBzb21lIGZ1bmN0aW9u cyBhcm91bmQgaW4gcHJlcGFyYXRpb24gZm9yIGFuIHVwY29taW5nIHBhdGNoIHRvCisgICAgICAg ICAgICNpZiBvdXQgY29kZSB3aGljaCBpcyBvbmx5IHVzZWQgd2hlbiBFTkFCTEUoTExJTlRfQ19M T09QKQorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5jcHA6CisgICAgICAgIChKU0M6 OkpTU3RhY2s6Omxvd0FkZHJlc3MpOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpoaWdoQWRkcmVz cyk6CisgICAgICAgIChKU0M6OkpTU3RhY2s6OmNvbW1pdHRlZEJ5dGVDb3VudCk6CisgICAgICAg ICogaW50ZXJwcmV0ZXIvSlNTdGFjay5oOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpjb250YWlu c0FkZHJlc3MpOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpsb3dBZGRyZXNzKToKKwogMjAxMy0x Mi0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEl0IHNob3Vs ZCBiZSBwb3NzaWJsZSB0byBydW4gdGhlIGZ1bGwgdmVyc2lvbiBvZiBWOHY3L2NyeXB0byB3aXRo IHRoZSBGVEwgYW5kIGNhbGwgSUMncwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL0pTU3RhY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9KU1N0YWNrLmNwcAkocmV2aXNpb24gMTYwOTY3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIs MTIgKzE0Miw2IEBAIHZvaWQgSlNTdGFjazo6aW5pdGlhbGl6ZVRocmVhZGluZygpCiAgICAgc3Rh Y2tTdGF0aXN0aWNzTXV0ZXgoKTsKIH0KIAotc2l6ZV90IEpTU3RhY2s6OmNvbW1pdHRlZEJ5dGVD b3VudCgpCi17Ci0gICAgTXV0ZXhMb2NrZXIgbG9ja2VyKHN0YWNrU3RhdGlzdGljc011dGV4KCkp OwotICAgIHJldHVybiBjb21taXR0ZWRCeXRlc0NvdW50OwotfQotCiB2b2lkIEpTU3RhY2s6OmFk ZFRvQ29tbWl0dGVkQnl0ZUNvdW50KGxvbmcgYnl0ZUNvdW50KQogewogICAgIE11dGV4TG9ja2Vy IGxvY2tlcihzdGFja1N0YXRpc3RpY3NNdXRleCgpKTsKQEAgLTE3Niw2ICsxNzAsMzUgQEAgdm9p ZCBKU1N0YWNrOjpkaXNhYmxlRXJyb3JTdGFja1Jlc2VydmUoKQogICAgIH0KIH0KIAorI2lmICFF TkFCTEUoTExJTlRfQ19MT09QKQorUmVnaXN0ZXIqIEpTU3RhY2s6Omxvd0FkZHJlc3MoKSBjb25z dAoreworICAgIEFTU0VSVCh3dGZUaHJlYWREYXRhKCkuc3RhY2soKS5pc0dyb3dpbmdEb3dud2Fy ZCgpKTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxSZWdpc3Rlcio+KG1fdm0uanNTdGFj a0xpbWl0KCkpOworfQorCitSZWdpc3RlciogSlNTdGFjazo6aGlnaEFkZHJlc3MoKSBjb25zdAor eworICAgIEFTU0VSVCh3dGZUaHJlYWREYXRhKCkuc3RhY2soKS5pc0dyb3dpbmdEb3dud2FyZCgp KTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxSZWdpc3Rlcio+KHd0ZlRocmVhZERhdGEo KS5zdGFjaygpLm9yaWdpbigpKTsKK30KKyNlbmRpZiAvLyAhRU5BQkxFKExMSU5UX0NfTE9PUCkK Kworc2l6ZV90IEpTU3RhY2s6OmNvbW1pdHRlZEJ5dGVDb3VudCgpCit7CisjaWYgRU5BQkxFKExM SU5UX0NfTE9PUCkKKyAgICBNdXRleExvY2tlciBsb2NrZXIoc3RhY2tTdGF0aXN0aWNzTXV0ZXgo KSk7CisgICAgcmV0dXJuIGNvbW1pdHRlZEJ5dGVzQ291bnQ7CisjZWxzZQorICAgIC8vIFdoZW4g dXNpbmcgdGhlIEMgc3RhY2ssIHdlIGRvbid0IGtub3cgaG93IG1hbnkgc3RhY2sgcGFnZXMgYXJl IGFjdHVhbGx5CisgICAgLy8gY29tbWl0dGVkLiBTbywgd2UgdXNlIHRoZSBjdXJyZW50IHN0YWNr IHVzYWdlIGFzIGFuIGVzdGltYXRlLgorICAgIEFTU0VSVCh3dGZUaHJlYWREYXRhKCkuc3RhY2so KS5pc0dyb3dpbmdEb3dud2FyZCgpKTsKKyAgICBpbnQ4X3QqIGN1cnJlbnQgPSByZWludGVycHJl dF9jYXN0PGludDhfdCo+KCZjdXJyZW50KTsKKyAgICBpbnQ4X3QqIGhpZ2ggPSByZWludGVycHJl dF9jYXN0PGludDhfdCo+KHd0ZlRocmVhZERhdGEoKS5zdGFjaygpLm9yaWdpbigpKTsKKyAgICBy ZXR1cm4gaGlnaCAtIGN1cnJlbnQ7CisjZW5kaWYKK30KKwogdm9pZCBKU1N0YWNrOjp1cGRhdGVT dGFja0xpbWl0KCkKIHsKICNpZiBFTkFCTEUoTExJTlRfQ19MT09QKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5oCShyZXZpc2lvbiAxNjA5NjcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSlNTdGFjay5oCSh3b3JraW5nIGNv cHkpCkBAIC04NSw2ICs4NSw5IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIHZvaWQgdXBk YXRlU3RhY2tMaW1pdCgpOwogCisgICAgICAgIGJvb2wgY29udGFpbnNBZGRyZXNzKFJlZ2lzdGVy KiBhZGRyZXNzKSB7IHJldHVybiAobG93QWRkcmVzcygpIDw9IGFkZHJlc3MgJiYgYWRkcmVzcyA8 IGhpZ2hBZGRyZXNzKCkpOyB9CisgICAgICAgIHN0YXRpYyBzaXplX3QgY29tbWl0dGVkQnl0ZUNv dW50KCk7CisKICAgICAgICAgdm9pZCBnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDb25zZXJ2YXRp dmVSb290cyYpOwogICAgICAgICB2b2lkIGdhdGhlckNvbnNlcnZhdGl2ZVJvb3RzKENvbnNlcnZh dGl2ZVJvb3RzJiwgSklUU3R1YlJvdXRpbmVTZXQmLCBDb2RlQmxvY2tTZXQmKTsKICAgICAgICAg dm9pZCBzYW5pdGl6ZVN0YWNrKCk7CkBAIC05Niw3ICs5OSw2IEBAIG5hbWVzcGFjZSBKU0Mgewog CiAgICAgICAgIHNpemVfdCBzaXplKCkgY29uc3QgeyByZXR1cm4gaGlnaEFkZHJlc3MoKSAtIGxv d0FkZHJlc3MoKTsgfQogCi0gICAgICAgIHN0YXRpYyBzaXplX3QgY29tbWl0dGVkQnl0ZUNvdW50 KCk7CiAgICAgICAgIHN0YXRpYyB2b2lkIGluaXRpYWxpemVUaHJlYWRpbmcoKTsKIAogICAgICAg ICBSZWdpc3Rlciogc3RhcnRPZkZyYW1lRm9yKENhbGxGcmFtZSopOwpAQCAtMTA1LDggKzEwNyw2 IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIHZvaWQgcG9wRnJhbWUoQ2FsbEZyYW1lKik7 CiAKLSAgICAgICAgYm9vbCBjb250YWluc0FkZHJlc3MoUmVnaXN0ZXIqIGFkZHJlc3MpIHsgcmV0 dXJuIChsb3dBZGRyZXNzKCkgPD0gYWRkcmVzcyAmJiBhZGRyZXNzIDw9IGhpZ2hBZGRyZXNzKCkp OyB9Ci0KICNpZiBFTkFCTEUoREVCVUdfSlNTVEFDSykKICAgICAgICAgdm9pZCBpbnN0YWxsRmVu Y2UoQ2FsbEZyYW1lKiwgY29uc3QgY2hhciAqZnVuY3Rpb24gPSAiIiwgaW50IGxpbmVObyA9IDAp OwogICAgICAgICB2b2lkIHZhbGlkYXRlRmVuY2UoQ2FsbEZyYW1lKiwgY29uc3QgY2hhciAqZnVu Y3Rpb24gPSAiIiwgaW50IGxpbmVObyA9IDApOwpAQCAtMTIyLDE1ICsxMjIsMjAgQEAgbmFtZXNw YWNlIEpTQyB7CiAgICAgICAgIGlubGluZSBSZWdpc3RlciogdG9wT2ZTdGFjaygpOwogICAgICAg ICBpbmxpbmUgUmVnaXN0ZXIqIHRvcE9mU3RhY2tGb3JDYXBhY2l0eUNoZWNrKCk7CiAKKyNpZiBF TkFCTEUoTExJTlRfQ19MT09QKQogICAgICAgICBSZWdpc3RlciogbG93QWRkcmVzcygpIGNvbnN0 CiAgICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiBtX2VuZDsKKyAgICAgICAgICAgIHJldHVy biBtX2VuZCArIDE7CiAgICAgICAgIH0KIAogICAgICAgICBSZWdpc3RlciogaGlnaEFkZHJlc3Mo KSBjb25zdAogICAgICAgICB7CiAgICAgICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdF9w dHI8UmVnaXN0ZXIqPihzdGF0aWNfY2FzdDxjaGFyKj4obV9yZXNlcnZhdGlvbi5iYXNlKCkpICsg bV9yZXNlcnZhdGlvbi5zaXplKCkpOwogICAgICAgICB9CisjZWxzZQorICAgICAgICBSZWdpc3Rl ciogbG93QWRkcmVzcygpIGNvbnN0OworICAgICAgICBSZWdpc3RlciogaGlnaEFkZHJlc3MoKSBj b25zdDsKKyNlbmRpZiAvLyBFTkFCTEUoTExJTlRfQ19MT09QKQogCiAgICAgICAgIFJlZ2lzdGVy KiByZXNlcnZhdGlvbkVuZCgpIGNvbnN0CiAgICAgICAgIHsK