126138 2013-12-22 11:04:19 -0800 [GTK][WK2] WebGL is not working with GLES 2013-12-23 02:15:30 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED http://learningwebgl.com/lessons/lesson01 P2 Normal --- 1 changseok changseok commit-queue dino d-r gustavo kondapallykalyan mrobinson noam roger_fong zan oldest_to_newest 962346 0 changseok 2013-12-22 11:04:19 -0800 Just run http://learningwebgl.com/lessons/lesson01 962352 1 219881 changseok 2013-12-22 12:23:32 -0800 Created attachment 219881 Patch 962353 2 commit-queue 2013-12-22 12:24:10 -0800 Attachment 219881 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:128: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:136: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:136: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:127: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:134: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 962355 3 changseok 2013-12-22 12:33:01 -0800 (In reply to comment #2) > Attachment 219881 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp', '--commit-queue']" exit_code: 1 > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:128: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:136: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:136: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:127: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:134: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:135: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > Total errors found: 8 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. False positives, sigh.. 962423 4 219881 changseok 2013-12-23 01:47:16 -0800 Comment on attachment 219881 Patch Thank you for the review! 962425 5 219881 commit-queue 2013-12-23 02:15:26 -0800 Comment on attachment 219881 Patch Clearing flags on attachment: 219881 Committed r160991: <http://trac.webkit.org/changeset/160991> 962426 6 commit-queue 2013-12-23 02:15:30 -0800 All reviewed patches have been landed. Closing bug. 219881 2013-12-22 12:23:32 -0800 2013-12-23 02:15:26 -0800 Patch bug-126138-20131223052331.patch text/plain 5357 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwOTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjIwOWM5NTdhMmNlYTUx NDg4ODdjMDFhNWY3MGQ3OTYwZGI2Y2VhNS4uMDEwZTE0MjI2ZTg5OWM5Yjc2MmMzODMwZGViNzY3 YTEwNDkzZTU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTEyLTIyICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXVtX SzJdIFdlYkdMIGlzIG5vdCB3b3JraW5nIHdpdGggR0xFUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbV90ZXh0dXJlIGhhcyBiZWVuIHVubmVjZXNzYXJp bHkgcmVnZW5lcmF0ZWQuIEl0J3MgZ2VuZXJhdGVkIGluIEdyYXBoaWNzQ29udGV4dDNECisgICAg ICAgIGNvbnN0cnVjdG9yIGZvciBvZmZzY3JlZW4gcmVuZGVyaW5nLiBBbmQgbV9jb21wb3NpdG9y VGV4dHVyZSBpcyB1c2VkIGJ5IG9ubHkgTWFjIHBvcnQuCisgICAgICAgIFRoZXkgY3JlYXRlIGl0 IGluIHRoZWlyIEdyYXBoaWNzQ29udGV4dDNEIGNvbnN0cnVjdG9yIHNvIHRoYXQgd2UgZG9uJ3Qg bmVlZCB0byByZWNyZWF0ZSBpdAorICAgICAgICBpbiBHQzNET3BlbkdMRVM6OnJlc2hhcGVGQk9z LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBubyBmdW5jdGlvbmFsaXR5IGNoYW5nZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENh aXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjp+R3JhcGhpY3ND b250ZXh0M0QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0Nv bnRleHQzRE9wZW5HTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6 cmVzaGFwZUZCT3MpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGlj c0NvbnRleHQzRE9wZW5HTEVTLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDNEOjpyZXNoYXBlRkJPcyk6CisKIDIwMTMtMTItMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQXNzZXJ0IHRoYXQgUm9vdElubGluZUJveDo6c2V0TGluZUJy ZWFrSW5mbyBzaG91bGQgaXMgbmV2ZXIgY2FsbGVkIG9uIGEgUmVuZGVySW5saW5lIHdpdGhvdXQg bGluZSBib3hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAppbmRleCBmYzkxN2Mx NDY2ZWY5NDE4MDkzZDJiYzExYTgxMjI3ZTJkZjNiYmQ0Li44NjQxZmQ0ODM5ZmEyOWFjYzVkMTUy YTY2N2E4YzE1NmQyNGRjMTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcApA QCAtMTU5LDggKzE1OSwxMSBAQCBHcmFwaGljc0NvbnRleHQzRDo6fkdyYXBoaWNzQ29udGV4dDNE KCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbWFrZUNvbnRleHRDdXJyZW50KCk7Ci0gICAgOjpn bERlbGV0ZVRleHR1cmVzKDEsICZtX3RleHR1cmUpOwotICAgIDo6Z2xEZWxldGVUZXh0dXJlcygx LCAmbV9jb21wb3NpdG9yVGV4dHVyZSk7CisgICAgaWYgKG1fdGV4dHVyZSkKKyAgICAgICAgOjpn bERlbGV0ZVRleHR1cmVzKDEsICZtX3RleHR1cmUpOworICAgIGlmIChtX2NvbXBvc2l0b3JUZXh0 dXJlKQorICAgICAgICA6OmdsRGVsZXRlVGV4dHVyZXMoMSwgJm1fY29tcG9zaXRvclRleHR1cmUp OworCiAgICAgaWYgKG1fYXR0cnMuYW50aWFsaWFzKSB7CiAgICAgICAgIDo6Z2xEZWxldGVSZW5k ZXJidWZmZXJzKDEsICZtX211bHRpc2FtcGxlQ29sb3JCdWZmZXIpOwogICAgICAgICBpZiAobV9h dHRycy5zdGVuY2lsIHx8IG1fYXR0cnMuZGVwdGgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNE T3BlbkdMLmNwcAppbmRleCA4NjQ0YzljNDYyZjBjM2NiOWQ3ZmQxNjdlZDA5M2M0YzA1ZDBiZGU3 Li41MjM4NGQ2MzA2MTY2M2M3MGIwMzViYTVjMjZlMzI3ZTA3NDExNTM2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RP cGVuR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9H cmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKQEAgLTEyNCwxMiArMTI0LDE4IEBAIGJvb2wgR3Jh cGhpY3NDb250ZXh0M0Q6OnJlc2hhcGVGQk9zKGNvbnN0IEludFNpemUmIHNpemUpCiAgICAgICAg IG11c3RSZXN0b3JlRkJPID0gdHJ1ZTsKICAgICAgICAgOjpnbEJpbmRGcmFtZWJ1ZmZlckVYVChH TF9GUkFNRUJVRkZFUl9FWFQsIG1fZmJvKTsKICAgICB9CisKKyAgICBBU1NFUlQobV90ZXh0dXJl KTsKICAgICA6OmdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgbV90ZXh0dXJlKTsKICAgICA6 OmdsVGV4SW1hZ2UyRChHTF9URVhUVVJFXzJELCAwLCBtX2ludGVybmFsQ29sb3JGb3JtYXQsIHdp ZHRoLCBoZWlnaHQsIDAsIGNvbG9yRm9ybWF0LCBHTF9VTlNJR05FRF9CWVRFLCAwKTsKICAgICA6 OmdsRnJhbWVidWZmZXJUZXh0dXJlMkRFWFQoR0xfRlJBTUVCVUZGRVJfRVhULCBHTF9DT0xPUl9B VFRBQ0hNRU5UMF9FWFQsIEdMX1RFWFRVUkVfMkQsIG1fdGV4dHVyZSwgMCk7Ci0gICAgOjpnbEJp bmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIG1fY29tcG9zaXRvclRleHR1cmUpOwotICAgIDo6Z2xU ZXhJbWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIG1faW50ZXJuYWxDb2xvckZvcm1hdCwgd2lkdGgs IGhlaWdodCwgMCwgY29sb3JGb3JtYXQsIEdMX1VOU0lHTkVEX0JZVEUsIDApOwotICAgIDo6Z2xC aW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCAwKTsKKworICAgIGlmIChtX2NvbXBvc2l0b3JUZXh0 dXJlKSB7CisgICAgICAgIDo6Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCBtX2NvbXBvc2l0 b3JUZXh0dXJlKTsKKyAgICAgICAgOjpnbFRleEltYWdlMkQoR0xfVEVYVFVSRV8yRCwgMCwgbV9p bnRlcm5hbENvbG9yRm9ybWF0LCB3aWR0aCwgaGVpZ2h0LCAwLCBjb2xvckZvcm1hdCwgR0xfVU5T SUdORURfQllURSwgMCk7CisgICAgICAgIDo6Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCAw KTsKKyAgICB9CisKICAgICBpZiAoIW1fYXR0cnMuYW50aWFsaWFzICYmIChtX2F0dHJzLnN0ZW5j aWwgfHwgbV9hdHRycy5kZXB0aCkpIHsKICAgICAgICAgOjpnbEJpbmRSZW5kZXJidWZmZXJFWFQo R0xfUkVOREVSQlVGRkVSX0VYVCwgbV9kZXB0aFN0ZW5jaWxCdWZmZXIpOwogICAgICAgICA6Omds UmVuZGVyYnVmZmVyU3RvcmFnZUVYVChHTF9SRU5ERVJCVUZGRVJfRVhULCBpbnRlcm5hbERlcHRo U3RlbmNpbEZvcm1hdCwgd2lkdGgsIGhlaWdodCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0 M0RPcGVuR0xFUy5jcHAKaW5kZXggOWViMzA1ZTkyY2U5Nzc4ZDliNWEyYzQ1Nzk5OWVkNzUwMzNl NjEyMi4uYTc0OTM5MDJhZWZiNTk2ZDRkMGFkODZjNTMzOTZiMzRiMjlmZTEzMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4 dDNET3BlbkdMRVMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcApAQCAtMTI0LDE1ICsxMjQsMTYgQEAg Ym9vbCBHcmFwaGljc0NvbnRleHQzRDo6cmVzaGFwZUZCT3MoY29uc3QgSW50U2l6ZSYgc2l6ZSkK ICAgICAgICAgOjpnbEJpbmRGcmFtZWJ1ZmZlcihHTF9GUkFNRUJVRkZFUiwgbV9mYm8pOwogICAg IH0KIAotICAgIDo6Z2xHZW5UZXh0dXJlcygxLCAmbV90ZXh0dXJlKTsKKyAgICBBU1NFUlQobV90 ZXh0dXJlKTsKICAgICA6OmdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgbV90ZXh0dXJlKTsK ICAgICA6OmdsVGV4SW1hZ2UyRChHTF9URVhUVVJFXzJELCAwLCBtX2ludGVybmFsQ29sb3JGb3Jt YXQsIHdpZHRoLCBoZWlnaHQsIDAsIGNvbG9yRm9ybWF0LCBwaXhlbERhdGFUeXBlLCAwKTsKICAg ICA6OmdsRnJhbWVidWZmZXJUZXh0dXJlMkQoR0xfRlJBTUVCVUZGRVIsIEdMX0NPTE9SX0FUVEFD SE1FTlQwLCBHTF9URVhUVVJFXzJELCBtX3RleHR1cmUsIDApOwogCi0gICAgOjpnbEdlblRleHR1 cmVzKDEsICZtX2NvbXBvc2l0b3JUZXh0dXJlKTsKLSAgICA6OmdsQmluZFRleHR1cmUoR0xfVEVY VFVSRV8yRCwgbV9jb21wb3NpdG9yVGV4dHVyZSk7Ci0gICAgOjpnbFRleEltYWdlMkQoR0xfVEVY VFVSRV8yRCwgMCwgbV9pbnRlcm5hbENvbG9yRm9ybWF0LCB3aWR0aCwgaGVpZ2h0LCAwLCBjb2xv ckZvcm1hdCwgR0xfVU5TSUdORURfQllURSwgMCk7Ci0gICAgOjpnbEJpbmRUZXh0dXJlKEdMX1RF WFRVUkVfMkQsIDApOworICAgIGlmIChtX2NvbXBvc2l0b3JUZXh0dXJlKSB7CisgICAgICAgIDo6 Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCBtX2NvbXBvc2l0b3JUZXh0dXJlKTsKKyAgICAg ICAgOjpnbFRleEltYWdlMkQoR0xfVEVYVFVSRV8yRCwgMCwgbV9pbnRlcm5hbENvbG9yRm9ybWF0 LCB3aWR0aCwgaGVpZ2h0LCAwLCBjb2xvckZvcm1hdCwgR0xfVU5TSUdORURfQllURSwgMCk7Cisg ICAgICAgIDo6Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCAwKTsKKyAgICB9CiAKICAgICAv LyBXZSBkb24ndCBzdXBwb3J0IGFudGlhbGlhc2luZyB5ZXQuIFNlZSBHcmFwaGljc0NvbnRleHQz RDo6dmFsaWRhdGVBdHRyaWJ1dGVzLgogICAgIEFTU0VSVCghbV9hdHRycy5hbnRpYWxpYXMpOwo=