126126 2013-12-21 21:46:23 -0800 REGRESSION (r160672): Random remote layers are getting shadows 2013-12-23 13:06:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 962289 0 thorton 2013-12-21 21:46:23 -0800 In http://trac.webkit.org/changeset/160672, we unconditionally check m_properties.customAppearance in requiresCustomAppearanceUpdateOnBoundsChange without regard for whether it has ever been initialized. This would get us to send an uninitialized custom appearance to the UI process, which could end up requesting a shadow. I have a patch to initialize lots of things to their CA defaults. 962291 1 219862 thorton 2013-12-21 21:59:46 -0800 Created attachment 219862 patch 962557 2 thorton 2013-12-23 13:06:47 -0800 http://trac.webkit.org/changeset/161013 219862 2013-12-21 21:59:46 -0800 2013-12-22 07:50:24 -0800 patch randomshadows.diff text/plain 3225 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NWZlYjRjLi5lMTcyNTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTMtMTItMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE2MDY3Mik6IFJhbmRvbSByZW1vdGUgbGF5ZXJzIGFyZSBn ZXR0aW5nIHNoYWRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE2MDY3Miwgd2UgdW5j b25kaXRpb25hbGx5CisgICAgICAgIGNoZWNrIG1fcHJvcGVydGllcy5jdXN0b21BcHBlYXJhbmNl IHdpdGhvdXQgcmVnYXJkIGZvciB3aGV0aGVyIGl0CisgICAgICAgIGhhcyBldmVyIGJlZW4gaW5p dGlhbGl6ZWQuIFRoaXMgd291bGQgcmVzdWx0IGluIHNlbmRpbmcgYW4gdW5pbml0aWFsaXplZAor ICAgICAgICBjdXN0b20gYXBwZWFyYW5jZSB0byB0aGUgVUkgcHJvY2Vzcywgd2hpY2ggY291bGQg ZW5kIHVwIHJlcXVlc3RpbmcgYSBzaGFkb3cuCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1JlbW90 ZUxheWVyVHJlZVRyYW5zYWN0aW9uLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRy ZWVUcmFuc2FjdGlvbjo6TGF5ZXJQcm9wZXJ0aWVzOjpMYXllclByb3BlcnRpZXMpOgorICAgICAg ICBJbml0aWFsaXplIExheWVyUHJvcGVydGllcyB0byB0aGUgQ29yZUFuaW1hdGlvbiBkZWZhdWx0 cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVt b3RlLmNwcDoKKyAgICAgICAgKFBsYXRmb3JtQ0FMYXllclJlbW90ZTo6UGxhdGZvcm1DQUxheWVy UmVtb3RlKToKKyAgICAgICAgUmVtb3ZlIHdyb25nbHktcGxhY2VkIGRlZmF1bHQgaW5pdGlhbGl6 YXRpb24gb2YgY29udGVudHNTY2FsZTsKKyAgICAgICAgdGhlcmUncyBubyByZWFzb24gdG8gc2Vu ZCBpdCBhY3Jvc3MgdGhlIHdpcmUgZm9yIGV2ZXJ5IG5ldyBsYXllcgorICAgICAgICBpZiBpdCdz IGxlZnQgYXQgdGhlIGRlZmF1bHQuCisKIDIwMTMtMTItMjEgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGF0dGVtcHQg b24gRUZMIHBvcnQgYWZ0ZXIgcjE2MDk3MSBhbmQgcjE2MDk2OQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbSBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24ubW0KaW5kZXgg ZGVkNzJkOC4uNTFiOTNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9S ZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLm1tCkBAIC03MSw2ICs3MSwyNSBAQCBib29s IFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpMYXllckNyZWF0aW9uUHJvcGVydGllczo6ZGVj b2RlKENvcmVJUEM6OkFyZ3VtZQogUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJv cGVydGllczo6TGF5ZXJQcm9wZXJ0aWVzKCkKICAgICA6IGNoYW5nZWRQcm9wZXJ0aWVzKE5vQ2hh bmdlKQogICAgICwgZXZlckNoYW5nZWRQcm9wZXJ0aWVzKE5vQ2hhbmdlKQorICAgICwgYmFja2dy b3VuZENvbG9yKENvbG9yOjp0cmFuc3BhcmVudCkKKyAgICAsIGFuY2hvclBvaW50KDAuNSwgMC41 LCAwKQorICAgICwgYm9yZGVyV2lkdGgoMCkKKyAgICAsIGJvcmRlckNvbG9yKENvbG9yOjpibGFj aykKKyAgICAsIG9wYWNpdHkoMSkKKyAgICAsIGhpZGRlbihmYWxzZSkKKyAgICAsIGdlb21ldHJ5 RmxpcHBlZChmYWxzZSkKKyAgICAsIGRvdWJsZVNpZGVkKHRydWUpCisgICAgLCBtYXNrc1RvQm91 bmRzKGZhbHNlKQorICAgICwgb3BhcXVlKGZhbHNlKQorICAgICwgbWFza0xheWVySUQoMCkKKyAg ICAsIGNvbnRlbnRzUmVjdChGbG9hdFBvaW50KCksIEZsb2F0U2l6ZSgxLCAxKSkKKyAgICAsIGNv bnRlbnRzU2NhbGUoMSkKKyAgICAsIG1pbmlmaWNhdGlvbkZpbHRlcihQbGF0Zm9ybUNBTGF5ZXI6 OkZpbHRlclR5cGU6OkxpbmVhcikKKyAgICAsIG1hZ25pZmljYXRpb25GaWx0ZXIoUGxhdGZvcm1D QUxheWVyOjpGaWx0ZXJUeXBlOjpMaW5lYXIpCisgICAgLCBzcGVlZCgxKQorICAgICwgdGltZU9m ZnNldCgwKQorICAgICwgZWRnZUFudGlhbGlhc2luZ01hc2soa0NBTGF5ZXJMZWZ0RWRnZSB8IGtD QUxheWVyUmlnaHRFZGdlIHwga0NBTGF5ZXJCb3R0b21FZGdlIHwga0NBTGF5ZXJUb3BFZGdlKQor ICAgICwgY3VzdG9tQXBwZWFyYW5jZShHcmFwaGljc0xheWVyOjpOb0N1c3RvbUFwcGVhcmFuY2Up CiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9t YWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcAppbmRleCBhOGUzMmExLi5hN2Iz ZjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Bs YXRmb3JtQ0FMYXllclJlbW90ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3BwCkBAIC05MCw4ICs5MCw2IEBAIFBs YXRmb3JtQ0FMYXllclJlbW90ZTo6UGxhdGZvcm1DQUxheWVyUmVtb3RlKExheWVyVHlwZSBsYXll clR5cGUsIFBsYXRmb3JtQ0FMYXllCiAgICAgLCBtX2FjY2VsZXJhdGVzRHJhd2luZyhmYWxzZSkK ICAgICAsIG1fY29udGV4dChjb250ZXh0KQogewotICAgIC8vIEZJWE1FOiBtYXRjaCBhbGwgZGVm YXVsdCB2YWx1ZXMgZnJvbSBDQS4KLSAgICBzZXRDb250ZW50c1NjYWxlKDEpOwogfQogCiBQYXNz UmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4gUGxhdGZvcm1DQUxheWVyUmVtb3RlOjpjbG9uZShQbGF0 Zm9ybUNBTGF5ZXJDbGllbnQqIGNsaWVudCkgY29uc3QK