<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126114</bug_id>
          
          <creation_ts>2013-12-21 00:44:51 -0800</creation_ts>
          <short_desc>[SOUP] ResourceHandle doesn&apos;t implement continueShouldUseCredentialStorage()</short_desc>
          <delta_ts>2014-05-04 01:35:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Soup</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>126131</dependson>
    
    <dependson>126291</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>psolanki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>962217</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-12-21 00:44:51 -0800</bug_when>
    <thetext>Clients using the async methods like willSendRequestAsync or didReceiveResponseAsync use a method to continue like continueWillSendRequest or continueDidReceiveResponse. We are not implementing those yet, even though nwe are calling the async methods. In the case of willSendRequest it&apos;s clear we need to implement continueWillSendRequest because the request might have changed, but in the other cases we still don&apos;t know whether they are required or not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963107</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-12-27 03:14:04 -0800</bug_when>
    <thetext>Found a use case where continueDidReceiveResponse is required, when the main resource load is converted into a download by the policy checker. Patch attached to bug #126131 implements continueDidReceiveResponse.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963495</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-12-31 01:35:37 -0800</bug_when>
    <thetext>continueWillSendRequest() is now implemented too, so I&apos;m renaming the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006421</commentid>
    <comment_count>3</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2014-05-03 17:19:36 -0700</bug_when>
    <thetext>My fix for bug 132308 (r168232) removed the continueShouldUseCredentialStorage() call. I think there&apos;s anything more to do in this bug now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006422</commentid>
    <comment_count>4</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2014-05-03 17:20:09 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; I think there&apos;s anything more to do in this bug now.

I mean.. I don&apos;t think there&apos;s anything more to do in this bug now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>