126106 2013-12-20 18:44:09 -0800 Arity check stack restoration should preserve the ArgumentCount in case there is a register restoration thunk below it 2014-01-30 13:27:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 113621 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 962166 0 fpizlo 2013-12-20 18:44:09 -0800 Return thunks rely on the argument count to recover where the stack should have been. In the case of the arity check fail thunk, it should "pay it forward" and allow whatever it returns into to also use the argument count. 962167 1 219826 fpizlo 2013-12-20 18:44:48 -0800 Created attachment 219826 the patch 962200 2 fpizlo 2013-12-20 20:54:36 -0800 Landed in http://trac.webkit.org/changeset/160956 968052 3 219826 ggaren 2014-01-14 14:44:45 -0800 Comment on attachment 219826 the patch r=me 219826 2013-12-20 18:44:48 -0800 2014-01-14 14:44:45 -0800 the patch blah.patch text/plain 3413 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwOTU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEyLTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QXJpdHkgY2hlY2sgc3RhY2sgcmVzdG9yYXRpb24gc2hvdWxkIHByZXNlcnZlIHRoZSBBcmd1bWVu dENvdW50IGluIGNhc2UgdGhlcmUgaXMgYSByZWdpc3RlciByZXN0b3JhdGlvbiB0aHVuayBiZWxv dyBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2 MTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmg6CisgICAgICAgIChKU0M6OlJldHVybkFk ZHJlc3NQdHI6OmR1bXApOgorICAgICAgICAqIGppdC9Bcml0eUNoZWNrRmFpbFJldHVyblRodW5r cy5jcHA6CisgICAgICAgIChKU0M6OkFyaXR5Q2hlY2tGYWlsUmV0dXJuVGh1bmtzOjpyZXR1cm5Q Q3NGb3IpOgorCiAyMDEzLTEyLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBDU3RhY2s6IGNhbGxUb0phdmFTY3JpcHQgc2hvdWxkIGRvIHN0YWNrIGNoZWNrIGZv ciBpbmNvbWluZyBhcmdzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckNvZGVSZWYuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCShyZXZpc2lvbiAxNjA5MzUpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNTQsNiArMjU0LDExIEBAIHB1YmxpYzoKICAgICB9CiAKICAg ICB2b2lkKiB2YWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmFsdWU7IH0KKyAgICAKKyAgICB2b2lk IGR1bXAoUHJpbnRTdHJlYW0mIG91dCkgY29uc3QKKyAgICB7CisgICAgICAgIG91dC5wcmludChS YXdQb2ludGVyKG1fdmFsdWUpKTsKKyAgICB9CiAKIHByaXZhdGU6CiAgICAgdm9pZCogbV92YWx1 ZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXJpdHlDaGVja0ZhaWxSZXR1cm5U aHVua3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXJpdHlD aGVja0ZhaWxSZXR1cm5UaHVua3MuY3BwCShyZXZpc2lvbiAxNjA5MzYpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0FyaXR5Q2hlY2tGYWlsUmV0dXJuVGh1bmtzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjgsOCArNjgsNiBAQCBDb2RlTG9jYXRpb25MYWJlbCogQXJpdHlDaGVja0ZhaWxS ZXR1cm5UCiAgICAgZm9yICh1bnNpZ25lZCBzaXplID0gbV9uZXh0U2l6ZTsgc2l6ZSA8PSBudW1F eHBlY3RlZEFyZ3VtZW50c0luY2x1ZGluZ1RoaXM7IHNpemUgKz0gc3RhY2tBbGlnbm1lbnRSZWdp c3RlcnMoKSkgewogICAgICAgICBsYWJlbHMuYXBwZW5kKGppdC5sYWJlbCgpKTsKICAgICAgICAg Ci0gICAgICAgIGppdC5uZWFyQ2FsbCgpOwotICAgICAgICBqaXQucG9wKEdQUkluZm86OnJlZ1Qy KTsKICAgICAgICAgaml0LmxvYWQzMigKICAgICAgICAgICAgIEFzc2VtYmx5SGVscGVyczo6QWRk cmVzcygKICAgICAgICAgICAgICAgICBBc3NlbWJseUhlbHBlcnM6OnN0YWNrUG9pbnRlclJlZ2lz dGVyLApAQCAtNzksMTYgKzc3LDI1IEBAIENvZGVMb2NhdGlvbkxhYmVsKiBBcml0eUNoZWNrRmFp bFJldHVyblQKICAgICAgICAgaml0LmFkZDMyKAogICAgICAgICAgICAgQXNzZW1ibHlIZWxwZXJz OjpUcnVzdGVkSW1tMzIoCiAgICAgICAgICAgICAgICAgSlNTdGFjazo6Q2FsbEZyYW1lSGVhZGVy U2l6ZSAtIEpTU3RhY2s6OkNhbGxlckZyYW1lQW5kUENTaXplICsgc2l6ZSAtIDEpLAotICAgICAg ICAgICAgR1BSSW5mbzo6cmVnVDEpOwotICAgICAgICBqaXQubHNoaWZ0MzIoQXNzZW1ibHlIZWxw ZXJzOjpUcnVzdGVkSW1tMzIoMyksIEdQUkluZm86OnJlZ1QxKTsKLSAgICAgICAgaml0LmFkZFB0 cihBc3NlbWJseUhlbHBlcnM6OnN0YWNrUG9pbnRlclJlZ2lzdGVyLCBHUFJJbmZvOjpyZWdUMSk7 Ci0gICAgICAgIGppdC5sb2FkUHRyKEdQUkluZm86OnJlZ1QxLCBHUFJJbmZvOjpyZWdUMSk7Cisg ICAgICAgICAgICBHUFJJbmZvOjpyZWdUMSwgR1BSSW5mbzo6cmVnVDIpOworICAgICAgICBqaXQu bHNoaWZ0MzIoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tMzIoMyksIEdQUkluZm86OnJlZ1Qy KTsKKyAgICAgICAgaml0LmFkZFB0cihBc3NlbWJseUhlbHBlcnM6OnN0YWNrUG9pbnRlclJlZ2lz dGVyLCBHUFJJbmZvOjpyZWdUMik7CisgICAgICAgIGppdC5sb2FkUHRyKEdQUkluZm86OnJlZ1Qy LCBHUFJJbmZvOjpyZWdUMik7CiAgICAgICAgIAogICAgICAgICBqaXQuYWRkUHRyKAogICAgICAg ICAgICAgQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tMzIoc2l6ZSAqIHNpemVvZihSZWdpc3Rl cikpLAogICAgICAgICAgICAgQXNzZW1ibHlIZWxwZXJzOjpzdGFja1BvaW50ZXJSZWdpc3Rlcik7 CiAgICAgICAgIAotICAgICAgICBqaXQuanVtcChHUFJJbmZvOjpyZWdUMSk7CisgICAgICAgIC8v IFRodW5rcyBsaWtlIG91cnMgd2FudCB0byB1c2UgdGhlIHJldHVybiBQQyB0byBmaWd1cmUgb3V0 IHdoZXJlIHRoaW5ncworICAgICAgICAvLyB3ZXJlIHNhdmVkLiBTbywgd2UgcGF5IGl0IGZvcndh cmQuCisgICAgICAgIGppdC5zdG9yZTMyKAorICAgICAgICAgICAgR1BSSW5mbzo6cmVnVDEsCisg ICAgICAgICAgICBBc3NlbWJseUhlbHBlcnM6OkFkZHJlc3MoCisgICAgICAgICAgICAgICAgQXNz ZW1ibHlIZWxwZXJzOjpzdGFja1BvaW50ZXJSZWdpc3RlciwKKyAgICAgICAgICAgICAgICAoSlNT dGFjazo6QXJndW1lbnRDb3VudCAtIEpTU3RhY2s6OkNhbGxlckZyYW1lQW5kUENTaXplKSAqIHNp emVvZihSZWdpc3RlcikgKworICAgICAgICAgICAgICAgIFBheWxvYWRPZmZzZXQpKTsKKyAgICAg ICAgCisgICAgICAgIGppdC5qdW1wKEdQUkluZm86OnJlZ1QyKTsKICAgICB9CiAgICAgCiAgICAg TGlua0J1ZmZlciBsaW5rQnVmZmVyKHZtLCAmaml0LCBHTE9CQUxfVEhVTktfSUQpOwo=