126103 2013-12-20 18:22:58 -0800 StyleResolver::pseudoStyleForElement don't call initElement(0) before return and cause anchor element in a incorrect visited status 2013-12-20 18:32:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All NEW P4 Minor --- 1 xxhforest webkit-unassigned oldest_to_newest 962153 0 xxhforest 2013-12-20 18:22:58 -0800 1, Summary this may cause EInsideLink status of RenderStyle generated by StyleResolver::styleForElement be incorrect 2, Simple Example <head> <style> a:after { content:"" } </style> </head> <body> <a id="test" href="#test" style="overflow:hidden"> click me </a> 3, Steps 1) open the above simple example in a mobile browser 2) click the anchor element in the above example 4, Issue the anchor element will not be marked as visited 5, Conclusion At first, WebCore recieve a touch event, and StyleResolver::pseudoStyleForElement was triggered. Before pseudoStyleForElement return, initElement(0) is not called, so the anchor element is cached in StyleResolver Then, WebCore receive a mouse click event, so it is added to visited link list in PageGroup, and its RenderStyle is recalculate. StyleResolver::styleForElement is call to give the RenderStyle, but initElement(element) will do nothing, because the element is cached. so the anchor element's visited status will not be detected, and m_elementLinkState will not be set to InsideVisitedLink. finially the anchor element will not be marked as visited 6, Expect call initElement(0) before StyleResolver::pseudoStyleForElement return to clear cache to element 962155 1 219823 xxhforest 2013-12-20 18:26:59 -0800 Created attachment 219823 add a test html file containing the post example 219823 2013-12-20 18:26:59 -0800 2013-12-20 18:26:59 -0800 add a test html file containing the post example test.html text/html 148 xxhforest 77u/PGhlYWQ+CiAgICA8c3R5bGU+CiAgICAgICAgYTphZnRlciB7CiAgICAgICAgICAgIGNvbnRl bnQ6IiIKICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5Pgo8YSBpZD0idGVzdCIg aHJlZj0iI3Rlc3QiPgogICAgaGVsbG8gd29yZAo8L2E+Cg==