126095 2013-12-20 16:46:19 -0800 REGRESSION(r160941): Doesn't handle subpixel layout being disabled (Requested by smfr on #webkit). 2013-12-20 18:12:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126080 1 commit-queue commit-queue andersca bjonesbe oldest_to_newest 962109 0 commit-queue 2013-12-20 16:46:19 -0800 http://trac.webkit.org/changeset/160941 broke the build: Doesn't handle subpixel layout being disabled (Requested by smfr on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 962111 1 219811 commit-queue 2013-12-20 16:46:31 -0800 Created attachment 219811 ROLLOUT of r160941 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 962146 2 219811 commit-queue 2013-12-20 18:11:59 -0800 Comment on attachment 219811 ROLLOUT of r160941 Clearing flags on attachment: 219811 Committed r160953: <http://trac.webkit.org/changeset/160953> 962147 3 commit-queue 2013-12-20 18:12:00 -0800 All reviewed patches have been landed. Closing bug. 219811 2013-12-20 16:46:31 -0800 2013-12-20 18:11:59 -0800 ROLLOUT of r160941 bug-126095-20131220164631.patch text/plain 6049 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwOTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjg2Zjg1YjNkZTBhOTY2OTRhNjg4ODhhNjMyNzY5ZDNi ODRmMmYxMC4uNmNiZjA1MzI1Zjc3ZTRmOTBlODg3OWUwNjJiMTFhYjk2YzQxZDkyNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTEyLTIwICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYwOTQxLgorICAgICAgICBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNjA5NDEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjA5NQorCisgICAgICAgIERvZXNuJ3QgaGFu ZGxlIHN1YnBpeGVsIGxheW91dCBiZWluZyBkaXNhYmxlZCAoUmVxdWVzdGVkIGJ5CisgICAgICAg IHNtZnIgb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBnZGIvd2Via2l0LnB5OgorICAgICAgICAo SlNDSlNTdHJpbmdQcmludGVyLnRvX3N0cmluZyk6CisgICAgICAgIChhZGRfcHJldHR5X3ByaW50 ZXJzKToKKyAgICAgICAgKiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoV1RGTWVkaWFU aW1lX1N1bW1hcnlQcm92aWRlcik6CisgICAgICAgIChXVEZTdHJpbmdQcm92aWRlci50b19zdHJp bmcpOgorCiAyMDEzLTEyLTIwICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgog CiAgICAgICAgIFByZXR0eSBwcmludCBMYXlvdXRVbml0LCBMYXlvdXRQb2ludCwgYW5kIExheW91 dFNpemUgaW4gZ2RiIGFuZCBsbGRiCmRpZmYgLS1naXQgYS9Ub29scy9nZGIvd2Via2l0LnB5IGIv VG9vbHMvZ2RiL3dlYmtpdC5weQppbmRleCAwNDI1MGQ3N2Y0YjU4MzhmN2U2YWNhMGNlYzc4ZjUw Mjk3MjhjMmJlLi4yYTBjYjkyZWUyYTQ3MmIxZTUxNjVjNzYwOTdiMmNhOWJlNGM4MDAwIDEwMDY0 NAotLS0gYS9Ub29scy9nZGIvd2Via2l0LnB5CisrKyBiL1Rvb2xzL2dkYi93ZWJraXQucHkKQEAg LTE2NiwzMyArMTY2LDYgQEAgY2xhc3MgSlNDSlNTdHJpbmdQcmludGVyKFN0cmluZ1ByaW50ZXIp OgogICAgICAgICByZXR1cm4gV1RGU3RyaW5nUHJpbnRlcihzZWxmLnZhbFsnbV92YWx1ZSddKS50 b19zdHJpbmcoKQogCiAKLWNsYXNzIFdlYkNvcmVMYXlvdXRVbml0UHJpbnRlcjoKLSAgICAiUHJp bnQgYSBXZWJDb3JlOjpMYXlvdXRVbml0IgotICAgIGRlZiBfX2luaXRfXyhzZWxmLCB2YWwpOgot ICAgICAgICBzZWxmLnZhbCA9IHZhbAotCi0gICAgZGVmIHRvX3N0cmluZyhzZWxmKToKLSAgICAg ICAgcmV0dXJuICIlZ3B4IiAlIChzZWxmLnZhbFsnbV92YWx1ZSddIC8gNjQuMCkKLQotCi1jbGFz cyBXZWJDb3JlTGF5b3V0U2l6ZVByaW50ZXI6Ci0gICAgIlByaW50IGEgV2ViQ29yZTo6TGF5b3V0 U2l6ZSIKLSAgICBkZWYgX19pbml0X18oc2VsZiwgdmFsKToKLSAgICAgICAgc2VsZi52YWwgPSB2 YWwKLQotICAgIGRlZiB0b19zdHJpbmcoc2VsZik6Ci0gICAgICAgIHJldHVybiAnTGF5b3V0U2l6 ZSglcywgJXMpJyAlIChXZWJDb3JlTGF5b3V0VW5pdFByaW50ZXIoc2VsZi52YWxbJ21fd2lkdGgn XSkudG9fc3RyaW5nKCksIFdlYkNvcmVMYXlvdXRVbml0UHJpbnRlcihzZWxmLnZhbFsnbV9oZWln aHQnXSkudG9fc3RyaW5nKCkpCi0KLQotY2xhc3MgV2ViQ29yZUxheW91dFBvaW50UHJpbnRlcjoK LSAgICAiUHJpbnQgYSBXZWJDb3JlOjpMYXlvdXRQb2ludCIKLSAgICBkZWYgX19pbml0X18oc2Vs ZiwgdmFsKToKLSAgICAgICAgc2VsZi52YWwgPSB2YWwKLQotICAgIGRlZiB0b19zdHJpbmcoc2Vs Zik6Ci0gICAgICAgIHJldHVybiAnTGF5b3V0UG9pbnQoJXMsICVzKScgJSAoV2ViQ29yZUxheW91 dFVuaXRQcmludGVyKHNlbGYudmFsWydtX3gnXSkudG9fc3RyaW5nKCksIFdlYkNvcmVMYXlvdXRV bml0UHJpbnRlcihzZWxmLnZhbFsnbV95J10pLnRvX3N0cmluZygpKQotCi0KIGNsYXNzIFdlYkNv cmVRdWFsaWZpZWROYW1lUHJpbnRlcihTdHJpbmdQcmludGVyKToKICAgICAiUHJpbnQgYSBXZWJD b3JlOjpRdWFsaWZpZWROYW1lIgogCkBAIC0yOTgsOSArMjcxLDYgQEAgZGVmIGFkZF9wcmV0dHlf cHJpbnRlcnMoKToKICAgICAgICAgKHJlLmNvbXBpbGUoIl5XVEY6OkNTdHJpbmckIiksIFdURkNT dHJpbmdQcmludGVyKSwKICAgICAgICAgKHJlLmNvbXBpbGUoIl5XVEY6OlN0cmluZyQiKSwgV1RG U3RyaW5nUHJpbnRlciksCiAgICAgICAgIChyZS5jb21waWxlKCJeV1RGOjpTdHJpbmdJbXBsJCIp LCBXVEZTdHJpbmdJbXBsUHJpbnRlciksCi0gICAgICAgIChyZS5jb21waWxlKCJeV2ViQ29yZTo6 TGF5b3V0VW5pdCQiKSwgV2ViQ29yZUxheW91dFVuaXRQcmludGVyKSwKLSAgICAgICAgKHJlLmNv bXBpbGUoIl5XZWJDb3JlOjpMYXlvdXRQb2ludCQiKSwgV2ViQ29yZUxheW91dFBvaW50UHJpbnRl ciksCi0gICAgICAgIChyZS5jb21waWxlKCJeV2ViQ29yZTo6TGF5b3V0U2l6ZSQiKSwgV2ViQ29y ZUxheW91dFNpemVQcmludGVyKSwKICAgICAgICAgKHJlLmNvbXBpbGUoIl5XZWJDb3JlOjpRdWFs aWZpZWROYW1lJCIpLCBXZWJDb3JlUXVhbGlmaWVkTmFtZVByaW50ZXIpLAogICAgICAgICAocmUu Y29tcGlsZSgiXkpTQzo6SWRlbnRpZmllciQiKSwgSlNDSWRlbnRpZmllclByaW50ZXIpLAogICAg ICAgICAocmUuY29tcGlsZSgiXkpTQzo6SlNTdHJpbmckIiksIEpTQ0pTU3RyaW5nUHJpbnRlciks CmRpZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMvbGxkYi9sbGRi X3dlYmtpdC5weQppbmRleCBhMzgyNjEwMmFiNWFlZjg3Y2NhNzc0NzdjYWVkZDFiYTQ4ZWZjN2Ex Li4wNzQ1YzVmZjkzNzc5ZTBkMjc5ZTc0OGNkOTU5MzQ5ZmQ5ZmU5MzFjIDEwMDY0NAotLS0gYS9U b29scy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkK QEAgLTQxLDkgKzQxLDYgQEAgZGVmIF9fbGxkYl9pbml0X21vZHVsZShkZWJ1Z2dlciwgZGljdCk6 CiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFuZCgndHlwZSBzdW1tYXJ5IGFkZCAtLWV4cGFuZCAt RiBsbGRiX3dlYmtpdC5XVEZNZWRpYVRpbWVfU3VtbWFyeVByb3ZpZGVyIFdURjo6TWVkaWFUaW1l JykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN5bnRoZXRpYyBhZGQgLXggIldU Rjo6VmVjdG9yPC4rPiQiIC0tcHl0aG9uLWNsYXNzIGxsZGJfd2Via2l0LldURlZlY3RvclByb3Zp ZGVyJykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN5bnRoZXRpYyBhZGQgLXgg IldURjo6SGFzaFRhYmxlPC4rPiQiIC0tcHl0aG9uLWNsYXNzIGxsZGJfd2Via2l0LldURkhhc2hU YWJsZVByb3ZpZGVyJykKLSAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1hcnkg YWRkIC1GIGxsZGJfd2Via2l0LldlYkNvcmVMYXlvdXRVbml0X1N1bW1hcnlQcm92aWRlciBXZWJD b3JlOjpMYXlvdXRVbml0JykKLSAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1h cnkgYWRkIC1GIGxsZGJfd2Via2l0LldlYkNvcmVMYXlvdXRTaXplX1N1bW1hcnlQcm92aWRlciBX ZWJDb3JlOjpMYXlvdXRTaXplJykKLSAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1 bW1hcnkgYWRkIC1GIGxsZGJfd2Via2l0LldlYkNvcmVMYXlvdXRQb2ludF9TdW1tYXJ5UHJvdmlk ZXIgV2ViQ29yZTo6TGF5b3V0UG9pbnQnKQogCiBkZWYgV1RGU3RyaW5nX1N1bW1hcnlQcm92aWRl cih2YWxvYmosIGRpY3QpOgogICAgIHByb3ZpZGVyID0gV1RGU3RyaW5nUHJvdmlkZXIodmFsb2Jq LCBkaWN0KQpAQCAtODIsMjAgKzc5LDYgQEAgZGVmIFdURk1lZGlhVGltZV9TdW1tYXJ5UHJvdmlk ZXIodmFsb2JqLCBkaWN0KToKICAgICByZXR1cm4gInsgJWQvJWQsICVmIH0iICUgKHByb3ZpZGVy LnRpbWVWYWx1ZSgpLCBwcm92aWRlci50aW1lU2NhbGUoKSwgZmxvYXQocHJvdmlkZXIudGltZVZh bHVlKCkpIC8gcHJvdmlkZXIudGltZVNjYWxlKCkpCiAKIAotZGVmIFdlYkNvcmVMYXlvdXRVbml0 X1N1bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgotICAgIHByb3ZpZGVyID0gV2ViQ29yZUxh eW91dFVuaXRQcm92aWRlcih2YWxvYmosIGRpY3QpCi0gICAgcmV0dXJuICJ7ICVzIH0iICUgcHJv dmlkZXIudG9fc3RyaW5nKCkKLQotCi1kZWYgV2ViQ29yZUxheW91dFNpemVfU3VtbWFyeVByb3Zp ZGVyKHZhbG9iaiwgZGljdCk6Ci0gICAgcHJvdmlkZXIgPSBXZWJDb3JlTGF5b3V0U2l6ZVByb3Zp ZGVyKHZhbG9iaiwgZGljdCkKLSAgICByZXR1cm4gInsgd2lkdGggPSAlcywgaGVpZ2h0ID0gJXMg fSIgJSAocHJvdmlkZXIuZ2V0X3dpZHRoKCksIHByb3ZpZGVyLmdldF9oZWlnaHQoKSkKLQotCi1k ZWYgV2ViQ29yZUxheW91dFBvaW50X1N1bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgotICAg IHByb3ZpZGVyID0gV2ViQ29yZUxheW91dFBvaW50UHJvdmlkZXIodmFsb2JqLCBkaWN0KQotICAg IHJldHVybiAieyB4ID0gJXMsIHkgPSAlcyB9IiAlIChwcm92aWRlci5nZXRfeCgpLCBwcm92aWRl ci5nZXRfeSgpKQotCiAjIEZJWE1FOiBQcm92aWRlIHN1cHBvcnQgZm9yIHRoZSBmb2xsb3dpbmcg dHlwZXM6CiAjIGRlZiBXVEZWZWN0b3JfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6CiAj IGRlZiBXVEZDU3RyaW5nX1N1bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgpAQCAtMjAxLDM5 ICsxODQsNiBAQCBjbGFzcyBXVEZTdHJpbmdQcm92aWRlcjoKICAgICAgICAgcmV0dXJuIGltcGwu dG9fc3RyaW5nKCkKIAogCi1jbGFzcyBXZWJDb3JlTGF5b3V0VW5pdFByb3ZpZGVyOgotICAgICJQ cmludCBhIFdlYkNvcmU6OkxheW91dFVuaXQiCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsIHZhbG9i aiwgZGljdCk6Ci0gICAgICAgIHNlbGYudmFsb2JqID0gdmFsb2JqCi0KLSAgICBkZWYgdG9fc3Ry aW5nKHNlbGYpOgotICAgICAgICByZXR1cm4gIiVncHgiICUgKHNlbGYudmFsb2JqLkdldENoaWxk TWVtYmVyV2l0aE5hbWUoJ21fdmFsdWUnKS5HZXRWYWx1ZUFzVW5zaWduZWQoMCkgLyA2NC4wKQot Ci0KLWNsYXNzIFdlYkNvcmVMYXlvdXRTaXplUHJvdmlkZXI6Ci0gICAgIlByaW50IGEgV2ViQ29y ZTo6TGF5b3V0U2l6ZSIKLSAgICBkZWYgX19pbml0X18oc2VsZiwgdmFsb2JqLCBkaWN0KToKLSAg ICAgICAgc2VsZi52YWxvYmogPSB2YWxvYmoKLQotICAgIGRlZiBnZXRfd2lkdGgoc2VsZik6Ci0g ICAgICAgIHJldHVybiBXZWJDb3JlTGF5b3V0VW5pdFByb3ZpZGVyKHNlbGYudmFsb2JqLkdldENo aWxkTWVtYmVyV2l0aE5hbWUoJ21fd2lkdGgnKSwgZGljdCkudG9fc3RyaW5nKCkKLQotICAgIGRl ZiBnZXRfaGVpZ2h0KHNlbGYpOgotICAgICAgICByZXR1cm4gV2ViQ29yZUxheW91dFVuaXRQcm92 aWRlcihzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2hlaWdodCcpLCBkaWN0 KS50b19zdHJpbmcoKQotCi0KLWNsYXNzIFdlYkNvcmVMYXlvdXRQb2ludFByb3ZpZGVyOgotICAg ICJQcmludCBhIFdlYkNvcmU6OkxheW91dFBvaW50IgotICAgIGRlZiBfX2luaXRfXyhzZWxmLCB2 YWxvYmosIGRpY3QpOgotICAgICAgICBzZWxmLnZhbG9iaiA9IHZhbG9iagotCi0gICAgZGVmIGdl dF94KHNlbGYpOgotICAgICAgICByZXR1cm4gV2ViQ29yZUxheW91dFVuaXRQcm92aWRlcihzZWxm LnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX3gnKSwgZGljdCkudG9fc3RyaW5nKCkK LQotICAgIGRlZiBnZXRfeShzZWxmKToKLSAgICAgICAgcmV0dXJuIFdlYkNvcmVMYXlvdXRVbml0 UHJvdmlkZXIoc2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV95JyksIGRpY3Qp LnRvX3N0cmluZygpCi0KLQogY2xhc3MgV1RGVmVjdG9yUHJvdmlkZXI6CiAgICAgZGVmIF9faW5p dF9fKHNlbGYsIHZhbG9iaiwgaW50ZXJuYWxfZGljdCk6CiAgICAgICAgIHNlbGYudmFsb2JqID0g dmFsb2JqCg==