126090 2013-12-20 15:55:28 -0800 PostAttachCallbackDisabler should take a Document 2013-12-20 17:19:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca cmarcelo commit-queue esprehn+autocc kangil.han oldest_to_newest 962089 0 andersca 2013-12-20 15:55:28 -0800 PostAttachCallbackDisabler should take a Document 962091 1 219806 andersca 2013-12-20 15:58:30 -0800 Created attachment 219806 Patch 962097 2 219806 kling 2013-12-20 16:06:19 -0800 Comment on attachment 219806 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219806&action=review Nice move. r=me. > Source/WebCore/dom/Element.h:811 > + PostAttachCallbackDisabler(Document& document) explicit? 962125 3 andersca 2013-12-20 17:19:44 -0800 Committed r160942: <http://trac.webkit.org/changeset/160942> 219806 2013-12-20 15:58:30 -0800 2013-12-20 16:06:19 -0800 Patch bug-126090-20131220155829.patch text/plain 5854 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwOTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk3ODUxZmNjNDg3N2Uz NTQxMGI5OWI3MTE0MTY2ZWU2ZGIwMWY3MS4uNDgyMmY4MWFkOTJkM2IxOTYwZjVmNDY1NWVkMDA0 ZWZhMzliZmQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEzLTEyLTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUG9zdEF0dGFjaENh bGxiYWNrRGlzYWJsZXIgc2hvdWxkIHRha2UgYSBEb2N1bWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDkwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc3VzcGVuZFBvc3RBdHRhY2hDYWxsYmFja3Mg YW5kIHJlc3VtZVBvc3RBdHRhY2hDYWxsYmFja3MgYWx3YXlzIG9ubHkgZ2V0IHRoZSBkb2N1bWVu dCBmcm9tIHRoZQorICAgICAgICBjb250YWluZXIgbm9kZSwgc28gbWFrZSB0aGVtIHN0YXRpYyBt ZW1iZXIgZnVuY3Rpb25zIHRoYXQgdGFrZSBhIERvY3VtZW50Ji4gQWxzbywgbW92ZSBQb3N0QXR0 YWNoQ2FsbGJhY2tEaXNhYmxlcgorICAgICAgICB0byBFbGVtZW50LmggaW4gcHJlcGFyYXRpb24g Zm9yIG1vdmluZyBwb3N0IGF0dGFjaCBjYWxsYmFjayBoYW5kbGluZyB0byBFbGVtZW50LgorCisg ICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFp bmVyTm9kZTo6c3VzcGVuZFBvc3RBdHRhY2hDYWxsYmFja3MpOgorICAgICAgICAoV2ViQ29yZTo6 Q29udGFpbmVyTm9kZTo6cmVzdW1lUG9zdEF0dGFjaENhbGxiYWNrcyk6CisgICAgICAgICogZG9t L0NvbnRhaW5lck5vZGUuaDoKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoV2Vi Q29yZTo6UG9zdEF0dGFjaENhbGxiYWNrRGlzYWJsZXI6OlBvc3RBdHRhY2hDYWxsYmFja0Rpc2Fi bGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlBvc3RBdHRhY2hDYWxsYmFja0Rpc2FibGVyOjp+UG9z dEF0dGFjaENhbGxiYWNrRGlzYWJsZXIpOgorICAgICAgICAqIHN0eWxlL1N0eWxlUmVzb2x2ZVRy ZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OmF0dGFjaFJlbmRlclRyZWUpOgorCisy MDEzLTEyLTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAg ICAgTW92ZSBzY2hlZHVsZVNldE5lZWRzU3R5bGVSZWNhbGMgdG8gSFRNTEZyYW1lT3duZXJFbGVt ZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYw ODMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCmluZGV4IDcwNDJjYTUyNjYwMTIy YTg4ZjNhOThmYmU1MWZkOTExZTA5NjIyOTguLjVlMTQ4ODJjYTNmMjkzYmFkNTc3ZmE1OGQyMTgx NzFkNjYwN2FhYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2Rl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKQEAgLTc2Mywx MSArNzYzLDExIEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cGFyc2VyQXBwZW5kQ2hpbGQoUGFzc1Jl ZlB0cjxOb2RlPiBuZXdDaGlsZCkKICAgICBuZXdDaGlsZC0+c2V0TmVlZHNTdHlsZVJlY2FsYyhS ZWNvbnN0cnVjdFJlbmRlclRyZWUpOwogfQogCi12b2lkIENvbnRhaW5lck5vZGU6OnN1c3BlbmRQ b3N0QXR0YWNoQ2FsbGJhY2tzKCkKK3ZvaWQgQ29udGFpbmVyTm9kZTo6c3VzcGVuZFBvc3RBdHRh Y2hDYWxsYmFja3MoRG9jdW1lbnQmIGRvY3VtZW50KQogewogICAgIGlmICghc19hdHRhY2hEZXB0 aCkgewogICAgICAgICBBU1NFUlQoIXNfc2hvdWxkUmVFbmFibGVNZW1vcnlDYWNoZUNhbGxzQWZ0 ZXJBdHRhY2gpOwotICAgICAgICBpZiAoUGFnZSogcGFnZSA9IGRvY3VtZW50KCkucGFnZSgpKSB7 CisgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZG9jdW1lbnQucGFnZSgpKSB7CiAgICAgICAgICAg ICAvLyBGSVhNRTogSG93IGNhbiB0aGlzIGNhbGwgYmUgc3BlY2lmaWMgdG8gb25lIFBhZ2UsIHdo aWxlIHRoZQogICAgICAgICAgICAgLy8gc19hdHRhY2hEZXB0aCBpcyBhIGdsb2JhbD8gRG9lc24n dCBtYWtlIHNlbnNlLgogICAgICAgICAgICAgaWYgKHBhZ2UtPmFyZU1lbW9yeUNhY2hlQ2xpZW50 Q2FsbHNFbmFibGVkKCkpIHsKQEAgLTc4MCwxNiArNzgwLDE2IEBAIHZvaWQgQ29udGFpbmVyTm9k ZTo6c3VzcGVuZFBvc3RBdHRhY2hDYWxsYmFja3MoKQogICAgICsrc19hdHRhY2hEZXB0aDsKIH0K IAotdm9pZCBDb250YWluZXJOb2RlOjpyZXN1bWVQb3N0QXR0YWNoQ2FsbGJhY2tzKCkKK3ZvaWQg Q29udGFpbmVyTm9kZTo6cmVzdW1lUG9zdEF0dGFjaENhbGxiYWNrcyhEb2N1bWVudCYgZG9jdW1l bnQpCiB7CiAgICAgaWYgKHNfYXR0YWNoRGVwdGggPT0gMSkgewotICAgICAgICBSZWY8Q29udGFp bmVyTm9kZT4gcHJvdGVjdCgqdGhpcyk7CisgICAgICAgIFJlZjxEb2N1bWVudD4gcHJvdGVjdChk b2N1bWVudCk7CiAKICAgICAgICAgaWYgKHNfcG9zdEF0dGFjaENhbGxiYWNrUXVldWUpCiAgICAg ICAgICAgICBkaXNwYXRjaFBvc3RBdHRhY2hDYWxsYmFja3MoKTsKICAgICAgICAgaWYgKHNfc2hv dWxkUmVFbmFibGVNZW1vcnlDYWNoZUNhbGxzQWZ0ZXJBdHRhY2gpIHsKICAgICAgICAgICAgIHNf c2hvdWxkUmVFbmFibGVNZW1vcnlDYWNoZUNhbGxzQWZ0ZXJBdHRhY2ggPSBmYWxzZTsKLSAgICAg ICAgICAgIGlmIChQYWdlKiBwYWdlID0gZG9jdW1lbnQoKS5wYWdlKCkpCisgICAgICAgICAgICBp ZiAoUGFnZSogcGFnZSA9IGRvY3VtZW50LnBhZ2UoKSkKICAgICAgICAgICAgICAgICBwYWdlLT5z ZXRNZW1vcnlDYWNoZUNsaWVudENhbGxzRW5hYmxlZCh0cnVlKTsKICAgICAgICAgfQogICAgICAg ICBwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+bG9hZGVyU3RyYXRlZ3koKS0+cmVzb3VyY2VMb2FkU2No ZWR1bGVyKCktPnJlc3VtZVBlbmRpbmdSZXF1ZXN0cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJO b2RlLmgKaW5kZXggYjcyMTQ2NTBkZmFmM2ExYjU0NGZjMzM5NmI5MGQ0YjY2ZWYzZmI3ZS4uMmQ2 M2MzOGUyNWE2MGFhMmFlZGMyNWI5MDk3ZjFiZDE2NDIyOGU2YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29u dGFpbmVyTm9kZS5oCkBAIC0xNTgsOCArMTU4LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIGluc2Vy dEJlZm9yZUNvbW1vbihOb2RlJiBuZXh0Q2hpbGQsIE5vZGUmIG9sZENoaWxkKTsKIAogICAgIHN0 YXRpYyB2b2lkIGRpc3BhdGNoUG9zdEF0dGFjaENhbGxiYWNrcygpOwotICAgIHZvaWQgc3VzcGVu ZFBvc3RBdHRhY2hDYWxsYmFja3MoKTsKLSAgICB2b2lkIHJlc3VtZVBvc3RBdHRhY2hDYWxsYmFj a3MoKTsKKyAgICBzdGF0aWMgdm9pZCBzdXNwZW5kUG9zdEF0dGFjaENhbGxiYWNrcyhEb2N1bWVu dCYpOworICAgIHN0YXRpYyB2b2lkIHJlc3VtZVBvc3RBdHRhY2hDYWxsYmFja3MoRG9jdW1lbnQm KTsKIAogICAgIGJvb2wgZ2V0VXBwZXJMZWZ0Q29ybmVyKEZsb2F0UG9pbnQmKSBjb25zdDsKICAg ICBib29sIGdldExvd2VyUmlnaHRDb3JuZXIoRmxvYXRQb2ludCYpIGNvbnN0OwpAQCAtMzE1LDIz ICszMTUsNiBAQCBwcml2YXRlOgogICAgIENoaWxkTm9kZXNMYXp5U25hcHNob3QqIG1fbmV4dFNu YXBzaG90OwogfTsKIAotY2xhc3MgUG9zdEF0dGFjaENhbGxiYWNrRGlzYWJsZXIgewotcHVibGlj OgotICAgIFBvc3RBdHRhY2hDYWxsYmFja0Rpc2FibGVyKENvbnRhaW5lck5vZGUmIG5vZGUpCi0g ICAgICAgIDogbV9ub2RlKG5vZGUpCi0gICAgewotICAgICAgICBtX25vZGUuc3VzcGVuZFBvc3RB dHRhY2hDYWxsYmFja3MoKTsKLSAgICB9Ci0KLSAgICB+UG9zdEF0dGFjaENhbGxiYWNrRGlzYWJs ZXIoKQotICAgIHsKLSAgICAgICAgbV9ub2RlLnJlc3VtZVBvc3RBdHRhY2hDYWxsYmFja3MoKTsK LSAgICB9Ci0KLXByaXZhdGU6Ci0gICAgQ29udGFpbmVyTm9kZSYgbV9ub2RlOwotfTsKLQogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gQ29udGFpbmVyTm9kZV9oCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuaAppbmRleCBlYTI2YTVjZjdiMGZiZWM5NWQ5YWMxZmZiOGYyZTk4YjNlMDcwNjU0Li5k MjEyNTM3ODdkZjkzYWJjNTgzMDRlOTE3N2NlNmEzYzU2ODNjYjlkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmgKQEAgLTgwNiw2ICs4MDYsMjMgQEAgaW5saW5lIFVuaXF1ZUVsZW1lbnREYXRhJiBFbGVtZW50 OjplbnN1cmVVbmlxdWVFbGVtZW50RGF0YSgpCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFVuaXF1 ZUVsZW1lbnREYXRhJj4oKm1fZWxlbWVudERhdGEpOwogfQogCi19IC8vIG5hbWVzcGFjZQorY2xh c3MgUG9zdEF0dGFjaENhbGxiYWNrRGlzYWJsZXIgeworcHVibGljOgorICAgIFBvc3RBdHRhY2hD YWxsYmFja0Rpc2FibGVyKERvY3VtZW50JiBkb2N1bWVudCkKKyAgICAgICAgOiBtX2RvY3VtZW50 KGRvY3VtZW50KQorICAgIHsKKyAgICAgICAgRWxlbWVudDo6c3VzcGVuZFBvc3RBdHRhY2hDYWxs YmFja3MobV9kb2N1bWVudCk7CisgICAgfQorCisgICAgflBvc3RBdHRhY2hDYWxsYmFja0Rpc2Fi bGVyKCkKKyAgICB7CisgICAgICAgIEVsZW1lbnQ6OnJlc3VtZVBvc3RBdHRhY2hDYWxsYmFja3Mo bV9kb2N1bWVudCk7CisgICAgfQorCitwcml2YXRlOgorICAgIERvY3VtZW50JiBtX2RvY3VtZW50 OworfTsKKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUv c3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKaW5kZXggYTNkNTllNzhkZTUyNjUxNGEyNTM2NDM0 NTY4ODVkNDdiY2QyOGMwOC4uNzA5NGI5MWZmNWQyMGQ2ODdmZmQ2MmVlYzQxZTkzZTFiNTcyZjFk YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKQEAgLTUxNSw3 ICs1MTUsNyBAQCBzdGF0aWMgdm9pZCBhdHRhY2hCZWZvcmVPckFmdGVyUHNldWRvRWxlbWVudElm TmVlZGVkKEVsZW1lbnQmIGN1cnJlbnQsIFBzZXVkb0lkCiAKIHN0YXRpYyB2b2lkIGF0dGFjaFJl bmRlclRyZWUoRWxlbWVudCYgY3VycmVudCwgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gcmVzb2x2 ZWRTdHlsZSkKIHsKLSAgICBQb3N0QXR0YWNoQ2FsbGJhY2tEaXNhYmxlciBjYWxsYmFja0Rpc2Fi bGVyKGN1cnJlbnQpOworICAgIFBvc3RBdHRhY2hDYWxsYmFja0Rpc2FibGVyIGNhbGxiYWNrRGlz YWJsZXIoY3VycmVudC5kb2N1bWVudCgpKTsKICAgICBXaWRnZXRIaWVyYXJjaHlVcGRhdGVzU3Vz cGVuc2lvblNjb3BlIHN1c3BlbmRXaWRnZXRIaWVyYXJjaHlVcGRhdGVzOwogCiAgICAgaWYgKGN1 cnJlbnQuaGFzQ3VzdG9tU3R5bGVSZXNvbHZlQ2FsbGJhY2tzKCkpCg==