126084 2013-12-20 14:26:19 -0800 CStack Branch: CodeBlocks aren't being marked by garbage collector 2013-12-20 15:01:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 962053 0 msaboff 2013-12-20 14:26:19 -0800 CodeBlocks are not being properly marked in Heap::markRoots(). 962059 1 219796 msaboff 2013-12-20 14:33:38 -0800 Created attachment 219796 Patch with right defect referenced in ChangeLog 962064 2 msaboff 2013-12-20 15:01:09 -0800 Committed r160931: <http://trac.webkit.org/changeset/160931> 219796 2013-12-20 14:33:38 -0800 2013-12-20 14:35:15 -0800 Patch with right defect referenced in ChangeLog 126084.patch text/plain 7430 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwOTI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTEyLTIwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IENvZGVCbG9ja3MgYXJlbid0IGJlaW5nIG1hcmtlZCBieSBnYXJi YWdlIGNvbGxlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI2MDg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2hhbmdlZCB0aGUgbmF0aXZlIHN0YWNrIG1hcmtpbmcgdG8gaW5jbHVkZSBtYXJraW5n IENvZGVCbG9ja3MgYW5kIEpJVFN0dWJSb3V0aW5lcy4KKyAgICAgICAgUGF0dGVybmVkIHRoZSBj b2RlIGFmdGVyIHdoYXQgd2FzIGluIEpTU3RhY2s6OmdhdGhlckNvbnNlcnZhdGl2ZVJvb3RzKCkK KworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6Om1hcmtSb290 cyk6CisgICAgICAgICogaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwOgorICAgICAgICAoSlND OjpNYWNoaW5lVGhyZWFkczo6Z2F0aGVyRnJvbUN1cnJlbnRUaHJlYWQpOgorICAgICAgICAoSlND OjpNYWNoaW5lVGhyZWFkczo6Z2F0aGVyRnJvbU90aGVyVGhyZWFkKToKKyAgICAgICAgKEpTQzo6 TWFjaGluZVRocmVhZHM6OmdhdGhlckNvbnNlcnZhdGl2ZVJvb3RzKToKKyAgICAgICAgKiBoZWFw L01hY2hpbmVTdGFja01hcmtlci5oOgorCiAyMDEzLTEyLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgRlRMIHNob3VsZCBiZSBhYmxlIHRvIGRvIGNhbGwgSUNz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTYwODgwKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQ0NywyMCArNDQ3LDIwIEBAIHZvaWQgSGVhcDo6bWFya1Jvb3RzKCkKICAgICBkb3VibGUgZ2NT dGFydFRpbWUgPSBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwogI2VuZGlmCiAK KyAgICBtX2NvZGVCbG9ja3MuY2xlYXJNYXJrcygpOwogICAgIHZvaWQqIGR1bW15OwotICAgIAor CiAgICAgLy8gV2UgZ2F0aGVyIGNvbnNlcnZhdGl2ZSByb290cyBiZWZvcmUgY2xlYXJpbmcgbWFy ayBiaXRzIGJlY2F1c2UgY29uc2VydmF0aXZlCiAgICAgLy8gZ2F0aGVyaW5nIHVzZXMgdGhlIG1h cmsgYml0cyB0byBkZXRlcm1pbmUgd2hldGhlciBhIHJlZmVyZW5jZSBpcyB2YWxpZC4KICAgICBD b25zZXJ2YXRpdmVSb290cyBtYWNoaW5lVGhyZWFkUm9vdHMoJm1fb2JqZWN0U3BhY2UuYmxvY2tz KCksICZtX3N0b3JhZ2VTcGFjZSk7CiAgICAgbV9qaXRTdHViUm91dGluZXMuY2xlYXJNYXJrcygp OwogICAgIHsKICAgICAgICAgR0NQSEFTRShHYXRoZXJDb25zZXJ2YXRpdmVSb290cyk7Ci0gICAg ICAgIG1fbWFjaGluZVRocmVhZHMuZ2F0aGVyQ29uc2VydmF0aXZlUm9vdHMobWFjaGluZVRocmVh ZFJvb3RzLCAmZHVtbXkpOworICAgICAgICBtX21hY2hpbmVUaHJlYWRzLmdhdGhlckNvbnNlcnZh dGl2ZVJvb3RzKG1hY2hpbmVUaHJlYWRSb290cywgbV9qaXRTdHViUm91dGluZXMsIG1fY29kZUJs b2NrcywgJmR1bW15KTsKICAgICB9CiAKICNpZiBFTkFCTEUoTExJTlRfQ0xPT1ApCiAgICAgQ29u c2VydmF0aXZlUm9vdHMgc3RhY2tSb290cygmbV9vYmplY3RTcGFjZS5ibG9ja3MoKSwgJm1fc3Rv cmFnZVNwYWNlKTsKLSAgICBtX2NvZGVCbG9ja3MuY2xlYXJNYXJrcygpOwogICAgIHsKICAgICAg ICAgR0NQSEFTRShHYXRoZXJTdGFja1Jvb3RzKTsKICAgICAgICAgc3RhY2soKS5nYXRoZXJDb25z ZXJ2YXRpdmVSb290cyhzdGFja1Jvb3RzLCBtX2ppdFN0dWJSb3V0aW5lcywgbV9jb2RlQmxvY2tz KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNr TWFya2VyLmNwcAkocmV2aXNpb24gMTYwODgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5LDcgKzIzOSw3 IEBAIHZvaWQgTWFjaGluZVRocmVhZHM6OnJlbW92ZUN1cnJlbnRUaHJlYWQKICNkZWZpbmUgUkVH SVNURVJfQlVGRkVSX0FMSUdOTUVOVAogI2VuZGlmCiAKLXZvaWQgTWFjaGluZVRocmVhZHM6Omdh dGhlckZyb21DdXJyZW50VGhyZWFkKENvbnNlcnZhdGl2ZVJvb3RzJiBjb25zZXJ2YXRpdmVSb290 cywgdm9pZCogc3RhY2tDdXJyZW50KQordm9pZCBNYWNoaW5lVGhyZWFkczo6Z2F0aGVyRnJvbUN1 cnJlbnRUaHJlYWQoQ29uc2VydmF0aXZlUm9vdHMmIGNvbnNlcnZhdGl2ZVJvb3RzLCBKSVRTdHVi Um91dGluZVNldCYgaml0U3R1YlJvdXRpbmVzLCBDb2RlQmxvY2tTZXQmIGNvZGVCbG9ja3MsIHZv aWQqIHN0YWNrQ3VycmVudCkKIHsKICAgICAvLyBzZXRqbXAgZm9yY2VzIHZvbGF0aWxlIHJlZ2lz dGVycyBvbnRvIHRoZSBzdGFjawogICAgIGptcF9idWYgcmVnaXN0ZXJzIFJFR0lTVEVSX0JVRkZF Ul9BTElHTk1FTlQ7CkBAIC0yNTUsMTIgKzI1NSwxMiBAQCB2b2lkIE1hY2hpbmVUaHJlYWRzOjpn YXRoZXJGcm9tQ3VycmVudFRoCiAgICAgdm9pZCogcmVnaXN0ZXJzQmVnaW4gPSAmcmVnaXN0ZXJz OwogICAgIHZvaWQqIHJlZ2lzdGVyc0VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHJvdW5k VXBUb011bHRpcGxlT2Y8c2l6ZW9mKHZvaWQqKT4ocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+ KCZyZWdpc3RlcnMgKyAxKSkpOwogICAgIHN3YXBJZkJhY2t3YXJkcyhyZWdpc3RlcnNCZWdpbiwg cmVnaXN0ZXJzRW5kKTsKLSAgICBjb25zZXJ2YXRpdmVSb290cy5hZGQocmVnaXN0ZXJzQmVnaW4s IHJlZ2lzdGVyc0VuZCk7CisgICAgY29uc2VydmF0aXZlUm9vdHMuYWRkKHJlZ2lzdGVyc0JlZ2lu LCByZWdpc3RlcnNFbmQsIGppdFN0dWJSb3V0aW5lcywgY29kZUJsb2Nrcyk7CiAKICAgICB2b2lk KiBzdGFja0JlZ2luID0gc3RhY2tDdXJyZW50OwogICAgIHZvaWQqIHN0YWNrRW5kID0gd3RmVGhy ZWFkRGF0YSgpLnN0YWNrKCkub3JpZ2luKCk7CiAgICAgc3dhcElmQmFja3dhcmRzKHN0YWNrQmVn aW4sIHN0YWNrRW5kKTsKLSAgICBjb25zZXJ2YXRpdmVSb290cy5hZGQoc3RhY2tCZWdpbiwgc3Rh Y2tFbmQpOworICAgIGNvbnNlcnZhdGl2ZVJvb3RzLmFkZChzdGFja0JlZ2luLCBzdGFja0VuZCwg aml0U3R1YlJvdXRpbmVzLCBjb2RlQmxvY2tzKTsKIH0KIAogc3RhdGljIGlubGluZSB2b2lkIHN1 c3BlbmRUaHJlYWQoY29uc3QgUGxhdGZvcm1UaHJlYWQmIHBsYXRmb3JtVGhyZWFkKQpAQCAtNDYy LDI0ICs0NjIsMjQgQEAgc3RhdGljIHZvaWQgZnJlZVBsYXRmb3JtVGhyZWFkUmVnaXN0ZXJzKAog I2VuZGlmCiB9CiAKLXZvaWQgTWFjaGluZVRocmVhZHM6OmdhdGhlckZyb21PdGhlclRocmVhZChD b25zZXJ2YXRpdmVSb290cyYgY29uc2VydmF0aXZlUm9vdHMsIFRocmVhZCogdGhyZWFkKQordm9p ZCBNYWNoaW5lVGhyZWFkczo6Z2F0aGVyRnJvbU90aGVyVGhyZWFkKENvbnNlcnZhdGl2ZVJvb3Rz JiBjb25zZXJ2YXRpdmVSb290cywgVGhyZWFkKiB0aHJlYWQsIEpJVFN0dWJSb3V0aW5lU2V0JiBq aXRTdHViUm91dGluZXMsIENvZGVCbG9ja1NldCYgY29kZUJsb2NrcykKIHsKICAgICBQbGF0Zm9y bVRocmVhZFJlZ2lzdGVycyByZWdzOwogICAgIHNpemVfdCByZWdTaXplID0gZ2V0UGxhdGZvcm1U aHJlYWRSZWdpc3RlcnModGhyZWFkLT5wbGF0Zm9ybVRocmVhZCwgcmVncyk7CiAKLSAgICBjb25z ZXJ2YXRpdmVSb290cy5hZGQoc3RhdGljX2Nhc3Q8dm9pZCo+KCZyZWdzKSwgc3RhdGljX2Nhc3Q8 dm9pZCo+KHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KCZyZWdzKSArIHJlZ1NpemUpKTsKKyAgICBj b25zZXJ2YXRpdmVSb290cy5hZGQoc3RhdGljX2Nhc3Q8dm9pZCo+KCZyZWdzKSwgc3RhdGljX2Nh c3Q8dm9pZCo+KHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KCZyZWdzKSArIHJlZ1NpemUpLCBqaXRT dHViUm91dGluZXMsIGNvZGVCbG9ja3MpOwogCiAgICAgdm9pZCogc3RhY2tQb2ludGVyID0gb3Ro ZXJUaHJlYWRTdGFja1BvaW50ZXIocmVncyk7CiAgICAgdm9pZCogc3RhY2tCYXNlID0gdGhyZWFk LT5zdGFja0Jhc2U7CiAgICAgc3dhcElmQmFja3dhcmRzKHN0YWNrUG9pbnRlciwgc3RhY2tCYXNl KTsKLSAgICBjb25zZXJ2YXRpdmVSb290cy5hZGQoc3RhY2tQb2ludGVyLCBzdGFja0Jhc2UpOwor ICAgIGNvbnNlcnZhdGl2ZVJvb3RzLmFkZChzdGFja1BvaW50ZXIsIHN0YWNrQmFzZSwgaml0U3R1 YlJvdXRpbmVzLCBjb2RlQmxvY2tzKTsKIAogICAgIGZyZWVQbGF0Zm9ybVRocmVhZFJlZ2lzdGVy cyhyZWdzKTsKIH0KIAotdm9pZCBNYWNoaW5lVGhyZWFkczo6Z2F0aGVyQ29uc2VydmF0aXZlUm9v dHMoQ29uc2VydmF0aXZlUm9vdHMmIGNvbnNlcnZhdGl2ZVJvb3RzLCB2b2lkKiBzdGFja0N1cnJl bnQpCit2b2lkIE1hY2hpbmVUaHJlYWRzOjpnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDb25zZXJ2 YXRpdmVSb290cyYgY29uc2VydmF0aXZlUm9vdHMsIEpJVFN0dWJSb3V0aW5lU2V0JiBqaXRTdHVi Um91dGluZXMsIENvZGVCbG9ja1NldCYgY29kZUJsb2Nrcywgdm9pZCogc3RhY2tDdXJyZW50KQog ewotICAgIGdhdGhlckZyb21DdXJyZW50VGhyZWFkKGNvbnNlcnZhdGl2ZVJvb3RzLCBzdGFja0N1 cnJlbnQpOworICAgIGdhdGhlckZyb21DdXJyZW50VGhyZWFkKGNvbnNlcnZhdGl2ZVJvb3RzLCBq aXRTdHViUm91dGluZXMsIGNvZGVCbG9ja3MsIHN0YWNrQ3VycmVudCk7CiAKICAgICBpZiAobV90 aHJlYWRTcGVjaWZpYykgewogICAgICAgICBQbGF0Zm9ybVRocmVhZCBjdXJyZW50UGxhdGZvcm1U aHJlYWQgPSBnZXRDdXJyZW50UGxhdGZvcm1UaHJlYWQoKTsKQEAgLTUwMSw3ICs1MDEsNyBAQCB2 b2lkIE1hY2hpbmVUaHJlYWRzOjpnYXRoZXJDb25zZXJ2YXRpdmVSCiAgICAgICAgIC8vIGFuZCBz aW5jZSB0aGlzIGlzIGEgc2hhcmVkIGhlYXAsIHRoZXkgYXJlIHJlYWwgbG9ja3MuCiAgICAgICAg IGZvciAoVGhyZWFkKiB0aHJlYWQgPSBtX3JlZ2lzdGVyZWRUaHJlYWRzOyB0aHJlYWQ7IHRocmVh ZCA9IHRocmVhZC0+bmV4dCkgewogICAgICAgICAgICAgaWYgKCFlcXVhbFRocmVhZCh0aHJlYWQt PnBsYXRmb3JtVGhyZWFkLCBjdXJyZW50UGxhdGZvcm1UaHJlYWQpKQotICAgICAgICAgICAgICAg IGdhdGhlckZyb21PdGhlclRocmVhZChjb25zZXJ2YXRpdmVSb290cywgdGhyZWFkKTsKKyAgICAg ICAgICAgICAgICBnYXRoZXJGcm9tT3RoZXJUaHJlYWQoY29uc2VydmF0aXZlUm9vdHMsIHRocmVh ZCwgaml0U3R1YlJvdXRpbmVzLCBjb2RlQmxvY2tzKTsKICAgICAgICAgfQogCiAgICAgICAgIGZv ciAoVGhyZWFkKiB0aHJlYWQgPSBtX3JlZ2lzdGVyZWRUaHJlYWRzOyB0aHJlYWQ7IHRocmVhZCA9 IHRocmVhZC0+bmV4dCkgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGlu ZVN0YWNrTWFya2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv TWFjaGluZVN0YWNrTWFya2VyLmgJKHJldmlzaW9uIDE2MDg4MCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw4 ICsyOCwxMCBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAorICAgIGNsYXNzIENvZGVCbG9ja1NldDsK ICAgICBjbGFzcyBDb25zZXJ2YXRpdmVSb290czsKICAgICBjbGFzcyBIZWFwOworICAgIGNsYXNz IEpJVFN0dWJSb3V0aW5lU2V0OwogCiAgICAgY2xhc3MgTWFjaGluZVRocmVhZHMgewogICAgICAg ICBXVEZfTUFLRV9OT05DT1BZQUJMRShNYWNoaW5lVGhyZWFkcyk7CkBAIC0zNywyMCArMzksMjAg QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIE1hY2hpbmVUaHJlYWRzKEhlYXAqKTsKICAgICAg ICAgfk1hY2hpbmVUaHJlYWRzKCk7CiAKLSAgICAgICAgdm9pZCBnYXRoZXJDb25zZXJ2YXRpdmVS b290cyhDb25zZXJ2YXRpdmVSb290cyYsIHZvaWQqIHN0YWNrQ3VycmVudCk7CisgICAgICAgIHZv aWQgZ2F0aGVyQ29uc2VydmF0aXZlUm9vdHMoQ29uc2VydmF0aXZlUm9vdHMmLCBKSVRTdHViUm91 dGluZVNldCYsIENvZGVCbG9ja1NldCYsIHZvaWQqIHN0YWNrQ3VycmVudCk7CiAKICAgICAgICAg SlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBtYWtlVXNhYmxlRnJvbU11bHRpcGxlVGhyZWFkcygpOwog ICAgICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGFkZEN1cnJlbnRUaHJlYWQoKTsgLy8gT25s eSBuZWVkcyB0byBiZSBjYWxsZWQgYnkgY2xpZW50cyB0aGF0IGNhbiB1c2UgdGhlIHNhbWUgaGVh cCBmcm9tIG11bHRpcGxlIHRocmVhZHMuCiAKICAgICBwcml2YXRlOgotICAgICAgICB2b2lkIGdh dGhlckZyb21DdXJyZW50VGhyZWFkKENvbnNlcnZhdGl2ZVJvb3RzJiwgdm9pZCogc3RhY2tDdXJy ZW50KTsKKyAgICAgICAgdm9pZCBnYXRoZXJGcm9tQ3VycmVudFRocmVhZChDb25zZXJ2YXRpdmVS b290cyYsIEpJVFN0dWJSb3V0aW5lU2V0JiwgQ29kZUJsb2NrU2V0Jiwgdm9pZCogc3RhY2tDdXJy ZW50KTsKIAogICAgICAgICBjbGFzcyBUaHJlYWQ7CiAKICAgICAgICAgc3RhdGljIHZvaWQgcmVt b3ZlVGhyZWFkKHZvaWQqKTsKICAgICAgICAgdm9pZCByZW1vdmVDdXJyZW50VGhyZWFkKCk7CiAK LSAgICAgICAgdm9pZCBnYXRoZXJGcm9tT3RoZXJUaHJlYWQoQ29uc2VydmF0aXZlUm9vdHMmLCBU aHJlYWQqKTsKKyAgICAgICAgdm9pZCBnYXRoZXJGcm9tT3RoZXJUaHJlYWQoQ29uc2VydmF0aXZl Um9vdHMmLCBUaHJlYWQqLCBKSVRTdHViUm91dGluZVNldCYsIENvZGVCbG9ja1NldCYpOwogCiAg ICAgICAgIE11dGV4IG1fcmVnaXN0ZXJlZFRocmVhZHNNdXRleDsKICAgICAgICAgVGhyZWFkKiBt X3JlZ2lzdGVyZWRUaHJlYWRzOwo=