126074 2013-12-20 11:28:44 -0800 http/tests/misc/object-image-error.html asserts 2013-12-20 12:46:26 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned ap commit-queue esprehn+autocc gyuyoung.kim oldest_to_newest 961936 0 koivisto 2013-12-20 11:28:44 -0800 http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r160914%20(1133)/http/tests/misc/object-image-error-crash-log.txt ASSERTION FAILED: !child->renderer() || current.shadowRoot() || current.isInsertionPoint() /Volumes/Data/slave/mavericks-debug/build/Source/WebCore/style/StyleResolveTree.cpp(441) : void WebCore::Style::attachChildren(WebCore::ContainerNode &) 1 0x11352e780 WTFCrash 2 0x1146601fc WebCore::Style::attachChildren(WebCore::ContainerNode&) 3 0x11465f8ae WebCore::Style::attachRenderTree(WebCore::Element&, WTF::PassRefPtr<WebCore::RenderStyle>) 4 0x11465efc9 WebCore::Style::resolveLocal(WebCore::Element&, WebCore::Style::Change) 5 0x11465ebe0 WebCore::Style::resolveTree(WebCore::Element&, WebCore::Style::Change) 6 0x11465eda0 WebCore::Style::resolveTree(WebCore::Element&, WebCore::Style::Change) 7 0x11465eda0 WebCore::Style::resolveTree(WebCore::Element&, WebCore::Style::Change) 8 0x11465f6e8 WebCore::Style::resolveTree(WebCore::Document&, WebCore::Style::Change) 9 0x11496e716 WebCore::Document::recalcStyle(WebCore::Style::Change) 10 0x11496af0f WebCore::Document::updateStyleIfNeeded() 11 0x11496eba5 WebCore::Document::implicitClose() 961967 1 219777 koivisto 2013-12-20 11:51:21 -0800 Created attachment 219777 patch 961969 2 commit-queue 2013-12-20 11:53:52 -0800 Attachment 219777 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 961974 3 219777 kling 2013-12-20 11:57:27 -0800 Comment on attachment 219777 patch View in context: https://bugs.webkit.org/attachment.cgi?id=219777&action=review r=me > Source/WebCore/html/HTMLPlugInImageElement.cpp:256 > + queuePostAttachCallback(&HTMLPlugInImageElement::startLoadingImageCallback, this); This deserves a comment. 962001 4 koivisto 2013-12-20 12:46:26 -0800 https://trac.webkit.org/r160920 219777 2013-12-20 11:51:21 -0800 2013-12-20 11:57:27 -0800 patch plugin-image-post-attach.patch text/plain 3367 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDkxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTEyLTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwL3Rlc3RzL21pc2Mvb2Jq ZWN0LWltYWdlLWVycm9yLmh0bWwgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBo dG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFBs dWdJbkltYWdlRWxlbWVudDo6ZGlkQXR0YWNoUmVuZGVyZXJzKToKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnVwZGF0ZVdpZGdldENhbGxiYWNrKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnN0YXJ0TG9hZGluZ0ltYWdlKToKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnN0YXJ0TG9hZGluZ0ltYWdl Q2FsbGJhY2spOgorICAgICAgICAqIGh0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5oOgorICAg ICAgICAKKyAgICAgICAgICAgIFN0YXJ0IGltYWdlIGxvYWQgZnJvbSBwb3N0LWF0dGFjaCBzbyB3 ZSBkb24ndCByZS1lbnRlciBhdHRhY2ggd2hlbiBpbWFnZSBsb2FkIGZhaWxzIHN5bmNocm9ub3Vz bHkuCisKIDIwMTMtMTItMjAgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIENyYXNoZXMgaW4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6Y29tcHV0ZUFjY2Vz c2liaWxpdHlJc0lnbm9yZWQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0lu SW1hZ2VFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQ bHVnSW5JbWFnZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjA5MDQpCisrKyBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTIs OSArMjUyLDggQEAgdm9pZCBIVE1MUGx1Z0luSW1hZ2VFbGVtZW50OjpkaWRBdHRhY2hSZQogICAg IH0KICAgICBpZiAoIXJlbmRlcmVyKCkgfHwgdXNlRmFsbGJhY2tDb250ZW50KCkpCiAgICAgICAg IHJldHVybjsKLSAgICBpZiAoIW1faW1hZ2VMb2FkZXIpCi0gICAgICAgIG1faW1hZ2VMb2FkZXIg PSBhZG9wdFB0cihuZXcgSFRNTEltYWdlTG9hZGVyKHRoaXMpKTsKLSAgICBtX2ltYWdlTG9hZGVy LT51cGRhdGVGcm9tRWxlbWVudCgpOworCisgICAgcXVldWVQb3N0QXR0YWNoQ2FsbGJhY2soJkhU TUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnN0YXJ0TG9hZGluZ0ltYWdlQ2FsbGJhY2ssIHRoaXMpOwog fQogCiB2b2lkIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OndpbGxEZXRhY2hSZW5kZXJlcnMoKQpA QCAtMzM0LDkgKzMzMywyMSBAQCBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBIVE1MUGx1Z0luSW1h Z2VFCiAgICAgcmV0dXJuIG1fY3VzdG9tU3R5bGVGb3JQYWdlQ2FjaGU7CiB9CiAKLXZvaWQgSFRN TFBsdWdJbkltYWdlRWxlbWVudDo6dXBkYXRlV2lkZ2V0Q2FsbGJhY2soTm9kZSogbiwgdW5zaWdu ZWQpCit2b2lkIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnVwZGF0ZVdpZGdldENhbGxiYWNrKE5v ZGUqIG5vZGUsIHVuc2lnbmVkKQoreworICAgIHRvSFRNTFBsdWdJbkltYWdlRWxlbWVudChub2Rl KS0+dXBkYXRlV2lkZ2V0SWZOZWNlc3NhcnkoKTsKK30KKwordm9pZCBIVE1MUGx1Z0luSW1hZ2VF bGVtZW50OjpzdGFydExvYWRpbmdJbWFnZSgpCit7CisgICAgaWYgKCFtX2ltYWdlTG9hZGVyKQor ICAgICAgICBtX2ltYWdlTG9hZGVyID0gYWRvcHRQdHIobmV3IEhUTUxJbWFnZUxvYWRlcih0aGlz KSk7CisgICAgbV9pbWFnZUxvYWRlci0+dXBkYXRlRnJvbUVsZW1lbnQoKTsKK30KKwordm9pZCBI VE1MUGx1Z0luSW1hZ2VFbGVtZW50OjpzdGFydExvYWRpbmdJbWFnZUNhbGxiYWNrKE5vZGUqIG5v ZGUsIHVuc2lnbmVkKQogewotICAgIHRvSFRNTFBsdWdJbkltYWdlRWxlbWVudChuKS0+dXBkYXRl V2lkZ2V0SWZOZWNlc3NhcnkoKTsKKyAgICB0b0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQobm9kZSkt PnN0YXJ0TG9hZGluZ0ltYWdlKCk7CiB9CiAKIHZvaWQgSFRNTFBsdWdJbkltYWdlRWxlbWVudDo6 dXBkYXRlU25hcHNob3QoUGFzc1JlZlB0cjxJbWFnZT4gaW1hZ2UpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaAkocmV2aXNpb24gMTYwOTA0KQor KysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTExMyw3ICsxMTMsOSBAQCBwcm90ZWN0ZWQ6CiAgICAgU3RyaW5nIG1fdXJsOwog ICAgIFVSTCBtX2xvYWRlZFVybDsKIAotICAgIHN0YXRpYyB2b2lkIHVwZGF0ZVdpZGdldENhbGxi YWNrKE5vZGUqLCB1bnNpZ25lZCA9IDApOworICAgIHN0YXRpYyB2b2lkIHVwZGF0ZVdpZGdldENh bGxiYWNrKE5vZGUqLCB1bnNpZ25lZCk7CisgICAgc3RhdGljIHZvaWQgc3RhcnRMb2FkaW5nSW1h Z2VDYWxsYmFjayhOb2RlKiwgdW5zaWduZWQpOworCiAgICAgdmlydHVhbCB2b2lkIGRpZEF0dGFj aFJlbmRlcmVycygpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsRGV0YWNoUmVuZGVy ZXJzKCkgT1ZFUlJJREU7CiAKQEAgLTEzOSw2ICsxNDEsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1 YWwgdm9pZCBmaW5pc2hQYXJzaW5nQ2hpbGRyZW4oKSBPVkVSUklERTsKIAogICAgIHZvaWQgdXBk YXRlV2lkZ2V0SWZOZWNlc3NhcnkoKTsKKyAgICB2b2lkIHN0YXJ0TG9hZGluZ0ltYWdlKCk7CiAK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlU25hcHNob3QoUGFzc1JlZlB0cjxJbWFnZT4pIE9WRVJS SURFOwogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaFBlbmRpbmdNb3VzZUNsaWNrKCkgT1ZFUlJJ REU7Cg==