126064 2013-12-20 03:29:50 -0800 [arm] Missing implementation of branchTest8(ResultCondition, BaseIndex, TrustedImm32) in MacroAssembler 2013-12-20 07:43:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue mhahnenberg msaboff ossy rgabor zherczeg oldest_to_newest 961812 0 jbriance 2013-12-20 03:29:50 -0800 CPU(ARM_TRADITIONAL) build is broken: [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITPropertyAccess.cpp.o /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In member function ‘JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Jump JSC::JIT::checkMarkWord(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)’: /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp:885:99: error: no matching function for call to ‘JSC::JIT::branchTest8(JSC::MacroAssemblerARM::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::BaseIndex)’ A patch similar to http://trac.webkit.org/changeset/160680 is needed for CPU(ARM_TRADITIONAL) architecture. 961813 1 219747 jbriance 2013-12-20 03:33:23 -0800 Created attachment 219747 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). 961859 2 219747 mhahnenberg 2013-12-20 07:16:44 -0800 Comment on attachment 219747 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). r=me 961862 3 219747 commit-queue 2013-12-20 07:43:14 -0800 Comment on attachment 219747 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). Clearing flags on attachment: 219747 Committed r160911: <http://trac.webkit.org/changeset/160911> 961863 4 commit-queue 2013-12-20 07:43:16 -0800 All reviewed patches have been landed. Closing bug. 219747 2013-12-20 03:33:23 -0800 2013-12-20 07:43:14 -0800 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). bug-126064.patch text/plain 1511 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwOTAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTIwICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFthcm1dIEFkZCBtaXNzaW5nIGltcGxlbWVudGF0aW9uIGluIE1hY3JvQXNzZW1ibGVy IHRvIGZpeCBDUFUoQVJNX1RSQURJVElPTkFMKSBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjA2NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpicmFuY2hUZXN0OCk6CisKIDIw MTMtMTItMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBBZGQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmRlYnVnZ2FibGVUeXBl IHRvIGxldCB0aGUgZnJvbnRlbmQga25vdyBpdCdzIGJhY2tlbmQgaXMgSmF2YVNjcmlwdCBvciBX ZWIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDE2MDg5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2luZyBjb3B5KQpAQCAtNjM3LDYg KzYzNywxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBicmFuY2hUZXN0MzIoY29uZCwgQVJN UmVnaXN0ZXJzOjpTMSwgbWFzayk7CiAgICAgfQogCisgICAgSnVtcCBicmFuY2hUZXN0OChSZXN1 bHRDb25kaXRpb24gY29uZCwgQmFzZUluZGV4IGFkZHJlc3MsIFRydXN0ZWRJbW0zMiBtYXNrID0g VHJ1c3RlZEltbTMyKC0xKSkKKyAgICB7CisgICAgICAgIGxvYWQ4KGFkZHJlc3MsIEFSTVJlZ2lz dGVyczo6UzEpOworICAgICAgICByZXR1cm4gYnJhbmNoVGVzdDMyKGNvbmQsIEFSTVJlZ2lzdGVy czo6UzEsIG1hc2spOworICAgIH0KKwogICAgIEp1bXAgYnJhbmNoVGVzdDgoUmVzdWx0Q29uZGl0 aW9uIGNvbmQsIEFic29sdXRlQWRkcmVzcyBhZGRyZXNzLCBUcnVzdGVkSW1tMzIgbWFzayA9IFRy dXN0ZWRJbW0zMigtMSkpCiAgICAgewogICAgICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRkcmVz cy5tX3B0ciksIEFSTVJlZ2lzdGVyczo6UzEpOwo=