126063 2013-12-20 03:16:05 -0800 [sh4] Missing implementation of branchTest8(ResultCondition, BaseIndex, TrustedImm32) in MacroAssembler 2013-12-20 07:45:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue mhahnenberg msaboff yannick.poirier oldest_to_newest 961810 0 jbriance 2013-12-20 03:16:05 -0800 sh4 build is broken: [ 11%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITPropertyAccess.cpp.o /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In member function ‘JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Jump JSC::JIT::checkMarkWord(JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID)’: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp:885:99: error: no matching function for call to ‘JSC::JIT::branchTest8(JSC::MacroAssemblerSH4::ResultCondition, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::BaseIndex)’ A patch similar to http://trac.webkit.org/changeset/160680 is needed for sh4 architecture. 961811 1 219746 jbriance 2013-12-20 03:20:40 -0800 Created attachment 219746 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler. 961860 2 219746 mhahnenberg 2013-12-20 07:17:14 -0800 Comment on attachment 219746 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler. r=me 961865 3 219746 commit-queue 2013-12-20 07:45:27 -0800 Comment on attachment 219746 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler. Clearing flags on attachment: 219746 Committed r160912: <http://trac.webkit.org/changeset/160912> 961866 4 commit-queue 2013-12-20 07:45:29 -0800 All reviewed patches have been landed. Closing bug. 219746 2013-12-20 03:20:40 -0800 2013-12-20 07:45:27 -0800 Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in sh4 macro assembler. bug-126063.patch text/plain 1583 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwOTAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTIwICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEFkZCBtaXNzaW5nIGltcGxlbWVudGF0aW9uIGluIE1hY3JvQXNzZW1ibGVy IHRvIGZpeCBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjA2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0Lmg6CisgICAgICAgIChKU0M6Ok1h Y3JvQXNzZW1ibGVyU0g0OjpicmFuY2hUZXN0OCk6CisKIDIwMTMtMTItMTkgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQg SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmRlYnVnZ2FibGVUeXBlIHRvIGxldCB0aGUgZnJvbnRlbmQg a25vdyBpdCdzIGJhY2tlbmQgaXMgSmF2YVNjcmlwdCBvciBXZWIKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgJKHJldmlz aW9uIDE2MDg5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJTSDQuaAkod29ya2luZyBjb3B5KQpAQCAtMTU3MCw2ICsxNTcwLDE1IEBAIHB1YmxpYzoK ICAgICAgICAgcmV0dXJuIGptcDsKICAgICB9CiAKKyAgICBKdW1wIGJyYW5jaFRlc3Q4KFJlc3Vs dENvbmRpdGlvbiBjb25kLCBCYXNlSW5kZXggYWRkcmVzcywgVHJ1c3RlZEltbTMyIG1hc2sgPSBU cnVzdGVkSW1tMzIoLTEpKQorICAgIHsKKyAgICAgICAgUmVnaXN0ZXJJRCBhZGRyZXNzVGVtcFJl Z2lzdGVyID0gY2xhaW1TY3JhdGNoKCk7CisgICAgICAgIGxvYWQ4KGFkZHJlc3MsIGFkZHJlc3NU ZW1wUmVnaXN0ZXIpOworICAgICAgICBKdW1wIGptcCA9IGJyYW5jaFRlc3QzMihjb25kLCBhZGRy ZXNzVGVtcFJlZ2lzdGVyLCBtYXNrKTsKKyAgICAgICAgcmVsZWFzZVNjcmF0Y2goYWRkcmVzc1Rl bXBSZWdpc3Rlcik7CisgICAgICAgIHJldHVybiBqbXA7CisgICAgfQorCiAgICAgSnVtcCBicmFu Y2hUZXN0OChSZXN1bHRDb25kaXRpb24gY29uZCwgQWJzb2x1dGVBZGRyZXNzIGFkZHJlc3MsIFRy dXN0ZWRJbW0zMiBtYXNrID0gVHJ1c3RlZEltbTMyKC0xKSkKICAgICB7CiAgICAgICAgIFJlZ2lz dGVySUQgYWRkcmVzc1RlbXBSZWdpc3RlciA9IGNsYWltU2NyYXRjaCgpOwo=