126059 2013-12-20 00:30:34 -0800 Build fails in debug mode after r160834. 2013-12-20 02:49:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned benjamin cmarcelo commit-queue ossy oldest_to_newest 961772 0 tgergely.u-szeged 2013-12-20 00:30:34 -0800 Compile error in debug mode: Source/WTF/wtf/dtoa/double-conversion.cc: In static member function 'static double WTF::double_conversion::StringToDoubleConverter::StringToDouble(const char*, size_t, size_t*)': Source/WTF/wtf/dtoa/double-conversion.cc:488:33: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Source/WTF/wtf/dtoa/double-conversion.cc:525:37: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Source/WTF/wtf/dtoa/double-conversion.cc:596:25: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] 961775 1 219737 tgergely.u-szeged 2013-12-20 00:42:28 -0800 Created attachment 219737 patch 961797 2 219737 ossy 2013-12-20 02:22:24 -0800 Comment on attachment 219737 patch LGTM, r=me. 961800 3 219737 commit-queue 2013-12-20 02:49:13 -0800 Comment on attachment 219737 patch Clearing flags on attachment: 219737 Committed r160899: <http://trac.webkit.org/changeset/160899> 961801 4 commit-queue 2013-12-20 02:49:14 -0800 All reviewed patches have been landed. Closing bug. 219737 2013-12-20 00:42:28 -0800 2013-12-20 02:49:12 -0800 patch fix_debug_build.patch text/plain 1314 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTJlMTEyMi4uZjhhMmYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0xMi0yMCAg VGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisK KyAgICAgICAgQnVpbGQgZmFpbHMgaW4gZGVidWcgbW9kZSBhZnRlciByMTYwODM0LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDU5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVidWcgbW9kZSBidWls ZCBmYWlsZWQgZHVlIHRvIGNvbXBhcmluZyBzaWduZWQgYW5kIHVuc2lnbmVkIGluCisgICAgICAg IEFTU0VSVCgpLiBOb3cgYm90aCB2YWx1ZXMgYXJlIHVuc2lnbmVkLgorCisgICAgICAgICogd3Rm L2R0b2EvZG91YmxlLWNvbnZlcnNpb24uY2M6CisKIDIwMTMtMTItMTkgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaW5hbCBwcmVwYXJhdGlv bnMgZm9yIEdTdHJlYW1lciBvbiBXaW5kb3dzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv ZHRvYS9kb3VibGUtY29udmVyc2lvbi5jYyBiL1NvdXJjZS9XVEYvd3RmL2R0b2EvZG91YmxlLWNv bnZlcnNpb24uY2MKaW5kZXggYWRiYmQxYy4uYWJmMjg3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvZHRvYS9kb3VibGUtY29udmVyc2lvbi5jYworKysgYi9Tb3VyY2UvV1RGL3d0Zi9kdG9h L2RvdWJsZS1jb252ZXJzaW9uLmNjCkBAIC00NDQsNyArNDQ0LDcgQEAgbmFtZXNwYWNlIGRvdWJs ZV9jb252ZXJzaW9uIHsKICAgICAgICAgaWYgKGN1cnJlbnQgPT0gZW5kKSByZXR1cm4gMC4wOwog ICAgICAgICAKICAgICAgICAgLy8gVGhlIGxvbmdlc3QgZm9ybSBvZiBzaW1wbGlmaWVkIG51bWJl ciBpczogIi08c2lnbmlmaWNhbnQgZGlnaXRzPi4xZVhYWFwwIi4KLSAgICAgICAgY29uc3QgaW50 IGtCdWZmZXJTaXplID0ga01heFNpZ25pZmljYW50RGlnaXRzICsgMTA7CisgICAgICAgIGNvbnN0 IHVuc2lnbmVkIGtCdWZmZXJTaXplID0ga01heFNpZ25pZmljYW50RGlnaXRzICsgMTA7CiAgICAg ICAgIGNoYXIgYnVmZmVyW2tCdWZmZXJTaXplXTsgIC8vIE5PTElOVDogc2l6ZSBpcyBrbm93biBh dCBjb21waWxlIHRpbWUuCiAgICAgICAgIHVuc2lnbmVkIGJ1ZmZlcl9wb3MgPSAwOwogICAgICAg ICAK