126055 2013-12-19 23:28:03 -0800 #defined constants should use all uppercase names with words separated by underscores. 2016-09-17 07:19:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 126645 1 gbalogh.u-szeged webkit-unassigned ap commit-queue darin glenn oldest_to_newest 961759 0 gbalogh.u-szeged 2013-12-19 23:28:03 -0800 wrong: #define lowercase good: #define UPPER_CASE 964569 1 220418 gbalogh.u-szeged 2014-01-06 00:52:11 -0800 Created attachment 220418 patch 964657 2 220418 ap 2014-01-06 09:49:38 -0800 Comment on attachment 220418 patch View in context: https://bugs.webkit.org/attachment.cgi?id=220418&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2726 > + if not match(r'^[A-Z_]+$', name): This expression doesn't allow for digits, which may be legitimately present in macro names. 964913 3 220500 gbalogh.u-szeged 2014-01-07 01:15:22 -0800 Created attachment 220500 patch fix I just fixed the above mentioned regex error. 965026 4 220500 commit-queue 2014-01-07 08:55:19 -0800 Comment on attachment 220500 patch fix Clearing flags on attachment: 220500 Committed r161427: <http://trac.webkit.org/changeset/161427> 965027 5 commit-queue 2014-01-07 08:55:21 -0800 All reviewed patches have been landed. Closing bug. 965523 6 commit-queue 2014-01-08 09:41:56 -0800 Re-opened since this is blocked by bug 126645 965525 7 ap 2014-01-08 09:42:50 -0800 Turns out that we have macros that intentionally do not follow these rules - all include guards in headers are like this. Rolling out, because this style error is now emitted for all newly added header files. See bug 126626 comment 4 for an example. 965702 8 darin 2014-01-08 17:27:59 -0800 Header guards are macros that are not made of all capital letters. However, they are distinctive because they end “_h”, so we could possibly refine the rule to understand that. We still should run the script across the entire source tree before checking it in to make sure that all the things it complains about are actual problems and there are no false positives. 971053 9 221952 gbalogh.u-szeged 2014-01-22 23:57:57 -0800 Created attachment 221952 Patch 971124 10 darin 2014-01-23 07:23:02 -0800 What were the results when you ran this across the entire source tree? Did you find any other obvious false positives? Could you post the results file from running on the current source tree? 1230840 11 221952 mcatanzaro 2016-09-17 07:19:51 -0700 Comment on attachment 221952 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 220418 2014-01-06 00:52:11 -0800 2014-01-07 01:15:22 -0800 patch f2763.diff text/plain 3440 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YWQy YTA4Li43MmUzMzcwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDEtMDYgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIGRlZmluZWQgY29uc3RhbnRzIHNob3VsZCB1 c2UgYWxsIHVwcGVyY2FzZSBuYW1lcyB3aXRoIHdvcmRzIHNlcGFyYXRlZCBieSB1bmRlcnNjb3Jl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjA1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19zdHls ZSk6CisgICAgICAgIChDcHBDaGVja2VyKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50 ZXN0X2RlZmluZV9jb25zdGFudHMpOgorCiAyMDEzLTEyLTE5ICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIG1pc3Rh a2VubHkgZmxhZ3MgYXNzaWduaW5nIHRvIGEgZGVyZWZlcmVuY2VkIHBvaW50ZXIKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMzk3NGJlMi4uYzE0 ODU1YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK QEAgLTI3MTksNiArMjcxOSwxNCBAQCBkZWYgY2hlY2tfc3R5bGUoY2xlYW5fbGluZXMsIGxpbmVf bnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgY2xhc3Nfc3RhdGUsIGZpbGVfc3RhdAogICAgIGNoZWNr X2luZGVudGF0aW9uX2Ftb3VudChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAg IGNoZWNrX2VudW1fY2FzaW5nKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZW51bV9zdGF0ZSwg ZXJyb3IpCiAKKyAgICAjICNkZWZpbmVkIGNvbnN0YW50cyBzaG91bGQgdXNlIGFsbCB1cHBlcmNh c2UgbmFtZXMgd2l0aCB3b3JkcyBzZXBhcmF0ZWQgYnkgdW5kZXJzY29yZXMuCisgICAgZGVmaW5l X2NoZWNrID0gbWF0Y2gocicjZGVmaW5lXHMoP1A8bmFtZT5bXHdfXSspKFxzLip8XHM/KSQnLCBs aW5lKQorICAgIGlmIGRlZmluZV9jaGVjazoKKyAgICAgICAgbmFtZSA9IGRlZmluZV9jaGVjay5n cm91cCgnbmFtZScpCisgICAgICAgIGlmIG5vdCBtYXRjaChyJ15bQS1aX10rJCcsIG5hbWUpOgor ICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9uYW1pbmcvZGVmaW5l L2NvbnN0YW50cycsIDQsCisgICAgICAgICAgICAgICAgbmFtZSArICIgaXMgaW5jb3JyZWN0LiAj ZGVmaW5lZCBjb25zdGFudHMgc2hvdWxkIHVzZSBhbGwgdXBwZXJjYXNlIG5hbWVzIHdpdGggd29y ZHMgc2VwYXJhdGVkIGJ5IHVuZGVyc2NvcmVzLiIpCisKIAogX1JFX1BBVFRFUk5fSU5DTFVERV9O RVdfU1RZTEUgPSByZS5jb21waWxlKHInI2luY2x1ZGUgKyJbXi9dK1wuaCInKQogX1JFX1BBVFRF Uk5fSU5DTFVERSA9IHJlLmNvbXBpbGUocideXHMqI1xzKmluY2x1ZGVccyooWzwiXSkoW14+Il0q KVs+Il0uKiQnKQpAQCAtMzcwMCw2ICszNzA4LDcgQEAgY2xhc3MgQ3BwQ2hlY2tlcihvYmplY3Qp OgogICAgICAgICAncmVhZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUnLAogICAgICAgICAncmVhZGFi aWxpdHkvbmFtaW5nJywKICAgICAgICAgJ3JlYWRhYmlsaXR5L25hbWluZy91bmRlcnNjb3Jlcycs CisgICAgICAgICdyZWFkYWJpbGl0eS9uYW1pbmcvZGVmaW5lL2NvbnN0YW50cycsCiAgICAgICAg ICdyZWFkYWJpbGl0eS9udWxsJywKICAgICAgICAgJ3JlYWRhYmlsaXR5L3Bhc3NfcHRyJywKICAg ICAgICAgJ3JlYWRhYmlsaXR5L3N0cmVhbXMnLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBiNDc5MzY1Li42Y2U1 NDUzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQpAQCAtNTAyNiw2ICs1MDI2LDE5IEBAIGNsYXNzIFdlYktpdFN0eWxl VGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50IHRoaXMu CiAgICAgICAgIHBhc3MKIAorICAgIGRlZiB0ZXN0X2RlZmluZV9jb25zdGFudHMoc2VsZik6Cisg ICAgICAgIGJhZF9uYW1lX2Vycm9yID0gIiBpcyBpbmNvcnJlY3QuICNkZWZpbmVkIGNvbnN0YW50 cyBzaG91bGQgdXNlIGFsbCB1cHBlcmNhc2UgbmFtZXMgd2l0aCB3b3JkcyBzZXBhcmF0ZWQgYnkg dW5kZXJzY29yZXMuICBbcmVhZGFiaWxpdHkvbmFtaW5nL2RlZmluZS9jb25zdGFudHNdIFs0XSIK KworICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIGxvd2VyY2FzZScsICdsb3dlcmNh c2UnICsgYmFkX25hbWVfZXJyb3IpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUg VVBQRVJDQVNFJywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgbWl4ZWRD QVNFJywgJ21peGVkQ0FTRScgKyBiYWRfbmFtZV9lcnJvcikKKyAgICAgICAgc2VsZi5hc3NlcnRf bGludCgnI2RlZmluZSBsb3dlcl9jYXNlJywgJ2xvd2VyX2Nhc2UnICsgYmFkX25hbWVfZXJyb3Ip CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgVVBQRVJfQ0FTRScsICcnKQorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIG1peGVkX0NBU0UnLCAnbWl4ZWRfQ0FTRScg KyBiYWRfbmFtZV9lcnJvcikKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBkbG93 ZXJjYXNlIHNvbWUoYmxhKScsICdkbG93ZXJjYXNlJyArIGJhZF9uYW1lX2Vycm9yKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIERVUFBFUkNBU0UgZGQoZm9vKScsICcnKQorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIERtaXhlZENBU0UgZGtqZ2hbc2RmXScsICdE bWl4ZWRDQVNFJyArIGJhZF9uYW1lX2Vycm9yKQorCiAKIGNsYXNzIENwcENoZWNrZXJUZXN0KHVu aXR0ZXN0LlRlc3RDYXNlKToKIAo= 220500 2014-01-07 01:15:22 -0800 2014-01-22 23:57:50 -0800 patch fix f2763.fix.diff text/plain 3450 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYmZj MDdjLi43MzkxYmZmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDEtMDYgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIGRlZmluZWQgY29uc3RhbnRzIHNob3VsZCB1 c2UgYWxsIHVwcGVyY2FzZSBuYW1lcyB3aXRoIHdvcmRzIHNlcGFyYXRlZCBieSB1bmRlcnNjb3Jl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjA1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19zdHls ZSk6CisgICAgICAgIChDcHBDaGVja2VyKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50 ZXN0X2RlZmluZV9jb25zdGFudHMpOgorCiAyMDE0LTAxLTA2ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjU2MD4gRml4IGlu Y29ycmVjdG5lc3MgaW4gdXNlIG9mIHNvbWUgQXBwS2l0IGVudW1zCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDM5NzRiZTIuLjcyMzNiNjQgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yNzE5 LDYgKzI3MTksMTQgQEAgZGVmIGNoZWNrX3N0eWxlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZmlsZV9leHRlbnNpb24sIGNsYXNzX3N0YXRlLCBmaWxlX3N0YXQKICAgICBjaGVja19pbmRlbnRh dGlvbl9hbW91bnQoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKICAgICBjaGVja19l bnVtX2Nhc2luZyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVudW1fc3RhdGUsIGVycm9yKQog CisgICAgIyAjZGVmaW5lZCBjb25zdGFudHMgc2hvdWxkIHVzZSBhbGwgdXBwZXJjYXNlIG5hbWVz IHdpdGggd29yZHMgc2VwYXJhdGVkIGJ5IHVuZGVyc2NvcmVzLgorICAgIGRlZmluZV9jaGVjayA9 IG1hdGNoKHInI2RlZmluZVxzKD9QPG5hbWU+W1x3X10rKShccy4qfFxzPykkJywgbGluZSkKKyAg ICBpZiBkZWZpbmVfY2hlY2s6CisgICAgICAgIG5hbWUgPSBkZWZpbmVfY2hlY2suZ3JvdXAoJ25h bWUnKQorICAgICAgICBpZiBub3QgbWF0Y2gocideWzAtOUEtWl9dKyQnLCBuYW1lKToKKyAgICAg ICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nL2RlZmluZS9jb25z dGFudHMnLCA0LAorICAgICAgICAgICAgICAgIG5hbWUgKyAiIGlzIGluY29ycmVjdC4gI2RlZmlu ZWQgY29uc3RhbnRzIHNob3VsZCB1c2UgYWxsIHVwcGVyY2FzZSBuYW1lcyB3aXRoIHdvcmRzIHNl cGFyYXRlZCBieSB1bmRlcnNjb3Jlcy4iKQorCiAKIF9SRV9QQVRURVJOX0lOQ0xVREVfTkVXX1NU WUxFID0gcmUuY29tcGlsZShyJyNpbmNsdWRlICsiW14vXStcLmgiJykKIF9SRV9QQVRURVJOX0lO Q0xVREUgPSByZS5jb21waWxlKHInXlxzKiNccyppbmNsdWRlXHMqKFs8Il0pKFtePiJdKilbPiJd LiokJykKQEAgLTM3MDAsNiArMzcwOCw3IEBAIGNsYXNzIENwcENoZWNrZXIob2JqZWN0KToKICAg ICAgICAgJ3JlYWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lJywKICAgICAgICAgJ3JlYWRhYmlsaXR5 L25hbWluZycsCiAgICAgICAgICdyZWFkYWJpbGl0eS9uYW1pbmcvdW5kZXJzY29yZXMnLAorICAg ICAgICAncmVhZGFiaWxpdHkvbmFtaW5nL2RlZmluZS9jb25zdGFudHMnLAogICAgICAgICAncmVh ZGFiaWxpdHkvbnVsbCcsCiAgICAgICAgICdyZWFkYWJpbGl0eS9wYXNzX3B0cicsCiAgICAgICAg ICdyZWFkYWJpbGl0eS9zdHJlYW1zJywKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggYjQ3OTM2NS4uMmJiOTdiZiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKQEAgLTUwMjYsNiArNTAyNiwxOSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3Qo Q3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICMgRklYTUU6IEltcGxlbWVudCB0aGlzLgogICAg ICAgICBwYXNzCiAKKyAgICBkZWYgdGVzdF9kZWZpbmVfY29uc3RhbnRzKHNlbGYpOgorICAgICAg ICBiYWRfbmFtZV9lcnJvciA9ICIgaXMgaW5jb3JyZWN0LiAjZGVmaW5lZCBjb25zdGFudHMgc2hv dWxkIHVzZSBhbGwgdXBwZXJjYXNlIG5hbWVzIHdpdGggd29yZHMgc2VwYXJhdGVkIGJ5IHVuZGVy c2NvcmVzLiAgW3JlYWRhYmlsaXR5L25hbWluZy9kZWZpbmUvY29uc3RhbnRzXSBbNF0iCisKKyAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBsb3dlcjFjYXNlJywgJ2xvd2VyMWNhc2Un ICsgYmFkX25hbWVfZXJyb3IpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgVVBQ RVIxQ0FTRScsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIG1peGVkMUNB U0UnLCAnbWl4ZWQxQ0FTRScgKyBiYWRfbmFtZV9lcnJvcikKKyAgICAgICAgc2VsZi5hc3NlcnRf bGludCgnI2RlZmluZSBsb3dlcl8xY2FzZScsICdsb3dlcl8xY2FzZScgKyBiYWRfbmFtZV9lcnJv cikKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBVUFBFUl8xQ0FTRScsICcnKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIG1peGVkXzFDQVNFJywgJ21peGVkXzFD QVNFJyArIGJhZF9uYW1lX2Vycm9yKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5l IGRsb3dlcjFjYXNlIHNvbWUoYmxhKScsICdkbG93ZXIxY2FzZScgKyBiYWRfbmFtZV9lcnJvcikK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBEVVBQRVIxQ0FTRSBkZChmb28pJywg JycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgRG1peGVkMUNBU0UgZGtqZ2hb c2RmXScsICdEbWl4ZWQxQ0FTRScgKyBiYWRfbmFtZV9lcnJvcikKKwogCiBjbGFzcyBDcHBDaGVj a2VyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAK 221952 2014-01-22 23:57:57 -0800 2016-09-17 07:19:51 -0700 Patch bug-126055-20140122235757.patch text/plain 3793 gbalogh.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNTk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWI3YTVkYmY1ZWJkYjdhMDg1YWRlMjVkOGE3MmNhNTAy ZGU0OGI4Yy4uNTFkNDQxY2FiOGZmZTE1OTkyYTNlNzM3YWU2MzhlNTE1NGE5NWZiNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTAxLTIyICBHZXJnbyBCYWxvZ2ggIDxnYmFsb2doLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgZGVmaW5lZCBjb25zdGFudHMgc2hvdWxkIHVzZSBhbGwg dXBwZXJjYXNlIG5hbWVzIHdpdGggd29yZHMgc2VwYXJhdGVkIGJ5IHVuZGVyc2NvcmVzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3N0eWxlKToKKyAg ICAgICAgKENwcENoZWNrZXIpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfZGVm aW5lX2NvbnN0YW50cyk6CisKIDIwMTQtMDEtMDUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gcnVuLXdlYmtpdC10ZXN0cyBz aG91bGQgc3VwcG9ydCB0aGUgQ01ha2UgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNzc0MTczOTljM2E5MzNlMDg0Yjg4M2MxMzMxNDk5 N2I3YTVlOGQxNi4uOTA5Y2VjZDM5Y2Y4MjhhNWYwY2ExZDVkZjIwYzZkOTlmMTg3Y2IxNCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI3MTks NiArMjcxOSwxNSBAQCBkZWYgY2hlY2tfc3R5bGUoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBm aWxlX2V4dGVuc2lvbiwgY2xhc3Nfc3RhdGUsIGZpbGVfc3RhdAogICAgIGNoZWNrX2luZGVudGF0 aW9uX2Ftb3VudChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAgIGNoZWNrX2Vu dW1fY2FzaW5nKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZW51bV9zdGF0ZSwgZXJyb3IpCiAK KyAgICAjICNkZWZpbmVkIGNvbnN0YW50cyBzaG91bGQgdXNlIGFsbCB1cHBlcmNhc2UgbmFtZXMg d2l0aCB3b3JkcyBzZXBhcmF0ZWQgYnkgdW5kZXJzY29yZXMuCisgICAgaWYgbm90IGxpbmUuZW5k c3dpdGgoJ19oJyk6CisgICAgICAgIGRlZmluZV9jaGVjayA9IG1hdGNoKHInI2RlZmluZVxzKD9Q PG5hbWU+W1x3X10rKShccy4qfFxzPykkJywgbGluZSkKKyAgICAgICAgaWYgZGVmaW5lX2NoZWNr OgorICAgICAgICAgICAgbmFtZSA9IGRlZmluZV9jaGVjay5ncm91cCgnbmFtZScpCisgICAgICAg ICAgICBpZiBub3QgbWF0Y2gocideWzAtOUEtWl9dKyQnLCBuYW1lKToKKyAgICAgICAgICAgICAg ICBlcnJvcihsaW5lX251bWJlciwgJ3JlYWRhYmlsaXR5L25hbWluZy9kZWZpbmUvY29uc3RhbnRz JywgNCwKKyAgICAgICAgICAgICAgICAgICAgbmFtZSArICIgaXMgaW5jb3JyZWN0LiAjZGVmaW5l ZCBjb25zdGFudHMgc2hvdWxkIHVzZSBhbGwgdXBwZXJjYXNlIG5hbWVzIHdpdGggd29yZHMgc2Vw YXJhdGVkIGJ5IHVuZGVyc2NvcmVzLiIpCisKIAogX1JFX1BBVFRFUk5fSU5DTFVERV9ORVdfU1RZ TEUgPSByZS5jb21waWxlKHInI2luY2x1ZGUgKyJbXi9dK1wuaCInKQogX1JFX1BBVFRFUk5fSU5D TFVERSA9IHJlLmNvbXBpbGUocideXHMqI1xzKmluY2x1ZGVccyooWzwiXSkoW14+Il0qKVs+Il0u KiQnKQpAQCAtMzcwMyw2ICszNzEyLDcgQEAgY2xhc3MgQ3BwQ2hlY2tlcihvYmplY3QpOgogICAg ICAgICAncmVhZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUnLAogICAgICAgICAncmVhZGFiaWxpdHkv bmFtaW5nJywKICAgICAgICAgJ3JlYWRhYmlsaXR5L25hbWluZy91bmRlcnNjb3JlcycsCisgICAg ICAgICdyZWFkYWJpbGl0eS9uYW1pbmcvZGVmaW5lL2NvbnN0YW50cycsCiAgICAgICAgICdyZWFk YWJpbGl0eS9udWxsJywKICAgICAgICAgJ3JlYWRhYmlsaXR5L3Bhc3NfcHRyJywKICAgICAgICAg J3JlYWRhYmlsaXR5L3N0cmVhbXMnLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBjNGNmMDEwOGY0ZTU4ZjZhMDgz NGUzMjcwMDgxMGQ3ZTk3ZTM4MDMyLi44Zjc4MTNhNTc1MzAzMjY0OTAxM2E3OTI0NjY2YzFiNDhi NzQ3NTI3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weQpAQCAtNTAyNiw2ICs1MDI2LDIwIEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50IHRo aXMuCiAgICAgICAgIHBhc3MKIAorICAgIGRlZiB0ZXN0X2RlZmluZV9jb25zdGFudHMoc2VsZik6 CisgICAgICAgIGJhZF9uYW1lX2Vycm9yID0gIiBpcyBpbmNvcnJlY3QuICNkZWZpbmVkIGNvbnN0 YW50cyBzaG91bGQgdXNlIGFsbCB1cHBlcmNhc2UgbmFtZXMgd2l0aCB3b3JkcyBzZXBhcmF0ZWQg YnkgdW5kZXJzY29yZXMuICBbcmVhZGFiaWxpdHkvbmFtaW5nL2RlZmluZS9jb25zdGFudHNdIFs0 XSIKKworICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIEhlYWRlcl9oJywgJycpCisg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgbG93ZXIxY2FzZScsICdsb3dlcjFjYXNl JyArIGJhZF9uYW1lX2Vycm9yKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIFVQ UEVSMUNBU0UnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBtaXhlZDFD QVNFJywgJ21peGVkMUNBU0UnICsgYmFkX25hbWVfZXJyb3IpCisgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJyNkZWZpbmUgbG93ZXJfMWNhc2UnLCAnbG93ZXJfMWNhc2UnICsgYmFkX25hbWVfZXJy b3IpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgVVBQRVJfMUNBU0UnLCAnJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBtaXhlZF8xQ0FTRScsICdtaXhlZF8x Q0FTRScgKyBiYWRfbmFtZV9lcnJvcikKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmlu ZSBkbG93ZXIxY2FzZSBzb21lKGJsYSknLCAnZGxvd2VyMWNhc2UnICsgYmFkX25hbWVfZXJyb3Ip CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgRFVQUEVSMUNBU0UgZGQoZm9vKScs ICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5lIERtaXhlZDFDQVNFIGRramdo W3NkZl0nLCAnRG1peGVkMUNBU0UnICsgYmFkX25hbWVfZXJyb3IpCisKIAogY2xhc3MgQ3BwQ2hl Y2tlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCg==