126053 2013-12-19 22:08:29 -0800 Add a test for reattaching collapsed whitespace when siblings change style 2013-12-24 00:08:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa enrica kling koivisto mmaxfield oldest_to_newest 961741 0 rniwa 2013-12-19 22:08:29 -0800 Merge the test from https://chromium.googlesource.com/chromium/blink/+/dd5636728643ff958aebeaf064d38754b0d5904b so that we may not introduce the same regression in WebKit. 961742 1 219730 rniwa 2013-12-19 22:11:32 -0800 Created attachment 219730 Adds the test 962159 2 219730 mitz 2013-12-20 18:36:01 -0800 Comment on attachment 219730 Adds the test View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review > LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31 > + shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400"); Is there a way to write this 400 as “more than half the width of ” something? 962728 3 rniwa 2013-12-24 00:07:46 -0800 (In reply to comment #2) > (From update of attachment 219730 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review > > > LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31 > > + shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400"); > > Is there a way to write this 400 as “more than half the width of ” something? Replaced it with container.offsetWidth * 2 / 3. 962729 4 rniwa 2013-12-24 00:08:10 -0800 Committed r161052: <http://trac.webkit.org/changeset/161052> 219730 2013-12-19 22:11:32 -0800 2013-12-20 18:36:01 -0800 Adds the test bug-126053-20131219221131.patch text/plain 2930 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MDg5NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTE5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIHJlYXR0YWNoaW5nIGNv bGxhcHNlZCB3aGl0ZXNwYWNlIHdoZW4gc2libGluZ3MgY2hhbmdlIHN0eWxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYwNTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSB0aGUgdGVzdCBmcm9t IGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rL2RkNTYz NjcyODY0M2ZmOTU4YWViZWFmMDY0ZDM4NzU0YjBkNTkwNGIKKyAgICAgICAgc28gdGhhdCB3ZSBt YXkgbm90IGludHJvZHVjZSB0aGUgc2FtZSByZWdyZXNzaW9uIGluIFdlYktpdC4KKworICAgICAg ICAqIGZhc3QvY3NzL2NvbGxhcHNlZC13aGl0ZXNwYWNlLXJlYXR0YWNoLWluLXN0eWxlLXJlY2Fs Yy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2NvbGxhcHNlZC13aGl0 ZXNwYWNlLXJlYXR0YWNoLWluLXN0eWxlLXJlY2FsYy5odG1sOiBBZGRlZC4KKwogMjAxMy0xMi0x OSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxNjA4NDcpOiBmYXN0L2V2ZW50cy9vdmVyZmxvd2NoYW5nZWQtaW5zaWRlLXNlbGVjdGlvbi1j b2xsYXBzZS1jcmFzaC5odG1sIGZhaWxzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb2xs YXBzZWQtd2hpdGVzcGFjZS1yZWF0dGFjaC1pbi1zdHlsZS1yZWNhbGMtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2NvbGxhcHNlZC13aGl0ZXNwYWNlLXJl YXR0YWNoLWluLXN0eWxlLXJlY2FsYy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2Nzcy9jb2xsYXBzZWQtd2hpdGVzcGFjZS1yZWF0dGFjaC1pbi1zdHlsZS1y ZWNhbGMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0 ZXN0IGVuc3VyZXMgdGhhdCB3ZSBwcm9wZXJseSByZWF0dGFjaCBjb2xsYXBzZWQgd2hpdGVzcGFj ZSB3aGVuIHNpYmxpbmcgc3R5bGUgY2hhbmdlcyByZXF1aXJlLiBUZXN0IHBhc3NlcyBpZiB0aGUg c3BhbnMgYmVsb3cgYXJlIGp1c3RpZmllZCBhY3Jvc3MgdGhlIHBhZ2UuCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitQQVNTCisgc3BhbnNbc3BhbnMubGVuZ3RoIC0gMV0ub2Zmc2V0 TGVmdCBpcyA+PSA0MDAKKworCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb2xsYXBzZWQt d2hpdGVzcGFjZS1yZWF0dGFjaC1pbi1zdHlsZS1yZWNhbGMuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2Nzcy9jb2xsYXBzZWQtd2hpdGVzcGFjZS1yZWF0dGFjaC1pbi1zdHls ZS1yZWNhbGMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2NvbGxh cHNlZC13aGl0ZXNwYWNlLXJlYXR0YWNoLWluLXN0eWxlLXJlY2FsYy5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC0wLDAgKzEsNDMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxz dHlsZT4KK2RpdiB7CisgICAgdGV4dC1hbGlnbjoganVzdGlmeTsKK30KKworLmlubGluZUJsb2Nr IHsKKyAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Cit9CisKK3NwYW4geworICAgIGRpc3BsYXk6 IGJsb2NrOworfQorCitkaXY6YWZ0ZXIgeworICAgIGNvbnRlbnQ6ICcnOworICAgIGRpc3BsYXk6 IGlubGluZS1ibG9jazsKKyAgICB3aWR0aDogMTAwJTsKK30KKworPC9zdHlsZT4KKzxzY3JpcHQg c3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4K K2Rlc2NyaXB0aW9uKCdUaGlzIHRlc3QgZW5zdXJlcyB0aGF0IHdlIHByb3Blcmx5IHJlYXR0YWNo IGNvbGxhcHNlZCB3aGl0ZXNwYWNlIHdoZW4gc2libGluZyBzdHlsZSBjaGFuZ2VzIHJlcXVpcmUu IFRlc3QgcGFzc2VzIGlmIHRoZSBzcGFucyBiZWxvdyBhcmUganVzdGlmaWVkIGFjcm9zcyB0aGUg cGFnZS4nKTsKK29ubG9hZCA9IGZ1bmN0aW9uKCkgeworICAgIHNwYW5zID0gZG9jdW1lbnQuZ2V0 RWxlbWVudHNCeVRhZ05hbWUoInNwYW4iKTsKKyAgICBmb3IgKHZhciBpID0gc3BhbnMubGVuZ3Ro IC0gMTsgaSA+PSAwOyBpLS0pCisgICAgICAgIHNwYW5zW2ldLmNsYXNzTGlzdC5hZGQoJ2lubGlu ZUJsb2NrJyk7CisgICAgc2hvdWxkQmVHcmVhdGVyVGhhbk9yRXF1YWwoJ3NwYW5zW3NwYW5zLmxl bmd0aCAtIDFdLm9mZnNldExlZnQnLCAiNDAwIik7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2NvbnRhaW5lcicpLnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7Cit9Cis8L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICA8c3Bhbj5JdGVtIDE8L3Nw YW4+CisgICAgPHNwYW4+SXRlbSAyPC9zcGFuPgorICAgIDxzcGFuPkl0ZW0gMzwvc3Bhbj4KKzwv ZGl2PgorPC9ib2R5PgorPC9odG1sPgo=