<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126052</bug_id>
          
          <creation_ts>2013-12-19 21:55:26 -0800</creation_ts>
          <short_desc>Avoid checking adjacent rules when doing a Force recalc or if no children changed</short_desc>
          <delta_ts>2013-12-19 22:15:47 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>961739</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-12-19 21:55:26 -0800</bug_when>
    <thetext>Consider merging https://chromium.googlesource.com/chromium/blink/+/2e53720ae89d22d963aae65fe2de1d4d82cbf3c2

Iterating the children is a waste if we&apos;re already going to recalc
everyone like in a Force situation or if we know that no children
needStyleRecalc(). We should skip all the checking in these cases.

I also refactored the loop into checkForChildrenAdjacentRuleChanges()
since recalcChildStyle was getting too long.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>961743</commentid>
    <comment_count>1</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-12-19 22:15:47 -0800</bug_when>
    <thetext>Also see https://chromium.googlesource.com/chromium/blink/+/f35b2c4dcecf6fbe803bd8369a1ddd63a3609da2</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>