<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126049</bug_id>
          
          <creation_ts>2013-12-19 21:47:01 -0800</creation_ts>
          <short_desc>Remove a significant source of memory allocations during CSS parsing</short_desc>
          <delta_ts>2016-04-29 09:20:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>140599</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>joepeck</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>961732</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-12-19 21:47:01 -0800</bug_when>
    <thetext>Consider merging https://chromium.googlesource.com/chromium/blink/+/3d1744e53a3540be9bdb385deadec60469e6019c
or come up with a similar improvement

This is about +2% on Parser/css-parser-yui.html locally.

Previously, we were allocating and freeing small vector buffers (most commonly
24 or 72 byte allocations on 64-bit), only to immediately throw them away.

Note that uncheckedAppend has an ASSERT that will cleanly catch any future
problems with sizing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1188449</commentid>
    <comment_count>1</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-04-28 17:11:20 -0700</bug_when>
    <thetext>Still worth taking? Seems like a pretty small change, but might be out of date now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1188636</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-04-29 09:20:35 -0700</bug_when>
    <thetext>I don&apos;t believe this is still needed after:
https://bugs.webkit.org/show_bug.cgi?id=140599

*** This bug has been marked as a duplicate of bug 140599 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>