126036 2013-12-19 18:19:51 -0800 CStack: The JIT does not need a slow path stack check 2013-12-19 18:35:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125928 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 961665 0 mark.lam 2013-12-19 18:19:51 -0800 The JIT uses the C stack which is not growable. Hence, by the time we get to the operationStackCheck() helper, a stack overflow is imminent. Redoing the stack check there will achieve nothing. Hence, we'll rename operationStackCheck() to operationThrowStackOverflowError(), and change the JIT code to reflect this reality that a StackOverflowError will be thrown unconditionally when we call this helper. 961666 1 219710 mark.lam 2013-12-19 18:25:02 -0800 Created attachment 219710 the patch. 961670 2 219710 ggaren 2013-12-19 18:31:17 -0800 Comment on attachment 219710 the patch. r=me Once we have a host zone reserved, we should just compare SP to addressOfJSStackLimit. 961671 3 mark.lam 2013-12-19 18:35:29 -0800 Thanks for the review. Landed in r160890: <http://trac.webkit.org/r160890>. 219710 2013-12-19 18:25:02 -0800 2013-12-19 18:31:17 -0800 the patch. bug-126036.patch text/plain 7579 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwODg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTEyLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IFRoZSBKSVQgZG9lcyBub3QgbmVlZCBhIHNsb3cgcGF0aCBzdGFjayBjaGVjay4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAzNi4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgSklUIHVz ZXMgdGhlIEMgc3RhY2sgd2hpY2ggaXMgbm90IGdyb3dhYmxlLiBJZiB3ZSBmYWlsIGEgc3RhY2sK KyAgICAgICAgY2hlY2sgaW4gdGhlIGZ1bmN0aW9uIGhlYWRlciwgdGhlbiBhIHN0YWNrIG92ZXJm bG93IGlzIGltbWluZW50LCBhbmQKKyAgICAgICAgdGhlcmUncyBubyBuZWVkIHRvIHJlZG8gdGhl IGNoZWNrIGluIHRoZSBzbG93IHBhdGggaGVscGVyLgorCisgICAgICAgIEhlbmNlLCByZW5hbWVk IG9wZXJhdGlvblN0YWNrQ2hlY2soKSB0byBvcGVyYXRpb25UaHJvd1N0YWNrT3ZlcmZsb3dFcnJv cigpCisgICAgICAgIGFuZCBjaGFuZ2UgdGhlIEpJVCBhbmQgREZHIGNvZGUgdG8gdXNlIHRoaXMg YXBwcm9wcmlhdGVseS4KKworICAgICAgICAqIGRmZy9ERkdKSVRDb21waWxlci5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6SklUQ29tcGlsZXI6OmNvbXBpbGVGdW5jdGlvbik6CisgICAgICAgICog aml0L0pJVC5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6cHJpdmF0ZUNvbXBpbGUpOgorICAgICAg ICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5o OgorCiAyMDEzLTEyLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAg ICAgICAgIENTdGFjayBCcmFuY2g6IEZpeCBjYWxsIG9wZXJhdGlvblN0YWNrQ2hlY2sgdG8gY2hl Y2sgdGhlIHByb3BlciBzdGFjawpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdK SVRDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdKSVRDb21waWxlci5jcHAJKHJldmlzaW9uIDE2MDg4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjcsOSArMzI3 LDcgQEAgdm9pZCBKSVRDb21waWxlcjo6Y29tcGlsZUZ1bmN0aW9uKCkKICAgICBMYWJlbCBmcm9t QXJpdHlDaGVjayh0aGlzKTsKICAgICAvLyBQbGFudCBhIGNoZWNrIHRoYXQgc3VmZmljaWVudCBz cGFjZSBpcyBhdmFpbGFibGUgaW4gdGhlIEpTU3RhY2suCiAgICAgYWRkUHRyKFRydXN0ZWRJbW0z Mih2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbChtX2dyYXBoLnJlcXVpcmVkUmVnaXN0ZXJDb3VudEZv ckV4ZWN1dGlvbkFuZEV4aXQoKSAtIDEpLm9mZnNldCgpICogc2l6ZW9mKFJlZ2lzdGVyKSksIEdQ UkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBHUFJJbmZvOjpyZWdUMSk7Ci0gICAgSnVtcCBzdGFj a0NoZWNrID0gYnJhbmNoUHRyKEFib3ZlLCBBYnNvbHV0ZUFkZHJlc3MobV92bS0+YWRkcmVzc09m SlNTdGFja0xpbWl0KCkpLCBHUFJJbmZvOjpyZWdUMSk7Ci0gICAgLy8gUmV0dXJuIGhlcmUgYWZ0 ZXIgc3RhY2sgY2hlY2suCi0gICAgTGFiZWwgZnJvbVN0YWNrQ2hlY2sgPSBsYWJlbCgpOworICAg IEp1bXAgc3RhY2tPdmVyZmxvdyA9IGJyYW5jaFB0cihBYm92ZSwgQWJzb2x1dGVBZGRyZXNzKG1f dm0tPmFkZHJlc3NPZkpTU3RhY2tMaW1pdCgpKSwgR1BSSW5mbzo6cmVnVDEpOwogCiAgICAgY2hl Y2tTdGFja1BvaW50ZXJBbGlnbm1lbnQoKTsKIApAQCAtMzQ0LDE3ICszNDIsMTUgQEAgdm9pZCBK SVRDb21waWxlcjo6Y29tcGlsZUZ1bmN0aW9uKCkKIAogICAgIC8vID09PSBGdW5jdGlvbiBmb290 ZXIgY29kZSBnZW5lcmF0aW9uID09PQogICAgIC8vCi0gICAgLy8gR2VuZXJhdGUgY29kZSB0byBw ZXJmb3JtIHRoZSBzbG93IHN0YWNrIGNoZWNrIChpZiB0aGUgZmFzdCBvbmUgaW4KKyAgICAvLyBH ZW5lcmF0ZSBjb2RlIHRvIHBlcmZvcm0gdGhlIHN0YWNrIG92ZXJmbG93IGhhbmRsaW5nIChpZiB0 aGUgc3RhY2sgY2hlY2sgaW4KICAgICAvLyB0aGUgZnVuY3Rpb24gaGVhZGVyIGZhaWxzKSwgYW5k IGdlbmVyYXRlIHRoZSBlbnRyeSBwb2ludCB3aXRoIGFyaXR5IGNoZWNrLgogICAgIC8vCi0gICAg Ly8gR2VuZXJhdGUgdGhlIHN0YWNrIGNoZWNrOyBpZiB0aGUgZmFzdCBjaGVjayBpbiB0aGUgZnVu Y3Rpb24gaGVhZCBmYWlscywKLSAgICAvLyB3ZSBuZWVkIHRvIGNhbGwgb3V0IHRvIGEgaGVscGVy IGZ1bmN0aW9uIHRvIGNoZWNrIHdoZXRoZXIgbW9yZSBzcGFjZSBpcyBhdmFpbGFibGUuCi0gICAg Ly8gRklYTUU6IGNoYW5nZSB0aGlzIGZyb20gYSBjdGkgY2FsbCB0byBhIERGRyBzdHlsZSBvcGVy YXRpb24gKG5vcm1hbCBDIGNhbGxpbmcgY29udmVudGlvbnMpLgotICAgIHN0YWNrQ2hlY2subGlu ayh0aGlzKTsKKyAgICAvLyBHZW5lcmF0ZSB0aGUgc3RhY2sgb3ZlcmZsb3cgaGFuZGxpbmc7IGlm IHRoZSBzdGFjayBjaGVjayBpbiB0aGUgZnVuY3Rpb24gaGVhZCBmYWlscywKKyAgICAvLyB3ZSBu ZWVkIHRvIGNhbGwgb3V0IHRvIGEgaGVscGVyIGZ1bmN0aW9uIHRvIHRocm93IHRoZSBTdGFja092 ZXJmbG93RXJyb3IuCisgICAgc3RhY2tPdmVyZmxvdy5saW5rKHRoaXMpOwogCiAgICAgZW1pdFN0 b3JlQ29kZU9yaWdpbihDb2RlT3JpZ2luKDApKTsKLSAgICBtX3NwZWN1bGF0aXZlLT5jYWxsT3Bl cmF0aW9uV2l0aENhbGxGcmFtZVJvbGxiYWNrT25FeGNlcHRpb24ob3BlcmF0aW9uU3RhY2tDaGVj aywgbV9jb2RlQmxvY2spOwotICAgIGp1bXAoZnJvbVN0YWNrQ2hlY2spOworICAgIG1fc3BlY3Vs YXRpdmUtPmNhbGxPcGVyYXRpb25XaXRoQ2FsbEZyYW1lUm9sbGJhY2tPbkV4Y2VwdGlvbihvcGVy YXRpb25UaHJvd1N0YWNrT3ZlcmZsb3dFcnJvciwgbV9jb2RlQmxvY2spOwogICAgIAogICAgIC8v IFRoZSBmYXN0IGVudHJ5IHBvaW50IGludG8gYSBmdW5jdGlvbiBkb2VzIG5vdCBjaGVjayB0aGUg Y29ycmVjdCBudW1iZXIgb2YgYXJndW1lbnRzCiAgICAgLy8gaGF2ZSBiZWVuIHBhc3NlZCB0byB0 aGUgY2FsbCAod2Ugb25seSB1c2UgdGhlIGZhc3QgZW50cnkgcG9pbnQgd2hlcmUgd2UgY2FuIHN0 YXRpY2FsbHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAJKHJldmlzaW9uIDE2MDg4 MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTE5LDcgKzUxOSw3IEBAIENvbXBpbGF0aW9uUmVzdWx0IEpJVDo6cHJpdmF0ZUNvbXBpbGUo SkkKICAgICBzYW1wbGVJbnN0cnVjdGlvbihtX2NvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKCkuYmVn aW4oKSk7CiAjZW5kaWYKIAotICAgIEp1bXAgc3RhY2tDaGVjazsKKyAgICBKdW1wIHN0YWNrT3Zl cmZsb3c7CiAgICAgaWYgKG1fY29kZUJsb2NrLT5jb2RlVHlwZSgpID09IEZ1bmN0aW9uQ29kZSkg ewogI2lmIEVOQUJMRShWQUxVRV9QUk9GSUxFUikKICAgICAgICAgQVNTRVJUKG1fYnl0ZWNvZGVP ZmZzZXQgPT0gKHVuc2lnbmVkKS0xKTsKQEAgLTU0MiwxMSArNTQyLDkgQEAgQ29tcGlsYXRpb25S ZXN1bHQgSklUOjpwcml2YXRlQ29tcGlsZShKSQogI2VuZGlmCiAKICAgICAgICAgYWRkUHRyKFRy dXN0ZWRJbW0zMihzdGFja1BvaW50ZXJPZmZzZXRGb3IobV9jb2RlQmxvY2spICogc2l6ZW9mKFJl Z2lzdGVyKSksIGNhbGxGcmFtZVJlZ2lzdGVyLCByZWdUMSk7Ci0gICAgICAgIHN0YWNrQ2hlY2sg PSBicmFuY2hQdHIoQWJvdmUsIEFic29sdXRlQWRkcmVzcyhtX3ZtLT5hZGRyZXNzT2ZKU1N0YWNr TGltaXQoKSksIHJlZ1QxKTsKKyAgICAgICAgc3RhY2tPdmVyZmxvdyA9IGJyYW5jaFB0cihBYm92 ZSwgQWJzb2x1dGVBZGRyZXNzKG1fdm0tPmFkZHJlc3NPZkpTU3RhY2tMaW1pdCgpKSwgcmVnVDEp OwogICAgIH0KIAotICAgIExhYmVsIGZ1bmN0aW9uQm9keSA9IGxhYmVsKCk7Ci0KICAgICBjaGVj a1N0YWNrUG9pbnRlckFsaWdubWVudCgpOwogICAgIGFkZFB0cihUcnVzdGVkSW1tMzIoc3RhY2tQ b2ludGVyT2Zmc2V0Rm9yKG1fY29kZUJsb2NrKSAqIHNpemVvZihSZWdpc3RlcikpLCBjYWxsRnJh bWVSZWdpc3Rlciwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOwogICAgIGNoZWNrU3RhY2tQb2ludGVy QWxpZ25tZW50KCk7CkBAIC01NjAsMTQgKzU1OCw5IEBAIENvbXBpbGF0aW9uUmVzdWx0IEpJVDo6 cHJpdmF0ZUNvbXBpbGUoSkkKIAogICAgIExhYmVsIGFyaXR5Q2hlY2s7CiAgICAgaWYgKG1fY29k ZUJsb2NrLT5jb2RlVHlwZSgpID09IEZ1bmN0aW9uQ29kZSkgewotICAgICAgICBzdGFja0NoZWNr LmxpbmsodGhpcyk7CisgICAgICAgIHN0YWNrT3ZlcmZsb3cubGluayh0aGlzKTsKICAgICAgICAg bV9ieXRlY29kZU9mZnNldCA9IDA7Ci0gICAgICAgIC8vIEZJWE1FOiBDU3RhY2sgLSBUaGlzIG1h eSBuZWVkIHRvIGhhdmUgc29tZSBzdGFjayBzcGFjZSBhbGxvY2F0ZWQgdG8gbWFrZSB0aGUgY2Fs bAotICAgICAgICBjYWxsT3BlcmF0aW9uV2l0aENhbGxGcmFtZVJvbGxiYWNrT25FeGNlcHRpb24o b3BlcmF0aW9uU3RhY2tDaGVjaywgbV9jb2RlQmxvY2spOwotI2lmbmRlZiBOREVCVUcKLSAgICAg ICAgbV9ieXRlY29kZU9mZnNldCA9ICh1bnNpZ25lZCktMTsgLy8gUmVzZXQgdGhpcywgaW4gb3Jk ZXIgdG8gZ3VhcmQgaXRzIHVzZSB3aXRoIEFTU0VSVHMuCi0jZW5kaWYKLSAgICAgICAganVtcChm dW5jdGlvbkJvZHkpOworICAgICAgICBjYWxsT3BlcmF0aW9uV2l0aENhbGxGcmFtZVJvbGxiYWNr T25FeGNlcHRpb24ob3BlcmF0aW9uVGhyb3dTdGFja092ZXJmbG93RXJyb3IsIG1fY29kZUJsb2Nr KTsKIAogICAgICAgICBhcml0eUNoZWNrID0gbGFiZWwoKTsKICAgICAgICAgc3RvcmU4KFRydXN0 ZWRJbW0zMigwKSwgJm1fY29kZUJsb2NrLT5tX3Nob3VsZEFsd2F5c0JlSW5saW5lZCk7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAJKHJldmlzaW9u IDE2MDg4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcwLDcgQEAgdm9pZCAqIF9SZXR1cm5BZGRyZXNzKHZv aWQpOwogI2VuZGlmCiAKIAotdm9pZCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblN0YWNrQ2hlY2so RXhlY1N0YXRlKiBleGVjLCBDb2RlQmxvY2sqIGNvZGVCbG9jaykKK3ZvaWQgSklUX09QRVJBVElP TiBvcGVyYXRpb25UaHJvd1N0YWNrT3ZlcmZsb3dFcnJvcihFeGVjU3RhdGUqIGV4ZWMsIENvZGVC bG9jayogY29kZUJsb2NrKQogewogICAgIC8vIFdlIHBhc3MgaW4gb3VyIG93biBjb2RlIGJsb2Nr LCBiZWNhdXNlIHRoZSBjYWxsZnJhbWUgaGFzbid0IGJlZW4gcG9wdWxhdGVkLgogICAgIFZNKiB2 bSA9IGNvZGVCbG9jay0+dm0oKTsKQEAgLTc5LDE2ICs3OSw3IEBAIHZvaWQgSklUX09QRVJBVElP TiBvcGVyYXRpb25TdGFja0NoZWNrKEUKICAgICAgICAgY2FsbGVyRnJhbWUgPSBleGVjOwogCiAg ICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgY2FsbGVyRnJhbWUpOwotCi0jaWYg RU5BQkxFKExMSU5UX0NMT09QKQotICAgIEpTU3RhY2smIHN0YWNrID0gdm0tPmludGVycHJldGVy LT5zdGFjaygpOwotCi0gICAgaWYgKFVOTElLRUxZKCFzdGFjay5ncm93KCZleGVjLT5yZWdpc3Rl cnMoKVtjb2RlQmxvY2stPnN0YWNrUG9pbnRlck9mZnNldCgpXSkpKQotICAgICAgICB2bS0+dGhy b3dFeGNlcHRpb24oY2FsbGVyRnJhbWUsIGNyZWF0ZVN0YWNrT3ZlcmZsb3dFcnJvcihjYWxsZXJG cmFtZSkpOwotI2Vsc2UKLSAgICBpZiAoIWV4ZWMtPnZtKCkuaXNTYWZlVG9SZWN1cnNlKGNvZGVC bG9jay0+ZnJhbWVSZWdpc3RlckNvdW50KCkgKiBzaXplb2YoUmVnaXN0ZXIpKSkKLSAgICAgICAg dm0tPnRocm93RXhjZXB0aW9uKGNhbGxlckZyYW1lLCBjcmVhdGVTdGFja092ZXJmbG93RXJyb3Io Y2FsbGVyRnJhbWUpKTsKLSNlbmRpZiAvLyBFTkFCTEUoTExJTlRfQ0xPT1ApCisgICAgdm0tPnRo cm93RXhjZXB0aW9uKGNhbGxlckZyYW1lLCBjcmVhdGVTdGFja092ZXJmbG93RXJyb3IoY2FsbGVy RnJhbWUpKTsKIH0KIAogaW50MzJfdCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNhbGxBcml0eUNo ZWNrKEV4ZWNTdGF0ZSogZXhlYykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3BlcmF0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3BlcmF0aW9ucy5oCShyZXZpc2lvbiAxNjA4ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0pJVE9wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTg3LDcgKzE4Nyw3IEBAIHR5 cGVkZWYgSlNTdHJpbmcqIEpJVF9PUEVSQVRJT04gKCpKc3NfSkkKIHZvaWQgSklUX09QRVJBVElP TiBsb29rdXBFeGNlcHRpb25IYW5kbGVyKEV4ZWNTdGF0ZSopIFdURl9JTlRFUk5BTDsKIHZvaWQg SklUX09QRVJBVElPTiBvcGVyYXRpb25WTUhhbmRsZUV4Y2VwdGlvbihFeGVjU3RhdGUqKSBXVEZf SU5URVJOQUw7CiAKLXZvaWQgSklUX09QRVJBVElPTiBvcGVyYXRpb25TdGFja0NoZWNrKEV4ZWNT dGF0ZSosIENvZGVCbG9jayopIFdURl9JTlRFUk5BTDsKK3ZvaWQgSklUX09QRVJBVElPTiBvcGVy YXRpb25UaHJvd1N0YWNrT3ZlcmZsb3dFcnJvcihFeGVjU3RhdGUqLCBDb2RlQmxvY2sqKSBXVEZf SU5URVJOQUw7CiBpbnQzMl90IEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uQ2FsbEFyaXR5Q2hlY2so RXhlY1N0YXRlKikgV1RGX0lOVEVSTkFMOwogaW50MzJfdCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlv bkNvbnN0cnVjdEFyaXR5Q2hlY2soRXhlY1N0YXRlKikgV1RGX0lOVEVSTkFMOwogRW5jb2RlZEpT VmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZXRCeUlkKEV4ZWNTdGF0ZSosIFN0cnVjdHVy ZVN0dWJJbmZvKiwgRW5jb2RlZEpTVmFsdWUsIFN0cmluZ0ltcGwqKSBXVEZfSU5URVJOQUw7Cg==