126032 2013-12-19 17:03:45 -0800 Revise WebGL DataView test to match ECMAScript Draft Specification 2014-01-10 08:54:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED WONTFIX InRadar P2 Normal --- 126475 1 bfulgham bfulgham bfulgham commit-queue dino fpizlo oliver oldest_to_newest 961644 0 bfulgham 2013-12-19 17:03:45 -0800 Although the original WebGL specification declared the following syntax illegal: // Use try/catch instead of calling shouldThrow to avoid different exception message being reported from different platform. try { expr = DataView(new ArrayBuffer); TestEval(expr); testFailed(expr + " does not throw exception"); } catch (e) { testPassed(expr + " threw exception"); } ... this was later superseded by the language in the ECMAScript 6 Draft Specification, which allows DataView to be used as a function returning a constructed DataView object (see http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts for the current draft). See http://people.mozilla.org/~jorendorff/es6-draft.html#sec-dataview-constructor for an HTML version of the document. 961645 1 bfulgham 2013-12-19 17:06:14 -0800 Specific language: "The DataView constructor is the %DataView% intrinsic object and the initial value of the DataView property of the global object. When DataView is called as a function rather than as a constructor, it initialises its this value with the internal state necessary to support the DataView.prototype internal methods." 961648 2 219708 bfulgham 2013-12-19 17:11:06 -0800 Created attachment 219708 Patch 961653 3 bfulgham 2013-12-19 17:18:34 -0800 <rdar://problem/15201835> 964183 4 219708 dino 2014-01-03 11:03:48 -0800 Comment on attachment 219708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219708&action=review > LayoutTests/ChangeLog:6 > + Revise WebGL DataView test to match ECMAScript Draft Specification > + https://bugs.webkit.org/show_bug.cgi?id=126032 > + > + Reviewed by NOBODY (OOPS!). Could you note here that we believe this is a bug in the test, and we'll try to get it fixed upstream? 964204 5 bfulgham 2014-01-03 11:43:43 -0800 (In reply to comment #4) > (From update of attachment 219708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219708&action=review > > > LayoutTests/ChangeLog:6 > > + Revise WebGL DataView test to match ECMAScript Draft Specification > > + https://bugs.webkit.org/show_bug.cgi?id=126032 > > + > > + Reviewed by NOBODY (OOPS!). > > Could you note here that we believe this is a bug in the test, and we'll try to get it fixed upstream? Done! 964205 6 bfulgham 2014-01-03 11:43:51 -0800 Committed r161274: <http://trac.webkit.org/changeset/161274> 964305 7 dino 2014-01-03 16:06:07 -0800 After more discussion with EMCA folk, it looks like this was an incorrect change. 964335 8 commit-queue 2014-01-03 17:12:57 -0800 Re-opened since this is blocked by bug 126475 966383 9 bfulgham 2014-01-10 08:54:50 -0800 After further review, this change is incorrect. We need to modify the behavior of DataView. 219708 2013-12-19 17:11:06 -0800 2014-01-03 11:03:47 -0800 Patch bug-126032-20131219171105.patch text/plain 1552 bfulgham SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MDg3OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTE5ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlzZSBXZWJHTCBEYXRhVmlldyB0ZXN0 IHRvIG1hdGNoIEVDTUFTY3JpcHQgRHJhZnQgU3BlY2lmaWNhdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJnbC8xLjAuMi9yZXNvdXJjZXMv d2ViZ2xfdGVzdF9maWxlcy9jb25mb3JtYW5jZS90eXBlZGFycmF5cy9kYXRhLXZpZXctdGVzdC5o dG1sOiBEbyBub3QKKyAgICAgICAgcHJvaGliaXQgdXNpbmcgRGF0YVZpZXcgYXMgYSBmdW5jdGlv bi4KKwogMjAxMy0xMi0xOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIERPTSBiaW5kaW5ncyBzaG91bGQgdXNlIHRoaXNWYWx1ZSBmb3IgYXR0cmlidXRlcwpJbmRl eDogTGF5b3V0VGVzdHMvd2ViZ2wvMS4wLjIvcmVzb3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29u Zm9ybWFuY2UvdHlwZWRhcnJheXMvZGF0YS12aWV3LXRlc3QuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy93ZWJnbC8xLjAuMi9yZXNvdXJjZXMvd2ViZ2xfdGVzdF9maWxlcy9jb25mb3Jt YW5jZS90eXBlZGFycmF5cy9kYXRhLXZpZXctdGVzdC5odG1sCShyZXZpc2lvbiAxNjA4NzUpCisr KyBMYXlvdXRUZXN0cy93ZWJnbC8xLjAuMi9yZXNvdXJjZXMvd2ViZ2xfdGVzdF9maWxlcy9jb25m b3JtYW5jZS90eXBlZGFycmF5cy9kYXRhLXZpZXctdGVzdC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yNzAsOSArMjcwLDkgQEAgZnVuY3Rpb24gcnVuQ29uc3RydWN0b3JUZXN0cygpCiAgICAgLy8g VXNlIHRyeS9jYXRjaCBpbnN0ZWFkIG9mIGNhbGxpbmcgc2hvdWxkVGhyb3cgdG8gYXZvaWQgZGlm ZmVyZW50IGV4Y2VwdGlvbiBtZXNzYWdlIGJlaW5nIHJlcG9ydGVkIGZyb20gZGlmZmVyZW50IHBs YXRmb3JtLgogICAgIHRyeSB7CiAgICAgICAgIFRlc3RFdmFsKGV4cHIpOwotICAgICAgICB0ZXN0 RmFpbGVkKGV4cHIgKyAiIGRvZXMgbm90IHRocm93IGV4Y2VwdGlvbiIpOworICAgICAgICB0ZXN0 UGFzc2VkKGV4cHIgKyAiIGRvZXMgbm90IHRocm93IGV4Y2VwdGlvbiIpOwogICAgIH0gY2F0Y2gg KGUpIHsKLSAgICAgICAgdGVzdFBhc3NlZChleHByICsgIiB0aHJldyBleGNlcHRpb24iKTsKKyAg ICAgICAgdGVzdEZhaWxlZChleHByICsgIiB0aHJldyBleGNlcHRpb24iKTsKICAgICB9CiAKICAg ICBkZWJ1ZygiIik7Cg==