12603 2007-02-04 11:46:44 -0800 A crash when trying to use XPath functions normalize-space() and string-length() 2007-02-07 11:08:19 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P1 Normal --- 1 ap ap oldest_to_newest 27673 0 ap 2007-02-04 11:46:44 -0800 That's the punishment for using a manually written tokenizer! 27671 1 12921 ap 2007-02-04 11:48:02 -0800 Created attachment 12921 test case This test is also used for bug 12602 (with two offending cases commented out). 26114 2 mjs 2007-02-06 23:25:23 -0800 <rdar://problem/4980996> 24905 3 ap 2007-02-07 10:43:51 -0800 Actually, the tokenizer is OK - it's just another problem with implicit arguments in these functions (and in number()). 24907 4 13011 ap 2007-02-07 10:52:07 -0800 Created attachment 13011 proposed fix 24908 5 mitz 2007-02-07 10:56:00 -0800 Per the style guidelines, + if (argCount() == 0) should be rewritten as + if (!argCount()) 24909 6 13011 darin 2007-02-07 11:02:19 -0800 Comment on attachment 13011 proposed fix r=me 24910 7 ap 2007-02-07 11:08:19 -0800 Committed revision 19467. (In reply to comment #5) > Per the style guidelines, Fixed here and in several other places in the file. /me stabs this guideline. 12921 2007-02-04 11:48:02 -0800 2007-02-04 11:48:02 -0800 test case implicit-node-args.html text/html 875 ap PGh0bWw+CiAgPGJvZHk+CiAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5Om5vbmUiPjEyMzwvZGl2Pgog ICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Ij5idWcgPC9hPjoKICAgIDwvcD4KICAgIDxzY3JpcHQ+CiAgICAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOwoKCiAgICAgICAgdmFyIHRlc3RzID0gWwogICAgICAgICAgICAgICIvL2Rp dltzdHJpbmcoKSA9ICcxMjMnXSIKICAgICAgICAgICAgLCAiLy9kaXZbbm9ybWFsaXplLXNwYWNl KCkgPSAnMTIzJ10iCiAgICAgICAgICAgICwgIi8vZGl2W3N0cmluZy1sZW5ndGgoKSA9IDNdIgog ICAgICAgIF07CgogICAgICAgIHdoaWxlICh0ZXN0ID0gdGVzdHMucG9wKCkpIHsKICAgICAgICAg ICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmV2YWx1YXRlKHRlc3QsIGRvY3VtZW50LmRvY3VtZW50 RWxlbWVudCwgbnVsbCwgWFBhdGhSZXN1bHQuT1JERVJFRF9OT0RFX1NOQVBTSE9UX1RZUEUsIG51 bGwpOwogICAgICAgICAgICBpZiAocmVzdWx0LnNuYXBzaG90TGVuZ3RoID09IDEpCiAgICAgICAg ICAgICAgICBkb2N1bWVudC53cml0ZSgiPHByZT4iICsgdGVzdCArICI6IFNVQ0NFU1M8L3ByZT4i KTsKICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgZG9jdW1lbnQud3JpdGUoIjxwcmU+ IiArIHRlc3QgKyAiOiBGQUlMVVJFLiAiICsgcmVzdWx0LnNuYXBzaG90TGVuZ3RoICsgIiBub2Rl KHMpIG1hdGNoZWQgLSBzaG91bGQgYmUgMTwvcHJlPiIpOwogICAgICAgIH0KICAgIDwvc2NyaXB0 PgogIDwvYm9keT4KPC9odG1sPgo= 13011 2007-02-07 10:52:07 -0800 2007-02-07 11:02:19 -0800 proposed fix 12603r1_patch.txt text/plain 5365 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5NDY2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDItMDcgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAz CisgICAgICAgIEEgY3Jhc2ggd2hlbiB0cnlpbmcgdG8gdXNlIFhQYXRoIGZ1bmN0aW9ucyBub3Jt YWxpemUtc3BhY2UoKSwgc3RyaW5nLWxlbmd0aCgpIGFuZCBudW1iZXIoKQorCisgICAgICAgICog ZmFzdC94cGF0aC9pbXBsaWNpdC1ub2RlLWFyZ3MtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZh c3QveHBhdGgvaW1wbGljaXQtbm9kZS1hcmdzLmh0bWw6IFVuY29tbWVudGVkIGNhc2VzIHRoYXQg dXNlZCB0byBjcmFzaCBhbmQgYWRkZWQgYSBjYXNlIGZvciBudW1iZXIoKS4KKwogMjAwNy0wMi0w NiAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IGpvaG4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QveHBhdGgvaW1wbGljaXQtbm9k ZS1hcmdzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3hwYXRo L2ltcGxpY2l0LW5vZGUtYXJncy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE5NDY2KQorKysgTGF5 b3V0VGVzdHMvZmFzdC94cGF0aC9pbXBsaWNpdC1ub2RlLWFyZ3MtZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDQgKzEsNyBAQAogVGVzdCBmb3IgYnVnIDEyNjAyOgogCisvL2Rpdltu dW1iZXIoKSA9IDEyM106IFNVQ0NFU1MKKy8vZGl2W3N0cmluZy1sZW5ndGgoKSA9IDNdOiBTVUND RVNTCisvL2Rpdltub3JtYWxpemUtc3BhY2UoKSA9ICcxMjMnXTogU1VDQ0VTUwogLy9kaXZbc3Ry aW5nKCkgPSAnMTIzJ106IFNVQ0NFU1MKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC94cGF0aC9p bXBsaWNpdC1ub2RlLWFyZ3MuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3hw YXRoL2ltcGxpY2l0LW5vZGUtYXJncy5odG1sCShyZXZpc2lvbiAxOTQ2NikKKysrIExheW91dFRl c3RzL2Zhc3QveHBhdGgvaW1wbGljaXQtbm9kZS1hcmdzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTcsMTEgKzcsMTEgQEAKICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKIAotLy8gVGhl IGNvbW1lbnRlZCBvdXQgY2FzZXMgY2F1c2UgYSBjcmFzaDsgc2VlIDxodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYwMz4uCiAgICAgICAgIHZhciB0ZXN0cyA9IFsKICAg ICAgICAgICAgICAgIi8vZGl2W3N0cmluZygpID0gJzEyMyddIgotLy8gICAgICAgICAgICAsICIv L2Rpdltub3JtYWxpemUtc3BhY2UoKSA9ICcxMjMnXSIKLS8vICAgICAgICAgICAgLCAiLy9kaXZb c3RyaW5nLWxlbmd0aCgpID0gM10iCisgICAgICAgICAgICAgICwgIi8vZGl2W25vcm1hbGl6ZS1z cGFjZSgpID0gJzEyMyddIgorICAgICAgICAgICAgICAsICIvL2RpdltzdHJpbmctbGVuZ3RoKCkg PSAzXSIKKyAgICAgICAgICAgICAgLCAiLy9kaXZbbnVtYmVyKCkgPSAxMjNdIgogICAgICAgICBd OwogCiAgICAgICAgIHdoaWxlICh0ZXN0ID0gdGVzdHMucG9wKCkpIHsKSW5kZXg6IFdlYkNvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTQ2 NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMDctMDItMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAzCisgICAgICAgIEEgY3Jhc2ggd2hlbiB0cnlp bmcgdG8gdXNlIFhQYXRoIGZ1bmN0aW9ucyBub3JtYWxpemUtc3BhY2UoKSwgc3RyaW5nLWxlbmd0 aCgpIGFuZCBudW1iZXIoKQorCisgICAgICAgICogeG1sL1hQYXRoRnVuY3Rpb25zLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlhQYXRoOjpGdW5OdW1iZXI6OmRvRXZhbHVhdGUpOiBJbXBsZW1lbnRl ZCB6ZXJvIHBhcmFtZXRlciBjYXNlLgorICAgICAgICAoV2ViQ29yZTo6WFBhdGg6OkZ1bmN0aW9u TWFwcGluZzo6KTogQ29ycmVjdGVkIGRlc2NyaXB0aW9ucyBvZiB0aGVzZSBmdW5jdGlvbnMsIGFz IHRoZXkKKyAgICAgICAgZG8gYWxsb3cgemVybyBwYXJhbWV0ZXJzLgorICAgICAgICAoV2ViQ29y ZTo6WFBhdGg6OmNyZWF0ZUZ1bmN0aW9uKTogQ29tYmluZWQgdGhlIHR3byBmYWlsdXJlIGNhc2Vz IHRvIGVuc3VyZSB0aGF0IHRoaXMKKyAgICAgICAgZnVuY3Rpb24gbmV2ZXIgcmV0dXJucyAwLgor CiAyMDA3LTAyLTA3ICBaYWNrIFJ1c2luICA8enJ1c2luQHRyb2xsdGVjaC5jb20+CiAKICAgICAg ICAgRml4IGNvbXBpbGF0aW9uCkluZGV4OiBXZWJDb3JlL3htbC9YUGF0aEZ1bmN0aW9ucy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS94bWwvWFBhdGhGdW5jdGlvbnMuY3BwCShyZXZpc2lvbiAx OTQ2NikKKysrIFdlYkNvcmUveG1sL1hQYXRoRnVuY3Rpb25zLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjM1LDYgKzYzNSw4IEBAIGJvb2wgRnVuRmFsc2U6OmlzQ29uc3RhbnQoKSBjb25zdAogCiBW YWx1ZSBGdW5OdW1iZXI6OmRvRXZhbHVhdGUoKSBjb25zdAogeworICAgIGlmIChhcmdDb3VudCgp ID09IDApCisgICAgICAgIHJldHVybiBWYWx1ZShFeHByZXNzaW9uOjpldmFsdWF0aW9uQ29udGV4 dCgpLm5vZGUuZ2V0KCkpLnRvTnVtYmVyKCk7CiAgICAgcmV0dXJuIGFyZygwKS0+ZXZhbHVhdGUo KS50b051bWJlcigpOwogfQogCkBAIC02ODgsMTQgKzY5MCwxNCBAQCBzdGF0aWMgdm9pZCBjcmVh dGVGdW5jdGlvbk1hcCgpCiAgICAgICAgIHsgImxvY2FsLW5hbWUiLCB7ICZjcmVhdGVGdW5Mb2Nh bE5hbWUsIEludGVydmFsKDAsIDEpIH0gfSwKICAgICAgICAgeyAibmFtZSIsIHsgJmNyZWF0ZUZ1 bk5hbWUsIEludGVydmFsKDAsIDEpIH0gfSwKICAgICAgICAgeyAibmFtZXNwYWNlLXVyaSIsIHsg JmNyZWF0ZUZ1bk5hbWVzcGFjZVVSSSwgSW50ZXJ2YWwoMCwgMSkgfSB9LAotICAgICAgICB7ICJu b3JtYWxpemUtc3BhY2UiLCB7ICZjcmVhdGVGdW5Ob3JtYWxpemVTcGFjZSwgMSB9IH0sCisgICAg ICAgIHsgIm5vcm1hbGl6ZS1zcGFjZSIsIHsgJmNyZWF0ZUZ1bk5vcm1hbGl6ZVNwYWNlLCBJbnRl cnZhbCgwLCAxKSB9IH0sCiAgICAgICAgIHsgIm5vdCIsIHsgJmNyZWF0ZUZ1bk5vdCwgMSB9IH0s Ci0gICAgICAgIHsgIm51bWJlciIsIHsgJmNyZWF0ZUZ1bk51bWJlciwgMSB9IH0sCisgICAgICAg IHsgIm51bWJlciIsIHsgJmNyZWF0ZUZ1bk51bWJlciwgSW50ZXJ2YWwoMCwgMSkgfSB9LAogICAg ICAgICB7ICJwb3NpdGlvbiIsIHsgJmNyZWF0ZUZ1blBvc2l0aW9uLCAwIH0gfSwKICAgICAgICAg eyAicm91bmQiLCB7ICZjcmVhdGVGdW5Sb3VuZCwgMSB9IH0sCiAgICAgICAgIHsgInN0YXJ0cy13 aXRoIiwgeyAmY3JlYXRlRnVuU3RhcnRzV2l0aCwgMiB9IH0sCiAgICAgICAgIHsgInN0cmluZyIs IHsgJmNyZWF0ZUZ1blN0cmluZywgSW50ZXJ2YWwoMCwgMSkgfSB9LAotICAgICAgICB7ICJzdHJp bmctbGVuZ3RoIiwgeyAmY3JlYXRlRnVuU3RyaW5nTGVuZ3RoLCAxIH0gfSwKKyAgICAgICAgeyAi c3RyaW5nLWxlbmd0aCIsIHsgJmNyZWF0ZUZ1blN0cmluZ0xlbmd0aCwgSW50ZXJ2YWwoMCwgMSkg fSB9LAogICAgICAgICB7ICJzdWJzdHJpbmciLCB7ICZjcmVhdGVGdW5TdWJzdHJpbmcsIEludGVy dmFsKDIsIDMpIH0gfSwKICAgICAgICAgeyAic3Vic3RyaW5nLWFmdGVyIiwgeyAmY3JlYXRlRnVu U3Vic3RyaW5nQWZ0ZXIsIDIgfSB9LAogICAgICAgICB7ICJzdWJzdHJpbmctYmVmb3JlIiwgeyAm Y3JlYXRlRnVuU3Vic3RyaW5nQmVmb3JlLCAyIH0gfSwKQEAgLTcxNSw3ICs3MTcsMTAgQEAgRnVu Y3Rpb24qIGNyZWF0ZUZ1bmN0aW9uKGNvbnN0IFN0cmluZyYgbgogICAgIGlmICghZnVuY3Rpb25N YXApCiAgICAgICAgIGNyZWF0ZUZ1bmN0aW9uTWFwKCk7CiAKLSAgICBpZiAoIWZ1bmN0aW9uTWFw LT5jb250YWlucyhuYW1lKSkgeworICAgIEhhc2hNYXA8U3RyaW5nLCBGdW5jdGlvblJlYz46Oml0 ZXJhdG9yIGZ1bmN0aW9uTWFwSXRlciA9IGZ1bmN0aW9uTWFwLT5maW5kKG5hbWUpOworICAgIEZ1 bmN0aW9uUmVjKiBmdW5jdGlvblJlYyA9IDA7CisKKyAgICBpZiAoZnVuY3Rpb25NYXBJdGVyID09 IGZ1bmN0aW9uTWFwLT5lbmQoKSB8fCAhKGZ1bmN0aW9uUmVjID0gJmZ1bmN0aW9uTWFwSXRlci0+ c2Vjb25kKS0+YXJncy5jb250YWlucyhhcmdzLnNpemUoKSkpIHsKICAgICAgICAgZGVsZXRlQWxs VmFsdWVzKGFyZ3MpOwogCiAgICAgICAgIC8vIFJldHVybiBhIGR1bW15IGZ1bmN0aW9uIGluc3Rl YWQgb2YgMC4KQEAgLTcyNCwxMyArNzI5LDcgQEAgRnVuY3Rpb24qIGNyZWF0ZUZ1bmN0aW9uKGNv bnN0IFN0cmluZyYgbgogICAgICAgICByZXR1cm4gZnVuY1RydWU7CiAgICAgfQogCi0gICAgRnVu Y3Rpb25SZWMgZnVuY3Rpb25SZWMgPSBmdW5jdGlvbk1hcC0+Z2V0KG5hbWUpOwotICAgIGlmICgh ZnVuY3Rpb25SZWMuYXJncy5jb250YWlucyhhcmdzLnNpemUoKSkpIHsKLSAgICAgICAgZGVsZXRl QWxsVmFsdWVzKGFyZ3MpOwotICAgICAgICByZXR1cm4gMDsKLSAgICB9Ci0KLSAgICBGdW5jdGlv biogZnVuY3Rpb24gPSBmdW5jdGlvblJlYy5mYWN0b3J5Rm4oKTsKKyAgICBGdW5jdGlvbiogZnVu Y3Rpb24gPSBmdW5jdGlvblJlYy0+ZmFjdG9yeUZuKCk7CiAgICAgZnVuY3Rpb24tPnNldEFyZ3Vt ZW50cyhhcmdzKTsKICAgICBmdW5jdGlvbi0+c2V0TmFtZShuYW1lKTsKICAgICByZXR1cm4gZnVu Y3Rpb247Cg==