126026 2013-12-19 16:10:54 -0800 CStack Branch: Fix call operationStackCheck to check the proper stack 2013-12-19 16:36:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 961608 0 msaboff 2013-12-19 16:10:54 -0800 JITOperations::operationStackCheck() always checks the JSStack. It should check the correct stack based on the state of ENABLE(LLINT_CLOOP). 961610 1 219698 msaboff 2013-12-19 16:14:52 -0800 Created attachment 219698 Patch 961612 2 219698 mark.lam 2013-12-19 16:18:16 -0800 Comment on attachment 219698 Patch r=me. This is actually more conservative than it needs to be, it’s good enough for now until JSStack can be refactored to handle the check for both cases (coming soon). 961614 3 msaboff 2013-12-19 16:19:07 -0800 Committed r160871: <http://trac.webkit.org/changeset/160871> 961619 4 219698 ggaren 2013-12-19 16:27:34 -0800 Comment on attachment 219698 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:89 > + if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register))) Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP. 961621 5 msaboff 2013-12-19 16:30:55 -0800 (In reply to comment #4) > (From update of attachment 219698 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review > > > Source/JavaScriptCore/jit/JITOperations.cpp:89 > > + if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register))) > > Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP. I change it. 961624 6 msaboff 2013-12-19 16:36:49 -0800 (In reply to comment #4) > (From update of attachment 219698 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review > > > Source/JavaScriptCore/jit/JITOperations.cpp:89 > > + if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register))) > > Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP. Landed this update in change set r160874: <http://trac.webkit.org/changeset/160874> 219698 2013-12-19 16:14:52 -0800 2013-12-19 16:27:34 -0800 Patch 126026.patch text/plain 1610 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwODcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEyLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IEZpeCBjYWxsIG9wZXJhdGlvblN0YWNrQ2hlY2sgdG8gY2hlY2sg dGhlIHByb3BlciBzdGFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI2MDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hhbmdlZCBvcGVyYXRpb25TdGFja0NoZWNrKCkgdG8gY2hlY2sgdGhlIGFwcHJv cHJpYXRlIHN0YWNrIGJhc2VkIG9uIHRoZQorICAgICAgICBjb21waWxlIGZsYWcgRU5BQkxFKExM SU5UX0NMT09QKS4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKwogMjAxMy0x Mi0xOSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBDU3Rh Y2sgQnJhbmNoOiBGaXggY2FsbCBldmFsIGluIGJhc2VsaW5lIEpJVApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAxNjA4NjcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04MCwxMCArODAsMTUgQEAgdm9pZCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblN0YWNr Q2hlY2soRQogCiAgICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgY2FsbGVyRnJh bWUpOwogCisjaWYgRU5BQkxFKExMSU5UX0NMT09QKQogICAgIEpTU3RhY2smIHN0YWNrID0gdm0t PmludGVycHJldGVyLT5zdGFjaygpOwogCiAgICAgaWYgKFVOTElLRUxZKCFzdGFjay5ncm93KCZl eGVjLT5yZWdpc3RlcnMoKVtjb2RlQmxvY2stPnN0YWNrUG9pbnRlck9mZnNldCgpXSkpKQogICAg ICAgICB2bS0+dGhyb3dFeGNlcHRpb24oY2FsbGVyRnJhbWUsIGNyZWF0ZVN0YWNrT3ZlcmZsb3dF cnJvcihjYWxsZXJGcmFtZSkpOworI2Vsc2UKKyAgICBpZiAoIWV4ZWMtPnZtKCkuaXNTYWZlVG9S ZWN1cnNlKC1jb2RlQmxvY2stPnN0YWNrUG9pbnRlck9mZnNldCgpICogc2l6ZW9mKFJlZ2lzdGVy KSkpCisgICAgICAgIHZtLT50aHJvd0V4Y2VwdGlvbihjYWxsZXJGcmFtZSwgY3JlYXRlU3RhY2tP dmVyZmxvd0Vycm9yKGNhbGxlckZyYW1lKSk7CisjZW5kaWYgLy8gRU5BQkxFKExMSU5UX0NMT09Q KQogfQogCiBpbnQzMl90IEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uQ2FsbEFyaXR5Q2hlY2soRXhl Y1N0YXRlKiBleGVjKQo=