12602 2007-02-04 11:42:54 -0800 XPath functions string(), normalize-space() and string-length() don't work without arguments 2007-02-04 22:16:15 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 12584 1 ap ap oldest_to_newest 27709 0 ap 2007-02-04 11:42:54 -0800 This is another case of Value(bool) ctor being called unexpectedly. I'm really wondering if we should just remove it. 27656 1 12922 ap 2007-02-04 11:59:45 -0800 Created attachment 12922 proposed fix 27627 2 12922 darin 2007-02-04 18:10:29 -0800 Comment on attachment 12922 proposed fix Maybe we should nip this problem in the bud by getting rid of the Value constructor that takes a bool. Instead that one could be private and we could have a named constructor for making Value from a bool, like Value::fromBool(). r=me 27590 3 ap 2007-02-04 22:16:15 -0800 Committed revision 19399. 12922 2007-02-04 11:59:45 -0800 2007-02-04 18:10:29 -0800 proposed fix 12602r1_patch.txt text/plain 4800 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5Mzk1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDItMDQgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAy CisgICAgICAgIFhQYXRoIGZ1bmN0aW9ucyBzdHJpbmcoKSwgbm9ybWFsaXplLXNwYWNlKCkgYW5k IHN0cmluZy1sZW5ndGgoKSBkb24ndCB3b3JrCisgICAgICAgIHdpdGhvdXQgYXJndW1lbnRzCisK KyAgICAgICAgKiBmYXN0L3hwYXRoL2ltcGxpY2l0LW5vZGUtYXJncy1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QveHBhdGgvaW1wbGljaXQtbm9kZS1hcmdzLmh0bWw6IEFkZGVk LgorICAgICAgICBTb21lIGNhc2VzIGluIHRoZSB0ZXN0IGFyZSBjb21tZW50ZWQgb3V0IGZvciBu b3cgZHVlIHRvIGJ1ZyAxMjYwMy4KKwogMjAwNy0wMi0wMyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2Fy ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIExhbmRpbmcgcmVzdWx0cyB0aGF0IEkgdGhpbmsgTWFj aWVqIGludGVuZGVkIHRvIGxhbmQsIHRvIGdldCB0aGUgYnVpbGRib3QKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QveHBhdGgvaW1wbGljaXQtbm9kZS1hcmdzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL2ltcGxpY2l0LW5vZGUtYXJncy1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL2ltcGxpY2l0LW5vZGUt YXJncy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGVzdCBmb3Ig YnVnIDEyNjAyOgorCisvL2RpdltzdHJpbmcoKSA9ICcxMjMnXTogU1VDQ0VTUworCgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L3hwYXRoL2ltcGxpY2l0LW5vZGUtYXJncy1l eHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFp bgpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC94cGF0aC9pbXBsaWNpdC1ub2RlLWFyZ3MuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L3hwYXRoL2ltcGxpY2l0LW5vZGUtYXJncy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZmFzdC94cGF0aC9pbXBsaWNpdC1ub2RlLWFyZ3MuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwyNiBAQAorPGh0bWw+CisgIDxib2R5PgorICAgIDxkaXYgc3R5bGU9ImRpc3Bs YXk6bm9uZSI+MTIzPC9kaXY+CisgICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDIiPmJ1ZyAxMjYwMjwvYT46CisgICAgPC9w PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKy8vIFRo ZSBjb21tZW50ZWQgb3V0IGNhc2VzIGNhdXNlIGEgY3Jhc2g7IHNlZSA8aHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDM+LgorICAgICAgICB2YXIgdGVzdHMgPSBbCisg ICAgICAgICAgICAgICIvL2RpdltzdHJpbmcoKSA9ICcxMjMnXSIKKy8vICAgICAgICAgICAgLCAi Ly9kaXZbbm9ybWFsaXplLXNwYWNlKCkgPSAnMTIzJ10iCisvLyAgICAgICAgICAgICwgIi8vZGl2 W3N0cmluZy1sZW5ndGgoKSA9IDNdIgorICAgICAgICBdOworCisgICAgICAgIHdoaWxlICh0ZXN0 ID0gdGVzdHMucG9wKCkpIHsKKyAgICAgICAgICAgIHZhciByZXN1bHQgPSBkb2N1bWVudC5ldmFs dWF0ZSh0ZXN0LCBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQsIG51bGwsIFhQYXRoUmVzdWx0Lk9S REVSRURfTk9ERV9TTkFQU0hPVF9UWVBFLCBudWxsKTsKKyAgICAgICAgICAgIGlmIChyZXN1bHQu c25hcHNob3RMZW5ndGggPT0gMSkKKyAgICAgICAgICAgICAgICBkb2N1bWVudC53cml0ZSgiPHBy ZT4iICsgdGVzdCArICI6IFNVQ0NFU1M8L3ByZT4iKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICBkb2N1bWVudC53cml0ZSgiPHByZT4iICsgdGVzdCArICI6IEZBSUxVUkUuICIg KyByZXN1bHQuc25hcHNob3RMZW5ndGggKyAiIG5vZGUocykgbWF0Y2hlZCAtIHNob3VsZCBiZSAx PC9wcmU+Iik7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKyAgPC9ib2R5PgorPC9odG1sPgoK UHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC94cGF0aC9pbXBsaWNpdC1ub2Rl LWFyZ3MuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0bWwK CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gMTkzOTUpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE5IEBACisyMDA3LTAyLTA0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYwMgorICAgICAgICBY UGF0aCBmdW5jdGlvbnMgc3RyaW5nKCksIG5vcm1hbGl6ZS1zcGFjZSgpIGFuZCBzdHJpbmctbGVu Z3RoKCkgZG9uJ3Qgd29yaworICAgICAgICB3aXRob3V0IGFyZ3VtZW50cworCisgICAgICAgIFRl c3Q6IGZhc3QveHBhdGgvaW1wbGljaXQtbm9kZS1hcmdzLmh0bWwKKworICAgICAgICAqIHhtbC9Y UGF0aEZ1bmN0aW9ucy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYUGF0aDo6RnVuU3RyaW5nOjpk b0V2YWx1YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlhQYXRoOjpGdW5TdHJpbmdMZW5ndGg6OmRv RXZhbHVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6WFBhdGg6OkZ1bk5vcm1hbGl6ZVNwYWNlOjpk b0V2YWx1YXRlKToKKyAgICAgICAgRG9uJ3QgdHJ5IHRvIHBhc3MgUmVmUHRyPE5vZGU+IHRvIHRo ZSBWYWx1ZSBjdG9yLgorCiAyMDA3LTAyLTA0ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAa2Rl Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBaYWNrLgpJbmRleDogV2ViQ29yZS94bWwvWFBh dGhGdW5jdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUveG1sL1hQYXRoRnVuY3Rpb25z LmNwcAkocmV2aXNpb24gMTkzOTQpCisrKyBXZWJDb3JlL3htbC9YUGF0aEZ1bmN0aW9ucy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ0MCw3ICs0NDAsNyBAQCBib29sIEZ1bkNvdW50Ojppc0NvbnN0 YW50KCkgY29uc3QKIFZhbHVlIEZ1blN0cmluZzo6ZG9FdmFsdWF0ZSgpIGNvbnN0CiB7CiAgICAg aWYgKGFyZ0NvdW50KCkgPT0gMCkKLSAgICAgICAgcmV0dXJuIFZhbHVlKEV4cHJlc3Npb246OmV2 YWx1YXRpb25Db250ZXh0KCkubm9kZSkudG9TdHJpbmcoKTsKKyAgICAgICAgcmV0dXJuIFZhbHVl KEV4cHJlc3Npb246OmV2YWx1YXRpb25Db250ZXh0KCkubm9kZS5nZXQoKSkudG9TdHJpbmcoKTsK ICAgICByZXR1cm4gYXJnKDApLT5ldmFsdWF0ZSgpLnRvU3RyaW5nKCk7CiB9CiAKQEAgLTUzMiwx NCArNTMyLDE0IEBAIFZhbHVlIEZ1blN1YnN0cmluZzo6ZG9FdmFsdWF0ZSgpIGNvbnN0CiBWYWx1 ZSBGdW5TdHJpbmdMZW5ndGg6OmRvRXZhbHVhdGUoKSBjb25zdAogewogICAgIGlmIChhcmdDb3Vu dCgpID09IDApCi0gICAgICAgIHJldHVybiBWYWx1ZShFeHByZXNzaW9uOjpldmFsdWF0aW9uQ29u dGV4dCgpLm5vZGUpLnRvU3RyaW5nKCkubGVuZ3RoKCk7CisgICAgICAgIHJldHVybiBWYWx1ZShF eHByZXNzaW9uOjpldmFsdWF0aW9uQ29udGV4dCgpLm5vZGUuZ2V0KCkpLnRvU3RyaW5nKCkubGVu Z3RoKCk7CiAgICAgcmV0dXJuIGFyZygwKS0+ZXZhbHVhdGUoKS50b1N0cmluZygpLmxlbmd0aCgp OwogfQogCiBWYWx1ZSBGdW5Ob3JtYWxpemVTcGFjZTo6ZG9FdmFsdWF0ZSgpIGNvbnN0CiB7CiAg ICAgaWYgKGFyZ0NvdW50KCkgPT0gMCkgewotICAgICAgICBTdHJpbmcgcyA9IFZhbHVlKEV4cHJl c3Npb246OmV2YWx1YXRpb25Db250ZXh0KCkubm9kZSkudG9TdHJpbmcoKTsKKyAgICAgICAgU3Ry aW5nIHMgPSBWYWx1ZShFeHByZXNzaW9uOjpldmFsdWF0aW9uQ29udGV4dCgpLm5vZGUuZ2V0KCkp LnRvU3RyaW5nKCk7CiAgICAgICAgIHJldHVybiBWYWx1ZShzLnNpbXBsaWZ5V2hpdGVTcGFjZSgp KTsKICAgICB9CiAK