126015 2013-12-19 13:55:11 -0800 Enable video on WinCairo port 2014-01-03 09:34:07 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Enhancement --- 126319 1 alex.christensen webkit-unassigned bfulgham pnormand oldest_to_newest 961532 0 alex.christensen 2013-12-19 13:55:11 -0800 Let's enable video on the WinCairo port using GStreamer. People who want to build WinCairo without requiring GStreamer can still do that by removing ENABLE_MEDIA_CONTROLS_SCRIPT, ENABLE_VIDEO_TRACK, and ENABLE_VIDEO (or basically undoing this patch). 961533 1 219680 alex.christensen 2013-12-19 13:55:52 -0800 Created attachment 219680 Patch 961835 2 219680 pnormand 2013-12-20 05:38:39 -0800 Comment on attachment 219680 Patch I have no idea about the VS build system but can these options be disabled via build-webkit like in other ports? 961903 3 alex.christensen 2013-12-20 10:07:17 -0800 There is not. This is as simple as I could make the enabling and disabling. You could do a string replace on this file before building, but then there would be changes in WebKitLibraries. It would be somewhat complicated to put these feature defines in WebKitBuild. I think this is a good solution, unless someone can think of a better one. 962470 4 pnormand 2013-12-23 07:25:56 -0800 Ok then, I'll let Brent review this. Good work, it's nice to finally this land in trunk! 963427 5 alex.christensen 2013-12-30 18:44:28 -0800 How do I add the gstreamer binaries and development binaries as a dependency in http://www.webkit.org/building/tools.html ? I'd like to do that before putting this in. Applewin requires QuickTime and wincairo requires gstreamer or reversing this patch. 964133 6 alex.christensen 2014-01-03 09:34:07 -0800 http://trac.webkit.org/changeset/161266 219680 2013-12-19 13:55:52 -0800 2013-12-29 16:34:31 -0800 Patch bug-126015-20131219145552.patch text/plain 1796 alex.christensen SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwODUyKQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTE5ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbkNh aXJvXSBFbmFibGUgdmlkZW8gdXNpbmcgR1N0cmVhbWVyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVm aW5lc0NhaXJvLnByb3BzOgorICAgICAgICBEZWZpbmUgRU5BQkxFX01FRElBX0NPTlRST0xTX1ND UklQVCwgRU5BQkxFX1ZJREVPX1RSQUNLLCBhbmQgRU5BQkxFX1ZJREVPLgorCiAyMDEzLTEyLTE4 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W1dpbkNhaXJvXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTYwNzk4LgpJbmRleDogV2Vi S2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVzQ2Fpcm8ucHJvcHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVE ZWZpbmVzQ2Fpcm8ucHJvcHMJKHJldmlzaW9uIDE2MDg1MSkKKysrIFdlYktpdExpYnJhcmllcy93 aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lc0NhaXJvLnByb3BzCSh3b3JraW5nIGNvcHkp CkBAIC01Miw3ICs1Miw3IEBACiAgICAgPEVOQUJMRV9MSU5LX1BSRUZFVENIIC8+CiAgICAgPEVO QUJMRV9MSU5LX1BSRVJFTkRFUiAvPgogICAgIDxFTkFCTEVfTUFUSE1MPkVOQUJMRV9NQVRITUw8 L0VOQUJMRV9NQVRITUw+Ci0gICAgPEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgLz4KKyAg ICA8RU5BQkxFX01FRElBX0NPTlRST0xTX1NDUklQVD5FTkFCTEVfTUVESUFfQ09OVFJPTFNfU0NS SVBUPC9FTkFCTEVfTUVESUFfQ09OVFJPTFNfU0NSSVBUPgogICAgIDxFTkFCTEVfTUVESUFfU09V UkNFIC8+CiAgICAgPEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTIC8+CiAgICAgPEVOQUJMRV9NRVRF Ul9FTEVNRU5UPkVOQUJMRV9NRVRFUl9FTEVNRU5UPC9FTkFCTEVfTUVURVJfRUxFTUVOVD4KQEAg LTc3LDggKzc3LDggQEAKICAgICA8RU5BQkxFX1NWR19GT05UUz5FTkFCTEVfU1ZHX0ZPTlRTPC9F TkFCTEVfU1ZHX0ZPTlRTPgogICAgIDxFTkFCTEVfVEVNUExBVEVfRUxFTUVOVCAvPgogICAgIDxF TkFCTEVfVEVYVF9BVVRPU0laSU5HIC8+Ci0gICAgPEVOQUJMRV9WSURFTyAvPgotICAgIDxFTkFC TEVfVklERU9fVFJBQ0sgLz4KKyAgICA8RU5BQkxFX1ZJREVPPkVOQUJMRV9WSURFTzwvRU5BQkxF X1ZJREVPPgorICAgIDxFTkFCTEVfVklERU9fVFJBQ0s+RU5BQkxFX1ZJREVPX1RSQUNLPC9FTkFC TEVfVklERU9fVFJBQ0s+CiAgICAgPEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBIC8+CiAgICAg PEVOQUJMRV9XRUJfQVVESU8gLz4KICAgICA8RU5BQkxFX1dFQl9TT0NLRVRTPkVOQUJMRV9XRUJf U09DS0VUUzwvRU5BQkxFX1dFQl9TT0NLRVRTPgo=