126010 2013-12-19 12:53:16 -0800 GPRInfo references should be protected with ENABLE(JIT) 2013-12-19 15:01:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 7 RESOLVED WONTFIX P2 Trivial --- 1 alex.christensen webkit-unassigned fpizlo mhahnenberg oldest_to_newest 961508 0 alex.christensen 2013-12-19 12:53:16 -0800 http://trac.webkit.org/changeset/160796/trunk/Source/JavaScriptCore/runtime/VM.h broke the Win64 build. Here's the fix. 961509 1 fpizlo 2013-12-19 12:54:17 -0800 I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo? 961510 2 219678 alex.christensen 2013-12-19 12:55:56 -0800 Created attachment 219678 Patch 961511 3 alex.christensen 2013-12-19 12:57:07 -0800 (In reply to comment #1) > I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo? Should this array even be in VM.h? 961514 4 fpizlo 2013-12-19 13:04:59 -0800 (In reply to comment #3) > (In reply to comment #1) > > I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo? > Should this array even be in VM.h? No, it shouldn't. I don't think we need it. 961516 5 mhahnenberg 2013-12-19 13:09:54 -0800 See bug 126012. 961528 6 alex.christensen 2013-12-19 13:50:48 -0800 I'll let you fix this in the other bug, then. 219678 2013-12-19 12:55:56 -0800 2013-12-19 15:01:11 -0800 Patch bug-126010-20131219135555.patch text/plain 1165 alex.christensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwODUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTE5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgW1dpbjY0XSBCdWlsZCBmaXggYWZ0ZXIgcjE2MDc5Ni4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAxMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9WTS5oOgorICAg ICAgICBQcm90ZWN0ZWQgcmVmZXJlbmNlIHRvIEdQUkluZm8gd2l0aCBFTkFCTEUoSklUKS4KKwog MjAxMy0xMi0xOCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAg ICAgICAgIERlbGF5ZWRSZWxlYXNlU2NvcGUgaXMgaW4gdGhlIHdyb25nIHBsYWNlCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHJldmlzaW9uIDE2MDg1MSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHdvcmtpbmcgY29weSkKQEAgLTM4OCw3ICszODgs OSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgY29uc3QgQ2xhc3NJbmZvKiBjb25zdCBqc0Fy cmF5Q2xhc3NJbmZvOwogICAgICAgICBjb25zdCBDbGFzc0luZm8qIGNvbnN0IGpzRmluYWxPYmpl Y3RDbGFzc0luZm87CiAKKyNpZiBFTkFCTEUoSklUKQogICAgICAgICB2b2lkKiB3cml0ZUJhcnJp ZXJSZWdpc3RlckJ1ZmZlcltHUFJJbmZvOjpudW1iZXJPZlJlZ2lzdGVyc107CisjZW5kaWYKIAog ICAgICAgICBSZXR1cm5BZGRyZXNzUHRyIGV4Y2VwdGlvbkxvY2F0aW9uOwogICAgICAgICBKU1Zh bHVlIGhvc3RDYWxsUmV0dXJuVmFsdWU7Cg==