<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126007</bug_id>
          
          <creation_ts>2013-12-19 12:10:08 -0800</creation_ts>
          <short_desc>Implement a red zone in the JSStack so that we can remove entryChecks.</short_desc>
          <delta_ts>2014-01-13 17:10:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>126790</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>125928</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>961489</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-12-19 12:10:08 -0800</bug_when>
    <thetext>Currently, VM entry points in Interpreter.cpp calls JSStack::entryCheck() ensure adequate capacity on the JSStack before re-entering the VM.  We can eliminate this if we implement allow for a red zone in the JSStack.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>961556</commentid>
    <comment_count>1</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-12-19 15:01:23 -0800</bug_when>
    <thetext>Let&apos;s call this the &quot;host zone&quot;, to distinguish from the OS-provided redzone, which is for leaf functions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>962588</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-12-23 14:40:31 -0800</bug_when>
    <thetext>It&apos;s a bit difficult to get this right with the JSStack internal pointers sometime pointing to the top of stack and sometimes pointing past the end of the stack.  To make the code more sane to reason about, I will first fix https://bugs.webkit.org/show_bug.cgi?id=125849 before returning to this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967564</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-01-13 17:10:07 -0800</bug_when>
    <thetext>This was fixed in r161927: &lt;http://trac.webkit.org/r161927&gt; which was committed for https://bugs.webkit.org/show_bug.cgi?id=126790.

*** This bug has been marked as a duplicate of bug 126790 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>