126001 2013-12-19 11:26:04 -0800 tryAddEventListener uses local PassRefPtr<> 2013-12-19 11:40:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 961456 0 eric.carlson 2013-12-19 11:26:04 -0800 r160679 added a second use of a PassRefPtr<EventListener> parameter. 961462 1 219666 eric.carlson 2013-12-19 11:34:21 -0800 Created attachment 219666 Proposed patch 961463 2 219666 dbates 2013-12-19 11:36:42 -0800 Comment on attachment 219666 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review > Source/WebCore/ChangeLog:10 > + because it is sometimes used twice. Nit: This line begins with extraneous whitespace. 961465 3 dbates 2013-12-19 11:37:22 -0800 (In reply to comment #2) > (From update of attachment 219666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review > > > Source/WebCore/ChangeLog:10 > > + because it is sometimes used twice. > > Nit: This line begins with extraneous whitespace. This is OK as-is. I take it you feel this improves the readability of the change log entry. 961466 4 eric.carlson 2013-12-19 11:39:53 -0800 Committed r160849: https://trac.webkit.org/r160849 219666 2013-12-19 11:34:21 -0800 2013-12-19 11:40:00 -0800 Proposed patch patch_1.txt text/plain 1416 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDg0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIHRyeUFkZEV2ZW50TGlz dGVuZXIgdXNlcyBsb2NhbCBQYXNzUmVmUHRyPD4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjAwMQorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmll bCBCYXRlcy4KKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRy eUFkZEV2ZW50TGlzdGVuZXIpOiBQdXQgUGFzc1JlZlB0cjxFdmVudExpc3RlbmVyPiBwYXJhbWV0 ZXIgaW50byBhIGxvY2FsIFJlZlB0cgorICAgICAgICAgICAgYmVjYXVzZSBpdCBpcyBzb21ldGlt ZXMgdXNlZCB0d2ljZS4KKwogMjAxMy0xMi0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBvdmVyZmxvd2NoYW5nZWQgZXZlbnQgY291bGQgY2F1c2UgYSBjcmFz aApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAkocmV2aXNpb24gMTYwODQ3KQorKysgU291cmNlL1dlYkNv cmUvZG9tL05vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzg1LDggKzE3ODUsMTAgQEAgdm9p ZCBOb2RlOjpkaWRNb3ZlVG9OZXdEb2N1bWVudChEb2N1bWVudAogICAgIH0KIH0KIAotc3RhdGlj IGlubGluZSBib29sIHRyeUFkZEV2ZW50TGlzdGVuZXIoTm9kZSogdGFyZ2V0Tm9kZSwgY29uc3Qg QXRvbWljU3RyaW5nJiBldmVudFR5cGUsIFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVu ZXIsIGJvb2wgdXNlQ2FwdHVyZSkKK3N0YXRpYyBpbmxpbmUgYm9vbCB0cnlBZGRFdmVudExpc3Rl bmVyKE5vZGUqIHRhcmdldE5vZGUsIGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBQYXNz UmVmUHRyPEV2ZW50TGlzdGVuZXI+IHBycExpc3RlbmVyLCBib29sIHVzZUNhcHR1cmUpCiB7Cisg ICAgUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyID0gcHJwTGlzdGVuZXI7CisKICAgICBp ZiAoIXRhcmdldE5vZGUtPkV2ZW50VGFyZ2V0OjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwg bGlzdGVuZXIsIHVzZUNhcHR1cmUpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK