126000 2013-12-19 11:23:11 -0800 check-webkit-style marks rvalue references as violations 2013-12-19 15:20:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin dino glenn jonlee simon.fraser thorton oldest_to_newest 961454 0 mmaxfield 2013-12-19 11:23:11 -0800 check-webkit-style marks rvalue references as violations 961455 1 219663 mmaxfield 2013-12-19 11:24:44 -0800 Created attachment 219663 Patch 961572 2 219663 commit-queue 2013-12-19 15:20:18 -0800 Comment on attachment 219663 Patch Clearing flags on attachment: 219663 Committed r160864: <http://trac.webkit.org/changeset/160864> 961573 3 commit-queue 2013-12-19 15:20:20 -0800 All reviewed patches have been landed. Closing bug. 219663 2013-12-19 11:24:44 -0800 2013-12-19 15:20:18 -0800 Patch bug-126000-20131219112443.patch text/plain 4497 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwODIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzRiM2Y3OWM2YzczMGZjM2M3YjM1M2NlNjFkNGFiMWUz MTUzNzUwZC4uYjlmZWJiYWM4NjQ5OThhZGUzNTE4NWQyMWJhMjg4YTNkMjE5ZjM5ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTEyLTE5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIG1hcmtzIHJ2YWx1ZSByZWZlcmVuY2VzIGFz IHZpb2xhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNjAwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByZXZpb3VzbHksIGNoZWNrLXdlYmtpdC1zdHlsZSB3YXMgbWFraW5nIHN1cmUgdGhhdCBh bnkgbGluZSB3aXRoICImJiIgaGFkCisgICAgICAgIHNwYWNlcyBhcm91bmQgaXQuIEhvd2V2ZXIs IHdlIGNhbiBub3cgbGVnaXRpbWF0ZWx5IHVzZSAiJiYiIHdpdGhvdXQgYSBwcmV2aW91cworICAg ICAgICBzcGFjZSB3aGVuIGRlY2xhcmluZyBhbiBydmFsdWUgcmVmZXJlbmNlLiBUaGlzIHBhdGNo IHJlbGF4ZXMgdGhpcyBjaGVjay4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfc3BhY2luZyk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChD cHBTdHlsZVRlc3QudGVzdF9zcGFjaW5nX2Zvcl9iaW5hcnlfb3BzKToKKwogMjAxMy0xMi0xOCAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIERlcHJlY2F0 ZSBzb21lIFdLTXV0YWJsZURpY3Rpb25hcnkgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IGM3ZGEzODI4YzUzZjQ5MWNiMWUxNWY4 ZDAxZjM0OWM3Y2M0YTVmZDEuLmE0YWQwYmQ4OTIwODU4NjY5MWU5ODEwNGViNzVhZmIxYTM3MjUy ZjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBA IC0xODUwLDEwICsxODUwLDEwIEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5zaW9uLCBj bGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAjIEZJWE1FOiBJdCdzIG5vdCBv ayB0byBoYXZlIHNwYWNlcyBhcm91bmQgYmluYXJ5IG9wZXJhdG9ycyBsaWtlIC4KIAogICAgICMg WW91IHNob3VsZCBhbHdheXMgaGF2ZSB3aGl0ZXNwYWNlIGFyb3VuZCBiaW5hcnkgb3BlcmF0b3Jz LgotICAgICMgQWxhcywgd2UgY2FuJ3QgdGVzdCA8LCA+LCA8PCwgb3IgPj4gYmVjYXVzZSB0aGV5 J3JlIGxlZ2l0aW1hdGVseSB1c2VkIHNhbnMgc3BhY2VzCi0gICAgIyAoYS0+YiwgdmVjdG9yPGlu dD4gYSkuICBUaGUgb25seSB0aW1lIHdlIGNhbiB0ZWxsIGlzIGEgPCB3aXRoIG5vID4sIGFuZAor ICAgICMgQWxhcywgd2UgY2FuJ3QgdGVzdCA8LCA+LCA8PCwgPj4sIG9yICYmIGJlY2F1c2UgdGhl eSdyZSBsZWdpdGltYXRlbHkgdXNlZCBzYW5zIHNwYWNlcworICAgICMgKGEtPmIsIHZlY3Rvcjxp bnQ+IGEsIEZvbyYmIGEpLiAgVGhlIG9ubHkgdGltZSB3ZSBjYW4gdGVsbCBpcyBhIDwgd2l0aCBu byA+LCBhbmQKICAgICAjIG9ubHkgaWYgaXQncyBub3QgdGVtcGxhdGUgcGFyYW1zIGxpc3Qgc3Bp bGxpbmcgaW50byB0aGUgbmV4dCBsaW5lLgotICAgIG1hdGNoZWQgPSBzZWFyY2gocidbXjw+PSFc c10oPT18IT18XCs9fC09fFwqPXwvPXwvfFx8PXwmPXw8PD18Pj49fDw9fD49fFx8XHx8XHx8JiYp W148Pj0hXHNdJywgbGluZSkKKyAgICBtYXRjaGVkID0gc2VhcmNoKHInW148Pj0hXHNdKD09fCE9 fFwrPXwtPXxcKj18Lz18L3xcfD18Jj18PDw9fD4+PXw8PXw+PXxcfFx8fFx8KVtePD49IVxzXScs IGxpbmUpCiAgICAgaWYgbm90IG1hdGNoZWQ6CiAgICAgICAgICMgTm90ZSB0aGF0IHdoaWxlIGl0 IHNlZW1zIHRoYXQgdGhlICc8W148XSonIHRlcm0gaW4gdGhlIGZvbGxvd2luZwogICAgICAgICAj IHJlZ2V4cCBjb3VsZCBiZSBzaW1wbGlmaWVkIHRvICc8LionLCB3aGljaCB3b3VsZCBpbmRlZWQg bWF0Y2gKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkKaW5kZXggOWU4ZTc3N2UyZWZlYmMyMDVjYzRkYWQzZDRlYjhmNzMxYTE5 ZTUzOC4uN2FjYmYxMGU2ZTU2YzY2NDMyYzdjMzJhZmEzNjUwM2I5MzFiZWU1ZiAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKQEAgLTE3NDYsMTIgKzE3NDYsMTIgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVz dEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQgaGF2ZSBhIHNwYWNlIGJl dHdlZW4gLy8gYW5kIGNvbW1lbnQgICcKICAgICAgICAgICAgICAgICAgICAgICAgICAnW3doaXRl c3BhY2UvY29tbWVudHNdIFs0XScsCiAgICAgICAgICAgICAgICAgICAgICAgICAgJ01pc3Npbmcg c3BhY2VzIGFyb3VuZCB8fCAgW3doaXRlc3BhY2Uvb3BlcmF0b3JzXSBbM10nXSkKLSAgICAgICAg c2VsZi5hc3NlcnRfbGludCgnYTxGb28qPiB0IDw8PSBiJiZjOyAvLyBUZXN0JywgJ01pc3Npbmcg c3BhY2VzIGFyb3VuZCcKLSAgICAgICAgICAgICAgICAgICAgICAgICAnICYmICBbd2hpdGVzcGFj ZS9vcGVyYXRvcnNdIFszXScpCi0gICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2E8Rm9vKj4gdCA8 PD0gYiYmJmM7IC8vIFRlc3QnLCAnTWlzc2luZyBzcGFjZXMgYXJvdW5kJwotICAgICAgICAgICAg ICAgICAgICAgICAgICcgJiYgIFt3aGl0ZXNwYWNlL29wZXJhdG9yc10gWzNdJykKLSAgICAgICAg c2VsZi5hc3NlcnRfbGludCgnYTxGb28qPiB0IDw8PSBiJiYqYzsgLy8gVGVzdCcsICdNaXNzaW5n IHNwYWNlcyBhcm91bmQnCi0gICAgICAgICAgICAgICAgICAgICAgICAgJyAmJiAgW3doaXRlc3Bh Y2Uvb3BlcmF0b3JzXSBbM10nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdhPEZvbyo+IHQg PDw9IGJ8fGM7IC8vIFRlc3QnLCAnTWlzc2luZyBzcGFjZXMgYXJvdW5kJworICAgICAgICAgICAg ICAgICAgICAgICAgICcgfHwgIFt3aGl0ZXNwYWNlL29wZXJhdG9yc10gWzNdJykKKyAgICAgICAg c2VsZi5hc3NlcnRfbGludCgnYTxGb28qPiB0IDw8PSBifHwmYzsgLy8gVGVzdCcsICdNaXNzaW5n IHNwYWNlcyBhcm91bmQnCisgICAgICAgICAgICAgICAgICAgICAgICAgJyB8fCAgW3doaXRlc3Bh Y2Uvb3BlcmF0b3JzXSBbM10nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdhPEZvbyo+IHQg PDw9IGJ8fCpjOyAvLyBUZXN0JywgJ01pc3Npbmcgc3BhY2VzIGFyb3VuZCcKKyAgICAgICAgICAg ICAgICAgICAgICAgICAnIHx8ICBbd2hpdGVzcGFjZS9vcGVyYXRvcnNdIFszXScpCiAgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoJ2E8Rm9vKj4gdCA8PD0gYiAmJiAqYzsgLy8gVGVzdCcsICcnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdhPEZvbyo+IHQgPDw9IGIgJiYgJmM7IC8vIFRlc3Qn LCAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnYTxGb28qPiB0IDw8PSBiIHx8ICZjOyAg LypUZXN0JywgJ0NvbXBsZXggbXVsdGktbGluZSAnCkBAIC0xNzY3LDYgKzE3NjcsNyBAQCBjbGFz cyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X211 bHRpX2xpbmVfbGludCgnI2luY2x1ZGUgPHN5cy9pby5oPlxuJywgJycpCiAgICAgICAgIHNlbGYu YXNzZXJ0X211bHRpX2xpbmVfbGludCgnI2ltcG9ydCA8Zm9vL2Jhci5oPlxuJywgJycpCiAgICAg ICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgnI2lmIF9faGFzX2luY2x1ZGUoPEFwcGxp Y2F0aW9uU2VydmljZXMvQXBwbGljYXRpb25TZXJ2aWNlc1ByaXYuaD4pXG4nLCAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnRm9vJiYgYSA9IGJhcigpOycsICcnKQogCiAgICAgZGVmIHRl c3Rfb3BlcmF0b3JfbWV0aG9kcyhzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnU3Ry aW5nIG9wZXJhdG9yKyhjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykK