125998 2013-12-19 10:57:42 -0800 Have webkitdirs not look at VSINSTALLDIR variable when getting visualStudioInstallDir 2014-01-15 17:06:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 126395 1 roger_fong webkit-unassigned ap bfulgham commit-queue david.delaune roger_fong oldest_to_newest 961443 0 roger_fong 2013-12-19 10:57:42 -0800 Get rid of the check for VSINSTALLDIR when building on Windows. We can't build on anything besides VS2013 anymore anyways. 961444 1 219660 roger_fong 2013-12-19 11:00:38 -0800 Created attachment 219660 patch 961447 2 roger_fong 2013-12-19 11:07:43 -0800 http://trac.webkit.org/changeset/160846 963417 3 david.delaune 2013-12-30 17:22:51 -0800 Seriously? Your *fix* is to hard-code the path to Visual Studio? 963426 4 bfulgham 2013-12-30 18:22:13 -0800 (In reply to comment #3) > Seriously? > > Your *fix* is to hard-code the path to Visual Studio? Can you provide an error message or other useful feedback about this change? It's not clear from your message if this prevented you from building, or simply offended your sensibilities. 963461 5 ap 2013-12-30 22:26:59 -0800 David filed bug 126317 about this. 963462 6 david.delaune 2013-12-30 22:28:14 -0800 Hi, Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. Take a quick guess as to what is happening when the build script does not locate the compiler. 963755 7 bfulgham 2014-01-02 08:42:06 -0800 (In reply to comment #6) > Hi, > > Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. > > Take a quick guess as to what is happening when the build script does not locate the compiler. Let's continue discussion about this problem on Bug 126317. 963818 8 commit-queue 2014-01-02 11:56:01 -0800 Re-opened since this is blocked by bug 126395 219660 2013-12-19 11:00:38 -0800 2013-12-19 11:03:35 -0800 patch patch.patch text/plain 1394 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDg0 NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEy LTE5ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3Qg Y2hlY2sgVlNJTlNUQUxMRElSIHdoZW4gbG9va2luZyBmb3IgVmlzdWFsIFN0dWRpbyBpbnN0YWxs IGRpcmVjdG9yeS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNTk5OC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKHZpc3VhbFN0dWRpb0luc3Rh bGxEaXIpOgorICAgICAgICBHZXQgcmlkIG9mIHRoZSBWU0lOU1RBTExESVIgY2hlY2suIFdlIGNh bid0IGJ1aWxkIG9uIGFueXRoaW5nIGJlc2lkZXMgVlMyMDEzIG5vdyBhbnl3YXlzLgorCiAyMDEz LTEyLTE5ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0FUS10gW1dLMl0gcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhw b3NlZC5odG1sIGlzIGZhaWxpbmcKSW5kZXg6IFNjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDE2MDU2OSkKKysrIFNjcmlw dHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtNDMyLDEyICs0MzIsOCBAQAogewog ICAgIHJldHVybiAkdnNJbnN0YWxsRGlyIGlmIGRlZmluZWQgJHZzSW5zdGFsbERpcjsKIAotICAg IGlmICgkRU5WeydWU0lOU1RBTExESVInfSkgewotICAgICAgICAkdnNJbnN0YWxsRGlyID0gJEVO VnsnVlNJTlNUQUxMRElSJ307Ci0gICAgICAgICR2c0luc3RhbGxEaXIgPX4gc3xbXFwvXSR8fDsK LSAgICB9IGVsc2UgewotICAgICAgICAkdnNJbnN0YWxsRGlyID0gRmlsZTo6U3BlYy0+Y2F0ZGly KHByb2dyYW1GaWxlc1BhdGgoKSwgIk1pY3Jvc29mdCBWaXN1YWwgU3R1ZGlvIDEyLjAiKTsKLSAg ICB9CisgICAgJHZzSW5zdGFsbERpciA9IEZpbGU6OlNwZWMtPmNhdGRpcihwcm9ncmFtRmlsZXNQ YXRoKCksICJNaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyAxMi4wIik7CisKICAgICBjaG9tcCgkdnNJ bnN0YWxsRGlyID0gYGN5Z3BhdGggIiR2c0luc3RhbGxEaXIiYCkgaWYgaXNDeWd3aW4oKTsKIAog ICAgIHJldHVybiAkdnNJbnN0YWxsRGlyOwo=