125993 2013-12-19 06:00:06 -0800 [GTK] The fullscreen API should be enabled by default 2013-12-20 06:55:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eocanha webkit-unassigned cgarcia commit-queue gustavo mrobinson oldest_to_newest 961360 0 eocanha 2013-12-19 06:00:06 -0800 The enable-fullscreen setting should be enabled by default in WebKitGTK+. 961363 1 219644 eocanha 2013-12-19 06:11:38 -0800 Created attachment 219644 Patch 961364 2 commit-queue 2013-12-19 06:14:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 961789 3 219741 eocanha 2013-12-20 01:37:22 -0800 Created attachment 219741 Patch 961790 4 eocanha 2013-12-20 01:38:10 -0800 Rebased and corrected the changelog. 961815 5 219741 gustavo 2013-12-20 03:35:36 -0800 Comment on attachment 219741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review It sounds good to me, have this been discussed with Carlos, Phillippe or Martin? =) > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834 > + _("Whether the Mozilla style API should be enabled."), Mozilla style? This should say the same thing as the other one, and have a Since of 2.4 I believe. Would be good to have the gtk-doc documentation header added here, I think. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:907 > + _("Whether to enable the Javascriipt Fullscreen API"), Javascript has 2 i's here, let's fix that too =) 961830 6 219741 pnormand 2013-12-20 04:44:00 -0800 Comment on attachment 219741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review I agree with enabling this setting by default, fwiw >> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834 >> + _("Whether the Mozilla style API should be enabled."), > > Mozilla style? This should say the same thing as the other one, and have a Since of 2.4 I believe. Would be good to have the gtk-doc documentation header added here, I think. It's actually an on-going effort at W3C nowadays. http://www.w3.org/TR/fullscreen/ Can you please update the strings accordingly? 961832 7 219752 eocanha 2013-12-20 05:14:07 -0800 Created attachment 219752 Patch 961850 8 219752 gustavo 2013-12-20 06:26:54 -0800 Comment on attachment 219752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219752&action=review > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:836 > + * Whether to enable the Javascript Fullscreen API. The API > + * allows any HTML element to request fullscreen display. See also > + * the current draft of the spec: > + * http://www.w3.org/TR/fullscreen/ Nit: these lines could be longer. 961854 9 219752 commit-queue 2013-12-20 06:55:21 -0800 Comment on attachment 219752 Patch Clearing flags on attachment: 219752 Committed r160909: <http://trac.webkit.org/changeset/160909> 961855 10 commit-queue 2013-12-20 06:55:23 -0800 All reviewed patches have been landed. Closing bug. 219644 2013-12-19 06:11:38 -0800 2013-12-20 01:37:15 -0800 Patch bug-125993-20131219141137.patch text/plain 4099 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZjYxMmI3Y2I5 NjJkMzAzYmE4ZjMyNDlhNDM0ODlkNjQ1MGU4MDZkYy4uMTc3OTE4MzFlMzIwOTEwMTc1Mjk5ZWVi YTUzMGM5M2VjMGVmMWU0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEz LTEyLTE5ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGhlIGZ1bGxzY3JlZW4gQVBJIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRl ZmF1bHQKKworICAgICAgICBTZXQgdGhlIFdlYlNldHRpbmdzIHByb3BlcnR5IHRvIFRSVUUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTk5MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3Nf aW5pdCk6CisKIDIwMTMtMTItMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQdXNoIE1vcmUgSW5zcGVjdG9yIFJlcXVpcmVk IENsYXNzZXMgRG93biBpbnRvIEphdmFTY3JpcHRDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTVkY2ZlOGUy MjJlNTY4ZjNmMjQ2YTcwNTY3MGJhMjNhYjhiZTMxYy4uNTZmNTRkMzdmOGVhN2NhZjhhY2IwOTA1 MjIyZTVhOWYwMmVkOTNhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTE5 ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dUS10gVGhlIGZ1bGxzY3JlZW4gQVBJIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQg ICAgICAgCisKKyAgICAgICAgU2V0IHRoZSBXZWJTZXR0aW5ncyBwcm9wZXJ0eSB0byBUUlVFCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5OTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19j bGFzc19pbml0KToKKwogMjAxMy0xMi0xMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0F1dG90b29sc10gUHJlcGVuZCB0aGUgV2ViQ29yZSBsYXllciBh cmNoaXZlcycgbmFtZXMgd2l0aCAnbGliJwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJzZXR0aW5ncy5jcHAKaW5kZXggOTRkMmFmYzljN2UwN2QzMWNmZjQ4ZWY0MWM1YzNk NmFlOWQwYjFiZC4uYTI1ZTViZDliNWVjYmYxMDMwNmY2OGE4NTkyODc3M2Q0ZGZkZDMwOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC04 MjgsMTIgKzgyOCwxMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2lu aXQoV2ViS2l0V2ViU2V0dGluZ3NDbGFzcyoga2xhc3MpCiAKICAgICAvKiBVbmRvY3VtZW50ZWQg Zm9yIG5vdyAqLwogICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkoZ29iamVjdF9j bGFzcywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1BfRU5BQkxFX0ZV TExTQ1JFRU4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3Nw ZWNfYm9vbGVhbigiZW5hYmxlLWZ1bGxzY3JlZW4iLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIEZ1bGxzY3JlZW4iKSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IF8oIldoZXRoZXIgdGhlIE1vemlsbGEgc3R5bGUgQVBJIHNob3VsZCBiZSBlbmFibGVkLiIpLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg RkFMU0UsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmbGFncykpOworICAgICAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOLAorICAgICAg ICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLWZ1bGxzY3JlZW4iLAorICAgICAgICAgICAg XygiRW5hYmxlIEZ1bGxzY3JlZW4iKSwKKyAgICAgICAgICAgIF8oIldoZXRoZXIgdGhlIE1vemls bGEgc3R5bGUgQVBJIHNob3VsZCBiZSBlbmFibGVkLiIpLAorICAgICAgICAgICAgVFJVRSwKKyAg ICAgICAgICAgIGZsYWdzKSk7CisKICAgICAvKioKICAgICAqIFdlYktpdFdlYlNldHRpbmdzOmVu YWJsZS13ZWJnbDoKICAgICAqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggN2NjNDU2MGM2NTQ0YjE2YTdjYzEwZDQwNzgy MDc5NzFmMmNmMGIzNS4uYmRiYWMwOWE2OGU4YjhlNzBiZDAwZmVlMzVmNGUzNzQ2MjY4Mjk1OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGlu Z3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRp bmdzLmNwcApAQCAtOTAxLDEyICs5MDEsMTIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdz X2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICogaHR0cDovL2R2 Y3MudzMub3JnL2hnL2Z1bGxzY3JlZW4vcmF3LWZpbGUvdGlwL092ZXJ2aWV3Lmh0bWwKICAgICAg Ki8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KGdPYmplY3RDbGFzcywKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1BfRU5BQkxFX0ZVTExTQ1JFRU4s Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVh bigiZW5hYmxlLWZ1bGxzY3JlZW4iLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIEZ1bGxzY3JlZW4iKSwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIldoZXRo ZXIgdG8gZW5hYmxlIHRoZSBKYXZhc2NyaWlwdCBGdWxsc2NyZWVuIEFQSSIpLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFMU0UsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CisgICAgICAgIFBST1BfRU5BQkxFX0ZVTExT Q1JFRU4sCisgICAgICAgIGdfcGFyYW1fc3BlY19ib29sZWFuKCJlbmFibGUtZnVsbHNjcmVlbiIs CisgICAgICAgICAgICBfKCJFbmFibGUgRnVsbHNjcmVlbiIpLAorICAgICAgICAgICAgXygiV2hl dGhlciB0byBlbmFibGUgdGhlIEphdmFzY3JpaXB0IEZ1bGxzY3JlZW4gQVBJIiksCisgICAgICAg ICAgICBUUlVFLAorICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncykpOwog CiAgICAgLyoqCiAgICAgICogV2ViS2l0U2V0dGluZ3M6cHJpbnQtYmFja2dyb3VuZHM6Cg== 219741 2013-12-20 01:37:22 -0800 2013-12-20 05:13:59 -0800 Patch bug-125993-20131220093720.patch text/plain 4091 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOWIwMjk3ZTdl NGJlMjUzMTMwYmMzNjJmNTA4MGE3OWU1YjRiOGNjOC4uYjNmOTcxYWFiNWZjNmM2OWMxZmQ2ZDg5 OTYwYWVmN2ViMzA2NWFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEz LTEyLTE5ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGhlIGZ1bGxzY3JlZW4gQVBJIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRl ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NTk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNl dCB0aGUgV2ViU2V0dGluZ3MgcHJvcGVydHkgdG8gVFJVRQorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3Nf aW5pdCk6CisKIDIwMTMtMTItMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gQWRkIHN1cHBvcnQgZm9yIGJ1aWxkaW5nIFdl YktpdDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwppbmRleCA1N2RkMzUzMjZlMmFmZWNjOTdkNGFjYWQ1YWU0ODAxZTQ0ODZi YWJjLi45ZTQyNTM5Y2EwOWFlYTE4MWM3ZWM5NzNlOWYzNjU3MGQxYjFmZDBlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTkgIEVucmlxdWUgT2Nhw7FhIEdvbnrDoWxleiAg PGVvY2FuaGFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUaGUgZnVsbHNjcmVlbiBBUEkg c2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdCAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTk5MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCB0aGUgV2ViU2V0dGluZ3MgcHJvcGVydHkg dG8gVFJVRQorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3Bw OgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOgorCiAyMDEzLTEyLTE4ICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdDIg VmlldyBHZXN0dXJlczogTW92ZSBXZWJQcm9jZXNzLXNpZGUgZ2VvbWV0cnkgY29sbGVjdGlvbiBp bnRvIGl0cyBvd24gY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi c2V0dGluZ3MuY3BwCmluZGV4IDk0ZDJhZmM5YzdlMDdkMzFjZmY0OGVmNDFjNWMzZDZhZTlkMGIx YmQuLmEyNWU1YmQ5YjVlY2JmMTAzMDZmNjhhODU5Mjg3NzNkNGRmZGQzMDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAtODI4LDEyICs4 MjgsMTMgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19jbGFzc19pbml0KFdlYktp dFdlYlNldHRpbmdzQ2xhc3MqIGtsYXNzKQogCiAgICAgLyogVW5kb2N1bWVudGVkIGZvciBub3cg Ki8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RfY2xhc3MsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVO LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xl YW4oImVuYWJsZS1mdWxsc2NyZWVuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIF8oIkVuYWJsZSBGdWxsc2NyZWVuIiksCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJXaGV0 aGVyIHRoZSBNb3ppbGxhIHN0eWxlIEFQSSBzaG91bGQgYmUgZW5hYmxlZC4iKSwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZmxhZ3MpKTsKKyAgICAgICAgUFJPUF9FTkFCTEVfRlVMTFNDUkVFTiwKKyAgICAgICAgZ19wYXJh bV9zcGVjX2Jvb2xlYW4oImVuYWJsZS1mdWxsc2NyZWVuIiwKKyAgICAgICAgICAgIF8oIkVuYWJs ZSBGdWxsc2NyZWVuIiksCisgICAgICAgICAgICBfKCJXaGV0aGVyIHRoZSBNb3ppbGxhIHN0eWxl IEFQSSBzaG91bGQgYmUgZW5hYmxlZC4iKSwKKyAgICAgICAgICAgIFRSVUUsCisgICAgICAgICAg ICBmbGFncykpOworCiAgICAgLyoqCiAgICAgKiBXZWJLaXRXZWJTZXR0aW5nczplbmFibGUtd2Vi Z2w6CiAgICAgKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0U2V0dGluZ3MuY3BwCmluZGV4IDdjYzQ1NjBjNjU0NGIxNmE3Y2MxMGQ0MDc4MjA3OTcxZjJj ZjBiMzUuLmJkYmFjMDlhNjhlOGI4ZTcwYmQwMGZlZTM1ZjRlMzc0NjI2ODI5NTggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAK QEAgLTkwMSwxMiArOTAxLDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19p bml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAqIGh0dHA6Ly9kdmNzLnczLm9y Zy9oZy9mdWxsc2NyZWVuL3Jhdy1maWxlL3RpcC9PdmVydmlldy5odG1sCiAgICAgICovCiAgICAg Z19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnT2JqZWN0Q2xhc3MsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oImVuYWJs ZS1mdWxsc2NyZWVuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF8oIkVuYWJsZSBGdWxsc2NyZWVuIiksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJXaGV0aGVyIHRvIGVu YWJsZSB0aGUgSmF2YXNjcmlpcHQgRnVsbHNjcmVlbiBBUEkiKSwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRl Q29uc3RydWN0UGFyYW1GbGFncykpOworICAgICAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOLAor ICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLWZ1bGxzY3JlZW4iLAorICAgICAg ICAgICAgXygiRW5hYmxlIEZ1bGxzY3JlZW4iKSwKKyAgICAgICAgICAgIF8oIldoZXRoZXIgdG8g ZW5hYmxlIHRoZSBKYXZhc2NyaWlwdCBGdWxsc2NyZWVuIEFQSSIpLAorICAgICAgICAgICAgVFJV RSwKKyAgICAgICAgICAgIHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MpKTsKIAogICAgIC8q KgogICAgICAqIFdlYktpdFNldHRpbmdzOnByaW50LWJhY2tncm91bmRzOgo= 219752 2013-12-20 05:14:07 -0800 2013-12-20 06:55:20 -0800 Patch bug-125993-20131220131406.patch text/plain 4744 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOWIwMjk3ZTdl NGJlMjUzMTMwYmMzNjJmNTA4MGE3OWU1YjRiOGNjOC4uYjNmOTcxYWFiNWZjNmM2OWMxZmQ2ZDg5 OTYwYWVmN2ViMzA2NWFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEz LTEyLTE5ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGhlIGZ1bGxzY3JlZW4gQVBJIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRl ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NTk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNl dCB0aGUgV2ViU2V0dGluZ3MgcHJvcGVydHkgdG8gVFJVRQorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3Nf aW5pdCk6CisKIDIwMTMtMTItMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gQWRkIHN1cHBvcnQgZm9yIGJ1aWxkaW5nIFdl YktpdDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwppbmRleCA1N2RkMzUzMjZlMmFmZWNjOTdkNGFjYWQ1YWU0ODAxZTQ0ODZi YWJjLi4zYmNlNTNiYWJjMWQ2ZjJmMWQ2NjJhMTAzNjRiYjM1M2Q0OTRhOGI0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTkgIEVucmlxdWUgT2Nhw7FhIEdvbnrDoWxleiAg PGVvY2FuaGFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUaGUgZnVsbHNjcmVlbiBBUEkg c2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1OTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2V0IHRoZSBXZWJTZXR0aW5ncyBwcm9wZXJ0eSB0byBUUlVF CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAg ICAgICh3ZWJraXRfc2V0dGluZ3NfY2xhc3NfaW5pdCk6CisKIDIwMTMtMTItMTggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBWaWV3IEdl c3R1cmVzOiBNb3ZlIFdlYlByb2Nlc3Mtc2lkZSBnZW9tZXRyeSBjb2xsZWN0aW9uIGludG8gaXRz IG93biBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5n cy5jcHAKaW5kZXggOTRkMmFmYzljN2UwN2QzMWNmZjQ4ZWY0MWM1YzNkNmFlOWQwYjFiZC4uMDlh Y2NmODczZDFjMmM1ZDEzMjlkNTJmOWMwY2Y0NTczMzM1NDM4MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC04MjYsMTQgKzgyNiwyNSBA QCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0V2ViU2V0 dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBGQUxTRSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzKSk7CiAKLSAgICAvKiBVbmRvY3VtZW50 ZWQgZm9yIG5vdyAqLworICAgIC8qKgorICAgICogV2ViS2l0V2ViU2V0dGluZ3M6ZW5hYmxlLWZ1 bGxzY3JlZW46CisgICAgKgorICAgICoKKyAgICAqIFdoZXRoZXIgdG8gZW5hYmxlIHRoZSBKYXZh c2NyaXB0IEZ1bGxzY3JlZW4gQVBJLiBUaGUgQVBJCisgICAgKiBhbGxvd3MgYW55IEhUTUwgZWxl bWVudCB0byByZXF1ZXN0IGZ1bGxzY3JlZW4gZGlzcGxheS4gU2VlIGFsc28KKyAgICAqIHRoZSBj dXJyZW50IGRyYWZ0IG9mIHRoZSBzcGVjOgorICAgICogaHR0cDovL3d3dy53My5vcmcvVFIvZnVs bHNjcmVlbi8KKyAgICAqCisgICAgKiBTaW5jZTogMi40CisgICAgKi8KICAgICBnX29iamVjdF9j bGFzc19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RfY2xhc3MsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oImVuYWJsZS1mdWxsc2Ny ZWVuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF8oIkVuYWJsZSBGdWxsc2NyZWVuIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJXaGV0aGVyIHRoZSBNb3ppbGxhIHN0 eWxlIEFQSSBzaG91bGQgYmUgZW5hYmxlZC4iKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MpKTsKKyAgICAgICAg UFJPUF9FTkFCTEVfRlVMTFNDUkVFTiwKKyAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oImVu YWJsZS1mdWxsc2NyZWVuIiwKKyAgICAgICAgICAgIF8oIkVuYWJsZSBGdWxsc2NyZWVuIiksCisg ICAgICAgICAgICBfKCJXaGV0aGVyIHRvIGVuYWJsZSB0aGUgSmF2YXNjcmlwdCBGdWxsc2NyZWVu IEFQSSIpLAorICAgICAgICAgICAgVFJVRSwKKyAgICAgICAgICAgIGZsYWdzKSk7CisKICAgICAv KioKICAgICAqIFdlYktpdFdlYlNldHRpbmdzOmVuYWJsZS13ZWJnbDoKICAgICAqCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKaW5k ZXggN2NjNDU2MGM2NTQ0YjE2YTdjYzEwZDQwNzgyMDc5NzFmMmNmMGIzNS4uMzU5ODAyZWRiMTUw YTgwYjFiMmE1MmI1NTU5YzMwMjM0MTZjOWJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcApAQCAtODk4LDE1ICs4OTgsMTUg QEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3ND bGFzcyoga2xhc3MpCiAgICAgICogV2hldGhlciB0byBlbmFibGUgdGhlIEphdmFzY3JpcHQgRnVs bHNjcmVlbiBBUEkuIFRoZSBBUEkKICAgICAgKiBhbGxvd3MgYW55IEhUTUwgZWxlbWVudCB0byBy ZXF1ZXN0IGZ1bGxzY3JlZW4gZGlzcGxheS4gU2VlIGFsc28KICAgICAgKiB0aGUgY3VycmVudCBk cmFmdCBvZiB0aGUgc3BlYzoKLSAgICAgKiBodHRwOi8vZHZjcy53My5vcmcvaGcvZnVsbHNjcmVl bi9yYXctZmlsZS90aXAvT3ZlcnZpZXcuaHRtbAorICAgICAqIGh0dHA6Ly93d3cudzMub3JnL1RS L2Z1bGxzY3JlZW4vCiAgICAgICovCiAgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0 eShnT2JqZWN0Q2xhc3MsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9Q X0VOQUJMRV9GVUxMU0NSRUVOLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Z19wYXJhbV9zcGVjX2Jvb2xlYW4oImVuYWJsZS1mdWxsc2NyZWVuIiwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIkVuYWJsZSBGdWxs c2NyZWVuIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBfKCJXaGV0aGVyIHRvIGVuYWJsZSB0aGUgSmF2YXNjcmlpcHQgRnVsbHNjcmVl biBBUEkiKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEZBTFNFLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncykpOworICAgICAg ICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOLAorICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigi ZW5hYmxlLWZ1bGxzY3JlZW4iLAorICAgICAgICAgICAgXygiRW5hYmxlIEZ1bGxzY3JlZW4iKSwK KyAgICAgICAgICAgIF8oIldoZXRoZXIgdG8gZW5hYmxlIHRoZSBKYXZhc2NyaXB0IEZ1bGxzY3Jl ZW4gQVBJIiksCisgICAgICAgICAgICBUUlVFLAorICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3Ry dWN0UGFyYW1GbGFncykpOwogCiAgICAgLyoqCiAgICAgICogV2ViS2l0U2V0dGluZ3M6cHJpbnQt YmFja2dyb3VuZHM6Cg==