125988 2013-12-19 02:06:42 -0800 Precede boolean values with words like "is" and "did". 2013-12-20 10:29:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned commit-queue darin galpeter glenn ossy rniwa oldest_to_newest 961323 0 gbalogh.u-szeged 2013-12-19 02:06:42 -0800 Right: bool isValid; bool didSendData; Wrong: bool valid; bool sentData; 961352 1 219641 gbalogh.u-szeged 2013-12-19 05:25:20 -0800 Created attachment 219641 patch 961381 2 219641 darin 2013-12-19 07:21:38 -0800 Comment on attachment 219641 patch This doesn’t seem like something the style checker can correctly check without linguistic analysis. For example, "requiresHeader" is a perfectly good name for a boolean. And "isRequiresHeader" is bad. 961756 3 gbalogh.u-szeged 2013-12-19 23:12:08 -0800 (In reply to comment #2) > (From update of attachment 219641 [details]) > This doesn’t seem like something the style checker can correctly check without linguistic analysis. For example, "requiresHeader" is a perfectly good name for a boolean. And "isRequiresHeader" is bad. My opinion is that every phrase in English (which has a truth-value) can be rephrase to begin with 'is' or 'did'. requiresHeader --> isHeaderRequired. Of course I am not a native speaker so it's may be wrong, but suppose it's true. I always prefer the more formal notion over the others, but not over readability. So I think the key question here is not that is the 'is-free' form grammatical correct, rather do the 'is-form' help the reader or the code writer to understand the code. An additional thought. If you use some kind of auto-completion tool and you know that every bool variable start with 'is', you can look for it, even you don't know the exact phrase that the developer used. We seen this before for example in the case of getters and setters in Java (getSomething(), setSomething()). Of course these are only my opinion. 961888 4 rniwa 2013-12-20 09:04:09 -0800 I don't think we should do that. 961900 5 darin 2013-12-20 09:58:00 -0800 I don’t want to adopt this newly-suggested pseudo-grammatical style rule. 961905 6 rniwa 2013-12-20 10:29:16 -0800 Closing the bug as invalid. If you feel strongly about this, please make a post on webkit-dev since we need a community-wide consensus to add a new style guideline like that. 219641 2013-12-19 05:25:20 -0800 2013-12-19 07:21:38 -0800 patch f2757.diff text/plain 4492 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNGIz Zjc5Li5mNmEzN2QxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTkgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFByZWNlZGUgYm9vbGVhbiB2YWx1ZXMgd2l0 aCB3b3JkcyBsaWtlICJpcyIgYW5kICJkaWQiLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1OTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weToKKyAgICAgICAgKGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbik6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6 CisgICAgICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF9uYW1lcyk6CisKIDIwMTMtMTItMTggIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBEZXByZWNhdGUg c29tZSBXS011dGFibGVEaWN0aW9uYXJ5IGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBjN2RhMzgyLi5jMDBlYWE1IDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzIxMyw3ICsz MjEzLDcgQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFt ZSwgbGluZV9udW1iZXIsIGxpbmUsIGZpbGVfc3RhdGUKICAgICBsaW5lLCBjb250cm9sX3N0YXRl bWVudCA9IHN1Ym4ocideXHMqKHdoaWxlfGVsc2UgaWZ8aWZ8c3dpdGNoKVxzKlwoJywgJycsIGxp bmUpCiAKICAgICAjIERldGVjdCB2YXJpYWJsZSBhbmQgZnVuY3Rpb25zLgotICAgIHR5cGVfcmVn ZXhwID0gcidcdyhbXHddfFxzKlsqJl1ccyp8OjopKycKKyAgICB0eXBlX3JlZ2V4cCA9IHInKD9Q PHR5cGU+XHcoW1x3XXxccypbKiZdXHMqfDo6KSspJwogICAgIGlkZW50aWZpZXJfcmVnZXhwID0g cicoP1A8aWRlbnRpZmllcj5bXHc6XSspJwogICAgIG1heWJlX2JpdGZpZWxkX3JlZ2V4cCA9IHIn KDpccypcZCtccyopPycKICAgICBjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcl9yZWdleHAgPSBy Jyg/UDxjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcj5bWzsoKT0sXSkoPyE9KScKQEAgLTMyNzUs NiArMzI3NSwxOCBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKGZp bGVuYW1lLCBsaW5lX251bWJlciwgbGluZSwgZmlsZV9zdGF0ZQogICAgICAgICBpZiBtb2RpZmll ZF9pZGVudGlmaWVyID09ICdsJzoKICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVh ZGFiaWxpdHkvbmFtaW5nJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQu IERvbid0IHVzZSB0aGUgc2luZ2xlIGxldHRlciAnbCcgYXMgYW4gaWRlbnRpZmllciBuYW1lLiIp CiAKKyAgICAgICAgI1ByZWNlZGUgYm9vbGVhbiB2YWx1ZXMgd2l0aCB3b3JkcyBsaWtlICJpcyIg YW5kICJkaWQiCisgICAgICAgIGlmICd0eXBlJyBpbiBtYXRjaGVkLmdyb3VwZGljdCgpOgorICAg ICAgICAgICAgdHlwZSA9IG1hdGNoZWQuZ3JvdXAoJ3R5cGUnKQorICAgICAgICAgICAgaWYgbWF0 Y2gocidib29sWyomXT8nLCB0eXBlKSBhbmQgbm90IGNoYXJhY3Rlcl9hZnRlcl9pZGVudGlmaWVy ID09ICdbJyBhbmQgbm90IGNoYXJhY3Rlcl9hZnRlcl9pZGVudGlmaWVyID09ICcoJzoKKyAgICAg ICAgICAgICAgICBuYW1lID0gJycKKyAgICAgICAgICAgICAgICBpZiAnOjonIGluIG1vZGlmaWVk X2lkZW50aWZpZXI6CisgICAgICAgICAgICAgICAgICAgIG5hbWUgPSBzZWFyY2gocic6Oig/UDxs YXN0Pltcd19dKykkJywgbW9kaWZpZWRfaWRlbnRpZmllcikuZ3JvdXAoJ2xhc3QnKQorICAgICAg ICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgICAgIG5hbWUgPSBtb2RpZmllZF9pZGVu dGlmaWVyCisgICAgICAgICAgICAgICAgaWYgbm90IChuYW1lLnN0YXJ0c3dpdGgoJ2lzJykgb3Ig bmFtZS5zdGFydHN3aXRoKCdkaWQnKSk6CisgICAgICAgICAgICAgICAgICAgIGVycm9yKGxpbmVf bnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3Jy ZWN0bHkgbmFtZWQuIEJvb2wgdmFsdWVzIHNob3VsZCBzdGFydCB3aXRoICdpcycgb3IgJ2RpZCcu IikKKwogICAgICAgICAjIFRoZXJlIGNhbiBiZSBvbmx5IG9uZSBkZWNsYXJhdGlvbiBpbiBub24t Zm9yLWNvbnRyb2wgc3RhdGVtZW50cy4KICAgICAgICAgaWYgY29udHJvbF9zdGF0ZW1lbnQ6CiAg ICAgICAgICAgICByZXR1cm4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggOWU4ZTc3Ny4uMGY3ODYzZiAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKQEAgLTQ2NTgsNiArNDY1OCw3IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHls ZVRlc3RCYXNlKToKICAgICBkZWYgdGVzdF9uYW1lcyhzZWxmKToKICAgICAgICAgbmFtZV91bmRl cnNjb3JlX2Vycm9yX21lc3NhZ2UgPSAiIGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb24ndCB1c2Ug dW5kZXJzY29yZXMgaW4geW91ciBpZGVudGlmaWVyIG5hbWVzLiAgW3JlYWRhYmlsaXR5L25hbWlu Zy91bmRlcnNjb3Jlc10gWzRdIgogICAgICAgICBuYW1lX3Rvb3Nob3J0X2Vycm9yX21lc3NhZ2Ug PSAiIGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb24ndCB1c2UgdGhlIHNpbmdsZSBsZXR0ZXIgJ2wn IGFzIGFuIGlkZW50aWZpZXIgbmFtZS4gIFtyZWFkYWJpbGl0eS9uYW1pbmddIFs0XSIKKyAgICAg ICAgbmFtZV9ib29sID0gIiBpcyBpbmNvcnJlY3RseSBuYW1lZC4gQm9vbCB2YWx1ZXMgc2hvdWxk IHN0YXJ0IHdpdGggJ2lzJyBvciAnZGlkJy4gIFtyZWFkYWJpbGl0eS9uYW1pbmddIFs0XSIKIAog ICAgICAgICAjIEJhc2ljIGNhc2VzIGZyb20gV2ViS2l0IHN0eWxlIGd1aWRlLgogICAgICAgICBz ZWxmLmFzc2VydF9saW50KCdzdHJ1Y3QgRGF0YTsnLCAnJykKQEAgLTQ3MTUsNiArNDcxNiwxOSBA QCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJ3NpemVfdCBsOycsICdsJyArIG5hbWVfdG9vc2hvcnRfZXJyb3JfbWVzc2Fn ZSkKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnbG9uZyBsb25nIGw7JywgJ2wnICsgbmFtZV90 b29zaG9ydF9lcnJvcl9tZXNzYWdlKQogCisgICAgICAgICMgQm9vbCB2YXJpYWJsZXMgc2hvdWxk IHN0YXJ0cyB3aXRoICdpcycgb3IgJ2lkJworICAgICAgICBzZWxmLmFzc2VydF9saW50KCdib29s IGZvbzsnLCAnZm9vJyArIG5hbWVfYm9vbCkKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnYm9v bCA6OmZvbzsnLCAnOjpmb28nICsgbmFtZV9ib29sKQorICAgICAgICBzZWxmLmFzc2VydF9saW50 KCdib29sIGJsYTo6Zm9vOycsICdibGE6OmZvbycgKyBuYW1lX2Jvb2wpCisgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJ2Jvb2wgaXNmb287JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQo J2Jvb2wgOjppc2ZvbzsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnYm9vbCBibGE6 OmlzZm9vOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdib29sIGRpZGZvbzsnLCAn JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnYm9vbCA6OmRpZGZvbzsnLCAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnYm9vbCBibGE6OmRpZGZvbzsnLCAnJykKKyAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnYm9vbCBmb29bMTBdOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9s aW50KCdib29sIGZvbygpOycsICcnKQorCiAgICAgICAgICMgUG9pbnRlcnMsIHJlZmVyZW5jZXMs IGZ1bmN0aW9ucywgdGVtcGxhdGVzLCBhbmQgYWRqZWN0aXZlcy4KICAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgnY2hhciogdW5kZXJfc2NvcmU7JywKICAgICAgICAgICAgICAgICAgICAgICAgICAn dW5kZXJfc2NvcmUnICsgbmFtZV91bmRlcnNjb3JlX2Vycm9yX21lc3NhZ2UpCg==